- 21 May, 2018 40 commits
-
-
Bernhard Bauer authored
Different channel builds on Android must have identical .so files. Previously ARCore was only enabled on the default channel but disabled on Canary, Dev, Beta, and Stable, which broke channel builds. Replacing the channel check with an official build check is the closest approximation that avoids reverting https://crrev.com/559923 completely. TBR: mthiesse@chromium.org Bug: 845080 Change-Id: Id75d793827db0a489523f1fe3ced094b0821d35d Reviewed-on: https://chromium-review.googlesource.com/1065917 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#560263}
-
Nico Weber authored
chromium_android_clang_and_gl_gtests already includes all the tests in chromium_swarm_android_gtests, but chromium_swarm_android_gtests has different swarming parameters, and they overwrite some of the other tests. Remove chromium_swarm_android_gtests to give the clang, fyi, and memmory bots the same swarming parameters as the main android bots. (Hopefully we can delete all the chromium_swarm_*_gtests config and remove the chromium.swarm waterfall.) Also see the discussion at https://chromium-review.googlesource.com/c/chromium/src/+/1061795/27/testing/buildbot/chromium.android.json#882 This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr@chromium.org Bug: 843511 Change-Id: I9e455cc3fc3ec69e813e4c72a9e1c2e7528dbf76 Reviewed-on: https://chromium-review.googlesource.com/1067109 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560262}
-
Nico Weber authored
This adds angle_unittests to more bots. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511 Change-Id: I8bb587a509c1ff233db6e564a381af3a89a41f10 Reviewed-on: https://chromium-review.googlesource.com/1067164 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Bence Béky authored
Unlike general move semantics, when a Callback (either OnceCallback or RepeatingCallback) is moved from, it is guaranteed to be left in a null state. (See, for example, [1].) This CL removes two Reset calls from a freshly moved-from Callback, and uses std::move instead of assignment then Reset for a third one. [1] https://cs.chromium.org/chromium/src/base/callback_helpers.h?l=24 Bug: 807724 Change-Id: I538408b26fc0b6af601b23a669cb5447d2f9b1fe Reviewed-on: https://chromium-review.googlesource.com/1064019Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#560260}
-
csharrison authored
This CL makes sure the safe browsing throttle always has a database manager that can make checks. For the (extremely rare) case where the manager is not supported on the platform, checks are completely synchronously as SAFE. A follow-up will remove DatabaseManager::CanCheckSubresourceFilter from safe browsing internals (resolving the TODO here). This CL changes when a throttle can be created, since we won't create one unless there is a SafeBrowsing service. Most platforms should have one though. TBR=jkarlin@chromium.org Change-Id: Ic4c2d174af8980d088507976ff903ee0bf9dff16 Reviewed-on: https://chromium-review.googlesource.com/1067152 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#560259}
-
Kouhei Ueno authored
Bug: 695730, 696775, 686281 Change-Id: Id11515ceb7ce61fa15411a57ac4a105d03f3e6e6 Reviewed-on: https://chromium-review.googlesource.com/1065559Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#560258}
-
https://webrtc.googlesource.com/src.git/+log/a832019f4e3a..6633d41bb0ee $ git log a832019f4..6633d41bb --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I011fe3205d4b516b19df66bedac18861166e1ee7 Reviewed-on: https://chromium-review.googlesource.com/1067014Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560257}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1d08c644fb9a..5ee9829622bc $ git log 1d08c644f..5ee982962 --date=short --no-merges --format='%ad %ae %s' 2018-05-18 perezju [Telemetry] Update meaning of --browser android-webview Created with: roll-dep src/third_party/catapult BUG=chromium:841757 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I792fdb841da0516a363100591d96d259d80367a0 Reviewed-on: https://chromium-review.googlesource.com/1066075Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560256}
-
Peter E Conn authored
This also rolls custom-tabs-client, including the following changes (only the most recent is directly depended upon): https://chromium-review.googlesource.com/c/custom-tabs-client/+/1028234 https://chromium-review.googlesource.com/c/custom-tabs-client/+/1063970 https://chromium-review.googlesource.com/c/custom-tabs-client/+/1065875 Bug: 816798 Change-Id: I3ec9bdcb658af5a30ea8d09f5603b56441f7f367 Reviewed-on: https://chromium-review.googlesource.com/1064236 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560255}
-
Erik Språng authored
This will be necessary in order to properly use temporal and spatial scalability in hardware accelerated video codecs. Bug: chromium:794608 Change-Id: I029e044a33c95eb4bcc9db04b028d04a3cb7f922 Reviewed-on: https://chromium-review.googlesource.com/1016900 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560254}
-
Alex Clarke authored
I was curious about the cost of locking in TaskQueueImpl and realised we don't have coverage for non-delayed PostTask so I added one. Change-Id: I765f3d4316e9e6c7bac01d7b2f3a1d02188a2185 Reviewed-on: https://chromium-review.googlesource.com/1065776Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#560253}
-
James Darpinian authored
This reverts commit 34cc115e. Originally reviewed at: https://chromium-review.googlesource.com/c/chromium/src/+/1065191 Broke Nexus 6 FYI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20(Nexus%206)/4593 TBR=piman@chromium.org Bug: 839609,839618 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4ebaedc578f8b32a5a423b73d2b7e29911c791c Reviewed-on: https://chromium-review.googlesource.com/1067135 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560252}
-
http://dromaeo.com?dom-modifyEmily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 844541 Change-Id: If20fbd49f847b5bc7e47790b6f2738c6ab152382 Reviewed-on: https://chromium-review.googlesource.com/1066408 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#560251}
-
Olga Sharonova authored
AudioManagerBase input streams may contain fake streams, which are not closed properly on Mac now. Fixing it. Bug: 810321 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I117da2df47c99f43c2d122be8af4ca43da87531d Reviewed-on: https://chromium-review.googlesource.com/1065679Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#560250}
-
Yuichiro Hanada authored
Bug: 829383, 834027 Change-Id: I440f2b11b8cfe8499af913b508dcda535c554cf4 Reviewed-on: https://chromium-review.googlesource.com/1060873Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#560249}
-
Marina Ciocea authored
This CL adds Memory.AudioService.PrivateMemoryFootprint, SharedMemoryFootprint and PrivateSwapFootprint metrics, and content::GetProcessIdForAudioService() to read audio service process id. Audio service design doc: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit?usp=sharing Bug: 843985 Change-Id: I8d8c9cd77c8dcd3a6ec836a8f74f36617a9e7f67 Reviewed-on: https://chromium-review.googlesource.com/1064064 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#560248}
-
Noel Gordon authored
When mounting a fake removable volume (MTP or USB), allow the test case to control filling the volume with entries or not. Add a new file display test for USB. Comment file_display.js some more, plus minor code and git cl format tweaks. FileDisplay is not supported on Mash: add Mash filter bot exclusions. Test=browser_test --gtest_filter="FileDisplay/FilesApp*" Tbr: fukino-san Bug: 845087,836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I841f21d6b737813fc8a59574bfe10abfdf0b6e0d Reviewed-on: https://chromium-review.googlesource.com/1067219Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#560247}
-
tzik authored
Move ctor and assign of CallbackBase get marked as noexcept recently, but they are not match to correspondings in .cc. That causes a build failure on some of bots. Change-Id: I0af0a3224147e13b526678c791199a54f87b988d Reviewed-on: https://chromium-review.googlesource.com/1067318Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#560246}
-
Tetsui Ohkubo authored
As NotificationTray will be replaced by UnifiedSystemTray, OpenMessageCenter request from ARC should be routed to UnifiedSystemTray when --enable-features=SystemTrayUnified. TEST=manual BUG=837508 Change-Id: I652897f580dd98ae6f58c297c99d869221fc0a60 Reviewed-on: https://chromium-review.googlesource.com/1065550Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#560245}
-
Tetsui Ohkubo authored
This CL adds a11y string of UnifiedSystemTray button, which is identical to old SystemTray. This a11y string is checked in the initialization of all browser_tests, so lack of this makes all browser_tests fail. TEST=out/Release/browser_tests --enable-features=SystemTrayUnified BUG=none Change-Id: I3d9d2cff593ee53da55c0c48ab70ab7de0a6cb41 Reviewed-on: https://chromium-review.googlesource.com/1065726Reviewed-by:
-
Darren Shen authored
In the current code, there are some consts that are unnecessary. For example, returning by const-value has no effect and could harm optimisations. Similary, taking const-value parameters in header files don't add anything useful (but const-value parameters in CPP files are important). This patch deletes some unnecessary consts, and changes some const-value parameters to const-ref parameters to save a copy. Change-Id: Ibafbd348de4ddd3f44388d2e6d5d93816387d0ba Reviewed-on: https://chromium-review.googlesource.com/1065725Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#560243}
-
Kent Tamura authored
Replace split_name() in name_utilities.py with tokenize_name() defined in name_style_converter.py. split_name() had upper_first_letter() call. It had no effect because the first letter of split_name() result was always converted to something. join_names() just joins tokenized names, but join_names() result is always tokenized and its first letter is always converted to something. upper_first_letter() converts None input to ''. It happens only for functions with @naming_style. So this CL adds None-check to naming_style(). Bug: 843927 Change-Id: I3b705fa46a8f04c37d2b571bfe2011dfe1ceaf3e Reviewed-on: https://chromium-review.googlesource.com/1067298Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#560242}
-
Noel Gordon authored
FileManagerBrowserTest was renamed in crrev.com/559833 so there are no FileManagerBrowserTests anymore. Remove their Mash bot filter excludes (and group the Files.App-related tests together) in the file. Bug: 843030,836254 Change-Id: I865e22f6e9d762b9766a192ec038860eb591f01c Reviewed-on: https://chromium-review.googlesource.com/1067317Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#560241}
-
Trent Apted authored
Calling CalculatePreferredSize() can be expensive. The default BubbleFrameView implmementations of GetMinimumSize() and GetMaximumSize() invoke it, but popovers are not user-sizable, so there is no point calculating anything other than the preferred size. Popups also commonly change their preferred size without calling Widget::OnSizeConstraintsChanged() so the min/max sizes set will be wrong anyway. Note that BubbleFrameView is also used for (non-bubble) DialogDelegateView. These dialogs may be user-sizable, so that implementation is unchanged. Bug: 788597 Change-Id: I7473177eb3f0c9906c7a3191c776d2f36080cb26 Reviewed-on: https://chromium-review.googlesource.com/790175 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#560240}
-
Kouhei Ueno authored
In the upcoming version of the signed exchange format, the 3-byte big-endian encoding would also be used to hold signature field length. This CL renames the func so they are no longer "header" specific. Bug: 803774 Change-Id: I15576ac789b9a95ae4e752cf305f1d73f05d72be Reviewed-on: https://chromium-review.googlesource.com/1067277Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#560239}
-
Maksim Sisov authored
This commit adds IsMinimized/IsMaximized/IsFullscreen to PlatformWindow and makes DesktopWindowTreeHostPlatform use it. What is more, DesktopWindowTreeHostPlatform also updates compositor's visibility based on OnWindowStateChanged's ui::PlatformWindowState, and does relayouting to update OpaqueBrowserFrameView's buttons. TEST = ozone_unittests and manual testing with ./out/ozone/chrome --ozone-platform=wayland --in-process-gpu. Bug: 843018 Change-Id: Ic7d671a3954dc5a700b9f0ffecbba0b707a31ca9 Reviewed-on: https://chromium-review.googlesource.com/1058792Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#560238}
-
Keishi Hattori authored
Fixes issue where Oilpan traces would not be closed when only the blink_gc category is enabled. (regressed in r558522) Bug: 840789 Change-Id: Ie6e005e88b05db592f47655966ddff3fd8bf65c8 Reviewed-on: https://chromium-review.googlesource.com/1065723Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Noel Gordon authored
Split the test for Ok button, Cancel button, ESC key, closing the open file dialog into separate test cases. Formerly the test tried to do all three per test case, but that causes persistent TIMEOUT-PASS flakes on MSAN/ASAN/DEBUG bots [1]. Splitting the test into separate test cases will shorten the test-time and hopefully minimize TIMEOUT-PASS flake likelihood on those bots. FileDialog is not supported in Mash, so add Mash bot filter exclusions for the new tests added in this change-set: FileDialog/FilesAppBrowserTest.Test/openFileDialogCancelDrive FileDialog/FilesAppBrowserTest.Test/openFileDialogEscapeDrive FileDialog/FilesAppBrowserTest.Test/openFileDialogCancelDownloads FileDialog/FilesAppBrowserTest.Test/openFileDialogEscapeDownloads [1] See crbug.com/845054#c2 Test: browser_tests --gtest_filter="FileDialog/FilesApp*" Bug: 845054 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idaa629727fb78babe96a51d4e0b89e43fb9abc97 Reviewed-on: https://chromium-review.googlesource.com/1065718 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Sasha Morrissey authored
Update drive.proto for the ChromeOS Files app to store four extra entry capabilities: can_read, can_delete, can_rename and can_add_children. Also update the Drive SDK code to query for these capabilities and save them in the DB accordingly. Bug: 719959 Change-Id: I163c7562cdb0c13bac06b78da8fe794635df74b5 Reviewed-on: https://chromium-review.googlesource.com/1056948 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Pawel Osciak authored
Add VP8Encoder, an implementation of AcceleratedVideoEncoder interface for VP8, and a VA-API implementation of VP8Encoder::Accelerator. Also introduce Vp8ReferenceFrameVector, to share reference frame management code between encoder and decoder classes. BUG=703988,794608 TEST=veaunittest,apprtc,vdaunittest Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7aa9bd9c110bf936728c2a5dab85649ca3328ed6 Reviewed-on: https://chromium-review.googlesource.com/918702 Commit-Queue: Pawel Osciak <posciak@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#560234}
-
Manu Cornet authored
Bug: 782320 Change-Id: I82a8af3958da1890211ba13a7afa85f145df59d6 Reviewed-on: https://chromium-review.googlesource.com/1063517Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Manu Cornet <manucornet@google.com> Cr-Commit-Position: refs/heads/master@{#560233}
-
Kent Tamura authored
'3d' should be recognized as a single token as well as '3D'. tokenize_name() will handle 'matrix3d' in CSSValueKeywords.json5. Bug: 843927 Change-Id: I409751a6dd19a02c457895a15b32680ca36f2dd7 Reviewed-on: https://chromium-review.googlesource.com/1065754Reviewed-by:
-
David Dorwin authored
This feature breaks non-exclusive WebXR sessions so it should not be enabled as part of Experimental Web Platform Features. We will still need it enabled when running the hit-test Layout Tests. Bug: 844228, 833633, 828321 Change-Id: Id59268fae445f67c01c34f4b2e381988157387ae Reviewed-on: https://chromium-review.googlesource.com/1066812Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560231}
-
James Cook authored
TouchAccessibilityEnablerTest.InteractsWithTouchExplorationController is flaky in ash_unittests because ScreenForShutdown persists between tests. Clean up ScreenForShutdown at the end of each AshTestBase. Bug: 844253 Test: ash_unittests Change-Id: I4437fea28bc7757dc38d27db8bfbd173ddfba07a Reviewed-on: https://chromium-review.googlesource.com/1065177Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#560230}
-
calamity authored
This reverts commit 250e7ef1. Reason for revert: oopif-performance-cpu-profiles.js failing consistently in: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7812 Original change's description: > Reland "DevTools: Support CPU profiles in OOPIFs" > > This is a reland of 91d5ec53 > > Original change's description: > > DevTools: Support CPU profiles in OOPIFs > > > > BUG=832313,820250 > > > > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf > > Reviewed-on: https://chromium-review.googlesource.com/1011350 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553688} > > TBR=dgozman > > Bug: 832313, 820250 > Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de > Reviewed-on: https://chromium-review.googlesource.com/1065230 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560049} TBR=dgozman@chromium.org,alph@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 832313, 820250 Change-Id: Idf9a6925438105817159658fd8fa19ba00d1b530 Reviewed-on: https://chromium-review.googlesource.com/1065539Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#560229}
-
Eric Willigers authored
".a+:matches(.c>.e)" requires the intersection of ".a+*" and ".c>.e", not ".a+.c>.e". WebKit passes the test, Blink's current implementation does not. BUG=842157 Change-Id: I51566255006199c511b1d235232c0d9bef40035a Reviewed-on: https://chromium-review.googlesource.com/1059982Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#560228}
-
Aleks Totic authored
Bug: 841587 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5454aa1fd7f48e4034b4379f5cd97ba17961c777 Reviewed-on: https://chromium-review.googlesource.com/1066929 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#560227}
-
Koji Ishii authored
Following bot results are included. 5628 5629 5630 5638 5642 5646 5647 5648 5649 5654 5655 5656 5658 5659 116 lines were removed and 18 lines were deflaked by consecutive results since 5630. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8566e77b2ceeb0db44e704ca127263f3967b699a Reviewed-on: https://chromium-review.googlesource.com/1065476 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iffd88ce923f335ee3b3b9979be0a252f9ef240e2 Reviewed-on: https://chromium-review.googlesource.com/1067237Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560225}
-
Kent Tamura authored
The new behavior matches to name_utilities.py. This CL has no behavior changes because the current users of name_style_converter never pass names with such characters. Bug: 843927 Change-Id: I8eeafb71ec85bb1a0f92eff317fb07eb2dc373ff Reviewed-on: https://chromium-review.googlesource.com/1065959 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
