- 19 Apr, 2018 40 commits
-
-
Friedrich Horschig authored
This reverts commit dcb5b1f4. Reason for revert: Regressed on some devices. Failure reason is not obvious enough for confident immediate fix. Bug: 834676 Original change's description: > Clear password search on X and close it with back button > > Right now, clicking the X button in the search will close it. > To start a new search, you have to open a new search. > That experience isn't very discoverable, so UX developed an improved > workflow - details in the bug. > > The new flow needs these changes: > - the X button _only_ clears the query text field now > - the X button is _only_ available when a query was entered > - closing the search happens only via the "navigate up" button > in the action bar. > - the three-dots overflow menu is hidden while a search is active > (already the case on small screens - now large screens do the same) > > Tests cover all of these cases. > > Bug: 821755 > Change-Id: Ieb2e16c096750d66874aa4c4999759629332491b > Reviewed-on: https://chromium-review.googlesource.com/966070 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550955} TBR=twellington@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821755 Change-Id: I9035e5aed91dca19bcff94e195cf060ef61f2b29 Reviewed-on: https://chromium-review.googlesource.com/1019150Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#552101}
-
Wez authored
DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase uses a prepared test database, and verifies that it can be opened and read. The test opens the file directly from DIR_TEST_DATA, and so fails if that is readonly. Create a copy of the test database to open, to allow for this. Bug: 798851 Change-Id: I8d99e927c82024be7b0d98cdb4959a6210fe98a8 Reviewed-on: https://chromium-review.googlesource.com/1018491 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#552100}
-
Devlin Cronin authored
Extensions are not allowed to inject scripts on the webstore, and shouldn't be allowed to XHR it in a same-origin fashion. Instead, force extension XHRs to the webstore to use CORS. Bug: 826946 Change-Id: Ia38698a2e31931bc410c8e6ba10569706c9f3d90 Reviewed-on: https://chromium-review.googlesource.com/1012520 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#552099}
-
Kurt Horimoto authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia3fbf9ce8af09ca056b6dfb890fe533ac9f65fe7 Reviewed-on: https://chromium-review.googlesource.com/1018001Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#552098}
-
Alexandr Ilin authored
This CL implements the CheckPlatformHandlePermissionsCorrespondToMode() function on Mac. This also enables extra testing of this function since it's implemented on all supported platforms. Bug: 825177 Change-Id: I6982d62618a33b2c67091651c09c9b0d3a23326a Reviewed-on: https://chromium-review.googlesource.com/1012075Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552097}
-
Sylvain Defresne authored
CL https://crrev.com/c/1013379 fixed the use of SharedURLLoaderFactory so that the object is always used on the correct thread. This fixes the tests that was failing on a DCHECK in the destructor of an object that should only be used on a single sequence. Bug: 831570 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3d57c7bb3f6c0694be862b93d9bb4762efccc8e6 Reviewed-on: https://chromium-review.googlesource.com/1019865Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552096}
-
Kevin Marshall authored
TBR=qinmin@chromium.org Bug: 832389 Change-Id: I3ba544b2413a6ce30038e60ae314a11abbab7bf6 Reviewed-on: https://chromium-review.googlesource.com/1011662Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Josh Horwich authored
If both ArcBackupRestoreEnabled and ArcLocationServiceEnabled are both false by policy, a managed user with ArcEnabled could have ARC running without notice given for 'Send system data'. This change will avoid setting SET_REPORTING_CONSENT true for managed users except during initial ARC setup. Unmanaged users will not be affected, nor will this prevent clearing the setting for a managed user for cases where the device owner or admin turns off DeviceMetricsReportingEnabled. BUG=b/74220823 TEST=Manual tests with managed/unmanaged users. Change-Id: Ia15b3051bea9dce27efc1415605b55f303492c9a Reviewed-on: https://chromium-review.googlesource.com/1019349 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#552094}
-
Devlin Cronin authored
Update ExtensionIconSourceTests to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I6fe638994b9ca34b03fc16debcfb547d75e967e1 Reviewed-on: https://chromium-review.googlesource.com/1018405Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552093}
-
Koji Ishii authored
This patch adds unit tests for ShapeResult::OffsetForPosition, in preparation to adding another variation for 'text-overflow: ellipsis'. The plan is to add separate entries for each functionalities, rather than adding a mode flag to OffsetForPosition. Before the refactoring, this patch adds tests to ensure the behavior does not change. Change-Id: I41b6d03d3ccbacabe12620c512ac7b5aad7164e4 Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/1019760 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#552092}
-
Theresa authored
For Chrome Home, we disabled the app menu item translation animation when showing the menu. Since we conditioned this behavior on ChromeActivity#getBottomSheet() != null, the app menu item translation animation was incorrectly disabled for EoC. BUG=833610,814528 Change-Id: I6225f7d490cc41d57b5efc6a8ffe26b706cccbbb Reviewed-on: https://chromium-review.googlesource.com/1015160Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552091}
-
Eric Stevenson authored
WebApkIntegrationTest#testLaunchAndNavigateOffOrigin started flaking heavily after https://chromium-review.googlesource.com/c/chromium/src/+/1003552. That CL is necessary for M67 though, so mark as flaky while we investigate. Bug: 834466 Change-Id: Idef70484302ba0e6dc9335ab2324531f3ae16c33 Reviewed-on: https://chromium-review.googlesource.com/1019543Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#552090}
-
Brian White authored
These mismatches shouldn't happen but crashing is a fairly severe response for the released products. Just report the error. Bug: 756948 Change-Id: Ia8f249afafec1e8ddf054a2a818b78b2ffd98132 Reviewed-on: https://chromium-review.googlesource.com/1012469Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#552089}
-
Bence Béky authored
Remove all uses of deprecated ScopedMockTimeMessageLoopTaskRunner in //net in favor of ScopedTaskEnvironment. Also add GetMockTimeTaskRunner() method to ScopedTaskEnvironment so that HasPendingTask(), GetPendingTaskCount(), and NextPendingTaskDelay() methods can be called just like before. The relation to https://crbug.com/829429 is that because of presubmit rules, this is blocking the rename of net/http/http_stream_factory_job_controller_unittest.cc at https://crrev.com/c/1000487. Bug: 829429, 791831 Change-Id: I445dca6ef8d91e1088c14b0f52d2358950b7e50f Reviewed-on: https://chromium-review.googlesource.com/1005109 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#552088}
-
Sylvain Defresne authored
The file base/mac/bind_objc_block.h only expose base::BindBlock (and base::BindBlockArc) templated method. If the method is not used, then the include is unnecessary and can be removed. Automated using the following command: for file in $(git grep -l base/mac/bind_objc_block.h); do if ! grep -q BindBlock $file; then sed -i '' -e '/base\/mac\/bind_objc_block.h/d' $file fi done Bug: none Change-Id: Ia9a172fbc114766a42b1a3c6ef2b8f7293623da1 Reviewed-on: https://chromium-review.googlesource.com/1018485Reviewed-by:Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552087}
-
Antoine Labour authored
At this point, viz::internal::Resource in LayerTreeResourceProvider is only used for tests, so a lot of support is not needed. Many tests are redundant with corresponding ImportedResource functionality, or only test Resource support itself, so remove those. Among others: 1- create and allocate the texture on Create*, and generate the mailbox there. This avoids transient states that are not useful. Note, this removes ETC1 support, which is not used. 2- remove the ScopedWriteLock* 3- remove support for mipmaps 4- remove many calls to CreateForTesting / AllocateForTesting / CopyToResource in remaining tests, which were only to trigger creation/allocation, now covered by (1) 5- remove unused ResourceTextureHint flags. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1a27edfd676e0a4e857c2e9d3cabb00b4e1b45b7 Reviewed-on: https://chromium-review.googlesource.com/1018480Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552086}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8dd917f1. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15841 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: I8f5a9d5990b012c88ea33cc52e18ec95d63fb44f Reviewed-on: https://chromium-review.googlesource.com/1019701 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#552085}
-
Geoff Lang authored
ANGLE's GL backend will likely only be released in conjuction with the passthrough command decoder. TBR=kbr@chromium.org BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I92df6a32eae8a8266454ab6312c2a3b56c2cf9e4 Reviewed-on: https://chromium-review.googlesource.com/984372 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552084}
-
Takuto Ikuta authored
chromium went to community support of cl.exe build and dropped cl.exe builder. And goma's canary client builder using cl.exe quickly saw compile error. crbug.com/834213 However, some subprojects (e.g. v8) still have cl.exe builders. So, goma team does not yet decide to drop cl.exe support for the subprojects. Let us continue to use canary client builder with small targets. Bug: b/78251210 Change-Id: Id86d2893f415894eae6797151b301de941511fd5 Reviewed-on: https://chromium-review.googlesource.com/1018681Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#552083}
-
Mirko Bonadei authored
From absl/memory/memory.h: // ABSL_ALLOCATOR_NOTHROW is a build time configuration macro for user to // specify whether the default allocation function can throw or never throws. // If the allocation function never throws, user should define it to a non-zero // value (e.g. via `-DABSL_ALLOCATOR_NOTHROW`). // If the allocation function can throw, user should leave it undefined or // define it to zero. Since exceptions are not allowed in Chromium, it is probably safe to assume the default allocation function also never throws. Bug: webrtc:8821 Change-Id: I18e617ae75084f32016c1b030375c0b81ca9aa50 Reviewed-on: https://chromium-review.googlesource.com/1018103Reviewed-by:
-
Peter Wen authored
Create .info files for resources during jinja processing, aapt2 compressing, and aapt2 linking, using these .info files to create a per-apk *.apk.res.info file that supersize then uses to properly map a resource file back to its source file. There is some complexity with resource overloading and android build tools changing the resource file or directory as part of packaging an apk. This is handled by a combination of storing renames and parsing heuristics. Bug: 827196 Change-Id: Ic8243c218791ec048b1563604d93c7b735fdc71c Reviewed-on: https://chromium-review.googlesource.com/1014255 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#552081}
-
Ian Vollick authored
Previously, if a shadow had set anchoring or centering, the size of the shadow would have affected the positioning. This should not be true; centering and anchoring should proceed as if there were no shadow at all. We have the property bounds_contain_padding that captures this concept in other contexts and this CL applies that notion to centering and anchoring. Bug: 834432 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I79465951c50374174710d7d76dc70d3e9cd6bdea Reviewed-on: https://chromium-review.googlesource.com/1019600 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552080}
-
Mirko Bonadei authored
Bug: None Change-Id: I91c5141b86826badad4d61e26c2f0ef0acf37e35 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1018105 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552079}
-
Justin Cohen authored
We are seeing an increased need to pass command line parameters in release builds, both on the bots and for Test team (e.g. Franky). Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I55333de3ac89e1f379135b355080854df0cbf90d Reviewed-on: https://chromium-review.googlesource.com/1019900Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552078}
-
Alex Moshchuk authored
Credit goes to nick@ for spotting it in https://chromium-review.googlesource.com/c/chromium/src/+/999182 Change-Id: I278234762e4ca8ced592c0b63636c6dc6b981e6f Reviewed-on: https://chromium-review.googlesource.com/1010473Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#552077}
-
Justin Cohen authored
Bug: 826369 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I76ad9c0e15b1ff7599ce71d68053a2757e67fa6f Reviewed-on: https://chromium-review.googlesource.com/1016705 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#552076}
-
Jacob Dufault authored
If there is a crash session manager will revert to webui. If there is a feature missing the user can click a button on the shelf which will revert to webui. Bug: 784495 Change-Id: I218b5a217941dfde51d1a78080ef4d9e30ca87d2 Reviewed-on: https://chromium-review.googlesource.com/972328 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552075}
-
Weidong Guo authored
Swiping up from shelf in overview mode will show the launcher. This change avoids such action. BUG=832991 Change-Id: I556a6ffd7d73718695dcb8c17b473dab9142876a Reviewed-on: https://chromium-review.googlesource.com/1018147Reviewed-by:
-
Evan Stade authored
Bug: 578868 Change-Id: I49cb32bffdddf770354268f1a32dff660e716a14 Reviewed-on: https://chromium-review.googlesource.com/1000021 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#552073}
-
Andrey Lushnikov authored
Ther sourcemap infobar might never be created if user has clicked "never show" button. R=dgozman, einbinder Change-Id: I5d494ca218bb3b793a0c734d5fcf92549821749d Reviewed-on: https://chromium-review.googlesource.com/1018530Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#552072}
-
Andrey Lushnikov authored
This patch adds new experimental Page.close() protocol method that closes the page, running page's beforeunload hooks. R=dgozman Change-Id: I4c091bb150e8d88e99c94920e92b1bdcf0ccb234 Reviewed-on: https://chromium-review.googlesource.com/1014676Reviewed-by:
-
Xiaohan Wang authored
- Convert runtime DCHECK to compile time static_assert. - Add helper function to simplify the check logic. - Use CDM interface version as CdmWrapperImpl template argument to simplify some code and check logic. Bug: 799169,733821 Test: No functionality change. Change-Id: I2a97be9a507db853eb91b739bf26511492665eee Reviewed-on: https://chromium-review.googlesource.com/1018144Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552070}
-
Sergey Poromov authored
In order to investigate how long does it take to install all enterprise force-installed extensions, the installation is tracked by new ForcedExtensionsTracker class which reports the installation time as "Extensions.ForceInstalledLoadTime" UMA stats. BUG=787970 TEST=Manual, check the stats reporting is triggered. Change-Id: Ibf7ec768eb7c0a6dd63461b87424e4378ac2edd8 Reviewed-on: https://chromium-review.googlesource.com/1012117Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0908c152..1b573fbc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia7a42afd15ac581b318e0faf25075a59e9f5213b Reviewed-on: https://chromium-review.googlesource.com/1019420Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552068}
-
Sebastien Marchand authored
Bug: 773382 Change-Id: Ic0f82d85a2d92c194f495d3f3b244af8b4725236 Reviewed-on: https://chromium-review.googlesource.com/1008168 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#552067}
-
John Z Wu authored
Create a delegate method on CWVAutofillControllerDelegate that allows the delegate to choose if they want to save a particular credit card. Also implemented in the shell app. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id5f0a691b44d360a421375fc38b71542048b674e Reviewed-on: https://chromium-review.googlesource.com/1018201Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
-
Rohit Rao authored
When the UIRefresh flag is enabled, MainController creates a TabGrid, which requires a non-NULL ChromeBrowserState. This CL also fixes a number of bugs that prevented MainController from being torn down properly. BUG=818736 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifc1ba0daaeec19d38a118e4b64ffa2c82a32a51a Reviewed-on: https://chromium-review.googlesource.com/1016672Reviewed-by:
-
David Black authored
- Exposes controller directly to view. - Limits model exposure to view: now view can only observe it. - Refactors RecognizedSpeech into more generic Query to handle both voice and text. Bug: b:77825712 Change-Id: I37166183277e9a67d98d3aadb6304f8a2a34c692 Reviewed-on: https://chromium-review.googlesource.com/1012197Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#552064}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Previously, the method returned a raw pointer, and ownership was implicitly passed. This CL updates the method to returned a unique_ptr. In this process of updating all call sites, this CL also: * Gets rid of UnloadControllerWebContentsDelegate, which added an unnecessary layer of abstraction. FastUnloadController can directly inherit from content::WebContentsDelegate, which removes an extraneous class. * Updates FastUnloadController to hold WebContents waiting for deletion in a vector of unique_ptrs. Previously, the WebContents were simply dropped on the floor, and then UnloadControllerWebContentsDelegate would delete the pointer it received in a callback. * Updates DevToolsWindow to use clear ownership semantics for the main_web_contents_. Ownership passes between DevToolsWindow and its member browser_, based on the |is_docked_| parameter, but ownership was not being explicitly specified. Change-Id: I4c21f04fe5d60a5149d79bda7b6ba3535bef2b7f Bug: 1012574 Reviewed-on: https://chromium-review.googlesource.com/1012938 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#552063}
-
khmel@google.com authored
This CL fixes following issues: Assistant has dependencies on ARC and it has to count them when checked for activation. This uses default helper IsArcTermsOfServiceOobeNegotiationNeeded to determine that ARC is not Opted-In. This also changes direct prefs::kArcEnabled manipulation to helper SetArcPlayStoreEnabledForProfile that has logic to start arc session when needed besides only setting that flag. Test: Manually Bug: 831302 Change-Id: I48ce9400d668052bff7691deed42b7bdeb777827 Reviewed-on: https://chromium-review.googlesource.com/1019348Reviewed-by:
-
