- 26 Jun, 2020 40 commits
-
-
Henrique Nakashima authored
- Make centering force proportional to the available space in each dimension to use the screen better. - Stronger repulsion between nodes to make the labels easier to read. - Run the simulation for longer before freezing it. Bug: 1093962 Change-Id: I3c663ab6a827998e2112f22d4123d6ab23fd8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268586 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783090}
-
Maksim Ivanov authored
Refactor CertificateProviderService to defer the input data hashing till the very last point before sending the signature request to the extension. As a consequence, change the CryptohomeKeyDelegate D-Bus service to pass the unhashed data. Also kill the call in the CertStoreInstance Mojo service that was passing pre-hashed data (that service will anyway be deleted in one of follow-ups - see b/119914122). This is a preparation step for introducing a new version of the chrome.certificateProvider API that will pass the unhashed inputs to the extension. There's no use-visible changes expected. All changes, except the one of CertStoreInstance, are backwards-compatible, and the CertStoreInstance is an unlaunched functionality that will be deleted soon (see b/119914122). Bug: 1078761 Change-Id: I656f46c41fdd5fd779e27abe76ee6c01ea2349f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246177 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#783089}
-
Bailey Berro authored
Punted to M86. Bug: 1062499 Change-Id: I58ba4b879de7ec0d91e432da7a4a6722db91e0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268119 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#783088}
-
Mirko Bonadei authored
This is a reland of 3a2a481f This CL moves the declare_arg of gtest_enable_absl_printers to //build_overrides (which is already imported by googletest and abseil-cpp BUILD.gn files) in order to avoid the "undefined identifier" error when build_with_chromium=true. Original change's description: > Add gtest absl deps to the absl component. > > This CL conditionally adds absl/debugging deps to the absl component > if build_with_chromium=false. This will allow downstream projects to > use gtest with absl (for pretty printers and matchers) but it will > remove these dependencies in Chromium to avoid to add static > initializers. > > When static initializers will be removed, the dependency will not be > conditional so Chromium will also be able to set > 'gtest_enable_absl_printers=true'. > > Bug: 1046390 > Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782889} Bug: 1046390 Change-Id: Id977a6a868b389b4d9924eb3af5a5f5cd0c3f4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270298 Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783087}
-
Moe Ahmadi authored
Omnibox page classification detection logic is failing to correctly report interactions from the WebUI NTP. This is due to the WebUI NTP not using the instant process. This CL fixes that by making the ChromeLocationBarModelDelegate::IsInstantNTP logic correctly identify both the local NTP and the WebUI NTP without the need for checking whether the NTP uses the instant process. As a result interactions from the WebUI NTP will continue to be reported as OmniboxEventProto::INSTANT_NTP_WITH_[OMNIBOX|FAKEBOX]_AS_STARTING_FOCUS without the NTP actually using the instant process. This logic *should* eventually be refactord into chrome/browser/search/search.cc once the WebUI NTP is fully launched and the references to the instant process are removed. Bug: 1098513 Change-Id: I6d4a9e75a45cd70232ffa3541b122c639a428a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265415 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783086}
-
Livvie Lin authored
For lookalike interstitials, call CancelAndDisplayError from ShouldAllowResponse rather than at the request stage, so that the provisional load has already started. This will allow PrepareErrorPage to trigger. This CL also puts a placeholder method in ChromeWebClient for preparing the lookalike interstitial HTML when it sees a lookalike error code. Bug: 1058898 Change-Id: Iff830bb48cdee60cc1e2b8b5f74ebe858c2d5993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261614Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#783085}
-
Jazz Xu authored
This CL fix the issue by creating a dragging widget when user start dragging. Bug: 1099387 Change-Id: Id0b1dab56216f7ec5614ae11580ce08ea208daf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267729 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783084}
-
Scott Little authored
The histogram OfflinePages.TabRestore is still in use, so this CL extends the expiration of this histogram. Fixed: 1089163 Change-Id: I4392c187acd66178b5590157ca531041072b3f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269482 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783083}
-
Jana Grill authored
Show notifications informing the user that ADB sideloading device policy has been changed to DISALLOW or DISALLOW_WITH_POWERWASH by the domain admin. In the latter case also ensure that the device is powerwashed. Bug: 1082668 Test: Unit tests Change-Id: I00a3e493a58822ca8d19bde4182b42974d072794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203205Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#783082}
-
Scott Little authored
The histogram NewTabPage.OfflineUrlsLoadTime seems to have been removed from the code quite a while ago, and M58 is the latest milestone that I can find data for. This CL marks this histogram as obsolete. Fixed: 1089098 Change-Id: I0ab5a29b7686fd6675e68cf5814af40a4be3e8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269541 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Note that some WebMediaStream -> MediaStreamDescriptor, and similar conversions were also performed. BUG=704136 R=guidou@chromium.org Change-Id: I7c8cd40f009e6e464487fdd46983567a13c9ae41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260932 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#783080}
-
Scott Little authored
This histogram seems to have been removed a long time ago. I'm not sure exactly which milestone it was, so this CL marks OfflinePages.ClearAllStatus2 as obsolete after M83. Fixed: 1089139 Change-Id: I4fcb4c60f4cc7e495b5906f62229e8c91350c010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268640 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
This is an implementation of media::ContentDecryptionModule that adapts the calls to a mojo interface for chromeos::cdm::mojom::ContentDecryptionModule. It also adapts the client interface chromeos::cdm::mojom::ContentDecryptionModuleClient and directs those to the callbacks provided when the media::CdmFactory creates the implementation. This also implements media::Decryptor. BUG=b:153111783 TEST=Unit tests pass Change-Id: Ie6b65a7f490d5130548c060fe5b3c96920128e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253461 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39368e75. With Chromium commits locally applied on WPT: 3398d444 "[COOP] moving reporting tests to reporting/" 771fe13c "[LayoutNG] Avoid break between last child and container edge." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm domenic@chromium.org, wjmaclean@chromium.org: external/wpt/origin-isolation jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/service-workers/cache-storage mkwst@chromium.org: external/wpt/cookies external/wpt/upgrade-insecure-requests mstensho@chromium.org: external/wpt/css/css-multicol yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ic991fea33a8ad329bfcbb4dc4c79b499c04e12c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269880Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783077}
-
Aaron Colwell authored
Several pieces of code related to web view guests generate site URLs solely for the purpose of getting the appropriate StoragePartition. Now that there is a way to get a StoragePartition using a StoragePartitionConfig, all of these pieces of code can be migrated away from using site URLs and just use StoragePartitionConfigs directly. Bug: 1085275 Change-Id: Id7b4b6e0be52f762236e7b2281644f270a92193e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254347 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#783076}
-
Nico Weber authored
Bug: 1098899 Change-Id: I7f03ab3d7305beec8057351f6c0aa50ccb9e4503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270700 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#783075}
-
Tom Anderson authored
Most of SendRequest doesn't depend on the template parameter |Reply|, so move the common code into a non-template function defined in the source file. This should hopefully reduce binary size since SendRequest() gets instantiated for every Request type (654 in total). BUG=1066670 R=sky Change-Id: Iee5934f42b1c4ceb02b3279452e4cadbb7a620fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268841Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#783074}
-
Scott Little authored
The histograms OfflinePages.PageLifetime.* and OfflinePages.PageSize.* are still in use, so this CL extends their expiration. Fixed: 1089761, 1089762, 1089763, 1089764 Change-Id: I1781c89bb8b505918da20cecc486a69f68038951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268593 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
ckitagawa authored
This CL modularizes PaintPreview to be a separate java target. See bug for design doc. Bug: 1097799 Change-Id: Ie7045db6bd913bb65c6d94862fef56fcd660a60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257560Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#783072}
-
Scott Little authored
This CL extends the expiration of two histograms that are still in use: OfflinePages.DownloadRequestTimeSinceDuplicateRequested and OfflinePages.DownloadRequestTimeSinceDuplicateSaved. Fixed: 975541 Change-Id: Ib164dbad14b981cbf92dadc78733235b9207cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268232 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Byungchul Kim authored
Bug: 1031540 Change-Id: I7a64d749c2c1f7484aedb8f7a7f74088972400f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270661Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Byungchul Kim <byungchul@chromium.org> Cr-Commit-Position: refs/heads/master@{#783070}
-
Mike Wasserman authored
Just check that the screen getter is invoked on fullscreenOptions. Tentative per the experimental web platform Window Placement feature. Bug: 1022988 Test: Automated Change-Id: I4d4064a8a912d679fd27f66cdf53e7f64e1cfe90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268310Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#783069}
-
Scott Little authored
The histogram OfflinePages.SQLStorage.StoreEvent is still in use, so this CL extends the expiration of this histogram. Fixed: 1089161 Change-Id: Ib70f47b6b3cb9fd6904908665cf39de07773eeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269758 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Scott Little authored
The histogram OfflinePages.Model.ConstructionToLoadedEventTime was removed from the code quite a while ago, and the latest milestone that I can find data for is M65. This CL marks the histogram as obsolete. Fixed: 1089145 Change-Id: I2fccc432fd993e73d6b08e55d294875103a279f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268591 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Scott Little authored
This histogram seems to have been removed quite a while ago, and the latest milestone I've found data for is M65, so this CL marks the OfflinePages.BatchDelete.TotalPageSize histogram as obsolete. Fixed: 1089137 Change-Id: Ib41a51928451b311018a644d29a9545404d3cb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268777 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Dominic Farolino authored
This CL makes ImageLoader::ShouldLoadImmediately perform a stricter check, such that we skip queueing the image loading microtask less often. The stricter check we perform is equivalent to the HTML Standard's list of available images tuple-matching logic [1]. This changes the image loading behavior for cases where an image request is made for a resource that is in the MemoryCache, but has a different CORS settings attribute / credentials mode. Consider the following, which are all requesting the same image: - An image resource was fetched with CORS settings attr B, and is in the MemoryCache / list of available images - An image request (1) for the same resource is made, with CORS settings attribute A - An image request (2) for the same resource is made, with CORS settings attribute B Prior to this CL, request (1) would skip queueing a microtask, because ImageLoader::ShouldLoadImmediately would naively consider the cached resource a match. The request would go the ResourceFetcher, and ResourceFetcher::DetermineRevalidationPolicyInternal would realize a cache miss, because the CORS settings attributes did not match. The ResourceFetcher would add the resource that was fetched with CORS settings attribute A to the MemoryCache. Then request (2) would be made, and the server would see both requests (1) and (2). After this CL, ImageLoader::ShouldLoadImmediately is more strict, implementing the same CORS settings attribute check that ResourceFetcher::DetermineRevalidationPolicyInternal does. ImageLoader queues a microtask for request (1). Then, request (2) is kicked off before the microtask is run, and requests (1) and (2) are coalesced. The server only see one (correct) request. [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:list-of-available-images R=yoavweiss@chromium.org Bug: 1093977 Change-Id: I3ca9a3cf63177572a8f45fa6be8a3b0c25f9c539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244191 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#783065}
-
Katie Dektar authored
This reverts commit 1312dd58. Reason for revert: During review of crrev.com/c/2243761, it was determined that this approach may sometimes remove the wrong entries from the navigation stack. Reverting, will try a new method after offline discussion. Original change's description: > Remove reader mode page from navigation stack on desktop. > > This means users will not be able to navigate to Reader Mode pages > using "back" or "forward" buttons, matching behavior in Android. > > Also improves the ReaderModeIconViewBrowserTest by resolving a TODO. > > AX-Relnotes: n/a. Reader mode is still behind a flag. > Bug: 1090588, 1087949 > Change-Id: I016a02b95b1a3acbff9299c518e8bf2780379d32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235988 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777001} TBR=ellyjones@chromium.org,wychen@chromium.org,katie@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090588, 1087949 Change-Id: Ibbdbf4d09ef0734848a9f12a3acf159720de967e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270697Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#783064}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Iaa71445dca0f193a1dfd1ea899c0b9756e964892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268460Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d43c3788d782..efc55b0134fa 2020-06-26 philipp.hancke@vonage.com sdp: test media type mismatch behaviour If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I114fa751e01d7abfaa5e85c5038abc20339ddb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783062}
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: 869492 Change-Id: I1dfe10e8444a7e36e50cf128a33667c68ca86639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270344 Commit-Queue: Scott Little <sclittle@chromium.org> Auto-Submit: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#783061}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/711a56c023b5..9eb483838965 2020-06-26 treehugger-gerrit@google.com Merge "Edit inline comments in .proto files" 2020-06-26 fmayer@google.com Merge "Add doc to client_ext.h." 2020-06-26 treehugger-gerrit@google.com Merge "Support partial heap graphs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied853007c9c2907cd64e9f4196651107c2d3d8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270533Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia4ac6eb542d7376561fa2e104f0c9b6e10ef6c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270112Reviewed-by:
-
Collin Baker authored
This reverts commit 89c9ea26. Reason for revert: two builds after this flaked in ../month-suggestion-picker-mouse-operations.html and ../datetimelocal-suggestion-picker-mouse-operations.html: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Original change's description: > Reland "Use wheelTick in forms/resources/common-wheel-event.js" > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. This CL we should replace > eventSender.mouseScrollBy with wheelTick which uses > gpuBenchmarking.smoothScrollByXY in > forms/resources/common-wheel-event.js. > > TBR=ellyjones@chromium.org,avi@chromium.org,sky@chromium.org,bokan@chromium.org,lanwei@chromium.org > > Bug: 1047176 > Change-Id: Ib45dce450fe395d53a443612033305bccef6b19d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268227 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783007} TBR=ellyjones@chromium.org,avi@chromium.org,sky@chromium.org,bokan@chromium.org,lanwei@chromium.org Change-Id: Ia0617e5e297d571c6812af0a31e69b26688d37ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269750Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#783058}
-
Dominique Fauteux-Chapleau authored
TBR=cammie@chromium.org Bug: 1099758 Change-Id: I581ff1493f52d23f4d8018442de11a3b57b86f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270346Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#783057}
-
zhaoyangli authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/8fbc948c8479..af46d99e3add $ git log 8fbc948c8..af46d99e3 --date=short --no-merges --format='%ad %ae %s' 2020-06-23 chanheepark Add GREYFailureHandlerHelpers.h to Xcode project. 2020-06-23 tirodkar GREYErroFormatter link up. 2020-06-23 tirodkar Move GREYErrorFormatter to CommonLib 2020-06-22 chanheepark Implement GREYErrorFormatter. 2020-06-22 tirodkar Fix project 2020-06-22 tirodkar rm unused statusBarOrientation / pre iOS8 calls. 2020-06-19 tirodkar Change GREYError keys. 2020-06-18 tirodkar RM new line after Search action info that's printed. 2020-06-17 tirodkar Unused property 2020-06-17 tirodkar Error Formatter Change 0. 2020-06-17 tirodkar Enable the ScrollView Indicator Test to work on any device config. 2020-06-16 tirodkar Failure Formatter update 2020-06-16 tirodkar Scroll Bar Synchronization 2020-06-10 tirodkar Remove Duplicated stack trace 2020-06-10 tirodkar Add animation information for sublayers of a UIView in the UIHierarchy. 2020-06-09 tirodkar https://github.com/google/EarlGrey/pull/1335 2020-06-05 tirodkar Fix doxygen comments for @return in the HostDOCategory. 2020-06-02 tirodkar Remove redundant message from the Keyboard dismissal error. 2020-06-02 chanheepark Remove description glossary from EarlGrey error message: 2020-06-02 tirodkar Revert "keyboard-dismissal-redundancy (#1322)" 2020-06-02 64929355+willsaid-google keyboard-dismissal-redundancy (#1322) 2020-06-02 albertbow Rewrite eDO app port test. 2020-06-01 tirodkar Error printing cleanup for search action & details. 2020-06-01 chanheepark Reformat error message when the app under test crashes. 2020-05-29 64929355+willsaid-google fixed 4 error typos (#1320) 2020-05-29 albertbow Add specific reasons to app-side eDO failure. 2020-05-28 tirodkar Comment update in GREYHostApplicationDistantObject 2020-05-28 mobile-devx-github-bot Add openDeepLinkURL to the Swift EarlGrey wrapper. 2020-05-27 chanheepark Remove tap constraint for checking if the button is enabled or not. 2020-05-27 chanheepark Fix broken error handling test. 2020-05-26 tirodkar Remove attribute constructor from GreyHostAppDO 2020-05-26 chanheepark Removed bundle ID from console output for error handling #1308 2020-05-21 tirodkar Internal GREYAppConfiguration refactor. 2020-05-20 tirodkar https://github.com/google/EarlGrey/pull/1307/files 2020-05-20 64929355+willsaid-google System version error (#1307) 2020-05-12 mobile-devx-github-bot Comments formatting updates 2020-05-11 chanheepark Fix failing functional test due to some eDO bug. 2020-05-11 mobile-devx-github-bot Update comments to match structure, required by doxygen 2020-05-11 tirodkar Patch https://github.com/google/EarlGrey/commit/86065a68f15a1674659b892cba007c76eb7f24d9 2020-05-08 chanheepark Remove test flag. 2020-05-08 mobile-devx-github-bot Replace `import` with `include` for c headers in EarlGrey2 2020-05-07 64929355+willsaid-google cleaned up xc schemes, and updated swift version to 5.0 for build errors (#1294) 2020-05-07 sskhandp Move static into method to scope it more tightly. 2020-05-07 sskhandp import to include for c headers 2020-05-07 tirodkar Fix the DistantObjectBackgroundExecutionTest 2020-05-06 tirodkar Remove did Happen interaction notifications. 2020-05-06 chanheepark Fix operand to AND so it sleeps only for iOS 12 and below with non delete key. 2020-05-06 tirodkar Remove did Happen interaction notifications. 2020-05-05 tirodkar Fix deep link API for iOS 13+ 2020-05-05 chanheepark Revert workaround for the automatic keyplane change when backspace is tapped. (...) 2019-12-04 mobile-devx-github-bot Pass in GREYTraversalObject directly to GREYVisibilityCheckerTarget. 2019-12-02 albertbow Translates eDO connection failure to application crash when the situation is met. 2019-12-02 mobile-devx-github-bot Change orders of the condition check. 2019-12-02 mobile-devx-github-bot Add initializers to GREYTraversalObject and make the properties readonly. 2019-11-30 tirodkar Fix xcode proj. 2019-11-29 sskhandp Rename last vestiges of GREYHierarchyObject. 2019-11-28 szymonkaz fix for GREYTraversalProperties 2019-11-27 sskhandp Remove unused method in default failure handler. 2019-11-27 mobile-devx-github-bot Integrate traversal properties to quick visibility checker. 2019-11-27 mobile-devx-github-bot Have accessibility elements to use traversal properties as well. 2019-11-26 sskhandp Format GREYKeyboard.m. 2019-11-26 tirodkar Formatting fix. 2019-11-25 mobile-devx-github-bot Have accessibility elements to use traversal properties as well. 2019-11-25 mobile-devx-github-bot Have accessibility elements to use traversal properties as well. 2019-11-25 mobile-devx-github-bot Support retrieving the interactionPoint of the target in quick visibility checker. 2019-11-25 tirodkar Fix podspec 2019-11-24 konrad.zdunczyk Fix EarlGreyTest.podspec 2019-11-22 mobile-devx-github-bot Change core actions' diagnosticsID. 2019-11-22 mobile-devx-github-bot Create a metadata class that stores useful information about the traversal element. 2019-11-18 tirodkar Expand interaction error legend. 2019-11-15 mobile-devx-github-bot In progress of implementing quick GREYVisibilityChecker::visibleInteractionPointForElement 2019-11-15 mobile-devx-github-bot Mark unused variable in failure handler 2019-11-14 mobile-devx-github-bot Move out some method to visibility utility file. 2019-11-13 tirodkar Fix project 2019-11-12 mobile-devx-github-bot Removing glossary and replacing [K] with the actual character string. 2019-11-11 tirodkar Remove @synthesize calls form v2 code where not needed. 2019-11-11 mobile-devx-github-bot Checking for zPosition is done on the higher level during traversal. 2019-11-11 mobile-devx-github-bot Add back-to-front traversal that sorts its sibling views by their zPositions. 2019-11-08 sskhandp Move block into variable for nicer formatting. 2019-11-08 mobile-devx-github-bot Initializing performFallback to NO as a default value. 2019-11-08 mobile-devx-github-bot Rename directory for VisibilityChecker. 2019-11-08 mobile-devx-github-bot Add corner case for updating boundingRect. 2019-11-06 tirodkar Fix warnings. 2019-11-06 tirodkar Update Podspecs for EG 2.1.0 release. 2019-11-06 mobile-devx-github-bot Changing the order of the view hierarchy back to front. 2019-11-06 tirodkar Clean up EDO imports. 2019-11-05 tirodkar Add EG 2 Changelog. 2019-11-05 tirodkar Experiment for draining before shifted view after-screenshot 2019-11-05 mobile-devx-github-bot Restructure visibility checker files to accommodate GREYQuickVisibilityChecker. 2019-11-05 mobile-devx-github-bot Changing the order of the view hierarchy back to front. 2019-11-05 mobile-devx-github-bot Internal change 2019-11-04 mobile-devx-github-bot Check q/Q instead of e/E to determine if keyboard is showing alphabetical keyplane. 2019-11-04 sskhandp Fix broken link in README and minor grammar changes. 2019-10-31 tirodkar Fix project break. 2019-10-31 mobile-devx-github-bot Added fast visibility checker files to VisibilityChecker. 2019-10-30 albertbow Remove invocation on keyWindow in iOS 13 and use alternative. 2019-10-30 tirodkar Remove grey_md5. 2019-10-29 tirodkar Initializer cleanup. 2019-10-29 tirodkar Remove unused key. 2019-10-29 tirodkar Duplicate Matcher for UITextField iOS 13 fix. Created with: roll-dep src/ios/third_party/earl_grey2/src Besides the roll: - Changed BUILD.gn file to build with file/directory changes. - Fixed the OWNERS file in ios/third_party/earl_grey2. - Disabled failing tests from this roll. Bug: 1097387, 1030701, 1099361, 1099358, 1099425, 1099429, 1099430, 1099432, 1099435, 1099436 Change-Id: I048899b3fe758d7e08124c4a3f5ac8cfe5449a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264942Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#783056}
-
Michael Chang authored
Currently the macOS updater code for //chrome/updater lacks self registration. Adding self registration for Install and Promote functionalities. Bug: 1097373 Change-Id: I2a435b49cbcf76a32d6a4c38185b6b55e5c786b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255124 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#783055}
-
Chris Davis authored
This change adds stack overflow protection for the recursive call to build the bookmarks tree. The depth of the tree is limited to 200 as we do for importing bookmarks. Anything deeper than this is silently ignored in the sync operation. Bug: 1093190 Change-Id: Id0cab5097aadc9068a77578ec4c39de536d3818a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246791 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783054}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eb0a25a189b7..5c7b568c6d20 2020-06-26 thakis@chromium.org mac: Add ARM64 support to swiftshader. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1098899 Tbr: swiftshader-team+autoroll@google.com Change-Id: I8c814d9960804d266ce8bb0449c4436a92473390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269960Reviewed-by:
-
Torne (Richard Coles) authored
Mention fieldtrial_testing_like_official_build to ensure builds don't get the test field trial config. Change-Id: I3f664bcf0c81d6d6dde33a4830e13f0dc11e15b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269747 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783052}
-
Tomasz Wiszkowski authored
This change replaces existing implementation of Accessibility with ViewCompat variant for compatibility with early Lollipop devices and adds more verbose announcement for executed action when user interacts with the Header view. Bug: 1099441 Change-Id: Ia3a63643dd3bfa19f46b10ae5b895b482ec3f4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268229 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#783051}
-
