GitLab

DevTools: do console evaluations in the global context of the inspected window. That context is exposed as contentWindow global variable to inject.js by ResetUtilityContext method.
Review URL: http://codereview.chromium.org/149174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19903 0039d316-1c4b-4281-b951-d872f2087c98

send() can send parts of the buffer fed in. We should send parts of the buffer until the entire buffer has been transferred.
Review URL: http://codereview.chromium.org/150229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19902 0039d316-1c4b-4281-b951-d872f2087c98

Some layout tests failed in a recent merge due to a FocusController change. They now pass (and a new test fails).

BUG=http://crbug.com/15780
TEST=Run the layout tests.
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/155044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19901 0039d316-1c4b-4281-b951-d872f2087c98

one in which isNull() returns true.

This assertion was being tripped as a result of some
recent changes I made to expose a CGImageRef as the basis
or a WebKit::WebImage.  I think it makes sense to put
this null check in CGImageToSkBitmap instead of at each
callsite.

TEST=covered by mac ui tests
BUG=none
TBR=mark

Review URL: http://codereview.chromium.org/149173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19900 0039d316-1c4b-4281-b951-d872f2087c98

We used to store/restore the frame and node that were focused last when a age would lose/gain focus. 
This patches lets WebKit takes care of it by using the new FocusController::setFocused method.

BUG=http://crbug.com/15777
TEST=Open www.google.com, the focus should be on the text-field (focus ring + blinking caret). Activate another window. The page should not show the text-field with the focus. Switch tabs, make sure the focus is remembered correctly. Do the same tests in a page with frames. Run the layout tests.


Review URL: http://codereview.chromium.org/151195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19899 0039d316-1c4b-4281-b951-d872f2087c98

SkBitmap member (avoiding a level of indirection).

This CL makes it so that Mac Chrome will now write bitmap data to the clipboard
when requested by WebKit.  I also simplified the ImageDecoder class that lives
in glue.

BUG=15648
TEST=none
R=dglazkov

Review URL: http://codereview.chromium.org/155010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19892 0039d316-1c4b-4281-b951-d872f2087c98

This code was written months ago, but temporarily disabled due
to build issues.  Let's see if the buildbots like it now!

Review URL: http://codereview.chromium.org/155036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19890 0039d316-1c4b-4281-b951-d872f2087c98

This project is responsible for listing and copying the 
extensions we want to ship with Chrome by default. It 
copies the .crx files listed in the project plus a
.json file from:
  src\chrome\browser\extensions\default_extensions
to
  debug\extensions

... where the mini_installer will pick them up. At the
moment only the json file is getting copied, but we can
add .crx files when they are ready.

BUG=None
TEST=I will give a build to QA for testing this.

Review URL: http://codereview.chromium.org/155016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/155025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19888 0039d316-1c4b-4281-b951-d872f2087c98

our Coverity overlord.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/149155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Coverity should stop complaining about this leak.

Review URL: http://codereview.chromium.org/149153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19886 0039d316-1c4b-4281-b951-d872f2087c98

Hide menus when the window is blurred or the user presses Alt or Meta.

Only show tootlip for the title of the thumbnail.

Allow mouse over on the window menu.

Made the windows opaque but with a hsla background color to make it more readable.

Quote all background image URLs so that we can display icons for URLs with spaces in them.

Call preventDefault when using the keyboard to navigate the options menu so that the page does not scroll.

BUG=15268, 15503, 15715, 15769, 15411, 15458

TEST=See bug descriptions

Review URL: http://codereview.chromium.org/149163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19884 0039d316-1c4b-4281-b951-d872f2087c98

Update layout test expectations so that LayoutTests/plugins/netscape-plugin-map-data-to-src.html is grouped with the rest of all the failing plugin tests on mac.
Review URL: http://codereview.chromium.org/155034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19883 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19882 0039d316-1c4b-4281-b951-d872f2087c98

The layout test LayoutTests/fast/js/navigator-mimeTypes-length.html asserts
that the number of mimetypes handled by plugins should be greater than the
number of plugins.  This isn't true if the layout test plugin is the only
plugin and it only handles one mimetype, so we make it handle an additional
fake mimetype.

Review URL: http://codereview.chromium.org/149146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=13907,15664
TEST=media layout tests should no longer unexpecedtly pass

Review URL: http://codereview.chromium.org/149133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19880 0039d316-1c4b-4281-b951-d872f2087c98

Modify ThumbnailStore to make one call to the HistoryBackend using QueryTopURLsAndRedirects instead of a seperate call for each URL.  Also clean up some of the code and fix bug 14644.

BUG=14644
TEST=none

Review URL: http://codereview.chromium.org/149126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19879 0039d316-1c4b-4281-b951-d872f2087c98

Hard code the DOM and the layout for the default case so that we do not
need to do any js layout at startup.

Be more careful when calling layout. I added a dirty bit so that we
don't layout too often.

CSS cleanup/optimization to make selectors faster.

TEST=Run the perf test

BUG=13362

Review URL: http://codereview.chromium.org/149127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19877 0039d316-1c4b-4281-b951-d872f2087c98

We had some undefined symbols in webkit_glue.

Review URL: http://codereview.chromium.org/149162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=n/a

Review URL: http://codereview.chromium.org/150211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/15500
TEST=select an image in a file chooser

Review URL: http://codereview.chromium.org/151100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19874 0039d316-1c4b-4281-b951-d872f2087c98

TEST=along with <http://codereview.chromium.org/151100>, it's possible to preview jpeg images
BUG=none

Review URL: http://codereview.chromium.org/151163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=4202
TEST=added regression test.
Review URL: http://codereview.chromium.org/149143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19872 0039d316-1c4b-4281-b951-d872f2087c98

height = 29 matches windows constant
padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows.

BUG=http://crbug.com/15882
TEST=look at bookmark bar

Review URL: http://codereview.chromium.org/155019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19871 0039d316-1c4b-4281-b951-d872f2087c98

TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug
BUG=http://crbug.com/15844

Review URL: http://codereview.chromium.org/149151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/15859
TEST=see bug

Review URL: http://codereview.chromium.org/155008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19869 0039d316-1c4b-4281-b951-d872f2087c98

A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.

A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.

TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images.
http://crbug.com/13967

Review URL: http://codereview.chromium.org/150176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19867 0039d316-1c4b-4281-b951-d872f2087c98

The current implementation only allows getting file size
if the child process has been granted permission to upload file.
May need to update the policy checking code if getFileSize
is needed in other cases.

Here is the webkit implementation to support this:
https://bugs.webkit.org/show_bug.cgi?id=26521

TEST=none
BUG=9102

Review URL: http://codereview.chromium.org/131082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19865 0039d316-1c4b-4281-b951-d872f2087c98

Turning async loading off to get the beachdemo to work again in IE.  This is logged as issue #82.  Once it's fixed, we should turn async loading back on.
Review URL: http://codereview.chromium.org/155028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19864 0039d316-1c4b-4281-b951-d872f2087c98

Fixing the check for offscreen. If the variable doesn't exist, then the function will return 0 and off_screen should be false.

Review URL: http://codereview.chromium.org/149157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15784


Review URL: http://codereview.chromium.org/155001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19862 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/1455

Review URL: http://codereview.chromium.org/149156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/74002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19860 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/147237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19859 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
BUG=15892
TEST=none
Review URL: http://codereview.chromium.org/149158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19857 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19854 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19851 0039d316-1c4b-4281-b951-d872f2087c98