- 17 Oct, 2017 40 commits
-
-
Lei Zhang authored
Fix some other nits in prefs code too. Change-Id: If08a48575024d8e338cc5ef009ba8535627584dd Reviewed-on: https://chromium-review.googlesource.com/721805Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#509487}
-
Andrey Kosyakov authored
Bug: 767683 Change-Id: Ib0da19e7fc845149b622c19af043760fb0eb2bed Reviewed-on: https://chromium-review.googlesource.com/719582 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509486}
-
Eric Lawrence authored
Previously, the "reduce-security-for-testing" flag was used by autofill and an Android media playback codepath to workaround limitations in test code. Everything that previously checked this flag is now gone and now the flag itself can be removed. Bug: 770356 Change-Id: I414d55a88d39c5f1116a4d9cf96682fd648b7089 Reviewed-on: https://chromium-review.googlesource.com/693289 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#509485}
-
Lei Tian authored
This reverts commit 3c56f8b6. Original test fails because for Tablet, ToolbarManager. mShouldUpdateToolbarPrimaryColor is false which prevents ToolbarManager to update the primary color. So for tablet, https scheme should be always emphasized if it is not in incognito mode. Bug: 771559,774979 Change-Id: I69bc09e0d933b0fd46760990030dccb5e7e7de76 Reviewed-on: https://chromium-review.googlesource.com/722129 Commit-Queue: Lei Tian <ltian@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#509484}
-
Peiyong Lin authored
The patch that added EQT plumbing to GRC was suspected as a cause of OOM crash when Windows was waken up, thus revert it speculatively. BUG=763710 Change-Id: I4695328752aa5c9a19f100dbeaaefd2afb1b350b Reviewed-on: https://chromium-review.googlesource.com/721613 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#509483}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f9068a5c08e5..6dc4fb899acf $ git log f9068a5c0..6dc4fb899 --date=short --no-merges --format='%ad %ae %s' 2017-10-17 dsinclair Remove friends from PWL classes 2017-10-17 dsinclair Remove fxge/ friend classes Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I8edd0e6a174beeb9fc27910c18fae1d768e3a820 Reviewed-on: https://chromium-review.googlesource.com/723751 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509482}
-
rnephew authored
Bug: 713222, 775560 Change-Id: I720321450eff6bf27c7f0648d9b777a46fb301b7 Reviewed-on: https://chromium-review.googlesource.com/723641Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#509481}
-
Dave Schuyler authored
This CL applies GlobalScrollTargetBehavior to the siteData iron-list so that the list only shows one scroll bar (rather than two) and the list scrolls properly. Bug: 775215 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b21f099446dabdf3e356dd66898352d8bc73610 Reviewed-on: https://chromium-review.googlesource.com/722340Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#509480}
-
Qiang Xu authored
1-pager: go/tablet-mode-screenshot-hotkey changes: - Creates PowerButtonScreenshotController for handling tablet mode power button screenshot accelerator. It is android-like accelerator now, which requires pressing power button and volume down simultaneously, the delay currently is set to 150 ms. - Makes volume down wait 150 ms (do not propagate it), and if power button is pressed, taking a screenshot, and do not propagate any volume down events. - For tablet power button, volume down or volume up key pressed cancels/invalidates the tablet power button behavior. - For forced clamshell power button (eve), make power button wait 150 ms, if volume key pressed, do not start the pressed clamshell power button. - Removes old power button screenshot logic code. - Add test coverage for new power button screenshot code. Follow-up work: - UMA: Record the delay between power button pressed and volume-down pressed. button, also added test coverage in power_button_screenshot_controller_unittest.cc Bug: 712072 Test: device test for both tablet power button and forced clamshell power Change-Id: I31e0a49317079557904a9e435f210a532364acc9 Reviewed-on: https://chromium-review.googlesource.com/704193 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#509479}
-
Fredrik Söderquist authored
This changes the path used for invalidation of filter effects (SVGFE*) from the layout tree to the DOM tree. This is done to allow invalidation to work when the filter is not part of the layout tree. That change will be done in a follow-up. Also add casting helpers for SVGFilterPrimitiveStandardAttributes and use it where applicable. Bug: 773811 Change-Id: I275534e59eb285c0cab805f6c09d00b1f725e4f4 Reviewed-on: https://chromium-review.googlesource.com/719837Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#509478}
-
Pavel Feldman authored
DevTools: assign devtools_main_frame_token for a newly created render view host in response to CreateNewWindow request. This is a follow up to r507878, it fixes one missing render frame creation code path. Bug: 715541 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I411b1ab93994e8722141bc8f747d0b8ec41d2409 Reviewed-on: https://chromium-review.googlesource.com/721891Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509477}
-
rbpotter authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0dae825d594d74c38877a1fd18838fe338bcc6df Reviewed-on: https://chromium-review.googlesource.com/721876 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#509476}
-
Wei-Yin Chen (陳威尹) authored
crrev.com/c/704398 unified the availability of partner customizations like bookmarks, homepage, etc. The rule was: they are available if Chrome is a system package, or is force-enabled by a command line argument "--allow-partner-customization". Hiding behind a command line argument reduced the benefit of staged deployment, and lowered the real world coverage. Now the rule is: partner customizations are available if Chrome is a system package, or is on pre-stable channels. Bug: 617284, 773623 Change-Id: I594c0313781cc9c10ab73d6e0f4d7e837d578d46 Reviewed-on: https://chromium-review.googlesource.com/719472 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Daniel Murphy authored
This reverts commit d81a48d9. Reason for revert: failing mac builders Bug: 775614 Original change's description: > Allow Chrome on Mac to recognize multiple MFi gamepads > > Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated > by the GameController framework. When multiple such devices are > connected at once, Chrome fails to properly distinguish them. > > GCController exposes a playerIndex field that defaults to the value > GCControllerPlayerIndexUnset (-1). The application may set this field > to a value between 0 and 3 to signal which LEDs should be lit on the > gamepad. Chrome also uses this field to distinguish gamepads, but does > not set the index to a unique value. This causes the first-connected > gamepad to shadow any other connected gamepads. > > This CL ensures each connected MFi gamepad is assigned a unique player > index up to the OS-defined limit of four. > > BUG=775270 > > Change-Id: Ic60efe4a660f3d6c9ca2f840d059f23c78a6fa6c > Reviewed-on: https://chromium-review.googlesource.com/722442 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509464} TBR=bajones@chromium.org,mattreynolds@chromium.org Change-Id: I4351f37277bf939055d3d1b0b123a3f9400c9043 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775270 Reviewed-on: https://chromium-review.googlesource.com/723805Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#509474}
-
Robert Liao authored
Response to https://chromium-review.googlesource.com/c/chromium/src/+/722103/4/base/win/scoped_variant.h BUG= Change-Id: I5322c3f7295d50d657d2343a2ad45d7c767139b9 Reviewed-on: https://chromium-review.googlesource.com/723767 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6342128c3c81..1e0b7a5ad455 $ git log 6342128c3..1e0b7a5ad --date=short --no-merges --format='%ad %ae %s' 2017-10-17 dnj [cipd] Fix ppc64le uname. Created with: roll-dep src/third_party/depot_tools BUG=773857 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: I809b3936c92a3d1031d6289988aa97d86a9ffb44 Reviewed-on: https://chromium-review.googlesource.com/723779Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509472}
-
Joel Kitching authored
BUG=b:64195183 TEST=./validate_format.py && ./pretty_print.py CQ-DEPEND=CL:691398 Change-Id: I76b2ead9519188d9baa50dca3dfa62359ff426ca Reviewed-on: https://chromium-review.googlesource.com/718556Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Joel Kitching <kitching@chromium.org> Cr-Commit-Position: refs/heads/master@{#509471}
-
Matt Reynolds authored
The SteelSeries Nimbus is a Made For iOS (MFi) gamepad. In Chrome for Mac, MFi gamepads are enumerated through the GameController framework. The Nimbus is also detected as a generic USB HID device, which are enumerated by GamepadPlatformDataFetcherMac. To prevent the gamepad from being enumerated by both data fetchers and taking an extra gamepad slot, the vendor/product ID pair for the Nimbus is blacklisted in the platform data fetcher. BUG=775268 Change-Id: Idf8510663ab15b0c11c1b0dd712f3889383e6894 Reviewed-on: https://chromium-review.googlesource.com/722522Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#509470}
-
Sigurdur Asgeirsson authored
It appears blocking in-line with startup has a performance impact, as some browser tests reliably time out with this in effect. Bug: 620813 Change-Id: Ibfa722ce7a5062f6ae74d63fc59d8371af2645d9 Reviewed-on: https://chromium-review.googlesource.com/721462Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509469}
-
Lei Zhang authored
Fix a couple other nits in the comments. Change-Id: I62e91808cbbe96190bf0c1ca9c939c1a2c65c4de Reviewed-on: https://chromium-review.googlesource.com/721963Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#509468}
-
Charles Harrison authored
The class is a URLRequestInterceptor which intercepts URL requests to the safe browsing endpoint https://safebrowsing.googleapis.com/v4 and responds with canned responses. This allows browsertests to additionally test that V4 metadata parsing is working as intended. Bug: 775530 Change-Id: I40d4504768b46d00259f13f2900be98fa6a713c1 Reviewed-on: https://chromium-review.googlesource.com/719816 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#509467}
-
Joy Ming authored
This is part of a larger refactor to make downloads a foreground service on all versions of Android. During the refactor, a few tradeoffs had to be made (ie. optimizing for single download or multiple). These metrics can give light into how to make such tradeoffs in the future, specifically around: notification interactions, number of notifications (as a proxy for multiple downloads), service lifecycle, unexpected/expected service stops, etc. Bug: 747563 Change-Id: I90ab96c863bfaa77ded0d09c74277f10795dfdf1 Reviewed-on: https://chromium-review.googlesource.com/710579Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#509466}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/06d8821c..4c81dcd5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I9e5ea75f713713ef79f7d07723dab695832d1795 Reviewed-on: https://chromium-review.googlesource.com/723502Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509465}
-
Matt Reynolds authored
Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated by the GameController framework. When multiple such devices are connected at once, Chrome fails to properly distinguish them. GCController exposes a playerIndex field that defaults to the value GCControllerPlayerIndexUnset (-1). The application may set this field to a value between 0 and 3 to signal which LEDs should be lit on the gamepad. Chrome also uses this field to distinguish gamepads, but does not set the index to a unique value. This causes the first-connected gamepad to shadow any other connected gamepads. This CL ensures each connected MFi gamepad is assigned a unique player index up to the OS-defined limit of four. BUG=775270 Change-Id: Ic60efe4a660f3d6c9ca2f840d059f23c78a6fa6c Reviewed-on: https://chromium-review.googlesource.com/722442Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL removes the pixel-value comparison from detection-HTMLVideoElement.html LayoutTest because it has platform quirks, e.g. in Linux the white colour is read back as 0xFFFFFEFF, breaking the comparison. Bug: 775127 Change-Id: I563f208bf858da80813631e0f2a66181bf94375b Reviewed-on: https://chromium-review.googlesource.com/721886Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#509463}
-
Kevin Marshall authored
Bug: 772488 Change-Id: Ie71f5b620b59c9618bbe4c05b61dad23ba37fb23 Reviewed-on: https://chromium-review.googlesource.com/710861Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#509462}
-
David Tseng authored
ChromeVox handles keys before the touch exploration event handler, so dispatching raw control keys won't work. Map the gesture to stop speech similarly to the way we do now for other gestures. Bug: 774885 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idf8d861a7887003c0fe12e364f3eef198567d18a Reviewed-on: https://chromium-review.googlesource.com/721461 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#509461}
-
Xiaohan Wang authored
The CDM needs to access files in PluginPrivateFileSystem to support persistent-state and persistent-license. It opens the through CdmStorage mojo service, which opens the file in the browser process, and pass the file descriptor to the CDM running in the sandboxed CDM (utility) process. Then the CDM needs to be able to read and write the file. To complete the write, we need to call base::File::SetLength() which needs to call ftruncate(). BUG=774762 Change-Id: I60d15bc4c308569128e6c0164d5c5d79bd5c9096 Reviewed-on: https://chromium-review.googlesource.com/720273 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#509460}
-
Tatiana Gornak authored
BUG=739343, 775509 Change-Id: I7f9b42cadd63c55c5b59d9787f6a41ff0742a556 Reviewed-on: https://chromium-review.googlesource.com/707436 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509459}
-
Ryan Harrison authored
There are no longer any callers of this method. BUG=chromium:766790 Change-Id: Ia52406f1ef76a2cb056e7b649f3fcc956f6c1a32 Reviewed-on: https://chromium-review.googlesource.com/723128Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#509458}
-
Ben Chan authored
Bug: 755727 Change-Id: I4c2a8db5950d867140cca53b6d28747d6eae9b31 Reviewed-on: https://chromium-review.googlesource.com/722177Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509457}
-
Klaus Weidner authored
This is one of the native GL methods needed for working with AHardwareBuffer objects. From https://developer.android.com/ndk/guides/stable_apis.html#a26 The native hardware buffer API (<android/hardware_buffer.h>) lets you directly allocate buffers to create your own pipelines for cross-process buffer management. You can allocate a AHardwareBuffer struct and use it to obtain an EGLClientBuffer resource type via the eglGetNativeClientBufferANDROID extension. You can pass that buffer to eglCreateImageKHR to create an EGLImage resource type, which may then be bound to a texture via glEGLImageTargetTexture2DOES on supported devices. This can be useful for creating textures that may be shared cross-process. Documented at: https://www.khronos.org/registry/EGL/extensions/ANDROID/EGL_ANDROID_get_native_client_buffer.txt BUG=761432 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I252641374dd0c6d7df7e02828c3572bedbecb1fc Reviewed-on: https://chromium-review.googlesource.com/679961Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509456}
-
rbpotter authored
Bug: 770851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieb74b2babaed060314746da71dbe508f763febea Reviewed-on: https://chromium-review.googlesource.com/722279Reviewed-by:
-
Alexander Alekseev authored
When user hits Enter on focused "Learn More" link of the EULA screen, adjacent checkbox was involuntary triggered. This CL fixed it. Bug: 771095 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I500ab0c41934c124a6ee1fa03a1ea7f62faf5485 Reviewed-on: https://chromium-review.googlesource.com/721892Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#509454}
-
Henrik Boström authored
Now that RTCPeerConnection and RTCPeerConnectionHandler listens to tracks being added/removed, not streams, we know when receivers are added or removed and keep track of them. This simplifies getReceivers() to "return rtp_receivers_;" instead of querying the lower layers. Bug: 741619 Change-Id: I84c43df31259bce8e31b9c34945ed8d972e45ca7 Reviewed-on: https://chromium-review.googlesource.com/707798Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#509453}
-
Raymond Toy authored
The method WarnIfOutsideRange is declared but not implemented and not used anywhere. Remove it. Bug: 774659 Test: None Change-Id: I1b852348fbea1cab9a5ff64c8a9c0e78423a4532 Reviewed-on: https://chromium-review.googlesource.com/719539Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509452}
-
Will Chen authored
There's some namespace collisions between ProfilerTestRunner.js and HeapSnapshotTestRunner.js (e.g. completeProfilerTest, startProfilerTest) so I split it into two modules and now profiler_test_runner should be only CPU-related and not memory-related. This also eliminates code duplication between the legacy and new test framework for these test helper modules. Bug: 667560 Change-Id: Icbd648df37ba2faddde5d2f8ab22b8a8350b622b Reviewed-on: https://chromium-review.googlesource.com/722222Reviewed-by:
-
Marc Treib authored
Previously, these tests used real databases, including disk I/O. Better to use fakes for unit tests. Bug: 755985 Change-Id: Icb9043593ff3bce6f54b9803294cf81a0944d4b3 Reviewed-on: https://chromium-review.googlesource.com/720810 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509450}
-
Boris Sazonov authored
This CL fixes a crash introduced by https://crrev.com/c/675684, which added a cache of the account list to AccountManagerFacade. Since the cache is updated asynchronously, the following situation could occur: 1. Account A is added to the account list. 2. AccountManagerFacade starts updating the cache asynchronously. 3. AccountsChangedReceiver notifies AccountTrackerService about the change to the account list. 4. AccountTrackerService gets account list from AccountManagerFacade. AccountManagerFacade returns the cached list (without the account A). 5. AccountTrackerService seeds the old account list and clears the mSystemAccountsChanged flag. 6. AccountManagerFacade finishes updating account list. 7. Now AccountTrackerService considers the account list to be up-to-date and never seeds account A. 8. Some code path tries to get account info for account A and crashes. This CL fixes the issue by adding an AccountsChangeObserver to AccountTrackerService that will invalidate seeding status whenever the cached account list in AccountManagerFacade changes. Bug: 768366 Change-Id: Ia1c8dcb6ac5b4033d6ed1ee204db50aaf8e02964 Reviewed-on: https://chromium-review.googlesource.com/721439 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#509449}
-
Alex Newcomer authored
Pagination grid animations should be constant regardless of whether they are partially completed. I created a new flavor of SlideAnimation for this, which ensures that the duration is dampened if the animation is partway complete. Also I added a new unit test for this new flavor of SlideAnimation. Bug: 771262 Change-Id: Ibb40799cb6d15b04e1e2f9f36ac224c3d28daf13 Reviewed-on: https://chromium-review.googlesource.com/699431 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
