- 18 Jul, 2018 40 commits
-
-
Pavol Marko authored
This reverts commit 8b20bfaf. Reason for revert: This should only apply on Chrome OS, see follow-up CL:1141742 . Original change's description: > Introduce command-line switch to force-enable developer tools > > Since CL:1125855, the new default is that policy-installed extensions > can not be inspected by developer tools. > However, some autotests rely on inspecting policy-installed extensions > and it is infeasible to change the policy the device sees there. > Introduce the "--force-devtools-available" command-line switch which > enforces developer tools availability. > > Bug: 838146 > Test: browser_tests --gtest_filter=*DevTools* > Change-Id: I666d9785195eff53f1a1346d95177985d1573d72 > Reviewed-on: https://chromium-review.googlesource.com/1140308 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575994} TBR=dgozman@chromium.org,atwilson@chromium.org,pmarko@chromium.org,jochen@chromium.org Change-Id: I8ca2b4920ebec5dbc811bdf05fbbf39afc94dc08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838146 Reviewed-on: https://chromium-review.googlesource.com/1142104Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576072}
-
Chris Hamilton authored
Currently there's an inversion where active tabs in minimized windows don't get loaded as they are created. This is an optimization in the occlusion tracking code that doesn't calls ReloadIfNecessary unless the window hosting the active tab actually becomes visible. Due to this inversion the TabLoader can start loading background tabs in the minimized window before the active tab in the minimized window is ever loaded. Giving TabLoader responsibility to load all tabs fixes this. In the case of active and visible tabs whose loads are initiated by the browser this is fine because calling ReloadIfNecessary twice is effectively a nop, and the TabLoader is already smart enough to track tabs that have started loading for external reasons. BUG=864725 Change-Id: I4b86a71470b2cb1a1a9106c4d4d92ee6b18c7284 Reviewed-on: https://chromium-review.googlesource.com/1141071Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#576071}
-
Xiaocheng Hu authored
Cold mode spellchecker sometimes creates shadow-crossing checking ranges (due to EndOfSentence() crossing shadow boundary). SpellCheckRequest converts the checking range into a |Range|, which may have a different or even null root editable element, and crashes when it's null. This patch stops the crash in such case. Note: So far we haven't found stable and meaningful test cases with shadow-crossing checking ranges, so we only stop the crash right now without further fixes. Bug: 863784 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I27e61f8bb2921559799a986b6d99c8c3d2fb114f Reviewed-on: https://chromium-review.googlesource.com/1141426Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#576070}
-
Fabio Tirelo authored
Accessibility event notification requires the popup's widget to exist. Widgets destruction order by the OS is not guaranteed, so this CL adds an observer to hide the popup if the widget is destroyed. Bug: 842183 Change-Id: Ibd7a70168af46e2ae20fd68addb0ad4d030de873 Reviewed-on: https://chromium-review.googlesource.com/1140194 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#576069}
-
David Grogan authored
Used to include padding scrollbars border Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I69a56029aded1f33bf232444de79026335a3bfa5 Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/1136058 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#576068}
-
Daniel Bratell authored
split_static_library is mainly a fix to avoid hitting internal size limits in the Windows toolchain and it's not needed when using lld because its thin archives are orders of magnitude smaller. Bug: 857060 Change-Id: Idf101fc57d5fed8ee8644715fdebb879f7974da6 Reviewed-on: https://chromium-review.googlesource.com/1138330 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#576067}
-
Friedrich Horschig authored
This reverts commit 82c224b0. Reason for revert: The linked build (7968) wasn't the first broken build. The first broken build was 7959 where https://crrev.com/c/1139057 reenabled this known-to-be-flaky test (see issue 849582). dullweber@ takes care of the new revert. Original change's description: > Revert "[Android] Change suggestions based on frame of focused field" > > This reverts commit 4c9cbfb5. > > Sorry for the revert -- this is failing on one of the ChromeOS builders: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/7968 > > You can see several failed tests in this log output: > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940668796232357776/+/steps/interactive_ui_tests/0/logs/All__x2f_PasswordManagerBrowserTestWithConditionalPopupViews.AutofillLoginSignupForm__x2f_1/0 > > > Original change's description: > > [Android] Change suggestions based on frame of focused field > > > > With this CL, the renderer notifies the password accessory controller > > when the focus moves to or away from valid input fields. > > > > Bug: 854152, 854150, 854149, 853742 > > Change-Id: I63f075ce238db8b77c784e945eea8ec83d8d4344 > > Reviewed-on: https://chromium-review.googlesource.com/1124466 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Reviewed-by: Mike West <mkwst@chromium.org> > > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575977} > > TBR=vasilii@chromium.org,dvadym@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org > > Change-Id: I01cc79e8dc98e29cbdb1a61c6da5a4cf021fcbfb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 854152, 854150, 854149, 853742 > Reviewed-on: https://chromium-review.googlesource.com/1141825 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576042} TBR=vasilii@chromium.org,dvadym@chromium.org,iclelland@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org Change-Id: Idaadebd9b00179935c3f6347cc669c0811a912e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854152, 854150, 854149, 853742 Reviewed-on: https://chromium-review.googlesource.com/1141885Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#576066}
-
Gabriel Charette authored
The existing documentation mentioned "narrow scope" and that could be read to infer as-close-as-possible to the AssertBlockingAllowed call. However, the allowance should specifically not be in low-level/intermediary code but rather in the client code which can then make an informed decision on whether blocking is allowed. R=fdoray@chromium.org NOTRY=True Bug: Docs Change-Id: I71db615900933768b5b0ea89f548cf030d9b96c9 Reviewed-on: https://chromium-review.googlesource.com/1127346 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#576065}
-
erikchen authored
Bug: 861939 Change-Id: Ia86ab5aaa039dd4df38ca722d853907262c16930 Reviewed-on: https://chromium-review.googlesource.com/1140197Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576064}
-
Vaclav Brozek authored
When the new FormData->PasswordForm parser looks for the username with its basic heuristics, it only considers the most likely fields the user would interact with (visible > with some value > the rest). This filter is on purpose not applied to server hints and autocomplete attribute analysis. But it should be applied to the local HTML classifier. This CL makes that happen by reordering the analysis steps to do basic heuristics before the HTML classifier, because the heuristics need to compute the bar for interactability. With that bar computed, the parser additionally runs the HTML classifier on fields meeting that bar. Bug: 851808 Change-Id: I0e54b6c1c6387b6130d297131b0dcb83fe52e265 Reviewed-on: https://chromium-review.googlesource.com/1141873 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#576063}
-
Henrik Boström authored
Add control to WebRtcSet[Local/Remote]DescriptionObserverHandler whether to only surface receievers (current/Plan B behavior) or transceivers (Unified Plan behavior). This will be needed in a follow-up CL. // Already passed all the bots except an unrelated random flake on one // bot, no need to wait for it to re-run. NOTRY=True Bug: 777617 Change-Id: I9cd311f9ef6e44028cb3e35457280f70a0695992 Reviewed-on: https://chromium-review.googlesource.com/1141876 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#576062}
-
Ian Clelland authored
external/wpt/encoding/legacy-mb-korean/euc-kr/euckr-decode-ksc_5601.html started failing recently on some Mac bots. Marking as flaky per WPT import instructions. Bug: 865004 Change-Id: I7f0fd0e3af4fbd5fce041456c906facf279a8c0b Tbr: jsbell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1141926Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576061}
-
Orsi Batiz authored
attribute src of HTMLEmbedElement changed from DOMString to ScriptURLString Tests added Bug: 739170 Change-Id: I6ded15b826d1da0d95f31885577db61f5adc7375 Reviewed-on: https://chromium-review.googlesource.com/1140305 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576060}
-
vitaliii authored
Bug: 851433 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3f9d06fcab5d9a48febc72a5de2554b7bf526dfa Reviewed-on: https://chromium-review.googlesource.com/1131183Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576059}
-
Peter Boström authored
* Adds meaning to "Paused" and "Error" short strings. * Takes context screenshots for both. * Moves screenshot folder to profile_strings_grdp so it gets detected by the upload script. Bug: chromium:863978 Change-Id: Ie62f52bbb67c33188658d170b9a12cb6d565d1aa Reviewed-on: https://chromium-review.googlesource.com/1141355Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576058}
-
Henrik Boström authored
This was recently added to webrtc::RtpTransceiverInterface. It is added to WebRTCRtpTransceiver and the content implementations are updated. Also removes unimplemented WebRTCRtpTransceiver::Stop() and does some minor refactoring. // Already passed all the bots except an unrelated random flake on one // bot, no need to wait for it to re-run. NOTRY=True Bug: 777617 Change-Id: I845e0d369a6af5ee162ba14f78f27047f499a046 Reviewed-on: https://chromium-review.googlesource.com/1141871 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#576057}
-
Robert Kroeger authored
ozone/drm/mojo did not support GPU process restart. Add the necessary handler to clear the cursor bindings and mark the connection as unavailable. BUG=620927 TEST=Run chrome --enable-drm-mojo on device, use chrome://gpucrash Change-Id: I6a552a93bc923d7633e5c60890c53197accb48f8 Reviewed-on: https://chromium-review.googlesource.com/1139017Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#576056}
-
Peter Boström authored
* Makes the PageActionIconView use a RoundRect. * Uses a mirrored rect for the security chip to fix placement in RTL. Bug: chromium:864594 Change-Id: I726c79752bf8c8601dac994f0386567ac03c840d Reviewed-on: https://chromium-review.googlesource.com/1141347Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576055}
-
Peter Boström authored
Makes use of RoundRects similar to ToolbarButton and friends to match the inkdrop look. Bug: chromium:864594 Change-Id: I91a8edff35624561b1a299ce3fd838493088f578 Reviewed-on: https://chromium-review.googlesource.com/1141296Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576054}
-
Christian Fremerey authored
When a video capture device is stopped, the video capture service is supposed to send callbacks to OnBufferRetired() to the receiver. A subtle message order issue caused these events to not actually make it through to the receiver. This CL fixes the ordering issue and adds a test case to ensure that the events arrive. This issue has surfaced on Android Canary, see crbug. The reason this has not caused any issue on other platforms is probably that in most use cases, when the device is stopped, the receiver is torn down as well. Bug: 862055 Change-Id: I6a2d895bbcbe8d0236d1a5041ee58c6f2e8cf926 Reviewed-on: https://chromium-review.googlesource.com/1140527Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#576053}
-
Rouslan Solomakhin authored
Stop monitoring bubbles and autofill for rouslan@ because no longer an owner or developer there. Bug: NONE Change-Id: I7fa00806450e505155aa1a28ecd6c9a6657a407b Reviewed-on: https://chromium-review.googlesource.com/1141281Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576052}
-
Sky Malice authored
The feed bug the old TODO mentions is now fixed, and this triggerRefresh() call is both not needed and actually cause a problem. It seems that existing content is being cleared on cold starts due to this. By removing it the feed behaves as it should. Change-Id: I1886962876696b06e93348d97aa88cbc80fae4fb Reviewed-on: https://chromium-review.googlesource.com/1140526Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#576051}
-
danakj authored
Just template the constructor with the arguments and forward them along with "perfect forwarding". R=dgozman@chromium.org Bug: 419087 Change-Id: I7f7b6ac11e5cbaeb1596db2b105ffe2b8e40d84f Reviewed-on: https://chromium-review.googlesource.com/1140897 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576050}
-
Jonathan Ross authored
In a previous change the failing CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground was set to exit early for surface sync: https://chromium-review.googlesource.com/c/chromium/src/+/1141110 This is because the test is not valid in the surface sync world. It was removed from filtering in Viz configs, but not Surface Sync. This updates that filter too. TEST=P/CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground/0 TBR=fsamuel@chromium.org Bug: 855533 Change-Id: I318fb474fd838418b21a38ca421e7fa7cbc326d7 Reviewed-on: https://chromium-review.googlesource.com/1141905 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#576049}
-
Greg Thompson authored
A little noise was left behind inadvertently following a tweak late in the review process for the initial commit. BUG=none R=georgesak@chromium.org Change-Id: I0df23bc4366eef91249e8cbf86d19e6c5d0d537e Reviewed-on: https://chromium-review.googlesource.com/1141575Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#576048}
-
Antonio Gomes authored
BUG=838955 TBR=noyau@chromium.org (one line in ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc) Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I050dbe74fc7ccd7b7811a5532abc931fda189177 Reviewed-on: https://chromium-review.googlesource.com/1140973 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576047}
-
Ulan Degenbaev authored
Bug: 808143 Change-Id: Ib5b2b6c264528581e89237f49328e738082ac808 Reviewed-on: https://chromium-review.googlesource.com/1141739 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576046}
-
Orsi Batiz authored
Changing src attribute of HTMLMediaElement from DOMString to URLString Adding SetSrc to html_media_element.cc which takes USVStringOrTrustedURL as argument Added tests Bug: 739170 Change-Id: Ifde2c90add06cb7ba55596e3cbc06fb160ee2378 Reviewed-on: https://chromium-review.googlesource.com/1141737 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#576045}
-
Matthew Cary authored
These benchmarks will be used to train the new production android orderfile. This is a reland of crrev.com/c/1124561 which was reverted due to presubmit errors which have been fixed. Bug: 843561 Change-Id: Id200a5957d20d19dc7fe83555c04aa9cecf51f27 Reviewed-on: https://chromium-review.googlesource.com/1125842Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#576044}
-
Devlin Cronin authored
Bug: 840412 Change-Id: I3da214023c2e896266e171cb153d367c43d6b2ba Reviewed-on: https://chromium-review.googlesource.com/1141069 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576043}
-
Ian Clelland authored
This reverts commit 4c9cbfb5. Sorry for the revert -- this is failing on one of the ChromeOS builders: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/7968 You can see several failed tests in this log output: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940668796232357776/+/steps/interactive_ui_tests/0/logs/All__x2f_PasswordManagerBrowserTestWithConditionalPopupViews.AutofillLoginSignupForm__x2f_1/0 Original change's description: > [Android] Change suggestions based on frame of focused field > > With this CL, the renderer notifies the password accessory controller > when the focus moves to or away from valid input fields. > > Bug: 854152, 854150, 854149, 853742 > Change-Id: I63f075ce238db8b77c784e945eea8ec83d8d4344 > Reviewed-on: https://chromium-review.googlesource.com/1124466 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575977} TBR=vasilii@chromium.org,dvadym@chromium.org,piman@chromium.org,fhorschig@chromium.org,mkwst@chromium.org Change-Id: I01cc79e8dc98e29cbdb1a61c6da5a4cf021fcbfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854152, 854150, 854149, 853742 Reviewed-on: https://chromium-review.googlesource.com/1141825Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576042}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. Bug: 846456 Change-Id: I23cfa6b2d02b77f056d16ea447b6a6528c2143ce Reviewed-on: https://chromium-review.googlesource.com/1096005Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#576041}
-
Allen Bauer authored
TBR=estade@chromium.org Bug: 863117 Change-Id: Ie131dfdbc7620b8ce8f14948224089ac9ffa15bb Reviewed-on: https://chromium-review.googlesource.com/1138642Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#576040}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c428ea5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21539 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, scottmg@chromium.org: external/wpt/domxpath mkwst@chromium.org: external/wpt/x-frame-options TBR=foolip No-Export: true Change-Id: Ie38ce374b93e56af9b92fe01cf6d631b37bd8e93 Reviewed-on: https://chromium-review.googlesource.com/1141656 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576039}
-
Anita Woodruff authored
This CL has two effects when notifications are disabled for Chrome: 1. Adds a link to 'Turn on permissions for Chrome' to the site settings of websites that have allowed/blocked notifications. 2. Replaces Settings > Site Settings > Notifications page with a link to 'Turn on permission for Chrome in Android Settings'. See screenshots at https://goo.gl/hVqEwN These effects are guarded behind a flag in about://flags ('Enable app notification status messaging'). Bug: 691898 Change-Id: Ib7b59905cfc4edcc2a80cd6aad45700714502abc Reviewed-on: https://chromium-review.googlesource.com/1140633Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#576038}
-
Maja Kabus authored
helper.js changed to helper.sub.js. URLS.safe modified to work with wpt. Bug: 739170 Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec Reviewed-on: https://chromium-review.googlesource.com/1141725Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Maja Kabus <kabusm@google.com> Cr-Commit-Position: refs/heads/master@{#576037}
-
Christos Froussios authored
When showing the manual fallbacks, we create a PasswordFormManager and pass it to the UI. Previously, this was done by creating a provisional save manager and moving it, but if we failed to move it, it would remain and signal that a submission in the previous navigation. I've refactored the showing of the manual fallbacks to have no side effects on |provisional_save_manager|. Bug: 859156 Change-Id: Iaf41b201bc6c812f483fdb355f8414a77b0a034f Reviewed-on: https://chromium-review.googlesource.com/1138322 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#576036}
-
Daniel Bratell authored
Chromecast wants to scroll exactly like Android and for that the code cloned the mobile scrolling code, but simpler and easier and with less code and fewer jumbo compilation errors is to just use the existing code directly. Only a minor code difference existed and that is controlled with a conditional statement instead now. Bug: 813911 Change-Id: I9d037da9b58c1ad0916dc22ee194328c113075cd Reviewed-on: https://chromium-review.googlesource.com/1136541Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#576035}
-
vitaliii authored
Bug: 840357,850428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I21266676a5e097dac3d7cc75dbff8b65a2ce9d1e Reviewed-on: https://chromium-review.googlesource.com/1141724 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576034}
-
yoshiki iguchi authored
- Adds Rounded corner mask to NativeViewHost of ARC notification - Makes corners of ARC notification background rounded Bug: 847784 Test: Manual (see ARC notification and confirm it has rounded corners) Change-Id: I859f1cbe0ee410fd4852d5b162c43670f6d541f7 Reviewed-on: https://chromium-review.googlesource.com/1100355 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576033}
-