- 03 Aug, 2020 40 commits
-
-
Tamir Duberstein authored
Instead, wait for the first event to arrive. fuchsia.netstack.Netstack eagerly sends a synthetic event upon connection. It is necessary to take this approach because Netstack does not guarantee the ordering of events with respect to non-event FIDL calls. This is a known flaw in the API, the replacement for which is being developed in https://fxbug.dev/21154. Bug: 964161 Change-Id: I1a80e254f9ccddc150b256561bda82c3ac1eef42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331860 Auto-Submit: Tamir Duberstein <tamird@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#794173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6f029c304ca..b5aa09d7531b 2020-08-03 lalitm@google.com Merge "ui: only draw visible data in tracks" 2020-08-03 lalitm@google.com Merge "tp: cache computed columns in experimental slice layout table" 2020-08-03 taylori@google.com Merge "perfetto-ui: Remove separate scheduling category" 2020-08-03 hjd@google.com ui: Fix "Uncaught ReferenceError: window is not defined" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3769e44d2dbb5c778fc499d38e165aec4bc8a814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794172}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib7cbb71865828acf58f92013def4dc34dd7aed9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293276Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#794171}
-
Thomas Lukaszewicz authored
Defines CrSearchFieldBehaviorInterface for CrSearchFieldBehavior such that uses of CrSearchFieldBehavior with the non-legacy class based Polymer3 syntax are parsable by the Closure Compiler. Bug: 1099917 Change-Id: Ic5257e6ca5f59860cebefdedea378905c3fd0fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333208 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794170}
-
Daniel Rubery authored
Since binary uploads don't use cookies, we can use the Profile's URLLoaderFactory and set the request to CredentialsMode::kOmit to prevent accidentally persisting user identifiers. Bug: 1049833 Change-Id: I6e73f5912283d3a2e94a01f0e288bb9f47ec9e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327147Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#794169}
-
Jose Leal Chapa authored
Related frontend CL: https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2303292 Bug: 1074732 Change-Id: Ic3998ce1c51d8dfc48243195b619b74afd57b020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259138 Commit-Queue: Jose Leal <joselea@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#794168}
-
Nodir Turakulov authored
Add an all-purpose "chromium:public" realm where everything is public. Change-Id: I60d98ff828063d024b98d153335a4a36a775c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335354Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794167}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98b332f2dbbd..01a0945e034b 2020-08-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I64bbc798cbf4cd8d414836e6d35f59f7cb04453b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335263Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the tests are passing when the Request Desktop by default flag is enabled. Bug: None Change-Id: Ic5bbb2b00acb61e075bf6d57aa63c1db8892f28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330052 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794165}
-
Richard Knoll authored
This hooks up the NotificationHandler with the NotificationManager to respond to notification clicks and close. Bug: 1102348 Change-Id: I300305a09ed651f488b286e8fcaf5d3f69ceb8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329539Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794164}
-
Min Qin authored
the Data directory could be a sim link in recent Android versions. So need to use canonical path when checking if a file is under it. BUG=1104628 Change-Id: I403b9582e09a799e5c51d2687ce4928dea8e7e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320071Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794163}
-
sczs authored
Calling stringValue on a NSString* crashes in iOS12 Bug: 1112103 Change-Id: Ice356b5a6da6e597fad850c3e5cb99e1f9fef52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332992 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#794162}
-
Mason Freed authored
These got missed the last time around, because they pass when the features are disabled. But they are all only testing WCv0 features, so they belong in the web-components-v0-only directory. Bug: 937746 Change-Id: Ifec22f31a69bf4358c4a4a9dfa5d54f7c3005db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335315 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#794161}
-
Omer Katz authored
This CL is dependent on https://chromium-review.googlesource.com/c/v8/v8/+/2327910/ Bug: 1108537 Change-Id: Ie2121ba8e1460a5979ceeba734ca3a516a63903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327672 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794160}
-
Richard Knoll authored
If a NotificationDelegate calls RemoveNotification in the Close handler we're currently ending up in an endless loop. Instead remove the Notification from the list before calling Close so the next call exits early and is a noop as expected. Bug: None Change-Id: I7ed211ba1bf78a33255211090bfbd11e986dfc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330019Reviewed-by:
-
Dan Harrington authored
Adding ContentSuggestions.Feed.LoadStepLatency.* UMA which record latency for individual steps in loading the feed. Bug: 1044139 Change-Id: I69350a8c9dcec1b0ee2c3260832d865e498bcbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332333 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#794158}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596434376-e66572c4bd7519ea423a67f597bf938ae289c1f8.profdata to chrome-win64-master-1596455409-191726fecbe6a9b7fc8fb41afab59db6a1bbda42.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifec3ac3a0ca4e33dbed9717fc1f13639f2766020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335259Reviewed-by:
-
Clark DuVall authored
getPacProcessor() is an R API and was causing verification errors on lower API levels. This makes a big improvement to startup time: android-pixel2_webview-perf https://pinpoint-dot-chromeperf.appspot.com/job/171ac7ac920000 webview_startup_wall_time -3.2% android-go_webview-perf https://pinpoint-dot-chromeperf.appspot.com/job/164d5e22920000 webview_startup_wall_time -3.4% Bug: 1105096, 1111909 Change-Id: Icfafbf5f20936fe045171603267453ce3f8db266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328302 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794156}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/de0ed93bda63..963bc42f8719 2020-07-31 vapier@chromium.org OWNERS.build: add Stephane 2020-07-31 kevinruvalcaba@google.com Adding 2 data structures for the visualization project. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2c7e4dddd6cc39698196c9d9729e5b2900052461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335262Reviewed-by:
-
Ross McIlroy authored
We are now shipping 64-bit browser to Q+ devices. Pixel2 devices can be upgraded to Android Q (although the ones in the labs are still Android O) and so move these bots to 64-bit to represent what we ship. BUG=chromium:934251 Ignore-CQ-Freeze Change-Id: I69143018228b9df2cda9452c13eb1ff6c68ee905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316259 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794154}
-
Rune Lillesveen authored
Bug: 1111710 Change-Id: Id685b5150e6c7356009f48c248a30383750b9dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332720 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794153}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=danakj@chromium.org Change-Id: I0f5ef4346c5a8deff2813adfcfbf1e41c1802a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298864 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
-
Dan Harrington authored
Hooks up UMA action reporting for several events. We're using Android views to trace actions back to their originating stream slice. This is a bit complicated, but does work well. Some actions aren't yet possible to track from the client, and will likely require server changes. In the interim, I've added some UMA for ephemeral changes, which will give us an idea of how many total hide-story / not interested in actions are triggered. Bug: 1111101 Change-Id: Ia7ad821bed087d75ad43454644fedac9694e8152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329929Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#794151}
-
Reda Tawfik authored
Bug: 1104132 Change-Id: I0e8356ce3cec6162a6367709121e887916916549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289978Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Cr-Commit-Position: refs/heads/master@{#794150}
-
Alex Ilin authored
Updating cookies from GaiaRemoteConsentFlow::OnEndBatchOfRefreshTokenStateChanges() is needed on ChromeOS to push new accounts added from the account manager. On Desktop, sign-in happens on the Web and a new account is directly added to getAuthToken's partition cookie jar. An extra update triggered from OnEndBatchOfRefreshTokenStateChanges might change cookies order in the middle of the consent flow and lead to a bug like https://crbug.com/1112343. This CL makes the cookie update in OnEndBatchOfRefreshTokenStateChanges executed only on ChromeOS. Bug: 1112343 Change-Id: Ica8c888a3572f406b8c282c17049ba9306bf7a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332192Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794149}
-
Dan Harrington authored
I've seen some crashes while debugging clank that appear to have been caused by calling this function from another thread, but the native crash fails to log the java callstack. I'm hoping this assert will help catch the problem closer to the source. Change-Id: I96b4b33a316de5c43c2a7f9a19aeb2e8a9c27fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332564Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#794148}
-
Yuki Shiino authored
This reverts commit e1dce34f. Reason for revert: Most critically due to https://crbug.com/1112227 but not limited to. Original change's description: > bind-gen: Switch to the new IDL interface implementation > > Blink-V8 bindings team has been developing the new improved > Web IDL bindings system, and this patch enables the new > bindings implementation of Web IDL interfaces at build time. > > Note that other IDL definitions (buffer source types, > dictionaries, callback functions, etc.) are not affected and > the old bindings are still used for them. > > The new IDL interface implementation is not 100% compatible > with the old one, and we see the following changes/improvement > that are visible from author script. > > Behavioral changes: > - Cross origin attributes become accessor properties. > - Indexed/named properties' behaviors change. > - Legacy platform objects with indexed properties support > @@iterator property. > - Maplike supports size() operation. > - [NoInterfaceObject] removes 'constructor' property. > - Some of error messages change. > For these changes, new behaviors are better conforming to > Web IDL specification. > > Non-behavioral changes: > - Keep-alive-GC optimization is removed. > > For performance, there is no major difference in speed perf > and -17KB improvement in APK binary size. > > Pinpoint results > https://pinpoint-dot-chromeperf.appspot.com/job/1230bdd8920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14b5b5d0920000 > https://pinpoint-dot-chromeperf.appspot.com/job/12ca6424920000 > https://pinpoint-dot-chromeperf.appspot.com/job/14e3aa48920000 > > Bug: 839389 > Change-Id: I9de8de3cc9e37b4ee46333c9270fe49bbdd69534 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081633 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793165} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839389 Change-Id: I797f9cde05ccd0132ff0fbe1a970634f8d152d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335214Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#794147}
-
Stephen Martinis authored
The freeze is now over! Bug: 1109980 Change-Id: If29ad7064c26090ff0e4a2ddc24c697f051f6d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334807 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fce06b20005c..4b656a010be5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7fec564e38101024aad053eb62637bbd1ec4baea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334811Reviewed-by:
-
Kyle Horimoto authored
This CL fixes a crash which would occur when searching for cellular settings which was caused by a null |cellular_guid_| field. The issue is fixed by (1) ensuring that cellular search tags are only added when an associated cellular network exists, and (2) fetching *all* networks (not only active or visible networks) when responding to network changes. Bug: 1110200 Change-Id: I7e5f29a698cd38905025dd9cfc5364efd8a3abe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334402Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794144}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4b656a010be5..c6f029c304ca 2020-08-03 taylori@google.com Merge "Fix 'find' for incomplete slice" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibd628cec2b873d2178aa3d4d4b6bb919f71fbb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335009Reviewed-by:
-
Peter Beverloo authored
Expired and removed * Notifications.ExtensionNotificationActionCount * Notifications.ExtensionNotificationType Expired because the Notification Triggers OT is ramping down, but we'd like to keep the code for now as it's expected to ramp up again soon. * Notifications.Triggers.ShowTriggerDelay * Notifications.Triggers.HasShowTrigger Relevent for on-going feature development (to M88) * GCM.AccountMappingMessageReceived Relevant for on-going feature development (to M90) * Notifications.Permissions.RevokeDeleteCount * ServiceWorker.NotificationClickEvent.Time * Webapp.NavigationStatus Networking reliability metrics (to M90) * GCM.CheckinRequestStatus * InstanceID.GetToken.NetErrorCode * PushMessaging.UnregistrationIIDResult On-disk database reliability metrics (to M90) * GCM.Crypto.InitKeyStoreSuccessRate * Notifications.Database.WriteTriggeredResult * Notifications.Database.ReadResourcesResult * Notifications.Database.ReadResourcesForTriggeredResult * Notifications.Database.DeleteAllForOriginsResult Bug: 1104954, 1104956, 1104957, 1105075, 1105077, 1105076 Bug: 1105078, 1105079, 1105081, 1104955, 1109826 Change-Id: I3269e6b54b012a863811e550c02ab3fe8b78e4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302111 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#794142}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/705d36be..d6c02e4a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e5ffed24b6cfbf7ad27d6fa8c412eb8f91e4ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334574Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794141}
-
Sigurd Schneider authored
This CL restricts web UI scheme support in the the resource loading for DevTools UI bindings: - Only devtools:// and chrome:// schemes are supported for now, but not the chrome-untrusted:// scheme. - In both cases, the resource must have the same scheme as the inspected window. To support chrome-untrusted:// we need to funnel the load of the source map through the renderer of the right iframe; currently we use the renderer of the top inspected window. Bug: chromium:1109587 Change-Id: I59270fe84b1fa11d04f798e28aaa9400dda53e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320793 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: -
Marc Treib authored
It lists some guidelines for changing the sync protos, mostly linking to the generic proto style guide and the do's and don'ts. Bug: none Change-Id: I4767e44653db14ecabf2fd6426cf6c4a83a9f164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332596 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794139}
-
Benoit Lize authored
PartitionAlloc has allocation and free hooks. These are used for the sampling heap profiler, as well as GWP-ASAN. When PartitionAlloc is malloc(), these two are already covered by the malloc() hooks. Which means that we have two issues: 1. Hooks can be called twice for the same allocation 2. Added branches for each malloc()/free() pairs. This commit adds a new path which bypasses hooks, and use it for the malloc() implementation. This makes the code shorter, and removes atomic loads and branches. On x86_64, the fast path return in PartitionMalloc() moves from offset 0x250 to offset 0x179. This removes one load and two branches per allocation. See below the removed code: 0x0000000000f5c60e <+30>: movabs $0xaaaaaaaaaaaaaaaa,%rax 0x0000000000f5c623 <+51>: mov (%rax),%r15b 0x0000000000f5c626 <+54>: test $0x1,%r15b 0x0000000000f5c62a <+58>: jne 0xf5c6eb <PartitionMalloc()+251> and: 0x0000000000f5c6c3 <+211>: test $0x1,%r15b 0x0000000000f5c6c7 <+215>: je 0xf5c6dc <PartitionMalloc()+236> As a minor consequence, %r15 is no longer used by the function. Bug: 998048 Change-Id: I389705b7ca29fd9c654d8097edc4d8ee87e1f343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323461 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8c201dfadc1b..eac38cfbc1de 2020-08-03 tommek@google.com Fixing a deprecated arrayLayer value inside Queue::WriteTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7f484d60e21fdbcba1db2cb60519340e123ba1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335012Reviewed-by:
-
Hitoshi Yoshida authored
In the new code generator, dictionaries are expected to be created with an isolate by default. This CL makes the default value construction follow it. Bug: 839389 Change-Id: I648304cf8df3e79ee3d2cdcb7b8b392bcc28f239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332025Reviewed-by:
-
Hans Wennborg authored
It currently only applies on Android, but turn it off by default so we actively opt-in when it starts working on other targets. Follow-up to 9795f362. (This may or may not mitigate the Win size increase from the latest clang roll, see the second bug.) Bug: 1110413, 1112174 Change-Id: I928d9125536b330276fa6557c00475c84ee50a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332591 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
This reverts commit 87e0206b. Reason for revert: chromium tree closure https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13785? Original change's description: > Roll src-internal from 981002aea991 to 3bd36057b471 (2 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/981002aea991..3bd36057b471 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC mstensho@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1033067 > Tbr: mstensho@google.com > Change-Id: Id3a9dedf774a0724d054fe1189ac5ad2553c2b20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335000 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#794114} TBR=mstensho@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I9a02d4b95705474b6755148805d04f14827c227a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1033067 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335333 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#794134}
-
