- 04 Dec, 2019 40 commits
-
-
Andy Paicu authored
This is a reland of 6e91b688 There was a clash with https://chromium-review.googlesource.com/c/chromium/src/+/1948892 which renamed a file that this CL included. PS1 contains the original CL. Original change's description: > Added IPH for the mini-infobar notification permission prompt (android) > > As part of the new quieter notification prompt, add IPH for the android > quieter notification permission prompt. To be shown the first time > the setting is enabled. > > This is controlled by using the functions: > * AdaptiveNotificationPermissionUiSelector::ShouldShowPromo > * AdaptiveNotificationPermissionUiSelector::PromoWasShown > > Quick mock of how this is supposed to look: > https://docs.google.com/document/d/1hsp1j08yzIK6M6G7pbsdEihU8CLN7QQ3V2iAxESrqQM/edit?usp=sharing > > Bug: 1029595 > Change-Id: I3c90dda846a70396f1130c2ad6dcfc3622b9b25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944173 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721442} TBR=nyquist@chromium.org,engedy@chromium.org,dtrainor@chromium.org,bcwhite@chromium.org,mdjones@chromium.org,bsazonov@chromium.org,hkamila@chromium.org Bug: 1029595 Change-Id: I33eb37e289c8bbea9f8ff3aba51db229aa523381 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950513 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721517}
-
Mike Dougherty authored
TBR=justincohen@chromium.org Bug: 1030701 Change-Id: I9f7ffcccf5484514d22121defe458ada25758d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950667 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721516}
-
Lei Zhang authored
Change-Id: I37ddc01a0427105b679d6f73708e734311f5502e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947965Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721515}
-
Mark Cogan authored
This CL modernizes the ARQuickLookCoordinator to use the superclass -initWithBaseViewController:browser: initializer, and to remove the spurious injection of BrowserState and WebStateList. It also updates the coordinator's unit test, using the new TestBrowser() constructor. Bug: 1029346 Change-Id: I29f6e14409dc66b34da36126d0ea7e516323ddaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943240 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#721514}
-
Mikhail Khokhlov authored
As an experiment in running the TBMv3 metrics on waterfall, this CL adds a simple console_error metric to the power.desktop benchmark. Note that this metric will only be computed when traces collected from Chrome are in proto format, i.e. currently only on linux-perf-fyi bot. The behavior of the benchmark on all other bots is not affected. Bug: 1012687 Change-Id: I24cc9aff5454c95c48b542e86ffa191073d5c01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950515 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#721513}
-
sczs authored
Bug: 1014652 Change-Id: I0ebc5257346656db6c54c9f7055bf99f1699bd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921552 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#721512}
-
Francois Doray authored
Prior to this CL, the SequenceManager set |PendingTask::delayed_run_time| for immediate tasks when the "add queue time to tasks" option was enabled. This caused the responsiveness watcher to consider an interval as janky only when a long task was running, not when a task was queued for a long time as intended. With this CL, SequenceManager only sets |PendingTask::delayed_run_time| for delayed tasks. The responsiveness watcher is modified to keep recording the same jank as before, to ensure that we can easily notice if there are real jank regressions. In an upcoming CL, we will modify the responsiveness watcher to record a new jank histogram that takes into account queuing time. Bug: 1029137 Change-Id: I8394cb42a8b6d77b01eb38cad1242fc4b0f6c74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940452Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#721511}
-
Markus Handell authored
This CL adds a new class VideoTrackRecorderPassthrough, that is used to handle EncodedVideoFrames coming from a source, handling the request of key frames upon construction and Resume(). The common parts of VideoTrackRecorder are abstracted to a new base class and ToT's VideoTrackRecorder is now VideoTrackRecorderImpl. This CL also adds unit tests for the new class. Change-Id: I4f8c71e4c4e1fba57a3b143a56cf64052b315ff4 Bug: 1013590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893935 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721510}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I117c327ee7eac55d032374df71244121fd2d8c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721509}
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: Ia128c291169bc77604e2fe091b0caf77117f1045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950517 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#721508}
-
Sangwoo Ko authored
components/infobars/core/infobar is a AnimationDelegate but this can't use AnimationDelegateViews or get widget as it would be layering violation. So it's subclass, InfoBarView sets AnimationDelegateNotifier with AnimationDelegateViews. AnimationDelegateViews will adapt CompositorAnimationRunner for InfoBar and then forward callbacks to InfoBar. There's no intentional behavior changes. Bug: 824026 Change-Id: Id824a6a402682e9ec5a0f36216d92d92cffa5669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933839Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#721507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd5a91ebf34d..bc546858739e git log fd5a91ebf34d..bc546858739e --date=short --first-parent --format='%ad %ae %s' 2019-12-04 vapier@chromium.org apiclient: finish migration to googleapiclient 2019-12-04 lamontjones@chromium.org api: sync protos 2019-12-04 vapier@chromium.org cidb: drop GetActionsForChanges/GetActionsForBuild/GetActionHistory 2019-12-04 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-04 bpastene@chromium.org chrome_chromeos_lkgm: When rolling, first close all old rolls that are open. 2019-12-03 vapier@chromium.org cbuildbot: hwtests: delete CQ-specific logic 2019-12-03 vapier@chromium.org triage_lib: drop unused module 2019-12-03 vapier@chromium.org build_failure_message: FindSuspectedChanges: drop unused helper 2019-12-03 vapier@chromium.org metadata_lib: drop unused RecordCLAction 2019-12-03 vapier@chromium.org unittests: use assertExists/assertNotExists in more places Created with: gclient setdep -r src/third_party/chromite@bc546858739e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I10f82497a4a7663e6fc1aaa074499b9c43ef3544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948800Reviewed-by:
-
Antonio Gomes authored
... to use THREAD_CHECKER instead. Blink does not currently make use of sequences. BUG=787254 R=guidou@chromium.org Change-Id: Idda5453badb39a2c52ea8c5d8282a338d9cb5d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946623 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721505}
-
Marc Treib authored
Making a few things private that should be private, renaming "ids" to "topics", updating comments etc. No functional changes. Bug: 1029698 Change-Id: If95081e1b68277bc0beb1e17b23dde0b4791a010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948438 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721504}
-
Mathieu Binette authored
Context: WinServer2008's end of support on Jan 14th 2020 https://support.microsoft.com/en-us/lifecycle/search?alpha=windows%20server%202008 Changes: - Removed Win2008r2 from the template host file used in tests. It's not currently used in any chromium tests, so no test to update. Follow-up to change in enterprise/cel: https://crrev.com/c/1936508 Bug: 1028769 Change-Id: I86410c88cdcfbe4e87e2600d1f20fde3638dd80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937572Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Auto-Submit: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#721503}
-
Antonio Gomes authored
File was removed (accidentally) in https://crrev.com/c/1745279, instead of getting moved down to Blink. R=jbroman@chromium.org Change-Id: I09da94c97c1dc04613bdf6714d01afa01f798016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950624 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#721502}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 204 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-05-31. Change-Id: Ie0a14fee5dec5f5390cfdcd36eebaa3394deedd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948232 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
This CL is adding unittests for GetFallbackFont(...) API. The goal is to increase coverage of the fallback font code for cases where the base font is not the default system font. Some chrome users are changing their default system font which may create bad cases for fallback fonts API. There are two unittests that required change: 1) Lao (u+0ED0) 2) Nko (u+07C1) In these two cases, the codepoint is present in "Segeo UI" but is not present in "Segeo UI Italic". Change-Id: Id9c50be56e025ae0c4a4651b1e2c47812430015d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948091 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#721500}
-
Tommy Li authored
Currently, in touch-mode, the Remove X looks wrong. This CL scales the X button in touch-mode, just like the keyword hint button. Bug: 1030423, 1205 Change-Id: Iee991d6189ac4bff2166bba481eaa4df25fc07c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949488Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#721499}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9c795fda9a8c..80d21bbafd2d git log 9c795fda9a8c..80d21bbafd2d --date=short --first-parent --format='%ad %ae %s' 2019-12-04 swiftshader.regress@gmail.com Regres: Update test lists @ bbd0694f Created with: gclient setdep -r src/third_party/swiftshader@80d21bbafd2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2e68306e84a26622252f679c67e6fc1741f0b0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950664Reviewed-by:
-
W. James MacLean authored
This CL removes more dead BrowserPlugin infrastructure. Specifically, it remove WebContentsViewGuest, and RenderWidgetHostViewGuest. It also removes the "guest_view_hack" which has been in RenderWidgetHostViewMac/Aura since the inception of BrowserPlugin. Bug: 533069 Change-Id: Ie6d28ca981d612d3f7bf8f180c615f78d53b7e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943097 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721497}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e4327893aa50..576b9e489dca git log e4327893aa50..576b9e489dca --date=short --first-parent --format='%ad %ae %s' 2019-12-04 github@aerotwist.com Migrates performance_monitor/ to esm 2019-12-04 github@aerotwist.com Migrates screencast/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@576b9e489dca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie473ef3867e3c461b5937b1d23ac87fdd75e440c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948798Reviewed-by:
-
Kaan Alsan authored
When performing a scroll snap on the impl thread, the element id of the target snap area will now be pushed to the corresponding snap container data on the main thread. Bug: 866127 Change-Id: If6edaacedbcb5a6acf8f2ec424fe48e31dde3e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943049 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#721495}
-
Rohit Agarwal authored
for profile type. Ambient authentication in private modes can currently be toggled with feature flag. The default value of the flag is to allow for all profile types. This default value would be set to disallowed for OTR profile types in the future. A policy is introduced for enterprise admins who still want the ambient authentication for the OTR profiles. This CL adds the logic to allow ambient authentication via policy and the existing feature flag. As a consequence for now, if either the policy or feature flag allows ambient authentication then the resulting behanviour is that we allow ambient authentication. This CL also adds browser tests. Bug: 458508 Change-Id: I488cf40ec4c178739d441fe76fb15a3e3450cb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944493 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#721494}
-
chrome://policyAlexander Hendrich authored
This CL adds the extension policy for login screen extensions to the visual output on chrome://policy. These extensions will be labeled with "(login screen profile)" next to their name. In the policy export, login screen extension policy will be located under the "loginScreenExtensionPolicies" key, next to the "extensionPolicies" key. Bug: 1025760, b:145596153 Change-Id: I442753dbfe7c8d9df6c1b0993b69e19b14516dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924573 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#721493}
-
Chris Mumford authored
Used OnceClosure except in MockVideoCaptureImplManager where CreateVideoCaptureImplForTesting could be called multiple times. Bug: 1007835 Change-Id: I088bec2a050d729fbc2c9b22825d9236c61c721d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949042Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#721492}
-
Peng Huang authored
This CL supports overlays with SkiaOutputDeviceBufferQueue via GLSurface. However this CL doesn't change the code in features::IsUsingSkiaRenderer() at [1], so SkiaRenderer is not used with Android surface control. [1] https://cs.chromium.org/chromium/src/components/viz/common/features.cc?type=cs&sq=package:chromium&g=0&l=76 TODO: * Refactor overlay related code out of GLSurface to a new class. those code is not GL related. * Use the new class to replace gl_surface_ in SkiaOutputDeviceBufferQueue. * Turn on SkiaRenderer with Android surface control. * Long term, we plan to use viz::BufferQueue for overlays. We need refactor overlay related code from SkiaOutputDevice* to a service side BufferQueue on GPU thread. Bug: 1012401 Change-Id: Ic66072cad8df72a1e4375a895ac4af5fde42a5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949270 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb1785937ac6..c68502c177c6 Created with: gclient setdep -r src-internal@c68502c177c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1017165 Tbr: jbudorick@google.com Change-Id: I738208bb62ee45fde96add382e87e1839814711d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721490}
-
Thomas Lukaszewicz authored
Removed references to hardcoded values for all control menu components and piped color access through native theme. Added appropriate color ids and native theme values for relevant platforms. Bug: 1003612 Change-Id: I013fed6425a8d74cd59288ef77898dd835e58d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949105Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721489}
-
Brandon Goddard authored
This change rebaselines and re-enables datagrid layout tests that were previously disabled in order to land https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881219 This effectively reverts https://chromium-review.googlesource.com/c/chromium/src/+/1893144 Bug: 963183 Change-Id: I61d58e8417cafac067cca298f025ee1300def544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904033Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721488}
-
Olya Kalitova authored
Adds offline scenario to Crostini configuration dialog. If Crostini configuration failed while internet connection was missing dialog informs user that Chromebook is offline and user can retry configuration by hitting retry button. Bug: 1029809 Change-Id: I6a5e006b5acb7300568eb6a40d9636725c229a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947655Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#721487}
-
Kevin Ellis authored
Double rAF start of the test to avoid starting the animation while too busy to handle updates in a timely manner. Bug: 1029541 Change-Id: I3e0e665f0b4b9dd6f6a87d84d207b0c18a1b51c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946668 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Hugo Holgersson authored
DeflateIfOverlapped() was introduced in SpatNav's very first WebKit commit [1], seemingly, to get some support for certain overlapping elements. It seems like we no longer need it... Since crrev.com/c/1605696, SpatNav better supports generic overlapping rects. The spec [2] that formalizes Chromium's SpatNav implementation never included it either. [1] https://trac.webkit.org/browser/webkit/trunk/ WebCore/page/SpatialNavigation.cpp?rev=55543 [2] https://drafts.csswg.org/css-nav-1/ Bug: 770147, 1000578 Change-Id: I498ccdb5032d97c89a5c015c893a2e5f08edd1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949785 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721485}
-
Ali Juma authored
This adds the file as an EG2 target, updates #includes, and replaces calls to helpers that can't be used in EG2. This also adds a ProgressIndicatorAppInterface class that provides a matcher for MDCProgressViews with a given progress value. Bug: 987646 Change-Id: I88b8bc9496bf962acbba59d855205cf19cf97fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949266 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#721484}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98d4bce4..2b3800c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f1fed78e8b3196d533d88692715164777b02269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950583Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721483}
-
Alex Chau authored
- RemoveKey was accidentally added in https://crrev.com/c/1944502 - Added test to verify JWT payload and base64 url decode public key Bug: 1029747, 1029483 Change-Id: I248b80898839846a0b0832cf333e49b2c29a8c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950532Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#721482}
-
Jonathan Backer authored
Bug: 967716 Change-Id: I009d6d13d4392f1c0609b684831ccdf07a9665c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925505 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#721481}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I3c6a42ab454d57b7072fc1b752ea1dcb1c7c5991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945817Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#721480}
-
Balazs Engedy authored
This is a reland of c8b3dc82. The previous attempt to land led to a compile error, because it clashed with a concurrently landed CL (crrev.com/c/1944173), which added an #include to `adaptive_notification_permission_ui_selector.h`, which is renamed by this CL. Relanding this verbatim, the other CL will be rebased on top of this one. Original change's description: > Socialize QuietNotificationPrompt prefs. > > Decouple call sites that wish to check the quiet UI state (or the promo > state) from AdaptiveNotificationPermissionUiSelector, and instead make > this call sites consult QuietNotificationPermissionUIState, which acts > a thin layer to read/write preferences. > > Rename AdaptiveNotificationPermissionUiSelector to > AdaptiveQuietNotificationPermissionUiEnabler to better reflect the new > responsibility of this class is to merely toggle a setting, the actual > UI will be selected by the PermissionRequestManager. > > This CL also renames `permission_features.h`, for consistency, to > `quiet_notification_permission_ui_config.h`. > > Bug: 1028642, 1030216 > Change-Id: If52dfab3532a473399091bf4291e863cf70142f0 > TBR: battre@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948892 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721449} Bug: 1028642, 1030216 Change-Id: I6bf5a7fa51da10fd8b7a8cdd7eecca236fbefb1d TBR: msramek@chromium.org, chouinard@chromium.org, battre@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950526Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Most likely, `std::move(*quit_task).Run();` could be called twice for the same |quit_task| at times. By introducing a RunLoop, it doesn't matter (anymore) how often the loop is quit. This should fix the flaky crashes of this test as described in the linked bug. Bug: 1030275 Change-Id: I9509d474cc950362996f31a879034fb01ca5303c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948895 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
