- 16 Sep, 2019 7 commits
-
-
Stephen McGruer authored
https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A Bug: 868224 Change-Id: I68b33822badc36c3cebcdca7bf6f47d834160270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797226Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696699}
-
Leon Han authored
nfc_constants.{cc,h} just defines some const texts like error messages etc. that we can just use directly in code. BUG=520391 Change-Id: Ied00da5594f22d07d9328d75874e9a2d54f8feff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797368 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696698}
-
Alan Cutter authored
This CL replaces BrowserWindow::GetOmniboxPageActionIconContainer() BrowserWindow::GetToolbarPageActionIconContainer() with BrowserWindow::UpdatePageActionIcon(type) BrowserWindow::ExecutePageActionIconForTesting(type) in order to hide the implementation detail of which container any given icon resides in. This is in preparation for adding more page-action-icons to PWA windows which only have one container. This is a pure refactor with no behavioural changes. Bug: 788051 Change-Id: I71a4e117db7595ac2bccdafc454f76e6b27c3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792521 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#696697}
-
Koji Ishii authored
This patch changes positions in |ShapingLineBreaker| from |LayoutUnit| to |float|. This change turns a few operations from |LayoutUnit| to |float|, but because |CachedPositionForOffset| uses |float|, it avoids a few casts between |LayoutUnit| and |float|, and avoids complexities caused by casting twice (|float| -> |LayoutUnit| -> |float|.) This patch can fix issue 1002442 without the previous one by eliminating snapping, because the issue occurs by the errors in snapping to |LayoutUnit|. There seems to be slight difference in the behavior, such as when extreme letter-spacing is used and positions become inifite numbers. The new behavior seems to be more correct, though an experiment to use the overflow state of |ShapingLineBreaker| more (crrev.com/c/1803994) in |NGLineBreaker| breaks slightly differently. Bug: 1002442, 1003742 Change-Id: I5ece8478b99fe76e7aa798b98cab64f24a95d5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801394Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696696}
-
Matt Giuca authored
- Added tests for scope parameter. - Added lots of different types and values for inputs. - Tests which value is set, not just the type of value. - Fixed assert argument order and fix failure messages. Explainer (current, but vague): https://github.com/WICG/badging/blob/master/explainer.md Spec (out of date): https://wicg.github.io/badging/ Bug: 987514, 1000968, 1001404, 1001405 Change-Id: I518ff82a81c9a56bd45421cf8b7b16b9855a7ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788966 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#696695}
-
Rune Lillesveen authored
This makes us match how Firefox applies minimum font-size and makes us not break relative length computation when pages use a font-size less than the user's minimum font-size as a basis for widths, heights, margins, padding, etc. This is a behavioral change for relative lengths for the following cases: - minimum-font-size does not affect em lengths - minimum-logical-font-size does not affect em lengths - text autosizing does not affect em lengths - text scaling accessibility setting in Chrome for Android does not affect em lengths Test expectation changes and reasons: Text scaling no longer applies to relative lengths (text zoom set from testRunner): svg/zoom/text/zoom-hixie-mixed-008.xml svg/zoom/text/zoom-hixie-rendering-model-004.xhtml svg/zoom/text/zoom-svg-float-border-padding.xml Minimum logical font-size not applying to relative lengths (minimum logical font-size set to 9px when running layout tests): fast/backgrounds/background-position-parsing.html virtual/controls-refresh/fast/forms/controls-new-ui/password/password-eye-icon-zoom-0.5x.html http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm Bug: 308862 Change-Id: I5e5fb99e69b516c9c0c3758d232cbae8f7f5894a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803281Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1843b085ee93..a5cce89fe5f6 Created with: gclient setdep -r src-internal@a5cce89fe5f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8da01f897bba9efa239599d9cefa92cdebf4b959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696693}
-
- 15 Sep, 2019 27 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I990d21b752327dc982d0df087fc84a618c99e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805308Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696692}
-
tby authored
There is a bug where a Drive file can be deleted via DriveFS, which takes a few seconds to propagate back to the Drive QuickAccess results, creating a window where we could surface a Drive file that can't be launched. We already deal with this for local files by checking they exist on-disk before finalizing the results, so this CL does the same thing for Drive files. integration service right now. Tested: manually, as we don't have a good way of mocking the drive Bug: 1003588 Change-Id: I3ad839c18ad0dbb28fec13141e756993a4b65c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802775Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#696691}
-
tby authored
We currently trigger a prefetch of Drive QuickAccess results via the AppListClientImpl::ViewShown method, which misses some launcher uses in tablet mode, leading to stale Drive results in zero state. There's a simple fix for this: AppListControllerImpl:: OnAppListVisibilityChanged is called in exactly the cases we want to prefetch. Note: this doesn't solve the issue of possibly stale results if the user sits on the home screen app list for a long time, that will come in a follow-up CL. Bug: 959679 Change-Id: Idf2c489ee39c2625ddd84622f42c160837442e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798080Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Auto-Submit: Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#696690}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52a8c7a0d882..1843b085ee93 Created with: gclient setdep -r src-internal@1843b085ee93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I108ac4b62e74513155734dd879e3fe5861af1075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805971Reviewed-by:
-
Kevin Qin authored
Test runtime actually updates IPD after session starts. In this test, I checked if runtime passed the IPD to js side. But we have to notice that fov and ipd is only updated in the following conditions: 1. "when the canvas element for this session's output context is resized." 2. when "ApplyPendingRenderState()" gets called Bug: 996502 Change-Id: I26496d0997290fbd2330a2a22e7dd1d40c5226ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793946 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#696688}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af6fbc37d76b..52a8c7a0d882 Created with: gclient setdep -r src-internal@52a8c7a0d882 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I23ded47194d8a8e4d2fb86a48652fd41c2ae815a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805903Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3877.0-1567418235-benchmark-78.0.3893.0-r1 to 78-3877.0-1568022778-benchmark-78.0.3902.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I1f35f1d88beecbd55322c5cbab9981e2929f7245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805923Reviewed-by:
-
Keishi Hattori authored
We should use asyncGC() instead of gc() to ensure a precise BlinkGC runs, so the wrapper object is collected. Bug: 1003268 Change-Id: I8210d6d718adb3490752c28f7647f287800d2c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800855Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696685}
-
Dominic Farolino authored
The network service's OnCancelURLRequestWithPolicyViolatingReferrerHeader method is called after it has been determined that a URLRequest's referrer does not match what the policy demands. This method performs a DumpWithoutCrash for debugging. However, this is called within the network service, so the path of the request's creation is not captured in the stack trace, making it less useful. This CL checks whether or not a request's referrer matches what its policy demands earlier, when a network::ResourceRequest is created by WebURLLoaderImpl. This captures a better picture of a renderer-initiated request's origins in the stack trace, which is much more useful for debugging. Bug: 1004083 Change-Id: I867e488a860e2ac042a1eb93bff04e5f10a3126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803936 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#696684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da33810f35a7..af6fbc37d76b Created with: gclient setdep -r src-internal@af6fbc37d76b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic4c001f7e48230acb4b05eca364f20412f836e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805837Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I421c6dcb899623ebf71d3beffa407524f130aae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804933Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e041176a44f7..da33810f35a7 Created with: gclient setdep -r src-internal@da33810f35a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia352de58cccb7912375a50b8158d39a2f399993f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804931Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a36b73b13cb..e041176a44f7 Created with: gclient setdep -r src-internal@e041176a44f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I87243625084283af60b0d277fc8bf24286e5b7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805714Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/974165680cfc..cb52badca04a git log 974165680cfc..cb52badca04a --date=short --no-merges --format='%ad %ae %s' 2019-09-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@cb52badca04a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I9a04aac8c3e1eaab7696d164c5526bdf2ab034a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805246Reviewed-by:
-
alanlxl authored
Smart dim only works on Chromebook; previously we use DeviceType to check this, this CL replace it with base::FeatureList. default on all Chromebook devices Bug: 994011, 980826 Test: tested in conjunction with CrOS CLs that enable the flag by Change-Id: I92e685728b173302d21e678051cfc463eaa0d85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757410Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#696678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ab7d4b74e94..9a36b73b13cb Created with: gclient setdep -r src-internal@9a36b73b13cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3bf27868c145e05d64cb78cba82a996be6e1fb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804930Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25c4f5b30816..974165680cfc git log 25c4f5b30816..974165680cfc --date=short --no-merges --format='%ad %ae %s' 2019-09-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@974165680cfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I73c5e4ea844c64c33e0cff5f932cca949f5a4ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805475Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I740bd1b8f9b70a107d4b0c9a5b7ce3faca663415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805245Reviewed-by:
-
Peter Kasting authored
Bug: 940774 Change-Id: I72e849532dfd1c8ea5bbed17d1123568cfda6740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805298 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#696674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcd5574e2866..8ab7d4b74e94 Created with: gclient setdep -r src-internal@8ab7d4b74e94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Icb395cc30667fade364edff25b67b6eb6a34d86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805243Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib6b3f76ef02c0eef71c03063735758bcbcc82810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803773Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696672}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b0b8d9e4cd23..899716dc3240 git log b0b8d9e4cd23..899716dc3240 --date=short --no-merges --format='%ad %ae %s' 2019-09-14 primiano@google.com Removed unused trace_processor/sched.proto Created with: gclient setdep -r src/third_party/perfetto@899716dc3240 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132880619 Change-Id: I5b08ce9597f60ae744fdaa470847a4078d822b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805242Reviewed-by:
-
Peng Huang authored
--use-vulkan flag is used, chrome will follow it, otherwise chrome will use the new added Vulkan feature. Bug: 1002487 Change-Id: I4d8d3674e0aa9831046810ec67edba21a9efd25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795486Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#696670}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ec06ebd25b71..fcbe4071ce46 git log ec06ebd25b71..fcbe4071ce46 --date=short --no-merges --format='%ad %ae %s' 2019-09-14 peah@webrtc.org Adding more refined control over choice of band-splitting Created with: gclient setdep -r src/third_party/webrtc@fcbe4071ce46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I26807f7591aa83a4e064929cd266a37b4485e4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805240Reviewed-by:
-
Eric Willigers authored
Restore the clamping test that was added in https://chromium-review.googlesource.com/c/chromium/src/+/1758169 The test had been moved to WPT, but clamping is Blink-specific and the test was removed from WPT. https://github.com/web-platform-tests/wpt/pull/19052 Change-Id: I21ba00ff2d5080d5ef0d9d77423333edd152a5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804695Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5966abc15e4d..ecd10922eec5 git log 5966abc15e4d..ecd10922eec5 --date=short --no-merges --format='%ad %ae %s' 2019-09-15 qyearsley@chromium.org Remove stale TODOs from qyearsley Created with: gclient setdep -r src/third_party/catapult@ecd10922eec5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: None Change-Id: Iba70e52ac3fe6e7ac1705d49642e5c68c96bf9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805241Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/decff32d5245..bcd5574e2866 Created with: gclient setdep -r src-internal@bcd5574e2866 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia7a35e6962cc28ed2d9fbc77efb9a9d4c280ddc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805238Reviewed-by:
-
- 14 Sep, 2019 6 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a94f125fb5a8..6fe107e0feca git log a94f125fb5a8..6fe107e0feca --date=short --no-merges --format='%ad %ae %s' 2019-09-14 dburger@chromium.org Increase CQ hw test timeout from 90 minutes to 2 hours. Created with: gclient setdep -r src/third_party/chromite@6fe107e0feca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0dd095e625a36fc1879822dc0558cf8264791785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804923Reviewed-by:
-
Nico Weber authored
otool is a symlink to llvm-otool, and llvm-otool shells out to llvm-objdump. TBR=creis Bug: 998873 Change-Id: I65e1d7cd3d1cad1985f2d01c52195d510dbcf0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803766 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#696664}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d36adc461e3d..decff32d5245 Created with: gclient setdep -r src-internal@decff32d5245 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I30169361ef7bd679147b039516ab1a48b960f486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804922Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4241f5e0a8ac..25c4f5b30816 git log 4241f5e0a8ac..25c4f5b30816 --date=short --no-merges --format='%ad %ae %s' 2019-09-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@25c4f5b30816 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I22104a258201f4e1c9ffceabccd557e3f9c42126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804790Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia4cb1a6bc4742f967beaea5b68e965b94a7eb730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804785Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/963a57e2211f..d36adc461e3d Created with: gclient setdep -r src-internal@d36adc461e3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3c4dab9e76331fd97f94a660e7ffd21af05a1a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804783Reviewed-by:
-
