GitLab

bonus: sort expectations file

TBR=dmikurube@chromium.org
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/334403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/341433003

git-svn-id: svn://svn.chromium.org/blink/trunk@176291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and make m_mediaElement Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/339843002

git-svn-id: svn://svn.chromium.org/blink/trunk@176290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- added "all" property to CSSProperties.in and so on.
- added "unset" CSSValue. "unset" is defined in all spec.

all spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html

Review URL: https://codereview.chromium.org/338023002

git-svn-id: svn://svn.chromium.org/blink/trunk@176289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the latest editor's draft spec [1], FontFaceSet#ready has been
changed from a method to an attribute. We are likely to deprecate
ready() in favor of ready attribute. To prepare for a deprecation
process, this patch adds a UseCounter for FontFaceSet#ready().

[1] http://dev.w3.org/csswg/css-font-loading/#dom-fontfaceset-ready

BUG=380990

Review URL: https://codereview.chromium.org/339563006

git-svn-id: svn://svn.chromium.org/blink/trunk@176288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/334373004

git-svn-id: svn://svn.chromium.org/blink/trunk@176287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NavigatorContentUtilsClientImpl has been placed in ChromeClientImpl.cpp.
It would be good if NavigatorContentUtilsClientImpl has own file, because
new functions have been added to the NavigatorContentUtilsClientImpl. Besides
more functionality will be added in future.

BUG=none

Review URL: https://codereview.chromium.org/331223002

git-svn-id: svn://svn.chromium.org/blink/trunk@176286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't try to mimic IE's special hit-testing behavior for touch-action - it probably only adds confusion and is unlikely to cause compat issues in practice.  See http://crbug.com/380203 for details.

Also reduces the hit tests done on touchstart from 2 to 1 for improved performance.

BUG=380203

Review URL: https://codereview.chromium.org/329773002

git-svn-id: svn://svn.chromium.org/blink/trunk@176285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, static SVGPropertyTearOff items inserted into a SVGListTearOff were not marked as a tear-off.
For such items, |svgAttributeChanged| was not dispatched to its context element, and view was not updated when its value changed.

This patch fixes the issue by converting a static tear-off inserted into a list to a dynamic tear-off.

Also this patch fixes an issue that a tearoff returned from replaceItem/removeItem was still attached to the list.

BUG=380546, 380176

Review URL: https://codereview.chromium.org/321403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebSocket::resume starts a timer which does the actual resume work when fired.
WebSocket::suspend must stop the timer in case it is called while the
timer is active.

BUG=NONE
R=tyoshino

Review URL: https://codereview.chromium.org/330253002

git-svn-id: svn://svn.chromium.org/blink/trunk@176283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the document gets detached before Service Worker registration
completes, the CallbackPromiseAdapter promise gets cleared. Then when
registration completes, ServiceWorker::from is passed the resolver with
the empty promise. Before this patch, an assert would then occur because
ScriptPromise::then bails before adopting its fulfilled/rejected
arguments. This patch fixes an overly aggressive assert in
V8GarbageCollected and also makes ServiceWorker creation skip waiting
on an empty promise.

BUG=384498

Review URL: https://codereview.chromium.org/337053004

git-svn-id: svn://svn.chromium.org/blink/trunk@176282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Forbid creating new wrapper from SetWrapperReferenceTo (https://codereview.chromium.org/332643003/)

Reason for revert:
There seems to be an existing bug which hits this callpath. Reverting the change until the bug is fixed.

Original issue's description:
> Forbid creating new wrapper from SetWrapperReferenceTo
> 
> SetWrapperReferenceTo IDL attribute is a hack to use V8 wrapper reference
> to avoid reference cycles in Blink. The |visitDOMWrapper| callback is
> used to create a temporary strong reference between the wrappers in GC
> prologue.
> 
> Before this patch, |visitDOMWrapper| was allowed to create a new wrapper
> if the wrapper for target object didn't exist. However this is dangerous,
> as the target object may be already destructed. The target wrapper must
> already exist for this reference hack to work correctly.
> 
> This patch forbids creating a new wrapper from |visitDOMWrapper| callback,
> and adds an ASSERT that checks that the target object wrapper already
> exists.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175998

TBR=nbarth@chromium.org,haraken@chromium.org
BUG=384459

Review URL: https://codereview.chromium.org/332183008

git-svn-id: svn://svn.chromium.org/blink/trunk@176281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

m_fontElement is a parent element. It's ok to use a strong reference.

BUG=357163

Review URL: https://codereview.chromium.org/338213004

git-svn-id: svn://svn.chromium.org/blink/trunk@176280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken,sof
BUG=none

Review URL: https://codereview.chromium.org/338833002

git-svn-id: svn://svn.chromium.org/blink/trunk@176279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the font name passed to check() does not match any font face in the
FontFaceSet, current implementation always returns true.  As per the
latest spec draft [1], it should return true if it matches platform font
name, otherwise false.

[1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-check

BUG=378989
TEST=fast/css/fontfaceset-check-platform-fonts.html

Review URL: https://codereview.chromium.org/324293003

git-svn-id: svn://svn.chromium.org/blink/trunk@176278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/331283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/336323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SubtargetGeometry is used only in Vector.

BUG=357163

Review URL: https://codereview.chromium.org/332183006

git-svn-id: svn://svn.chromium.org/blink/trunk@176272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and makes their element members Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/334223009

git-svn-id: svn://svn.chromium.org/blink/trunk@176271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/333403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/336293002

git-svn-id: svn://svn.chromium.org/blink/trunk@176269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGLengthContext is made STACK_ALLOCATED, as it is currently never used
on a heap.

BUG=357163

Review URL: https://codereview.chromium.org/339793004

git-svn-id: svn://svn.chromium.org/blink/trunk@176268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/333413006

git-svn-id: svn://svn.chromium.org/blink/trunk@176267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Types of m_maximumAge and m_imeout are "unsigned long"
but they are "int". Therefore their types should change to
"unsigned" for align with others.

BUG=368184

Review URL: https://codereview.chromium.org/336213002

git-svn-id: svn://svn.chromium.org/blink/trunk@176266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376377
TEST=no new test; just refactoring

Review URL: https://codereview.chromium.org/330543004

git-svn-id: svn://svn.chromium.org/blink/trunk@176265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change cleans up the code a little to make it easier to see that
the "direction of playback" is being used and corrects the definition of
"forward" to include playbackRate == 0. New test cases were added to
expose the change in behavior.

BUG=385343
TESTS=LayoutTests/media/media-ended.html LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html

Review URL: https://codereview.chromium.org/331063006

git-svn-id: svn://svn.chromium.org/blink/trunk@176264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Mark XMLTreeViewer STACK_ALLOCATED().
- Make m_document Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/339703004

git-svn-id: svn://svn.chromium.org/blink/trunk@176263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ThisValue should support "any" type other than "object".

BUG=382728

Review URL: https://codereview.chromium.org/330163004

git-svn-id: svn://svn.chromium.org/blink/trunk@176262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The content should take total window width while overlay-scrollbar is enabled. 

BUG=382900

Review URL: https://codereview.chromium.org/333633003

git-svn-id: svn://svn.chromium.org/blink/trunk@176261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This simply calls its superclass since about four months ago.
https://codereview.chromium.org/129873009/

Review URL: https://codereview.chromium.org/339753002

git-svn-id: svn://svn.chromium.org/blink/trunk@176260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we just report that "no squashing target was found". There
are many reasons why squashing might fail and this message is not very
informative. This cl expands the list of squashing-related compositing
reasons to make diagnosing layer explosions easier.

R=chrishtr@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/331203003

git-svn-id: svn://svn.chromium.org/blink/trunk@176259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trivial patch, found while investigating another issue. This patch
removes resetMargin and resetBorderRadius.

Review URL: https://codereview.chromium.org/337043002

git-svn-id: svn://svn.chromium.org/blink/trunk@176258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For repaint tests, compute minimum repaint by comparing pixel dump
before and after repaintTest() and output repaint in layout test result.

In overlay, visualize the minimum repaint in expected results.

In this way, when making repaint change and checking actual results,
we can easily discover under-repaint bugs if we see any solid black
area not covered by repaint rects.

This CL depends on chromium-side CL https://codereview.chromium.org/301243022.

Review URL: https://codereview.chromium.org/315443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL takes care the testing, timing, workers and xml subdirs under core.

BUG=381876

Review URL: https://codereview.chromium.org/339573006

git-svn-id: svn://svn.chromium.org/blink/trunk@176256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bonus: sort entries on serviceworker expectations section.

NOTRY=true
BUG=385384, 364390

Review URL: https://codereview.chromium.org/339013002

git-svn-id: svn://svn.chromium.org/blink/trunk@176255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/338233002

git-svn-id: svn://svn.chromium.org/blink/trunk@176254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop traverseNextElement() method from HTMLCollection class to avoid code
duplication with traverseForwardToOffset(). This method was only used
by supportedPropertyNames() and updateIdNameCache(). Now these methods
uses the standard traversal API (HTMLCollection::length() / item(index)),
and thus the standard code path for HTMLCollection traversal.

I did not see any regression with this change on Dromaeo:
http://dromaeo.com/?id=223149,223150

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/336133002

git-svn-id: svn://svn.chromium.org/blink/trunk@176253 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can't enable Oilpan for ImageBitmapFactories, another class in
modules/imagebitmap/, because it's a Supplement of DOMWindow or
WorkerGlobalScope.

BUG=340522

Review URL: https://codereview.chromium.org/323293004

git-svn-id: svn://svn.chromium.org/blink/trunk@176252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We check for form inputs in blockSuppressesAutosizing, but the block
must be a potential cluster root to reach this check.

BUG=376012

Review URL: https://codereview.chromium.org/334333002

git-svn-id: svn://svn.chromium.org/blink/trunk@176251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=abarth@chromium.org
CC=jkarlin@chromium.org, japhet@chromium.org

Review URL: https://codereview.chromium.org/338093006

git-svn-id: svn://svn.chromium.org/blink/trunk@176250 bbb929c8-8fbe-4397-9dbb-9b2b20218538