- 27 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I7488cb81c2e655dec6aaf630009030cb82bc3bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017507Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735365}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I1e39b9c33f4b1a99c713f560e10c5d759dd25b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017329Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: Ib956dacb9e2c63120faec9de2b485130903c87bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017522Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I2379c1b78e2088aa448ab50b2156c99f545d8139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017363Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: Ia66d2e3144a30257a5056a5e027948e756bd4da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017348Reviewed-by:
-
Colin Blundell authored
As one of the final steps in componentizing SSLErrorHandler for sharing with WebLayer, this CL introduces a //components-level SecurityBlockingPageFactory interface and has ChromeSecurityBlockingPageFactory derive from it. By doing so, SSLErrorHandler no longer needs to know about the embedder-level ChromeSecurityBlockingPageFactory. Bug: 1030692 Change-Id: If95f7d1871ff337f7aa252aa74291dc4fa89d3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019264 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#735360}
-
Eric Seckler authored
Replaces the KeyedServiceFactory::GetServiceForContext trace event with a typed trace event. Corresponding proto buffer definitions for these events were added in aosp/1180211. Typed trace events will allow inclusion of the event arguments in slow reports data in the future. The trace format is protocol-buffer based under the hood already (see docs.perfetto.dev for details), this patch adds strong typing for the arguments of the respective event(s) only. TBR: eseckler@google.com Bug: 644264 Change-Id: I67c0f8f78caca2db76e201f8f649f84eda53e3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950966 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735359}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I8681d8f472f14a1dbc22e680b236581e02093c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017503Reviewed-by:
-
sczs authored
Bug: 1040844 Change-Id: Id780551c330924f783bad502cad8bfc6195d63b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018328 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#735357}
-
Omer Katz authored
Tracing a Member or a WeakMember first checks whether the member is deleted. If the check passes, the member is traced. The check and the trace both use atomic loads, but not the same load. This can result in time-of-check vs time-of-use data races. This CL merges both loads to a single load to avoid such issues. Furthermore, members in hash tables now might be deleted while the relevant entry is deleted. Since the is deleted check is performed on a copy, member types need to bail out on deleted values (used to be a DCHECK before). Bug: 986235 Change-Id: I4307361af94081b62d159af67cdbde5666378550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012285 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735356}
-
Koji Ishii authored
Following bot results are included. 1140 1146 1151 1158 4 lines were removed and 4 lines were deflaked by consecutive results since 1128. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ibb13d19075f0edeceed016a972af5e7e46eebf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022043Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735355}
-
Koji Ishii authored
This patch fixes |LayoutInline::InvalidateDisplayItemClients| to support changes to culled inline boxes in rr729656 <crrev.com/c/1774425>. Also moves |NGInlineCursor::CurrentDisplayItemClient| to |NGInlineCursorPosition::GetDisplayItemClient|. Bug: 982194 Change-Id: Icc4ac6c3c27132473d235b9384c46a4f010b6932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016822Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735354}
-
Dominik Röttsches authored
The out-of-process font loader, now that it has moved to using CTFontManagerCreateFontDescriptorFromData, does not need to create a full CTFontRef anymore, but can instead wrap the out-of-process font data into a CTFontDescriptorRef built from data. Doing that avoids creating an extra CTFont copy in font_platform_data_mac, as we can merge the data descriptor with the cascade list attributes, and only then create the CTFontRef from it. Bug: 1033478 Change-Id: I025c265caf472578fd77a11acbc4b23a1d8fffb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013289 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735353}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I81e8fe019528dc7c2009c83fed797ef23ad1a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022565 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#735352}
-
Rushan Suleymanov authored
Do not send sharing message to sync server after first failure. Bug: 1034930 Change-Id: Ic88c12d646ef8028a3280f017d851ba1759575ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017410 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735351}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fcef6dcb6ab2..589b1875f6b6 git log fcef6dcb6ab2..589b1875f6b6 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 93ab50fc27de..b181c1a7ddb5 (4 commits) Created with: gclient setdep -r src/third_party/angle@589b1875f6b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Idfab494e303fcc1b5a0ace737ffec8df2e488aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735350}
-
Koji Ishii authored
This function was added to be the same interface as |NGPaintFragment::InlineFragmentsFor|, but as |NGInlineCursor| evoles, it has the same functionality though |MoveTo(const LayoutObject&)| and |MoveToNextForSameLayoutObject()|. Now we prefer |NGInlineCurosr| for all traversals that this patch removes |ItemsFor()| function and switch all usages to |NGInlineCusror|. Bug: 982194 Change-Id: Ia9dfd4f608d8cfc2c5f6ccc5b40b1e1dda0876f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022445Reviewed-by:
-
Mathias Carlen authored
This patch fixes a NPE by guarding for null tabs. There are situations where a tab is not ready or available and direct action availability is queried. In that case a null tab would crash instead of reporting that this direct action is simply not yet available. Bug: 1041669 Change-Id: Idda1c166405c726cca416898fcd842606e74d3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016625Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735348}
-
Colin Blundell authored
As one of the last stages of componentizing SSLErrorHandler for sharing with WebLayer, this CL starts the process of eliminating SSLErrorHandler's knowledge of ChromeSecurityBlockingPageFactory. To do so, it turns ChromeSecurityBlockingPageFactory's static methods into instance methods and has SSLErrorHandler(DelegateImpl) own an instance of ChromeSecurityBlockingPageFactory. The next CL will introduce a ChromeSecurityBlockingPageFactory interface and have SSLErrorHandler talk in terms of that rather than in terms of the //chrome-level implementation. Bug: 1030692 Change-Id: I42f337c9f3141cd23d46d370e0dfba065e95a6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019242 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Julian Pastarmov authored
If the data parameter is undefined the API will clear the current stored data and delete the file used to store as well as its immediate folder if it has become empty. BUG=1044673 TEST=unit_tests Change-Id: I2f4dd796c9b0e4eea2474def32a47924d0195ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015168Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#735346}
-
Martin Šrámek authored
This reverts commit b283bd25. Reason for revert: Probable culprit for the intermittent compile failures on android_arm64-builder-perf. See crbug.com/1045866. Original change's description: > Android: Use R8 for dex splitting. > > R8 has now added support (b/122902374) for this, fixing a few > outstanding bugs related to class merging. This also makes build rules > a bit simpler. > > Still need to switch Trichrome synchronized proguard over to using > R8 for dexsplitting, then we can remove dexsplitter support entirely. > > This CL updates R8 with another patch, but does not change the R8 > base version used. > > Binary-Size: R8 patch now keeping extra methods. > Bug: 1032609 > Change-Id: I79f88736c20d96b718eb129cdbd093fe1cd297b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014309 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735315} TBR=agrieve@chromium.org,estevenson@chromium.org,smaier@chromium.org Change-Id: I917a73a43e38a4583d9fcedf43d8a29fffbdf914 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032609, 1045866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020964Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#735345}
-
Miyoung Shin authored
Move FrameMsg_ScrollRectToVisible to a RemoteFrame and FrameHostMsg_ScrollRectToVisibleInParentFrame to a LocalFrameHost. Introduce web_scroll_into_view_params.mojom for WebScrollIntoViewParams struct. Bug: 1039285 Change-Id: I80e385fa332aa1749da5a842585d9fd28ec08e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993076 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735344}
-
Mihai Sardarescu authored
Bug: 1028509 Change-Id: I2e0c01f00093e889963ffe96d2972bad10e61bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022663Reviewed-by:
-
Simon Zünd authored
This CL relands one of the tests in https://crrev.com/c/2000023. This test is relanded as-is. Original change's description: > Remove event races in two breakpoint decoration tests > > This CL changes two layout tests to follow the pattern of: > 1. Install an instrumentation promise > 2. Run and await an async action > 3. Await that the instrumentation is called > 4. Dump breakpoint information > > This CL is also in preparation for asyncification of source mapping, > hence making the "action" async. > > Drive-by: Re-baseline one of the layout tests that seems to be fixed > now. > > Bug: chromium:1032016 > Change-Id: Ibad4160fe9ab32aa3f818cdd4937112c3f4e6f08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000023 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731171} Bug: chromium:1030216 Change-Id: I71873e000d0b67dfde630f3175968a87c4a49dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022662Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#735342}
-
Yuki Shiino authored
Auto-generate bindings/{core,modules}/v8/generated_bindings.gni which defines the list of generated source files. Bug: 839389 Change-Id: Ic4342e392509a613bfc7739c2e0002e627ec528e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022042Reviewed-by: -
Hitoshi Yoshida authored
If we want to instantiate a Union classes object from a member type value, we need to use a factory method |FromXxx|. This CL updates make_deafult_value_expr to use it. Bug: 839389 Change-Id: Ie2abbef18a6211c8fe59e6abe6f795966131b4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018563Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#735340}
-
Hirokazu Honda authored
Originally GpuVideoAcceleratorFactoriesImpl get HW encoder capabilities by referencing values stored GpuInfo instance. However, the values are not updated after GPU process boots up. Even if a new hw encoder is available after GPU process is initialized, the hw encoder is not detected. This fixes the problem by querying GPU process the hw encoder capabilities when a render process is created. e.g. open the page. Bug: b:147404923 Test: HW encoder is used at appr.tc Test: tast run webrtc.* on krane Change-Id: Ibca82b6e54e9b5d585037c8e63f4c663d085db0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994849Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735339}
-
Monica Basta authored
The CL that was causing the failure has been reverted in 8d4d0ff0. Re-enabling the tests. This reverts commit 1ea2a91b. Bug: 1043665 Change-Id: Idd8d15db36bb35cf76b9172baff381ac2f78c8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019368Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#735338}
-
Koji Ishii authored
This fixes paint invalidation problem, because this function is used in |LayoutObject::AdjustStyleDifference| to optimize invalidations. Fixes ~45 failures. Bug: 982194 Change-Id: I2c749aed856bdbf8e06b2fb5c1f50b266a68efb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022444 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#735337}
-
Hirokazu Honda authored
The original code of VaapiVEA expects the dimension of the GMB-based VideoFrame on Encode() to be the same as the one aligned by minigbm. This is wrong; GMB-based VideoFrame has a dimension specified by an application (e.g. webrtc app). In other words, the size is not aligned at all. This fixes the wrongness. See https://tinyurl.com/frame-dimension-in-VEA for the detail. Bug: 982201 Test: Hangout Meet on atlas Test: video.EncodeAccel.* Change-Id: I7b42c9e1b2486cb7b95715185e071f0cefcf7597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997426Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05d914745a97..5a0e94681cf8 Created with: gclient setdep -r src-internal@5a0e94681cf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia90648bc57068a221102c379ac005efd0f5464dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022608Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735335}
-
Alexandre Courbot authored
crrev.com/c/1982499 started passing NativePixmapHandles to the GL import methods instead of raw DMAbuf FDs without layout information. But creating a NativePixmapHandles involves duplicating the FDs of a frame ; something that would fail on Tegra which passed invalid FDs that were to be ignored during import. Fix this by returning a dummy FD created from pipe() instead of an invalid one. The dummy FD is not any more useful, but it can be duplicated safely. BUG=b:148105252 TEST=video_decode_accelerator_tests passing on nyan_big. Change-Id: Ifda5f98d8383f4883494d13708a45783149810f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016817Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735334}
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: Ibca97cfb784e396ef56b796d401ee23704996da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021785Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#735333}
-
Takashi Toyoshima authored
Behaviors have been unclear, but if requests are made from a custom scheme, the Origin header in outgoing requests should be set to "<scheme>://" without containing the host:port part those are officially required to be a proper origin for such special cases in WebView. Servers can use "Access-Control-Allow-Origin: *" or "Access-Control-Allow-Origin: <scheme>://" to permit such accesses. This patch adds tests to verify these behaviors to keep compatible behaviors. Bug: 1035366 Change-Id: Ia08e7b4ed764225566c3b09edef2980cfa1b1b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010591Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735332}
-
Francois Beaufort authored
This CL removes support for sharing URLs through NFC aka Android Beam as it is being deprecating. https://android-review.googlesource.com/q/topic:%22Deprecate-android-beam%22) Change-Id: Idb8445e962cdb8d52d870c2f919b67e1b302520a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989754 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
-
Koji Ishii authored
This patch fixes |NGInlineCursor::InternalMoveTo|: 1. When |FirstInlineFragmentItemIndex| is not available and |this| is not at the beginning, it sets |item_iter_| but forgot to set |item_|. 2. When |this| did not have a root, it adds item index to span. It should be span index instead. Bug: 982194 Change-Id: If14c1fe0a99c816789ee85a7695bb4ffceaeceed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022443 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f93a8436cea5..0fb0a21bd999 git log f93a8436cea5..0fb0a21bd999 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2ae61982..82459860 (508 commits) 2020-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f3b4e6c3030f..fcef6dcb6ab2 (15 commits) 2020-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5ef91b82cbed..748ad200897b (6 commits) Created with: gclient setdep -r src/third_party/skia@0fb0a21bd999 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ie231f3934adc9f600dc81f84deda7bcabc8b1ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020580Reviewed-by:
-
Dominik Röttsches authored
Include changes to always prefer AAT over GSUB in horizontal runs, but prefer GSUB over AAT in vertical for reasons of better control over glyph rotation in OpenType `vert` feature. Fallback positioning whitespace size difference in baselines explained in issue chromium:1040017. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/82545c5e2ba2..544031392417 $ git log 82545c5e2..544031392 --date=short --no-merges --format='%ad %ae %s' 2020-01-26 ebrahim Update COPYING 2020-01-25 ebrahim minor 2020-01-24 ebrahim Run morx if run is horizontal or GSUB doesn't exist 2020-01-25 ebrahim [test] Increase subset timeout 2020-01-25 ebrahim [tests] Apply expected results of Mplus1p-Regular subset 2020-01-24 ebrahim [sbix] minor style fixes 2020-01-21 qxliu [subset] Add "--name-languages" and "--name-legacy" options Make name table subsetting consistent with fontTools 2020-01-24 ebrahim Disable hb_ot_glyph_decompose in HB_TINY 2020-01-24 59700018+ckitagawa-work [subset] sbix fix missed offset is_null() check 2020-01-23 ebrahim [ot-glyph] Add a test for #2053 2020-01-24 ebrahim [cmake] Don't build src/main 2020-01-24 ebrahim [ci] Increase msan and fedora-O0 bots subset fuzzer timeout 2020-01-24 ebrahim [src/main] separate the places use private API, minor 2020-01-24 ebrahim Fold src/test-ot-glyph and src/test-ot-color into src/main 2020-01-23 ebrahim [test] Adopt test-ot-color with ot-glyph and remove freetype/cairo dependecy 2020-01-24 ebrahim Revert "[subset] Add "--name-languages" and "--name-legacy" options" 2020-01-24 drott Only prefer AAT morx for horizontal layout 2020-01-21 qxliu [subset] Add "--name-languages" and "--name-legacy" options Make name table subsetting consistent with fontTools 2020-01-22 qxliu [subset] Cmap table: remove encodingRecord entry for empty cmap4 subtable 2020-01-23 ckitagawa Move push call to caller 2020-01-23 ckitagawa [subset] Fix UBSAN issue in sbix 2020-01-22 ariza add api test 2020-01-22 ariza refix PR #2087 subset PairPos1 2020-01-23 ebrahim [ot-glyph] remove open callback 2020-01-23 ebrahim [ot-glyph] noop->nil, fix close path 2020-01-22 ckitagawa Address garretrieger@'s comments 2020-01-21 ckitagawa Add second fixed test 2020-01-21 ckitagawa Fix style issue 2020-01-21 ckitagawa [subset] Fix sbix fuzz problem 2020-01-18 ariza remove empty lookup subtables 2020-01-17 qxliu [subset] Add more tests for GPOS1 subsetting These tests were left out because of issue: https://github.com/fonttools/fonttools/issues/1709 Now re-adding these tests since the issue is resolved. 2020-01-16 ariza minor: un-include glyf.hh in gvar.hh 2020-01-15 ariza [subset] fixed GPOS device table sanitize & serialize (#2087) 2019-11-01 qxliu [subset] subset lookup/feature/script lists for GSUB/GPOS 2020-01-15 ckitagawa Add unittests 2020-01-14 ckitagawa Simplify copy and add fuzzing coverage 2020-01-14 ckitagawa Address initial comments 2020-01-09 ckitagawa [subset] Support sbix subsetting 2020-01-14 ebrahim [ot-glyph] Add open/close callbacks 2020-01-13 ebrahim [ot-glyph] make hb_ot_glyph_decompose_funcs_t struct opaque 2019-10-31 qxliu [subset] layout closure_features and store them in subset-plan 2020-01-13 drott Fix duplicate check in hb_ot_rotate chars 2020-01-13 ebrahim [ot-glyph] minor on tests 2020-01-12 ebrahim Fix collect lookups logic of FeatureTableSubstitution (#2097) 2020-01-11 ebrahim Fix collect lookups logic of FeatureVariationRecord 2020-01-11 ebrahim Use REPLACEME tag 2019-10-22 qxliu [subset] closure lookups for GSUB/GPOS 2020-01-11 ebrahim [ot-glyph] Add tests for hb_ot_glyph_decompose 2020-01-10 ebrahim [ot-glyphs] fix the tests 2020-01-10 ebrahim [ot-glyphs] Move CFF glyph decompose logic to their tables (...) 2019-03-20 ariza added TT VF full font test & fixed bugs 2019-03-19 ariza update CFF2 test results 2019-03-19 ariza add api test cases for HVAR with index map (and fix) 2019-03-19 ariza add gvar & HVAR retain-gids test cases 2019-03-19 ariza fix test build 2019-03-19 ariza add api tests for subset gvar & HVAR; bug fixes 2019-03-18 ariza replaced tt var api test with a composite glyph 2019-03-18 ariza move rounding advance width to glyf 2019-03-18 ariza fix empty glyf's advance width 2019-03-18 ariza add api test for tt var advance widths 2019-03-18 ariza fix build 2019-03-17 ariza fix composite glyf extents 2019-03-17 ariza fix unpack_points 2019-03-17 ariza fix infer_delta 2019-03-17 ariza added explicit casts to metrics 2019-03-17 ariza moved most of var code from gvar to glyf 2019-03-16 ariza add components transformation 2019-03-16 ariza fix tt var extents & add test 2019-03-12 ariza add gvar::get_extents 2019-03-01 ariza fix build 2019-03-01 ariza minor edits 2019-03-01 ariza build fix attempt 2019-03-01 ariza more build fixes 2019-03-01 ariza fix build attempt 2019-03-01 ariza calculate VF advance widths from gvar & glyf 2019-02-26 ariza gvar::subset() 2019-02-26 ariza Added hb-ot-var-gvar-table.hh 2019-02-25 ariza renamed hb_map2_t to hb_bimap_h in its own .hh 2019-02-22 ariza subset VVAR & outer indices 2019-02-22 ariza unuse set in hb_map2_t impl 2019-02-21 ariza fixed compiler gripes 2019-02-21 ariza fix CFF2 local subr subsetting 2019-02-21 ariza fix HVAR & VarStore subsetting 2019-02-20 ariza subset HVAR 2019-03-12 ariza add gvar::get_extents 2019-03-01 ariza fix build 2019-03-01 ariza minor edits 2019-03-01 ariza build fix attempt 2019-03-01 ariza more build fixes 2019-03-01 ariza fix build attempt 2019-03-01 ariza calculate VF advance widths from gvar & glyf 2019-02-26 ariza gvar::subset() 2019-02-26 ariza Added hb-ot-var-gvar-table.hh 2019-02-25 ariza renamed hb_map2_t to hb_bimap_h in its own .hh 2019-02-22 ariza subset VVAR & outer indices 2019-02-22 ariza unuse set in hb_map2_t impl 2019-02-21 ariza fixed compiler gripes 2019-02-21 ariza fix CFF2 local subr subsetting 2019-02-21 ariza fix HVAR & VarStore subsetting 2019-02-20 ariza subset HVAR Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1040017 Change-Id: I5980699aa76e2c588bff78f8db0baa9353b6a24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020963 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Ic95b6207bfaccbe91c2165d09614138bed00ba68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016776 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
We generate code of IDL dictionaries under {core,modules}/xxx/yyy/foo.{cc,h}, and their bindings code under bindings/{core,modules}/v8/v8_foo.{cc,h}. If we need the implementation of a dictionary, we included the former style header files, but bindings team decided to use the latter files as main include target. This CL updates the includes and some forward declarations for the change. Tbr: kinuko Bug: 839389, 1034398 Change-Id: I5371bac9dbd4c16d1db0c7fe4091100155ece4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016991 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735326}
-
