- 31 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7ac42f80c0e8..903d447d96eb git log 7ac42f80c0e8..903d447d96eb --date=short --no-merges --format='%ad %ae %s' 2019-05-31 cepheus@frii.com OpenCL ext. inst. header: Support C in addition to C++. Created with: gclient setdep -r src/third_party/spirv-headers/src@903d447d96eb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I0ec24a59bd8d0edf8b4a09a425ca77fdb9511777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665088}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=liberato@chromium.org Change-Id: I82c3d942c4491a3bc4885e203eb42618ded309d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635523 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665087}
-
Anders Hartvoll Ruud authored
Also let CSSPropertyID::kOverflowX fall through to kOverflowY in the parser fast path, since accepted keywords are identical for those properties. BUG=872356 Change-Id: I021dd07b4fe46e66b9ade3535d23cb869ea4affb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626428Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#665086}
-
Chih-Yu Huang authored
In the original CL, PlatformVideoFramePool class doesn't initialize the value of some data members. This CL fixed this issue. Original change's description: > DmabufVideoFramePool is used to allocate and recycle DMA-buf backed > VideoFrames. It is used by hardware accelerated video decoder. Besides > allocating and recycling VideoFrame, it also provide these functions: > > - Limit the number of buffers to prevent client from draining the > memory. > - Query the original frame by the wrapped frame. > > BUG=941330 > TEST=media_unittests > > Change-Id: I368d620fa0c8fb2b1a03c3479c08bad54acd55da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527911 > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664664} BUG=941330 TEST=Run "media_unittests --gtest_filter=PlatformVideoFramePool*" with gn args "is_msan = true" Change-Id: I51bfaf571c39ac53d2a2a9884e94f171373aa5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635126Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665085}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=dalecurtis@chromium.org Change-Id: Ib1c83dfc5dd51f2944a78ef4841af6d548aecfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635816Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665084}
-
Rune Lillesveen authored
Change-Id: I833f49fefd5dff0abe047a9d28c3ac2d81e21d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636065Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665083}
-
Rune Lillesveen authored
Pseudo styles, which do not have an associated PseudoElement, hangs off of the ComputedStyle of the originating element. Make that cache mutable to make it possible to prepare for making ComputedStyle itself immutable on Node and LayoutObject. Bug: 813068 Change-Id: Ic5916a9f6a19c6571ff928e7f23cddcb74d17ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636131Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=jam@chromium.org Change-Id: I5e7341427bf5ef241b73c3a82718c278d2401b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635817Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/944e0333f735..4b822d3d6e5f Created with: gclient setdep -r src-internal@4b822d3d6e5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ib8996bd8747053a35ffe73fda6074514e3cfb2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638173Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665080}
-
Kinuko Yasuda authored
Bug: N/A Change-Id: I6653cf9d84b71e2795bdd236b1fcae874523d321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637184 Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#665079}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a9e9c3dff0c2..887362fca7a7 git log a9e9c3dff0c2..887362fca7a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 mikewu@google.com chromeos_config: Add config for kumo Created with: gclient setdep -r src/third_party/chromite@887362fca7a7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I4d3ca1bc621263e88aaed105a2015e0267c4548f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638170Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/933d3cab3f30..944e0333f735 Created with: gclient setdep -r src-internal@944e0333f735 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I5815c8fb4c7a2d79d6bcff98fccbcc6bfeed628b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637223Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bad01ad3adaa..cd28c22b7b65 git log bad01ad3adaa..cd28c22b7b65 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@cd28c22b7b65 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2b0401be241e141637b610301a4799deb809e9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637222Reviewed-by:
-
Brandon Jones authored
Removes XRPresentationContext and adds the 'compositionDisabled' option to XRWebGLLayerInit. Bug: 968321 Change-Id: I9dbdd70b66e01f0df6182fbd8238a689365e93dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633231 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#665075}
-
Satoshi Niwa authored
https://screenshot.googleplex.com/Bov9fKoBQ6y.png BUG=b:133848333 TEST=Open files app with unknown MIME type and check the bottom left dropdown in the file selector Change-Id: I9c9f40ca623821e95f9e3d50a792413e3220d0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638205 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#665074}
-
David Jacobo authored
Previously "Open link in a new tab/window" via context menu would allow the user to stay on the web, regardless of whether or not we have installed apps that are good candidates (because of the url/intent filters the app exposes) nor if such apps were marked as preferred before. This CL aims to fix a regression where the user would escape to an installed app that was marked as preferred before (it can also be a verified app) while trying to open a given url on a new tab/window. new tab via context menu. Bug: 968616 Test: Manual checked yelp app is not opening while clicking open in a Change-Id: I9ebc76eeef44e73b204b8ac28343643ef584d50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638144Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665073}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b8451b73557c..0aa9d59e4eb7 git log b8451b73557c..0aa9d59e4eb7 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 dberris@chromium.org SheriffRedux: OpenAPI Cloud Endpoints Created with: gclient setdep -r src/third_party/catapult@0aa9d59e4eb7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Change-Id: I850a3edd9f7ecc6bc221395daaa82d673699baf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638169Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87cf28bc7a26..933d3cab3f30 Created with: gclient setdep -r src-internal@933d3cab3f30 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I533ae1c565a23cb8edb8c35be223159a5be0e33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638166Reviewed-by:
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 616447 Change-Id: Ia48bfa92137742c563fd65418ed661da111ba354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635625 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#665070}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5cef4b57. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." e1be827e "Reland "Use promise in wpt pointer event tests to finish the tests"" 5b933889 "Reland "Adding support to bitmaprenderer in OffscreenCanvas"" 22e874da "Reland "Keep scroll by keyboard after child focused node is removed"" 9d90efc8 "Deflaky pointerevent_touch-action-inherit_child-auto-child-none_touch.html" 2ef3bab9 "Use testdriver Action API in WPT pointerevent tests - Part 8" efd5ae5e "Revert "Reland "Adding support to bitmaprenderer in OffscreenCanvas""" 1a737994 "Revert "Reland "Keep scroll by keyboard after child focused node is removed""" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I2e63731266571b3d847ecae5cb0c5dfb16b5879a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637919Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665069}
-
Suman Nelson Kancherla authored
This is a reland of c6bc9419 fixed build break on Android x64 dbg and Android x86 dbg when enable_vr == false. Original change's description: > Added XR session request consent dialog for Android > > The consent dialog strings - title, body, button texts - are all shared > between Android and Windows. > > Bug: 963637, 962755 > Change-Id: I4d3f090db1ee2487f305b6993b2851c112df594c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620695 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Carlos Pizano <cpu@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664808} Bug: 963637, 962755, 968680 Change-Id: I297030f174660d1b079cb728a47a430df11d8a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637602 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665068}
-
Jeevan Shikaram authored
This CL enables visual feed back on the 'More Settings' icon when Tab focused. Bug: 965892 Change-Id: Iddffafc61fe008e3d46f18b0d013724044e3f9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637017Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#665067}
-
Gabriel Marin authored
Bug=None Change-Id: I73c027230d324d9281d60e3a60be80f403472e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637047Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665066}
-
Danan S authored
Also: - Move authorization token to url parameter - Add URL params for flowType and platformVersion Bug: 937995 Change-Id: I37ecd6e6e1ee283836fc19687a817016d0eb161f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606571 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665065}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=maxmorin@chromium.org Change-Id: I32710534bd1ce31feda549e8fea8b7e4156c933b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636355 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665064}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=maxmorin@chromium.org Change-Id: Ia7812103242968ac29a9055488c9d10e285d9b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635823 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e7a8ca8acb4..87cf28bc7a26 Created with: gclient setdep -r src-internal@87cf28bc7a26 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ic44d2e03ca42769e305025b15e20da79f47d10da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637220Reviewed-by:
-
Fish Lin authored
First, make mojo support deliver storage type, this is needed for v4l2_video_encode_accelerator to read DMABUF correctly, otherwise it will use kShmem. Sencond, DMABUF contains stride, size, and file handle, add the conversion code between VideoFrameData and VideoFrame. Current implementation only support 2 planes DMABUF for NV12, if we'll support more format, may need to modify some code to support them. BUG=chromium:963812 TEST=Deliver DMABUF frame from camera and send it into video encoder through mojo interface, and it can encode correct video out. Change-Id: Ibf9614b6389e080bc0599226c4a20a410bb9666b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631160 Commit-Queue: Fish Lin <linfish@google.com> Auto-Submit: Fish Lin <linfish@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#665061}
-
Timothy Loh authored
As Plugin VM can take a few seconds to start up, we should show a spinner similar to ARC and Crostini. Subsequent launches in a session tend to be slightly faster so we only show a spinner for the first launch. A subsequent CL will make us also show a spinner if we have to wait for the VM to finish shutting down or suspending before starting it (which isn't yet implemented). Bug: 940319 Change-Id: I9ef4078e21f15e4c926a2c23860de14095679f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634294Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665060}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I04f273a42c38251e2485cfd39a7b9b468e9aeac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635070 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
Timothy Loh authored
BUG=966391 Change-Id: I619862abcd348510ae3a90a465b8c091d97a06cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635113Reviewed-by:
-
Ken Rockot authored
WebView environments are configured to run the media service in the GPU process even though GPU runs in browser process. This means we have a valid GpuProcessHost with null process_id(). Recent refactoring of Service Manager code in content misinterpreted this to mean the GpuProcessHost was invalid and that services couldn't be launched by it. This fixes that assumption and always attempts to launch an in-GPU-process service if the GpuProcessHost is non-null. Also in such cases where the reported PID is null, this correctly uses the browser's own PID as the PID for the PID of the launched service instance. This mirrors the behavior of in-GPU-process services prior to the refactoring in r663141. Bug: 967288 Change-Id: Idc9223815f45a2e65766077fa4e695af3e6ceff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637980Reviewed-by:
-
Alex Newcomer authored
Keep the launcher widget alive for the duration of a user session. It is expensive to create and this will make the opening animation smoother after the first open. The view should be build using the Ctor, then call BuildView(). After the BuildView call we can just call SetupAndShow(), which will set the state of the view to be shown, and show the view. Also in this cl: - Update some stale code that was found. - Make the launcher show/hide animations interruptible (except by drag because this is likely not done on purpose). - Move all AppListView layer animations into AppListView, since the AppListPresenterImpl::ScheduleDismissAnimation() copies most of the code in AppListView::SetState(). I will move the close flow further into AppListView in a follow-up cl (crbug.com/965116). - Consolidate the animation observers of AppListView. - Move the WidgetObserver from AppListView to the presenter. This is a bit easier to understand because there will not be multiple widget observers. - Move the AppListBackgroundShieldView implementation details into the class to make the AppListView code a bit simpler. Bug:943356,911740,895688,965310,965311 TEST=automated and manual Change-Id: I87631d07e2ab54b0d83da3f127bc7181c448edc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555239Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#665056}
-
Noel Gordon authored
After CL:16311550, the piex wasm module C++ provides image photographic details derived from the RAW image EXIF. Parse the data for display to users. Store the result in the piex_loader.js {PiexLoaderResponse}. Update the piex/tests.html with the details parser: output the details data and hash to the test output. Update golden test file results. Test: piex/tests.sh PASS, speed unchanged. Bug: 965370 Change-Id: I9e36ff6bac741d0ba8793b9f4120ec27a8069c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632133 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665055}
-
Kent Tamura authored
Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ONvzLM5fPvk/FZDswIOpAwAJ Bug: 825684 Change-Id: I5b1108b72a345e2fb59596e58f7e13d6b772efe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635111Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#665054}
-
Kent Tamura authored
Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/0w_Z-9_kSNs/QV6ChIapAwAJ Bug: 905922 Change-Id: Ic5bec9cab0f56e8a95684896536eabb0205d5c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636990Reviewed-by:
-
Lucas Tenório authored
With this change we add basic error reporting (to be improved with UMA later) as well as more UI configuration options. This essentially decouples the webview loading from the presentation of the flow, so we don't flicker when we make async decisions. Example: 1: WebviewHost finishes load and reports header value. 2: WebviewHost shows empty webview contents. 3: Controller processes the value and decides to exit the flow. 4: The screen flickers since steps 2 and 3 happen too fast and are racing. Introducing a presentation struct solves this issue and also helps to implement another requirement, optional buttons for flow pages. This leaves us with the Controller holding all the important state for the flow, which allows us to write pretty detailed unit tests that cover most issues. This will remove some of the burden from the browser_tests, which are already too complex. Bug: 958995 Change-Id: I5929688ee6a753f817b023937f5d56be597b9fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628035Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
Rob Schonberger authored
This results in impression counts and open records for packages being mis-recorded. I've tested this fix to the bug and note that impressions of >5 are indeed hidden now. Bug: 960468 Change-Id: If0047fb0b9f8eb7a888032b778f374eff136c5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638200Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#665051}
-
Alexey Baskakov authored
DumpAccessibilityTreeTest.AccessibilityIframePostEnable/win fails on bulders: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/92023 https://ci.chromium.org/p/chromium/builders/ci/win-asan/5481 TBR=kschmi@microsoft.com Bug: None Change-Id: I986c5083365d079388e8933231ad0c3745b4cbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638201 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665050}
-
Dominic Farolino authored
This CL makes a SingleThreadTaskRunner example more explicit by using the SingleThreadTaskRunner type instead of using the SequencedTaskRunner base class. Bug: N/A Change-Id: I77fa2affacbda0f4847e4b808eab267f0977fb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636668Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#665049}
-
