- 23 Apr, 2020 40 commits
-
-
Liviu Tinta authored
The test code was not waiting for pointerlockchanged and pointerlockerror events before checking for correctness. Bug: 1014324 Change-Id: I04dac67731f954a5f220c426db031502a6309e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158934Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#761919}
-
Chris Mumford authored
No longer logging the following disused metrics: LevelDBEnv.TimeUntilSuccessFor* LevelDBEnv.IDB.TimeUntilSuccessFor* MojoLevelDBEnv.TimeUntilSuccessFor* Note: LevelDBEnv.IDB.TimeUntilSuccessFor did not have an entry in histograms.xml Bug: 1053059 Change-Id: If6cd4783d8b0714a5a2a359cb4bab8b97b1c5a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161126 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#761918}
-
Ryan Sturm authored
Chrome Prerender (NoStatePrefetch) no longer runs script, so the credentials manager can not run during a prerender. Bug: 1038066, 658732 Change-Id: I34dc2229e56119cf7949b855d66e667511c9830f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158446Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761917}
-
Liviu Tinta authored
The test was not waiting appropriately for events to fire. Now it waits for proper events to fire for requestPointerLock, exitPointerLock, mousemove before it checks for the correctness of the operation. Bug: 766450 Change-Id: Id9f1db83f4555a16a45960f1869680a90c77757e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158386Reviewed-by:
-
Elly Fong-Jones authored
This test flakily crashes, breaking the rest of the suite. Bug: 1069608 Change-Id: I2d4593342e903b75ebd7609f0171873176cd9aa3 Tbr: tommi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161348Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761915}
-
Colin Blundell authored
The //chrome and //weblayer ExternalNavigationDelegate implementations have identical isPdfDownload() functions. This CL dedupes these functions into the shared ExternalNavigationHandler.java. Bug: 1071390 Change-Id: Iebde2257f10a8704b79a76a2fa00b6d6f04845c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161014Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#761914}
-
https://login.live.comJan Wilken Dörrie authored
This change fixes recording the FillingAssistance for websites that submit fields that differ from the fields that the Password Manager filled in. This happens on popular websites such as https://login.live.com. Bug: 1071122 Change-Id: I6088034a1840d16b931ee3d8c8303e9bab74a66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160933Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761913}
-
Ella Ge authored
This CL adds PermissionUpdater and LocationPermissionUpdater classes. PermissionUpdater class owns both the NotificationPermissionUpdater and LocationPermissionUpdater. LocationPermissionUpdater only has constructor for now, implementation for updater TWA location permission will be added in following CLs. Bug: 1069506 Change-Id: I35069c18e3ec767c9baa657cad1d8dd232ce8ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131007 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#761912}
-
Nicolás Peña Moreno authored
This is a reland of 7aa36149 Original change's description: > Reland "Add an end-to-end test for LCP" > > This is a reland of 0a615aa9 > > Some tests run without DCHECK so we instead call > event.GetKnownArgAsValue(). > > Original change's description: > > Add an end-to-end test for LCP > > > > This CL adds an end-to-end test for verifying the behaviour of Largest > > Contentful Paint. Specifically, we check that the API exposed through > > JavaScript, UKM, UMA and TraceEvents all capture consistent measurements. > > > > Change-Id: I5d3c2489e747d410c7d67afe2a49ead6482a3bb5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105395 > > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > > Reviewed-by: Steve Kobes <skobes@chromium.org> > > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#760594} > > Bug: 1072789 > > Change-Id: Ic7f6cf486ed18939a98462a458ac0bb1cc74ff93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159616 > Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> > Commit-Queue: Steve Kobes <skobes@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761304} Bug: 1072789 Change-Id: I74b2e41bdce17444139e5f05f29db76f5c103db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161687Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#761911}
-
Anatoliy Potapchuk authored
This cl replaces placeholder logic with the display of actual menu with the list of features users can enable/disable. PRD: go/kiosk-a11y UX: go/kiosk-a11y-ux Bug: 1049566 Change-Id: If67d7ef3ce41b888cbed7fae59c8cadd8afba498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151565 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761910}
-
Daniel McArdle authored
New histograms: + Net.DNS.JobQueueTime.PerTransaction + Net.DNS.JobQueueTime.Failure + Net.DNS.JobQueueTime.Success The PerTransaction histogram records the time between DnsTask creation and the creation of individual DnsTransactions. We also aggregate the PerTransaction values by HostResolverManager::Job. The success or failure of the Job as a whole determines whether we use the Success or Failure variant. Change-Id: I47acb785f63171239522d56f6f3f4833e38a61c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145862Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#761909}
-
Michael Lippautz authored
Wrapper counts have been used to schedule GCs before unified heap. Bug: chromium:1056170 Change-Id: Ibd1b87dbe3d90d4b63ef643121f390f831db4cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162866Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761908}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I4f161c4e55a69e8e025a142d692e3210f36e4078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162267Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761907}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d4302437c9f1..7e972be1216d git log d4302437c9f1..7e972be1216d --date=short --first-parent --format='%ad %ae %s' 2020-04-23 cwallez@chromium.org Revert "Slab-allocate VkDescriptorSets" 2020-04-23 yunchao.he@intel.com Read and write usage in compute pass is valid 2020-04-22 bryan.bernhart@intel.com D3D12: Enable sub-allocation for RTV/DSV heaps. 2020-04-22 enga@chromium.org Slab-allocate VkDescriptorSets 2020-04-22 brandon1.jones@intel.com Non-Local Residency 1: Get Non-Local Memory Info 2020-04-22 rafael.cintron@microsoft.com Allow Ref<Derived> -> Ref<Base> assignment, and move operations Created with: gclient setdep -r src/third_party/dawn@7e972be1216d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3a6c3bd856e99a52d7049bfbd5d5c7f4e6cdb460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761906}
-
Jérôme Lebel authored
This is a reland of 45e71297 Changing the pure virtual into NOTREACHED() implementation. It is not possible land this patch with pure virtual methods since the subclass is already used. And this patch cannot be landed at the same time than crrev.com/i/2863263. Original change's description: > [iOS] Reauth for trusted vault service > > Adding virtual methods in ChromeTrustedVaultService class to support > re-authentication. > > To present the reauth UI: > void ChromeTrustedVaultService::Reauthentication() > To dismiss the reauth UI: > void ChromeTrustedVaultService::CancelReauthentication() > > See ChromeTrustedVaultServiceImpl for the real implementation (in > crrev.com/i/2863263). > > Related to: > => crrev.com/c/2149330 Adding APIs in ChromeTrustedVaultService > crrev.com/i/2863263 Implementation in ChromeTrustedVaultServiceImpl > crrev.com/c/2153071 Adding coordinator to present the view > crrev.com/c/2152788 Using the coordinator to present the view > > Bug: 1019685 > Change-Id: I935098793ead1f726d7f220e9bb886afb14baa7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149330 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#761800} Bug: 1019685 Change-Id: Idc27951ac252405a86f2447ca8686fa3d5e54716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160971 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761905}
-
Scott Violet authored
Without this, the value isn't reported. BUG=none TEST=none Change-Id: I4e02d0cfc5aa0a9156a44884e6ea37682aee9cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161583 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761904}
-
Benoit Lize authored
ParkableStrings can be written out to disk, through DiskDataAllocator which multiplexes all writes onto a single file descriptor. The file is provided by the browser process. This adds the logic on the browser side to actually provide the file. It is guarded by a (disabled by default) feature, and in any case for incognito renderers. This CL adds: - A mojo interface to provide the file - A feature to enable field trials - Plumbing on the browser and renderer side. Bug: 1029320 Change-Id: I6d1b4ce72561e6ac4dd74a1c4d2fd60a23c48995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160912 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761903}
-
Sigurd Schneider authored
Bug: chromium:1064587 Change-Id: Ib6cc1601a4cce272835748b160525c307a21ddb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119539 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#761902}
-
Stephen McGruer authored
This runs at 5-6s in the Chromium CQ, and occasionally tips to 7s, which then times out. Bug: 1069117 Change-Id: Ied941b276a59edec98cd12441b68ed0a1ac7a931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161894 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761901}
-
Ioana Pandele authored
These are no longer needed. Bug: 1021013, 1070241 Change-Id: Ifab53ce51898c3798446f47bf485818e8e006655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152591 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Alex Rudenko authored
The CL[1] changes the CSS color format used throughout DevTools. It breaks some of the web tests. This CL updates exectations according to the changes made in [1] and disables the tests temporarily. The tests will be re-enabled once the change is made. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2159516 Bug: 1073350 Change-Id: I4b27909e5f27ee142cf609bab0cbfdd7b3887364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162885Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761899}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d605957919ad..209a6444a270 git log d605957919ad..209a6444a270 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 wolfi@chromium.org Update protocol 2020-04-23 szuend@chromium.org [issues] Add test for de-duplication of cookies in AggregatedIssue 2020-04-23 janscheffler@chromium.org Add regression test for layers 2020-04-23 jacktfranklin@chromium.org assert.equal => assert.strictEqual 2020-04-23 bmeurer@chromium.org [CodeMirror] roll CodeMirror to 5.53.2 Created with: gclient setdep -r src/third_party/devtools-frontend/src@209a6444a270 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042721 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I476869145ef189b8afa89c8f79abd6fbf1488cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162687Reviewed-by:
-
Sebastien Lalancette authored
Added configuration in ConfirmationAlertViewController which allows moving the primary action button to the toolbar, and keep showing the image, when the layout changes to compact height mode. Also added a way to overwrite the title text size - made it smaller in the QRGeneratorVC case, as page titles tend to get fairly long. Bug: 1064990 Change-Id: I7588088b60b64a4cf2953326d666ccb081d2d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161376Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#761897}
-
David Jean authored
Bug: 1072990 Change-Id: I6965224ce0d8f8dfc90ecb9f5e0bf663f3e94204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160905 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01d51c49106c..595075bda5d3 git log 01d51c49106c..595075bda5d3 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 treehugger-gerrit@google.com Merge "trace_processor: Parse processDump" Created with: gclient setdep -r src/third_party/perfetto@595075bda5d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If16693042b40c57d65981d85729476ecba8dc670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162686Reviewed-by:
-
Noel Gordon authored
Move the feature back to x86_cpu_enable_simd (was x86_cpu_enable_sse2) to green waterfall android-pie-x86-rel bot, issue 1073809. Failure to be investigated [1], potential change of feature name, etc, but green android-pie-x86-rel waterfall bots come first. [1] Failing tests were in net::WebSocketDeflaterTest (see CL:2161015), and WebSocketDeflateParametersCompatibilityTest (also CL:2161015). Bot failure details recorded in issue 1073809. Tbr: cblume Bug: 1072308, 1073809 Change-Id: Ib55cf308250c958a80c1a8dffe279767372b4048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162509 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#761894}
-
Roman Sorokin authored
ExistingUserControllerTest.ExistingUserLogin ExistingUserControllerUntrustedTest.NewUserLoginForbidden ExistingUserControllerPublicSessionTest.LoginStopsAutoLogin Bug: 654719, 646965, 603735 Change-Id: I9207074e869401ba3db00e38f68badc6ad23f883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160917 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#761893}
-
Johann authored
Use HeapMojoRemote wrapper so that Oilpan will GC the object. Bug: chromium:1049056 Change-Id: If91318eb651fa32a7a2a3c37ce1d21c9f4d24f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143419Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#761892}
-
Johann authored
Use HeapMojoRemote wrapper so that Oilpan will GC the object. BUG=chromium:1049056 Change-Id: Ibd29c294c0d4cb17144f49c3f82c514e794b21d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147976Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I6fec78f63c5d07da8d6089dc562f90f729828d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162390 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#761890}
-
Kazuki Takise authored
A PIP window shouldn't be listed in the overview. We do this by explicitly setting kExcludeInMruKey on the window entering PIP. One edge case of this implementation is the one where a window gets PIP just after Ash enters overview mode. When a PIP window enters PIP, the window list for overview has already been created including the window that's just become PIP (as it was not PIP when the list was constructed). One concrete example is to minimize a PIPable window in splitview. In tablet mode, Ash enters overview immediately after it exits splitview, but it takes a while for the window to get PIP'ed. BUG=b:154082796 BUG=b:154082420 TEST=Minimizing YouTube in splitview doesn't cause YouTube to be listed in overview. Change-Id: I1ddd1b48c9f67ef41892252535843940758bd818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152131 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#761889}
-
David Roger authored
Chrome was doing a programmatic call to /Logout. However, this is not enough to cleanly logout SAML accounts. To fix this, a new tab is created and performs a navigation to /Logout. Fixed: 1068978 Bug: 1056242 Change-Id: Ia2a1079722630846030580d76083c866e9d5acba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149359Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#761888}
-
Vidhan authored
misclassified as ADDRESS_HOME_STATE This CL merges the logic of |ParseCityStateZipCode| and |ParseCountry| to create |ParseCityStateCountryZipCode| enabled by the use of finch flag, |kAutofillUseParseCityStateCountryZipCodeInHeuristic|. It also addresses the issue of the misclassification of the country field into |ADDRESS_HOME_STATE| instead of |ADDRESS_HOME_COUNTRY| by adding a condition to give preference to the country field type over the state field type in case the field appears to be both while predicting the heuristic type. Bug: 1071904 Change-Id: Ia0b1cf4f51dce38afce0033597e9763cf19353ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154946 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#761887}
-
Michael Lippautz authored
There's no particular reason FinalizerTrait needs to be overridable for user code. The concepts that should be used are: - T::FinalizeGarbageCollectedObject: Method that can dispatch finalization when virtual dtor is too expensive. - WTF::ConditionalDestructor: Conditionally adding/removing dtor per type. Bug: 1056170 Change-Id: I61ecef0392f4b1399b7311ff1b9acfeef18da2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107593 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#761886}
-
Sean Harrison authored
Decouple the safebrowsing enhanced launch from privacy settings redesign for added robustness of the privacy settings redesign launch. If safebrowsing enhanced needs to be rolled back they will take care of setting enhanced pref back off for everyone, but the pref will still exist, so security_page.js doesn't need to check the enhanced flag status when checking/settings the enhanced pref. Also, fixed tests that clicked on the disabled button but didn't properly handle the confirmation dialog. Bug: 1032584 Change-Id: I7e45d8c062daba8af412760a07aaa9c5c68180cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161106 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#761885}
-
Mirko Bonadei authored
This CL adds a patch to apply every time Abseil is updated in Chromium in order to define ABSL_OPTION_HARDENED to 1. From Abseil documentation: Hardened builds have additional security checks enabled when `NDEBUG` is defined. Defining `NDEBUG` is normally used to turn `assert()` macro into a no-op, as well as disabling other bespoke program consistency checks. By defining ABSL_OPTION_HARDENED to 1, a select set of checks remain enabled in release mode. These checks guard against programming errors that may lead to security vulnerabilities. In release mode, when one of these programming errors is encountered, the program will immediately abort, possibly without any attempt at logging. Bug: 1072380 Change-Id: I34ccbfdef4ef289886ed76368d7fe9a6cf3e747a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153153Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#761884}
-
arthursonzogni authored
Move the sandbox flags parser from blink to network. Design doc: https://docs.google.com/document/d/1PechV73KKMF8leh7uTlyGkR32kD5qILvu3ZeG8TYGfk/edit?usp=drive_web&ouid=112561809712693690020 Bug: 1041376 Change-Id: Ifbae41fa9e8b3ad86e6dca29594b7a1e9c5be8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129699 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f4ee036871f2..9427b51d6ff5 git log f4ee036871f2..9427b51d6ff5 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 ilnik@webrtc.org Launch external ref control for vp9 encoder Created with: gclient setdep -r src/third_party/webrtc@9427b51d6ff5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027108 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia6e6b541cef86835c907942a04e47c9641c429d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162647Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb1ed24df5aa..d605957919ad git log cb1ed24df5aa..d605957919ad --date=short --first-parent --format='%ad %ae %s' 2020-04-23 szuend@chromium.org [issues] Improve text colors in dark mode Created with: gclient setdep -r src/third_party/devtools-frontend/src@d605957919ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057979,chromium:1068935 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic081ade086a985948d24e1ce3b301597b1336299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162203Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5ab1f36a38aa..dc688a2f5c55 git log 5ab1f36a38aa..dc688a2f5c55 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 digit@google.com Update tests/presubmit.sh to accept Fuchsia bugs as fxb/# Created with: gclient setdep -r src/third_party/swiftshader@dc688a2f5c55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I542bd173dbf95a24c84e6815926576336fb98161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162344Reviewed-by:
-
