- 17 Oct, 2019 40 commits
-
-
Joey Arhar authored
Previous to this CL, and after [1], if a form Submit button had an onclick handler that also called form.submit() and did not call event.preventDefault(), the form would get submitted twice. The second request was eventually cancelled, but not before it hit the network. This behavior is specified in [2], through the "plan to navigate" mechanism. In the case of this bug, the "click" event occurs first, and changes the "planned navigation". Then, because the click handler does not preventDefault(), the default submit action is executed, which changes the "planned navigation", replacing the navigation queued by the onclick handler. Therefore, only the default submit navigation is performed. Note that there are other potential interactions which are less clearly specified, and which are not addressed in this CL. For example: <iframe id="test" name="test"></iframe> <form id=form1 target="test" action="click.html"></form> <a target="test" onclick="form1.submit()" href="href.html">Test</a> In this case, clicking the <a> link first submits the form (to click.html), and then queues a navigation to href.html. Because the navigation to href.html is specified (in [3]) to "queue a navigation", independently of the planned navigation specified in [2], it is unclear when/whether the form submission should take place. The spec ([4]) does have provisions for canceling existing navigations, but that leaves room for the form to still get to the network in this case, before getting canceled. [1] https://chromium.googlesource.com/chromium/src/+/6931ab86f19aa79abbdd0c1062084e16b5c4f0f6 [2] https://www.w3.org/TR/html52/sec-forms.html#form-submission-algorithm [3] https://html.spec.whatwg.org/#following-hyperlinks [4] https://html.spec.whatwg.org/#navigating-across-documents Bug: 977882 Change-Id: I693f3bdccb17c5e64df75c2e569fab589c02e88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850358 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#706782}
-
Justin Cohen authored
Bug: 987646 Change-Id: Iaa13ee085aec001158ac46151a50d5ab3cbfa46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862994 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706781}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3800252a84f8..edf765329fe2 git log 3800252a84f8..edf765329fe2 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 mmortensen@google.com Handle android branch/target/version for boards without android. 2019-10-17 ahassani@chromium.org auto_updater: Retry GetUpdateStatus on failure Created with: gclient setdep -r src/third_party/chromite@edf765329fe2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie2d1a68f6d1c13d8f248403817c0b03ec7c0c79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706780}
-
Kai Ninomiya authored
Note: Some of the tests in the WebGPU CTS right now require runtime compilation of GLSL to SPIR-V. Those tests are currently excluded from the variants list in cts.html to avoid importing glslang yet. Bug: 984818 # Tracking issue Bug: 1014785 # Expectations bug # Actual WebGPU bugs Bug: 1014734, 1014735, 1014738, 1014740 Bug: 1014744, 1014750, dawn:243 Change-Id: Ibb42565565afd29e428f72cc5f26d149b784cdfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860509 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#706779}
-
Alex Keng authored
The current implementation (which uses border-radius: 20px 0px 0px 20px for the value part) has two issues: 1) when the value is large (ex 99%), the flat end overlaps the rounded edge. 2) when the value is small (ex 1%), border-radius doesn't render correctly. (see the associated bug for details) The new implementation achieves the rounded corner effect using clip-path which is applied to a new container div (-internal-meter-clip) added between -webkit-meter-bar and -webkit-meter-*-value. test: fast/forms/controls-new-ui/meter/meter-extreme-values.html Bug: 1013977 Change-Id: I1d50a42bfa9903952664f5f9cac265021e57b642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858295Reviewed-by:
-
Darren Shen authored
We used to have a JSON-based rulebased API, where we needed to escape certain characters in the protocol. We then added an API based purely on Mojo types. However, the code for the JSON one was copied for the Mojo one, so we also escaped certain characters. This means that we actually insert escaped characters rather than the characters themselves. For example, typing "\" gives "\\". We delete the escaping code and add tests to prevent this in the future. Bug: 1014384 Change-Id: I8865869aa020b94c961c71826fa72d6cf2c96b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859809Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#706777}
-
Nicholas Verne authored
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1862337 This fixes an uninitialized member variable in a test fixture found by msan. Adds UpgradeContainer logic to CrostiniManager. A call to UpgradeContainer can start off a long-running upgrade process via the Cicerone daemon. A dbus signal UpgradeContainerProgressSignal is used to communicate progress to Chrome, including the final success or failure of the upgrade itself. Bug: 930901 Change-Id: I18ae12c5706f9a989c5c8247ca8ba223d25cf41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862883Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#706776}
-
Jeevan Shikaram authored
This CL renames the labels of App Management's localized strings to prevent overlap with other settings' localized string labels. It also removes any unused strings. Bug: 1014815 Change-Id: I52b20363b140d1abc7839f763013eeeff6d31513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862888Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#706775}
-
Justin Cohen authored
Record the time taken to read a stored session window, or write one to a file. Bug: 1007337, 1010609 Change-Id: I8f98348c51b8b407b60d9514008431c2fa564d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860303Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706774}
-
Ahmed Fakhry authored
- Make SetEnabledForTest/Dev() simulate a device physical tablet state, which is closer to reality. - This CL also fixes an issue with the overview button, where it should show after transitioning to UI tablet mode finishes. More follow-up CLs are planned for this feature. BUG=925087 TEST=No change in behavior, all tests must pass. Change-Id: I451b40a4f0da5814893d5e2e4cb618d7d4cf2aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865543 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706773}
-
tby authored
Add a CrSOActionRecorder call for each usage of the launcher, with type and query hash as conditions. Bug: 1012936 Change-Id: Ie1e42487c67dc922407bb39f538b67384297f48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865911Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f29cb70281d5..97afd2e21cbf git log f29cb70281d5..97afd2e21cbf --date=short --no-merges --format='%ad %ae %s' 2019-10-17 mtklein@google.com add bsl.16b, cmeq.4s, cmgt.4s Created with: gclient setdep -r src/third_party/skia@97afd2e21cbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Ib69eaaae775697029ea5e98db580db0023b2a7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866065Reviewed-by:
-
Tommy Steimel authored
This CL uses borders to separate notifications in the media dialog. Bug: 1004707 Change-Id: I3c129e46ac1c855a906ac0577fcd092f9087c576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864096 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5cf279fb5b69..91024cf94428 Created with: gclient setdep -r src-internal@91024cf94428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I0aed3ccbd031637e027f245ac761b66fc5f6703b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866064Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706769}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6ca1356dd6dde9fa416ca28f69f2b00f708584be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864368Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706768}
-
Dan Beam authored
Also hide focus outline; just rely on background-color. Fixed: 1015137 Change-Id: Ib9b7e28815317a0954a624923aae0c2712b633df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864822 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#706767}
-
Charles Zhao authored
If for some reason, lots of actions are generated at very short period of time, we need to make sure: (1) We don't use too much memory. (2) We don't use too much disk. Bug: 1012936 Change-Id: I00e9d79c3a45dc3bdbe682bc2e9aae532bc00862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866091Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL matches the status bar behaviour of WebAPKs to that of TWAs by: - Changing the status bar colour used by WebAPKs when the Web Manifest does not provide a "theme_color" to white. This requires increasing MINIMUM_REQUIRED_CHROMIUM_VERSION_NEW_SPLASH - Making the status bar use dark icons if the Web Manifest provides a light colour. BUG=997793 Change-Id: Ia628810345af90cd45bb9762e0ce24f500ed4bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857205 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706765}
-
Tao Bai authored
This essentially adds CorePageLoadMetricsObserver to WebView, the integration test will be in following patch to keep patch simple. Bug: 995880, 992028 Change-Id: Icb25cad2690323d9a0dbd495c57f8f3b461d7c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862251 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#706764}
-
Noel Gordon authored
.computers-root and .external-media-root are file-list only - remove their unneeded [selected] state (directory) tree rules since these icons are never shown that tree, ever. - and file-list does not add [selected] state to icons, ever. fix drive file-type-icon='folder' rules - remove redundant .tree prefix since .tree-item implies you are in a directory .tree, by-design. - moreover, tree-item[selected] also means tree-row[selected] so we can simplify these rules even more ... - rule .tree .tree-item[selected] === .tree-row[selected] as one .tree-row only can be [selected] in the .tree at any time. 'downloads' and root_type_icon='drive' rules - define the normal and tree [selected] rules in the same order. Fix a comment, remove redundant whitespace. Bug: 992819 Change-Id: I210b775b02bfff011c407c8c33f9f966afcd33b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865052Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#706763}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/55e5853e5ce4..2a0049f96a77 git log 55e5853e5ce4..2a0049f96a77 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2a0049f96a77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I4f592844c09091d065e50d2c2fdac0ee76ea430f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866062Reviewed-by:
-
Sanket Joshi authored
Bug: 1015095 Change-Id: I9df222bf1b310cdbc9e31c689b148e392be9b364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865614Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/16944ed21bc2..ae1b7786b89a git log 16944ed21bc2..ae1b7786b89a --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jonahr@google.com Fix ANGLE_FEATURE_CONDITION style issue Created with: gclient setdep -r src/third_party/angle@ae1b7786b89a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I3f24dba6093d05912c3c3cc7992be2b9bdac5afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865136Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c9f13b8d903d..8df31ad1d9b8 git log c9f13b8d903d..8df31ad1d9b8 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 crouleau@chromium.org Reland "[Telemetry] Refactor expectations code into story_filter.py." Created with: gclient setdep -r src/third_party/catapult@8df31ad1d9b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:985103 Change-Id: I71b1b2f2d63f06b5680de86e9d0af1341bc24ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865138Reviewed-by:
-
Sanket Joshi authored
This change fixes a bug where the HSL and Hex values for the selected color could be NaN if the color well's selection ring was the bottom of the color well and the page zoom was set to 150%. At certain zoom levels like 150%, the height of the color well is not a round number. However, the getImageData API, which is used to retrieve the underlying pixel color data for the color well, only works with integer values and will truncate decimal values. As such, if the color well's selection ring is placed at the bottom of the color well, a valid pixel data point for the ring's position cannot be found in the image data array for the color well. When such a situation occurs, the fix is to use the last color in the color well's image data array. This color will be the same as the color seen at the bottom of the color well (black), so the user will see what they expect. Bug: 1015238 Change-Id: I1b74a4870fa455d197c525dca39dc88e7c6f75f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866060Reviewed-by:
-
Fritz Koenig authored
GLES 3.0 does not have glFramebufferParameteri. The spec for MESA_framebuffer_flip_y was updated to add glFramebufferParameteriMESA which will allow the MESA_framebuffer_flip_y functionality on GLES 3.0. BUG=955198 TEST=betty-vm Change-Id: I7e7d762e85b862a1264e130bbb22000adb17ba58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850797Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Joel Hockey authored
Currently we disallow dropping tabs onto a browser that does not support FEATURE_TABSTRIP. This adds an extra check to also disallow if the source and target browser are not the same type (APP vs NORMAL). This CL includes some refactoring of the logic to check whether a tab can attach to a new target. * New function CanAttachTo replaces GetContextForWindow and ShouldDisallowDrag. * Removed TabDragContext.IsCompatibleWith and inlined the profile checking into CanAttachTo. * OnWidgetBoundsChanged no longer calls GetContextForWindow which was previously doing a number of pointless checks to see if the current attached context could drag to itself. Rather this codesite uses attached_context_ directly. From what I can tell, the widget change observer happens on move_loop_widget_ which is attached_context_. * GetTargetTabStripForPoint was previously doubling up on the checks in GetContextForWindow as this function was being called by ShouldDisallowDrag, then again immediately after to get destination_tab_strip_. Now these checks happen only once in CanAttachTo. * BringWindowUnderPointToFront now calls CanAttachTo which has the additional modal dialog check from ShouldDisallowDrag. Bug: 1012169 Change-Id: Iab0a09a1b37024b8611798822c94edd9c6820daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862884 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706756}
-
Brandon Wylie authored
The Google G (or other dse icon) should appear when scrolling the NTP. This icon wasn't displaying because the hasFocus boolean isn't set when scrolling. Adding plumbing to store the current focus percent in StatusMediator and factoring that into the dse icon showing logic. Bug: 1012508 Change-Id: Ia1f5a935ba5ceb8814000a520f482c661da716f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854505 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#706755}
-
Elly Fong-Jones authored
There are a handful of dialogs that need to customize parts of the DialogClientView or BubbleFrameView that DialogDelegate creates internally. Currently, that customization is achieved by overriding DialogDelegate::UpdateButton(), which is called "whenever needed" by DialogClientView. This change reworks that logic. Specifically, this change: 1) Adds a virtual method DialogDelegate::OnDialogInitialized() which is called after the DialogDelegate's frame, widget, etc are all initialized but not yet shown. This will be the new customization point for DialogDelegate subclasses that need to customize these elements. 2) Adds a virtual method WidgetDelegate::OnWidgetInitialized() which is called after Widget::Init is complete. DialogDelegate uses this to call OnDialogInitialized at the proper point. 3) Adds some accessors to DialogDelegate to make getting at the buttons in the DialogClientView easier (and make users of DialogDelegate not need to know about DialogClientView, which should be an implementation detail). 4) Removes DialogDelegate::UpdateButton, which is now superfluous, and folds the body of the old base implementation into DialogClientView where it belongs. 5) Removes some of the GlobalErrorBubbleViewTest suite, which were "change detector" unit tests for the internals of DialogDelegate. OnDialogInitialized is also a logical place to move some of the other customizations of DialogDelegate that are currently done via other hooks (e.g. CreateExtraView and friends); this will happen in a followup change. This is why DialogDelegate has OnDialogInitialized rather than encouraging subclasses to directly override WidgetDelegate::OnWidgetInitialized: soon it will be necessary for DialogDelegate to do its own setup in OnWidgetInitialized, and I want to maintain the "contractless" behavior of OnDialogInitialized. Bug: 1011446 Change-Id: I9a9a24aa077cd62fb219b8104267c5d6ab6edb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865410 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706754}
-
gogerald authored
This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1825165 Bug: 982018 Change-Id: I1cf69ab2aa2ecdaf97d39b92bcfdd690ca4f12ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853826 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706753}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/81607380ef4e..3800252a84f8 git log 81607380ef4e..3800252a84f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 vapier@chromium.org upload_symbols: drop poster module 2019-10-16 jrosenth@chromium.org lib/cros_build_lib_unittest: remove DummyOutput class Created with: gclient setdep -r src/third_party/chromite@3800252a84f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4df36373cb54bdc8ea7e2a25c75ecfc330670660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865137Reviewed-by:
-
Tsuyoshi Horo authored
We decided to use "WebBundles" for BundledHTTPExchanges in Chrome. Bug: 995177 Change-Id: I012effbaf1e1f413bc1aed47571dbb4677eb2593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862882Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706751}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e4c0dc7. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I2482308ce4cdd859286eabc7d30f6ed807a15719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866029Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706750}
-
Tsuyoshi Horo authored
Spec side PR: https://github.com/WICG/webpackage/pull/505 TBR=palmer@chromium.org Bug: 969596 Change-Id: I862fd24c2b3d8a4b237d0852829361dcf9cdde40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861614Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Fritz Koenig authored
GL_MESA_framebuffer_flip_y is needed for ChromeOS, which uses gles. There is no current benefit to using it on other platforms. BUG=964010 TEST=chrome://gpu Change-Id: I5261ac6aed84441d4cc79bea74fd18fd0f35e680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862250 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL adds a metric to measure the draw interval of the compositor, when there is a running custom property animation on the compositor thread. At this moment, a custom property animation is running on the compositor thread only if it is used by a paint workelt. So this metric reflect how smooth a paint worklet animation is running. Bug: 1002076 Change-Id: I7d3a7df096bb347a0f09257ed7bce498b447cac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827246Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706747}
-
Kazuki Takise authored
The current scenario is as follows: 1. Just before PIP resize, the next animation type is set kAnimationAnimated. 2. If the bounds doesn't change, the next animation type remains kAnimationAnimated. 3. PIP resize is started and window geometry and viewport are sent from Android before the first commit of PIP resize. 4. On the first commit, as the next animation type is set kAnimationAnimated, window geometry is applied with animation enabled, but viewport is applied immediately, so we observe a glitch for one frame. This CL changes it so that we make sure to set kAnimationNone once PIP resize has started. at the start of resize. Bug: b/142105182 Test: Resized PIP window and confirmed I didn't observe a glitch Change-Id: Ie61db4fe86891d5d10654d3c44b6dfe6cb7b1730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850684 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b060ba608175..5cf279fb5b69 Created with: gclient setdep -r src-internal@5cf279fb5b69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9b229e0f3219844ec5ba2d618bb1f09dfdf5bde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865482Reviewed-by:
-
sczs authored
Also fixes an issue where Mobile.Messages.Badge.Tapped wasn't part of the affected histograms. Bug: 1014652 Change-Id: Ic80c062183e8cc4fba5a00399ea7bbb3fb0a1d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862867 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706744}
-
Rob Schonberger authored
This CL could be split in two. First, adds a method to Stroke for the biggest touch-major of that stroke, and the corresponding unit test. More importantly: Adds an abstract class for what a checked in model looks like. All the configuration is accessible from the model when instantiated, and no implementation is added. All the fields in configuration are documented, and an explicit constructor for the configuration is added since this counts as a complex struct. Bug: 1009290 Change-Id: I7eeca918540e80a34133230c6d0a67c6b58c2af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864490Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706743}
-
