- 01 Nov, 2018 40 commits
-
-
Clemens Arbesser authored
[Autofill Assistant] Disabled autofill overlay during payment requests, because payment requests have their own overlay. Showing both overlays at the same time darkens the screen too much. However, the overlay color from autofill is different from that of the payment request. Even with this CL, there is a noticeable color change. We may want to adjust the color of our overlay to match that of the payment request. Bug: 806868 Change-Id: I63929cef745e4a573b90f567429ee996eb556b64 Reviewed-on: https://chromium-review.googlesource.com/c/1311922 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#604602}
-
Xianzhu Wang authored
This is a follow-up of crrev.com/c/1286894 which let a test fail if the test has some extra baselines. This CL let rebaseline-cl work for the failures by removing the extra baselines. Bug: 703899 Change-Id: Ib811cb1179af399406214ed78cb22520967915cb Reviewed-on: https://chromium-review.googlesource.com/c/1298124 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#604601}
-
Reza.Zakerinasab authored
This change fixes a memory allocation issue that apparently has caused a memory usage regression in video_VideoDecodeMemoryUsage Bug: 900455 Change-Id: Idc614a5c5171f3a12585ebd3c8384eddc5be7474 Reviewed-on: https://chromium-review.googlesource.com/c/1312627Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#604600}
-
Brian White authored
Bug: 900230 Change-Id: I37dd02c2a7e1b8ef586e101e036d6871c7361424 Reviewed-on: https://chromium-review.googlesource.com/c/1307935Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604599}
-
Dmitry Gozman authored
We don't need some test runner methods anymore. We can also determine capabilities by type instead of passing them separately. Bug: 882467 Change-Id: I0dc07f4379141905d41968f969650f3d794fdee2 Reviewed-on: https://chromium-review.googlesource.com/c/1311839 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#604598}
-
Mikhail Lopatkin authored
Without this the outputs list verification failure doesn't cause build to fail. R=agrieve@chromium.org Change-Id: I5c7416c3ff1681aab0f171ef3ee608aece130e8a Reviewed-on: https://chromium-review.googlesource.com/c/1309781Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604597}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb996dce7525..9e6f5134d1aa git log fb996dce7525..9e6f5134d1aa --date=short --no-merges --format='%ad %ae %s' 2018-11-01 dj2@everburning.com Reduce number of test targets (#2024) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9e6f5134d1aa The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I621e581b9ab2be759ec10ff6615e08c2a9badfa4 Reviewed-on: https://chromium-review.googlesource.com/c/1312626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604596}
-
François Beaufort authored
This CL is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1303364 Bug: 891427 Change-Id: Ie3075933134463107e43d2f452cc025405ba19c5 Reviewed-on: https://chromium-review.googlesource.com/c/1307394Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#604595}
-
Tommy Martino authored
The JellyBean implementation of the dropdown class doesn't show a divider between the ListView and the footer. This CL corrects that issue by wrapping the footer view in a simple new layout containing a divider, on Jellybean only. Bug: 900781 Change-Id: I37ed28c705dcfc4c0caa3aa9bde4dc122f29e9ca Reviewed-on: https://chromium-review.googlesource.com/c/1311938Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604594}
-
Xianzhu Wang authored
In SPv1, background painting on the main graphics layer and on the scrolling contents layer are initiated by CompositedLayerMapping separately, so BlockPainter::Paint() just check the context to paint the background once on either the main graphics layer or the scrolling contents layer. In SPv2, for background painting BlockPainter::Paint() is called only once for each object in the background paint, so it needs to deal with the background on the main graphics layer and on the scrolling contents layer at the same time. Bug: 732611 Change-Id: I22300b82a585c3b96624524c37ed4bf6abafd9c8 Reviewed-on: https://chromium-review.googlesource.com/c/1303358 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604593}
-
Ehsan Chiniforooshan authored
We have TBMv2 versions of thread_times metrics, implemented in the Catapult repo in tracing/tracing/metrics/rendering. The legacy code for these metrics live in the Chromium repo in tools/perf/metrics/timeline.py. In order to not have a pause in the perf dashboard when we replace metrics defined in the Chromium repo with the ones defined in the Catapult repo, we plan to: 1- (this CL) modify the AddTBMv2RenderingMetrics function to behave when both metrics (with the same name) exist, 2- for all (groups of) thread times metrics: 2.1- rename the TBMv2 version, in the Catapult repo, to have the same name as the legacy metric, 2.2- delete the legacy metric, from the Chromium repo. 3- and, finally, delete the rendering measurement and rendering_util, and completely move to TBMv2. Bug: 890757 Change-Id: Iafb84d3ec0f732177005651e0b54b8dccb307c65 Reviewed-on: https://chromium-review.googlesource.com/c/1307838Reviewed-by:Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604592}
-
James Cook authored
This reverts commit 76f7d242. Reason for revert: Failing LockScreenNoteTakingTest.Launch on MSan bot, see crbug.com/899055 Original change's description: > Let ash provide window show state if client has SHOW_STATE_DEFAULT > > For lock screen app windows the window manager needs to specify the > initial show state of the window. Ensure the client (chrome) does not > overwrite the aura window show-state property in ash if the client > window has ui::SHOW_STATE_DEFAULT. > > Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash > > Bug: 899055 > Test: added to views_mus_unittests > > Change-Id: Ib7b6f9a060835ebf3e017737e4b98387a31831c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1303273 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604517} TBR=jamescook@chromium.org,tbarzic@chromium.org,sky@chromium.org,tsepez@chromium.org Change-Id: I809656b611b297daf7c1bacb5ec620a94ee3f235 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899055 Reviewed-on: https://chromium-review.googlesource.com/c/1312931Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604591}
-
Peter K. Lee authored
This code should have been removed as part of http://crrev/c/832942 Bug: 795802 Change-Id: I6d087c8f2cfc8c955db8ca757feded7379b7b6a6 Reviewed-on: https://chromium-review.googlesource.com/c/1312299Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#604590}
-
Jordan Demeulenaere authored
See b/118735405. Change-Id: Ia759ad8bab73d9479d832aa7dd187b51337773fc Reviewed-on: https://chromium-review.googlesource.com/c/1312479Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#604589}
-
Antonio Gomes authored
This is a reland of 947d8086 Compared to the reverted CL, this CL changes the way profiles are created, making use of the helper IdentityTestEnvironmentProfileAdaptor::CreateProfileForIdentityTestEnvironment, by overriding CreateBrowserContext. It is worth saying that the original memory failure was reproduced locally with the original CL and is now fixed. Original change's description: > [s13n] Convert c/b/ui/webui/settings/people_handler_unittest.cc to IdentityManager > > This CL converts the PeopleHandler unittests away from SignManager and > ProfileOAuth2TokenService, in favor of the new IdentityManager. > > Production code has been converted in [1]. This is a follow up steps. > > [1] https://crrev.com/c/1261637 > > BUG=890810 > > Change-Id: I405e46d2126180a2da61393bf32263ae43877b6b > Reviewed-on: https://chromium-review.googlesource.com/c/1311093 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#604377} Bug: 890810 Change-Id: I0aa039575603765bf4cec86cbb87bc86fd0b301f Reviewed-on: https://chromium-review.googlesource.com/c/1312909 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604588}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f0bf6da3705..83a7a95315fa Created with: gclient setdep -r src-internal@83a7a95315fa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7aa172f8eb70914040249f75335de8b1d4e9a98a Reviewed-on: https://chromium-review.googlesource.com/c/1312622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604587}
-
Evan Stade authored
Bug: 814675 Change-Id: I0eef36c50c2ec3b6dcc5566e553ed26f27379528 Reviewed-on: https://chromium-review.googlesource.com/c/1311657Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#604586}
-
Lei Zhang authored
The flag is a no-op and will be deprecated/removed in the future. Change-Id: I51532a2bc2b8e03f0489b2ac05589101d709d0c1 Reviewed-on: https://chromium-review.googlesource.com/c/1312310 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#604585}
-
erikchen authored
The TearDown method on several contexts will invokes ADB. In some instances [e.g. on receiving a SIGTERM due to timeout] there's a high probability that ADB is non-responsive. In these cases, sending an ADB command will potentially take a long time to time out. Before this happens, the process will be hard-killed for not responding to SIGTERM fast enough. This CL makes the test_runner.py SIGTERM handler set allow_adb_on_teardown=False. This prevents these contexts from invoking ADB, increasing the likelihood that SIGTERM will handled within the 30 second limit and emit JSON test results. Bug: 895027 Change-Id: Ic30cff73a82a5415c5f531eae5c8f62fb4c953aa Reviewed-on: https://chromium-review.googlesource.com/c/1311259Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604584}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e16778c0abc9..5cb84f85868b git log e16778c0abc9..5cb84f85868b --date=short --no-merges --format='%ad %ae %s' 2018-11-01 primiano@google.com Create sqlstats table with query perf logs Created with: gclient setdep -r src/third_party/perfetto@5cb84f85868b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:115958658 TBR=perfetto-bugs@google.com Change-Id: I681a6b5c2f68ef8df1d44739a14f366939b4a7ee Reviewed-on: https://chromium-review.googlesource.com/c/1312620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604583}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/763fc966993d..e4dda60c7111 git log 763fc966993d..e4dda60c7111 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 mtklein@chromium.org remove unreachable paths in SkBlitter::Choose() Created with: gclient setdep -r src/third_party/skia@e4dda60c7111 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I08246ed8e3b51fd166c213292d469bec581f7262 Reviewed-on: https://chromium-review.googlesource.com/c/1312643Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604582}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c39d9737dc28..4115d82f09e2 git log c39d9737dc28..4115d82f09e2 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 dtu@chromium.org [pinpoint] Add metric label to chart y-axis. Created with: gclient setdep -r src/third_party/catapult@4115d82f09e2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia01320166958cf99a2c16c11bca33a2e4318bd2d Reviewed-on: https://chromium-review.googlesource.com/c/1312623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604581}
-
Anders Hartvoll Ruud authored
Initial values are currently not stored at all on ComputedStyle, and we must refer to the PropertyRegistration to figure out what the initial value for a given property is. The problem with this, is that registering a property also has the effect of giving all styles that are already computed new values (effectively). For example, if a property '--x' is not registered (and not applied on any style), the computed value of that property is the "empty value" as described in css-variables. If the property then becomes registered, the initial value suddenly becomes whatever is specified by the registration, even on the ComputedStyle objects that already exist. This causes problems for calculating transitions, because we incorrectly consider the previous computed value to be "initialValue" from the registration rather than what it really was: "empty value". This CL adds a StyleInitialData class which contains the initial values for all registered variables. This class is instantiated for the initial style, and then referenced by all ComputedStyles that inherit from that style. This makes it possible to know what the initial value was for a certain property at the time style calculation took place. R=futhark@chromium.org Bug: 848250 Change-Id: I0a44e06608738aab15cb35fbc448a47188932600 Reviewed-on: https://chromium-review.googlesource.com/c/1309736Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#604580}
-
Bin Wu authored
In QuicCryptoClientConfig, change the preferred encryption algorithm from chacha20 to aes-gcm. Client side code, not flag protected in GFE. Merge internal change: 219390992 Change-Id: I812be51b1ebacfd3c8a2fcbdac054da098306c3f Reviewed-on: https://chromium-review.googlesource.com/c/1312093Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604579}
-
Yutaka Hirano authored
Bug: 898179 Change-Id: Ief4827898994347056aa731b30c42b9c496e5838 Reviewed-on: https://chromium-review.googlesource.com/c/1312186 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#604578}
-
Peter Wen authored
This will be used when Crashpad is turned on. Tracking these counts client-side with histograms gives us more reliable numbers than counting the minidumps that have made it server-side, since for a number of reasons further down the codepath the minidump could not end up being successfully uploaded. e.g. Unable to get to network before 3 upload attempts complete. Bug: 894027 Change-Id: I6e385a22650254a10206a78b8eab49350b989b5f Reviewed-on: https://chromium-review.googlesource.com/c/1299926 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604577}
-
Vladislav Kaznacheev authored
Apply MD icon normalizer to icons returned by Play Store search to ensure that the they are roughly the same size as regular app icons. Bug: 900685 Test: manual Change-Id: I1960397c1ef3179590cccaac4fd69176849bce17 Reviewed-on: https://chromium-review.googlesource.com/c/1310915Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#604576}
-
gogerald authored
This solves the problem of card autofill failure when not choosing save to Chrome Bug: 806868 Change-Id: I80668ffe9f25661e735a1d2b7cc211f9c2c4e59c Reviewed-on: https://chromium-review.googlesource.com/c/1306640 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604575}
-
Guido Urdaneta authored
This CL adds: * NumericRangeSet::Contains(). * NumericRangeSet::EmptySet(). * ResolutionSet::FromNativeResolution(). These utilities are in preparation for supporting the resizeMode constrainable property in getUserMedia() and applyConstraints(). Drive-by: minor fixes/improvements. Bug: 854980 Change-Id: I858f406308aa9bba40521d5e740219b72e2c8a48 Reviewed-on: https://chromium-review.googlesource.com/c/1308133Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#604574}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4e9332983946..be837ac3bc79 git log 4e9332983946..be837ac3bc79 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 philipel@webrtc.org Remove RTPFragmentationHeader from LibvpxVp8Encoder. 2018-11-01 saza@webrtc.org Remove deprecated AudioProcessing::GetStatistics function Created with: gclient setdep -r src/third_party/webrtc@be837ac3bc79 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib70a8b1d0a0b7faa75f987ebd7311e99ff5a573a Reviewed-on: https://chromium-review.googlesource.com/c/1312642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604573}
-
Ella Ge authored
Fractional Mouse type pointerEvent shipped in M64 https://chromium-review.googlesource.com/753511 https://www.chromestatus.com/feature/5117956774166528 Remove the flag and clean up related todo. BUG=773813 Change-Id: Id8e17705b43d3bfe55deeed2a3bf7d39b61a71ed Reviewed-on: https://chromium-review.googlesource.com/c/1230577Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#604572}
-
Sean Gilhuly authored
Watch for a server socket when the frame sink manager is created, and run the viz devtools server on the compositor thread if it is present. The server socket is not passed in through mojo yet, so the devtools server will not be created. Bug: 816802 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic02853a2e1f845df365716c29e4f974ffd7482dc Reviewed-on: https://chromium-review.googlesource.com/c/1285078Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#604571}
-
Rune Lillesveen authored
LayoutNG used kNeedsReattachStyleChange instead of kSubtreeStyleChange on Document when changing designMode to force a re-attach. However, Document::UpdateStyle() does not have separate behavior for the two. The LayoutNG code triggers layout tree changes on style recalc appropriately. We would like to get rid of kNeedsReattachStyleChange for a full separation of style recalc and layout tree building. TEST=editing/ with LayoutNG enabled Change-Id: Iac04f705e56233de6771da224fc9e8edc9a487be Reviewed-on: https://chromium-review.googlesource.com/c/1312476Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#604570}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682dcdd0a083..5f0bf6da3705 Created with: gclient setdep -r src-internal@5f0bf6da3705 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I71437041194e0818c259fdd1733bf07783240e78 Reviewed-on: https://chromium-review.googlesource.com/c/1312641Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604569}
-
Fady Samuel authored
When parent-allocated and child-allocated LocalSurfaceIds are merged, a new LocalSurfaceId may result which represents a new allocation. The allocation timestamp was not updated upon this UpdateFrom(Child|Parent). This CL fixes that and adds corresponding unit tests. The existing unit test framework is also cleaned up a bit. Change-Id: I41038c281c6a2de48a1e3c36ae871018bbb842e8 Bug: 655231 Reviewed-on: https://chromium-review.googlesource.com/c/1310117Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#604568}
-
Mike Reed authored
Bug: skia:8493 Change-Id: Ic967d74a87741ba7e6044154730b98e44672a5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1310356 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604567}
-
Tsuyoshi Horo authored
CalculateOverheadSize() calls resource_request_.Url(), so resource_request_ must be set before setting overhead_size_. Bug: 900529 Change-Id: I7b373395c018a43934f92ef2e67acd18f00211f3 Reviewed-on: https://chromium-review.googlesource.com/c/1312187Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604566}
-
Mike Reed authored
The current behavior of setting the embedded bitmap flag based on avoid_embedded_bitmaps_ has been in place for ~1 year. This is overriding the older size based tests which are now effectively dead code. Change-Id: I26d4d338d7a5169932ff8b665bfcbdab222e125f Reviewed-on: https://chromium-review.googlesource.com/c/1310673 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#604565}
-
Juan Antonio Navarro Perez authored
These stories ara failing with an unhandleable error, preventing the rest of the benchmark to run. Disable these as a short term quick fix. NOTRY=true TBR=nednguyen@google.com Bug: 900909 Change-Id: I8e51ced1644853469ff8310de03cb232abba9253 Reviewed-on: https://chromium-review.googlesource.com/c/1311924Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#604564}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f4dfa4106c9..4e9332983946 git log 7f4dfa4106c9..4e9332983946 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 yvesg@webrtc.org Properly setup MockPeerConnectionObserver in tests (continued). 2018-11-01 tomas.popela@gmail.com Add support for screen sharing with PipeWire on Wayland Created with: gclient setdep -r src/third_party/webrtc@4e9332983946 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief57bdc07575588747837a3474c880e514bd82bf Reviewed-on: https://chromium-review.googlesource.com/c/1312640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604563}
-