- 11 Dec, 2017 40 commits
-
-
Dave Schuyler authored
This CL replaces the slower i18n() code with $i18nPolymer replacements and reduces usage if I18nBehavior. Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I324e5d148e71cd4abc0cfa028d5b48fbc1cefaf2 Reviewed-on: https://chromium-review.googlesource.com/812571Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#523215}
-
Dianna Hu authored
A *temporary* server-side change landed and was effectively reverted, but the code it touched in the interim had previously diverged from Chromium. This minor change reduces such divergence. This CL lands server change 177456734 by sbenza. BUG=488484 Change-Id: I871a2db6313dd9901785c2e8b02d20b2332e5746 Reviewed-on: https://chromium-review.googlesource.com/818745 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523214}
-
Daniel Bratell authored
In jumbo builds, the three different ReleaseOriginalFrame methods in content/renderer/media ended up in the same translation unit and then Bind() didn't know which one to use Bug: 746953 Change-Id: I584df28230d29bbc80d9d6cd2884300b7a3d9409 Reviewed-on: https://chromium-review.googlesource.com/819611Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523213}
-
Dave Tapuska authored
We didn't support setting keyCode/charCode from the KeyboardEventInit which other vendors did. Approved intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wEm8WWPpxU4/S4sLZgQNBgAJ BUG=679439 Change-Id: I2f817fa71ec09f80650ec458edfffe6ab328eb02 Reviewed-on: https://chromium-review.googlesource.com/793989 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#523212}
-
Jiaquan He authored
Bug: 785523 Change-Id: If05a0ec3164e402c9f475280ef6e6851eeb70d07 Reviewed-on: https://chromium-review.googlesource.com/798156Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#523211}
-
Isha Bobra authored
For the elements where a click listener is present in its ancestry chain, a default action verb "click-ancestor" is used. So for android this CL makes sure that such elements are not marked as clickable. Bug: 645167 Change-Id: I0ce047e8bf619bb6eaa3c77bc4bec4d2d999e203 Reviewed-on: https://chromium-review.googlesource.com/804202 Commit-Queue: Isha Bobra <ibobra@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523210}
-
Avi Drissman authored
It was added in cc0d9147 to control two things, but after 077f5031 it's redundant. BUG=none Change-Id: I92d9006226e1f2a0c30ebefd88b893b20bceada3 Reviewed-on: https://chromium-review.googlesource.com/809291Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523209}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9b88991c7211..c7abc08034a3 $ git log 9b88991c7..c7abc0803 --date=short --no-merges --format='%ad %ae %s' 2017-07-04 cwallez Implement EGL_ANGLE_iosurface_client_buffer Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2eee34b28912535b708fed872f0eba4d1cba12ba Reviewed-on: https://chromium-review.googlesource.com/820105Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523208}
-
Robert Sesek authored
Bug: 598854 Change-Id: Iddb9088de87cd583115070831d4b7799ab6863a7 Reviewed-on: https://chromium-review.googlesource.com/816154Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523207}
-
Sadrul Habib Chowdhury authored
Make sure the LayerTreeFrameSink has the LocalSurfaceId correctly set, even if the LocalSurfaceId is generated before a LayerTreeFrameSink is created. BUG=786453 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I768f06ab84ede54218afd2f9c3dbaf8bbb27296a Reviewed-on: https://chromium-review.googlesource.com/817632 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523206}
-
Aaron Leventhal authored
When arrow to search with screen reader, do not say "answer" unless there really is an answer (such as the current weather). Bug: 793468 Change-Id: Ic7de2826796f1f62b552940c3b8bfefd1f2878a4 Reviewed-on: https://chromium-review.googlesource.com/817956 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#523205}
-
Sadrul Habib Chowdhury authored
If a window is embedding another client, then it needs to be able to generate a LocalSurfaceId that the embedded client will use. BUG=786453 Change-Id: I2fa66355399a057536f5c07d512f5c82df10fe90 Reviewed-on: https://chromium-review.googlesource.com/818156 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523204}
-
Hiroshige Hayashizaki authored
Instead of storing a Resource pointer, this CL plumbs the Resource pointer given as the NotifyAppendData() argument. This removes the last persistent Resource pointer in bindings/core/v8. Bug: 788828 Change-Id: Iae1c457537a69c3acf9846d92b9cc02e84ec71fc Reviewed-on: https://chromium-review.googlesource.com/798530 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523203}
-
Peter Collingbourne authored
This variable is set to true in the build system if a sanitizer runtime is being linked. Since these are the exact circumstances in which we need to initialize the runtime library for sandboxing, have the sandbox initialization be controlled by this variable. This fixes an issue where we were failing to initialize the runtime for sandboxing if CFI diagnostics are enabled. Bug: 793560 Change-Id: I0c2fb922d2debe39a9bd0d6cc8ebf1b440e3ed63 Reviewed-on: https://chromium-review.googlesource.com/820450Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523202}
-
Steven Holte authored
Bug: 754895 Change-Id: I7b25e9759cc350b15581c1cf197ba1e534e11b55 Reviewed-on: https://chromium-review.googlesource.com/815765Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#523201}
-
Eugene But authored
This is the third refactoring CL for PassKit implementation based on ios/web Download API. CL creates PassKitCoordinator object which serves as PassKitTabHelperDelegate and coordinates the presentation of PKAddPassesViewController and error infobar. TabHelper CL: crrev.com/c/794021 Design doc: https://goto.google.com/ios-chrome-passkit Bug: 787943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifad43d79ed161f5540715accdcc1223639c55a08 Reviewed-on: https://chromium-review.googlesource.com/794302 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#523200}
-
Fady Samuel authored
A surface may stay alive after its CompositorFrameSink is thrown away. This can happen if the surface is referenced by a parent compositor. A new child CompositorFrameSink may be created (after context lost) and it may reuse the same surface before it is garbage collected. In this case, the surface refers to an invalid SurfaceClient (CompositorFrameSinkSuppport), and crashes. This CL fixes the issue. Bug: 791172 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7814bf40b706c52d755fdd69accce1deee9862a0 Reviewed-on: https://chromium-review.googlesource.com/818126Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523199}
-
Yuzhu Shen authored
This is a reland of c1ab49a9 Original change's description: > Remove AMD-style module support from gin/. > > Bug: 718047 > Change-Id: If480fff65a2e5993ed5143eede8354f890de3a3b > Reviewed-on: https://chromium-review.googlesource.com/812172 > Commit-Queue: Yuzhu Shen <yzshen@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522850} TBR=jochen@chromium.org (There is no changes to the original CL.) Bug: 718047 Change-Id: I95600ef92ce7014e5240712b4dc4e962f431b526 Reviewed-on: https://chromium-review.googlesource.com/820091 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523198}
-
Shivani Sharma authored
This CL removes the dcheck from HttpCache::Transaction::SetPriority that presence of network_trans_ implies !InWriters(). For a range request, it is possible that the transaction is in writers but is in the headers phase to serve a subsequent range and network_trans_ is the network transaction created for that range. Bug: 785561 Change-Id: If0c25209e3c1eefd911a8f544834e3f6604001d9 Reviewed-on: https://chromium-review.googlesource.com/820072 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523197}
-
Evan Stade authored
preferred size changes. This removes the only method from the interface which isn't just a thunk to an identical method on MessageCenter. After this, we can get rid of MessageViewDelegate and remove this layer of somewhat confusing indirection. Bug: 755413 Change-Id: I9338e3ff533116fb3a91d3e4909755d3b64be0d5 Reviewed-on: https://chromium-review.googlesource.com/812444 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523196}
-
Tom Anderson authored
Comment [1] explains that libssl1.0.0 can be manually installed on systems that are expected to have libssl1.0.2. In this case, libssl1.0.0 will appear to be available in the repos when it is not. The fix is to check for newer packages first. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=785818#c13 BUG=785818 R=dpranke@chromium.org Change-Id: I52a69adc5271b5485f7d09aabd1a01a24ff10352 Reviewed-on: https://chromium-review.googlesource.com/819976 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#523195}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d34224be..3477c932 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie561d7205745eae14b2ba915ace95904940a09d5 Reviewed-on: https://chromium-review.googlesource.com/820250Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523194}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c34676349da6..2326177e3499 $ git log c34676349..2326177e3 --date=short --no-merges --format='%ad %ae %s' 2017-12-10 csmartdalton CCPR: Don't use instanced draw calls with geometry shaders 2017-12-11 halcanary apps/build.gradle: skiaOut is now absolute since a2e7f5ae10 2017-12-11 fmalita Fix SampleLua build 2017-12-08 brianosman Create a Window::Layer interface to reduce sk_app glue code 2017-12-11 mtklein The downsamplebitmap_image GMs only use one image. 2017-12-11 mtklein Revert "add experimental bilerp_clamp_8888 stage" 2017-12-11 benjaminwagner Add Goma Test/Perf jobs. 2017-12-11 halcanary resources: file moved 2017-12-11 mtklein add experimental bilerp_clamp_8888 stage Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I906f3dad4df7433f4bb2f8499a996b502cd629df Reviewed-on: https://chromium-review.googlesource.com/820034Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523193}
-
jdoerrie authored
This change improves the usability of U2fDiscovery. Mainly it moves the responsibility of owning devices from U2fRequest to the individual discoveries. Furthermore, U2fRequest does not own the discoveries anymore, but simply registers as a observer. Bug: 763303 Change-Id: Ibb2eb45569094b85dc80de615caee540cd3b82c1 Reviewed-on: https://chromium-review.googlesource.com/819413 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523192}
-
sczs authored
Video: https://drive.google.com/open?id=1a1sRYytjBniCV-l8M-7T0Hjm1ppFDWlD Bug: 792786 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib153b2c26f14d9870a7f2ad9fba4f92d99360400 Reviewed-on: https://chromium-review.googlesource.com/815733 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523191}
-
edchin authored
This CL pulls ExternalAppLauncher ownership out of Tab, which is an improvement in its own right. This change is also required to remove the use of rootVC in ExternalAppLauncher in a future CL. Bug: 791792 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d49629245483c7ca2e22e720ae20f90b0615b93 Reviewed-on: https://chromium-review.googlesource.com/811387Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523190}
-
Ken Rockot authored
This removes direct dependencies on net::URLRequest (and NetLog) from most extensions code related to WebRequest and similar APIs, replacing it with a new WebRequestInfo type which can be constructed from a net::URLRequest or (eventually) some other source of request information. This is preparatory work for making these extensions APIs work when the Network Service is enabled, where direct usage of net::URLRequest in the browser will be forbidden. Incidentally this change also allows for the persistence of frame data throughout the lifetime of a request, fixing a long-standing bug. Bug: 721414, 522129 Change-Id: Ib427e5ddac66273bf0b23100c5cb4e74b7613506 Reviewed-on: https://chromium-review.googlesource.com/778461 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523189}
-
Lei Zhang authored
Change it to GetByteRangeStart(), since no caller actually cares about the end of the byte range. Fix some nits along the way. Change-Id: Ia7846923bcf0e5923dd677f85bfe2c5c0ea187c4 Reviewed-on: https://chromium-review.googlesource.com/810005Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523188}
-
Weiyong Yao authored
HW H264 encoder was enabled on Android for a while, lacking of auto test cases though. There are several regressions recently, which broke the intercommunication with H264 between Android and other WebRTC ends since there is no SW H264 fallback available on Android. This cl is to add a content browser test case to promote H264 on Android devices which support HW H264 and verify the H264 call works normally. PS: During developing this cl, it can catch a very recent regression, as in https://chromium-review.googlesource.com/c/chromium/src/+/810429 So it can really do its job. Bug: 776122 Change-Id: Ibf5d428a546a99e5af955005642446acca77fa91 Reviewed-on: https://chromium-review.googlesource.com/817699 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#523187}
-
Bence Béky authored
It is possible that a DCHECK in SpdySession::DcheckDraining() is triggered when SpdySessionPool destructor call SpdySessionPool::RemoveUnavailableSession() which destroys the SpdySession, if the SpdySession is in STATE_GOING_AWAY. One way for this is that on certain platforms, SpdySessionPool::OnIPAddressChanged() may leave a SpdySession with an active stream in STATE_GOING_AWAY. Another possible way is receiving a "graceful GOAWAY" from the server, which also puts a SpdySession with active streams in STATE_GOING_AWAY. Patch set 1 introduces two unit tests, one for each of the above scenarios, that trigger this DCHECK. See trybot outputs for failing tests. Patch set 2 fixes the bug by ensuring in SpdySessionPool::CloseAllSessions() that every owned SpdySession is draining, even if there are no currently active sessions. This method is not only called by SpdySessionPool destructor, but also by HttpNetworkSession destructor (also adding a TODO for that). Also include build/build_config.h for OS_ANDROID, OS_WIN, OS_IOS macros. Bug: 789791 Change-Id: Idc3e2350b2ac6354be5c5e6b32ea8e0227f3e2d6 Reviewed-on: https://chromium-review.googlesource.com/810889Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523186}
-
Ned Nguyen authored
Bug:792932 Change-Id: I4da6edf2c95e3a7e5b7f0d3dceba98c75ff7cca0 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng Change-Id: I4da6edf2c95e3a7e5b7f0d3dceba98c75ff7cca0 Reviewed-on: https://chromium-review.googlesource.com/815115 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523185}
-
Dave Tapuska authored
Mojo requires event types to not be undefined. There appear to be a few cases on Android where undefined types are possibly sent to the renderer. I hope this addresses the crash as the stack traces don't appear to be very good. BUG=791986 Change-Id: Ibdd76a47b7ecd19fa91ee43d4200e3140407d187 Reviewed-on: https://chromium-review.googlesource.com/820230Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#523184}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/665b8b46209c..c2efefbc3625 $ git log 665b8b462..c2efefbc3 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 simonhatch Dashboard - Batching in /add_histograms Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1c746da5c47dc250760a7ff2bd9f392d08ed8829 Reviewed-on: https://chromium-review.googlesource.com/820110 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523183}
-
Mathieu Perreault authored
Will start a background task to create an AddressValidator in the constructor. When the AddressValidator is loaded, it will load rules for any pending normalization request. Reland with ValidationRulesStorageFactory destruction fix. Bug: 789711 Test: components_unittests Change-Id: Ib08581c5afd48ddfe016d3024f28b228e33f646f Reviewed-on: https://chromium-review.googlesource.com/819594Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#523182}
-
Reilly Grant authored
This new test* fails with the NetworkService enabled because it reaches out to google.com and is surprised that there is a redirect served by the real thing. Tests should not be making actual network requests. * ExtensionApiTest.DoNotOpenUninstallUrlForBlacklistedExtension Bug: 793899 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic866fd1f8ac48428a8179f5cecbd60d5ff17b5be No-Presubmit: true No-Tree-Checks: true No-Try: true Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/820152Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523181}
-
Ehsan Karamad authored
When a crashed OOPIF is navigated again the RenderWidget is recreated but RenderWidgetHost is reused. Therefore RenderWidgt assumes no page focus while RenderWidgetHost might be focused. This leads to caret not showing for a focused input (and the text area no being highlighted). This CL adds a method to RenderFrameHostManager to ensure page focus consistency similar to page visibility. Bug: 752140 Change-Id: I1baaaa6c4b2c720a73f1cb72a3ad80e30e9036dc Reviewed-on: https://chromium-review.googlesource.com/818732Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523180}
-
Khushal authored
Currently we defer the impl-side invalidation until the draw deadline in order to merge them with the incoming main frame. But delaying until the deadline implies that this invalidation's raster will miss this frame's draw and result in a pending tree that has to wait until the next impl frame, which will block the pipeline. Instead use data from CompositorTimingHistory to decide whether invalidations should be prioritized over the main frame at the beginning of the impl frame. R=brianderson@chromium.org Bug: 691735 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7764cb2934aa2d3bf2d72534e128391341f75d10 Reviewed-on: https://chromium-review.googlesource.com/802414 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523179}
-
mrefaat authored
1- Add Feature flag for WKSystemCookieStore usage. 2- Create SystemCookieStoreUtil to create the correct type of HTTPSystemCookieStore based on iOS version and the feature flag value. Bug: 779106,759229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie4da0c3c49ede43e27368ef40162cdd7bc164a34 Reviewed-on: https://chromium-review.googlesource.com/809307 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#523178}
-
Luum Habtemariam authored
This reverts commit 8fabb768. Reason for revert: Incomplete migration. Will try again soonish Original change's description: > Migrate to metadata v2 and support PPD Restrictions > > Update the GetPrintersURL call to utilize metadata_v2. This allows for certain > restrictions to be placed on the model to determine whether or not the printer should be displayed > > Bug: chromium:773766 > Change-Id: Iaade00489a066340a095b3b07bbd853f13f8e35a > Reviewed-on: https://chromium-review.googlesource.com/797476 > Commit-Queue: Luum Habtemariam <luum@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521064} TBR=stevenjb@chromium.org,skau@chromium.org,justincarlson@chromium.org,luum@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:773766 Change-Id: Ia17119151bf2d88951589b47e2ea0c1c38796cd2 Reviewed-on: https://chromium-review.googlesource.com/820291Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#523177}
-
Robert Sesek authored
5e16410ad448 fuchsia: Download the toolchain to distinct directories per build host 1ee9fee37c44 Update buildtools, gtest, and gyp ef3ce94fbfbb Python 3 support for Python scripts (without compromising Python 2) 3f5c939c848a gn: Next step in getting compilation working 593ede52e053 Fixes for drive-by review comments after ef3ce94fbfbb 9465fc72ad90 gn: Move sources out to explicit blocks d25b0242c6c5 gn: Fix a couple of things after 9465fc72ad90 and 2bb56fafe3bd 7e9dbd53fb74 fuchsia: Misc fixes to get more pieces compiling eeb31321f706 gn, fuchsia: Add //testing forwarding and GN build file 5969d6b1eb22 android: NDK r16 compatibility 741a84a2987f fuchsia: Add runner, get crashpad_test_test building and running 7a0daa6989a9 Enable reading notes from ELF images 2403d066c4a5 fuchsia: Support runtime_deps of directories bfeb194b017e fuchsia: Get crashpad_util_test building 6719610b8c76 fuchsia: Get crashpad_snapshot_test building 612237a0328a android: Fix 32-bit test to build at API [21, 24) with unified headers e0f396313154 Sever the connection between the test support library and snapshot 15c4fff902ea Get crashpad_client_test and crashpad_handler_test building 82a80acd3155 Roll mini_chromium 96e32dd4..a12ed4a6 a4fc880278e7 gn, mac: Get basic generation working 914b0d675528 Fix enum vs unsigned -Wsign-compare warnings 659420bc7d7e android: Run tests by running run_tests.py on the build host 00e6bd088725 fuchsia: Get 'all' to build ac3cc1b884e0 Provide a non-explicit constructor for StringAnnotation Also modifies .gn to set crashpad_in_chromium=true. Change-Id: Ie886774e753e76cf6c2bfa11aa522c8c789c9d6f Reviewed-on: https://chromium-review.googlesource.com/817479 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#523176}
-