- 26 Jul, 2019 40 commits
-
-
Yue Ru Sun authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1687059 Change-Id: Ifbe03a84c72d4ae473bad07d61c7b89984c70521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715411 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#681355}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f002a637743f..0716ce0a2c0c git log f002a637743f..0716ce0a2c0c --date=short --no-merges --format='%ad %ae %s' 2019-07-26 jonahr@google.com Re-add case to blitframebuffer workaround where src is outside of bounds. Created with: gclient setdep -r src/third_party/angle@0716ce0a2c0c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:830046 Change-Id: I477b7ef33e008f4df9422988b1e82acb88dd8e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681354}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a69857888af..d8a18e30c0ce Created with: gclient setdep -r src-internal@d8a18e30c0ce The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I023b32f0f9cddc0b4a9b30d00cc408d7e92a17f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721015Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681353}
-
Sergio Villar Senin authored
After removing all the dependencies and migrating all the affected code we can now safely remove it from the tree. All the Blink code should be using base::Time* classes from now on. Bug: 919383 Change-Id: I3b2b012d2e1592fce45fc1baf9d1e7f9d4a44cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710554 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#681352}
-
John Budorick authored
This reverts commit 7dd2ac40. Reason for revert: landed on top of a change that needs to be reverted for https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [Password Manager] Restore UMA metric for how many linux users don't have encryption > > The existing UMA uploads don't separate new profiles from existing > profiles which couldn't be migrated. > > Bug: 950267 > Change-Id: I0f8f823e843bd2127a71438c347031f6a7b23346 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720630 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Auto-Submit: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681348} TBR=vasilii@chromium.org,cfroussios@chromium.org Change-Id: Ib6d74e8400e81f0a62160326273abf76dd74dc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721291Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#681351}
-
Ken Rockot authored
Gets rid of all Service Manager dependencies from the Unzip service and its client library. Also introduces a Content library under components/services/unzip/content/ for Content embedders to launch new Unzip service processes as needed. Bug: 977637 Change-Id: I7205f15ffcd55921fb0d01689165770281365ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715973 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#681350}
-
Pâris MEULEMAN authored
This merges back SigninManagerDelegate.java into SigninManager.java and likewise for c++ code. This is in the scope of a change of strategy regarding the identityManager implementation on Android, using a layering strategy similar to what was done on iOS. The change consist in: * copy chrome_signin_manager_delegate.* methods to signin_manager_android.* * rename occurrences of ChromeSigninManagerDelegate to SigninManagerAndroid, in Java including JNI invocations and C++. * Directly invoke methods instead of calling mDelegate (java) * Update constructors to include the delegate dependencies. * A significant change that is not an obvious code move is the rollback of SigninManagerAndroid's constructor using SigninClient/PrefService(local_state) to Profile. This makes the remainder of the change much simpler, but does cascade to the factory. The above changes are described in their files in PS3: crrev.com/c/1700210/3 Change-Id: I1b0de2129f3df649fa56d50b8dd191e8e1bb30ab Bug: 985256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700210 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681349}
-
Christos Froussios authored
The existing UMA uploads don't separate new profiles from existing profiles which couldn't be migrated. Bug: 950267 Change-Id: I0f8f823e843bd2127a71438c347031f6a7b23346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720630 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681348}
-
John Budorick authored
This reverts commit 3a84c395. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 didn't stick, see https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [Password Manager] Cleanup feature: Migrate Linux to LoginDB > > The migration has been completed and the feature is no longer used. > > Bug: 950269 > Change-Id: I91f79f33ccda95e75d2b6156ade5d44f2e27c0ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719008 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681244} TBR=vasilii@chromium.org,cfroussios@chromium.org Change-Id: Ic0733620d3ebca563f5fa0be9f60742770eacd45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721290Reviewed-by:
-
redatawfik authored
1- Initialize TableViewModel in AutofillAddCreditCardViewController with three sections. 2- Add Credit card holder's name TextEditItem to first section. 3- Add Credit card Number, Expiration month and Expiration year TextEditItems to second section. 4- Add 'Use Camera' button to third section. Bug: 984545 Change-Id: I259272a05af55626003d76d53fc7c0ebbbefc77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710561Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#681346}
-
Eugene But authored
ios/web/common directory contains common code shared between //ios/web and the rest of the layers (//components, //ios/chrome, //ios/web_view). This directory does not contain the public API to create and manage web contents (//ios/web/public is public API directory). The proposal to move the files was discussed on this doc: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit TBR=zhongyi@chromium.org Bug: 942244 Change-Id: Icc2f7c3a6deb004e703c4c3e163d8974a0dd8378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715630Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#681345}
-
Raphael Kubo da Costa authored
Convert some functions that explicitly returned resolved promises into async ones, and drop |reject| from promise functions that only use |resolve|. Bug: 987639 Change-Id: I77193e6f19f724848707e8b7e9f012eedda7c267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718374 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#681344}
-
Harald Alvestrand authored
This reverts commit 80b8d9bb. Reason for revert: Error report was a test count difference - must have been caused by a race in a rebase. The reland rebases the test. Original change's description: > Revert "Reland "Add datachannel.maxPacketLifeTime"" > > This reverts commit c9d067e0. > > Reason for revert: appears to be responsible for failures in external/wpt/webrtc/idlharness.https.window.html on: > - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests starting with https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/80197 > - https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 starting with https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/38821 > > Original change's description: > > Reland "Add datachannel.maxPacketLifeTime" > > > > This reverts commit 49d46905. > > > > Reason for revert: Blame not credible - listed failures seem to be all MSAN timeouts. > > > > All they had in common with this CL is that the tests used the "idlharness" tool. > > > > Original change's description: > > > Revert "Add datachannel.maxPacketLifeTime" > > > > > > This reverts commit e557c49c. > > > > > > Reason for revert: I suspect this CL causes the following test failures: > > > external/wpt/xhr/idlharness.any.html > > > external/wpt/storage/idlharness.https.any.html > > > external/wpt/background-fetch/idlharness.https.any.serviceworker.html > > > > > > The first failed build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/938 > > > > > > Original change's description: > > > > Add datachannel.maxPacketLifeTime > > > > > > > > Delete nonstandard attribute maxRetransmitTime, and make both > > > > maxPacketLifeTime and maxRetransmits nullable. > > > > (Usage of both attributes has been measured to be negligible.) > > > > > > > > Bug: 696681 > > > > Change-Id: If37e38114d4718b868413ea8ced9527c88510c15 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710557 > > > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > > > Reviewed-by: Florent Castelli <orphis@chromium.org> > > > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > > > Reviewed-by: Steve Anton <steveanton@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#679965} > > > > > Bug: 696681 > > > > Change-Id: Ic6264584cb4184f1c5acb1049fa5eb2312b41bdb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715508 > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > Reviewed-by: Florent Castelli <orphis@chromium.org> > > Reviewed-by: Steve Anton <steveanton@chromium.org> > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680916} TBR=hta@chromium.org,foolip@chromium.org,jbudorick@chromium.org,orphis@chromium.org,steveanton@chromium.org Bug: 696681 Change-Id: I5e81b4107d0384664f4e6959d0e06fe6f307d3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721069Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#681343}
-
Brandon Wylie authored
Change-Id: Ifce96f6250ad03e8feb49e41ad333dec59dd47af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715735Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681342}
-
Oksana Zhuravlova authored
This CL adds the mojom interface that the renderer will use to get interfaces from the browser, as well as its implementation, functions for registering interface handlers and all the necessary plumbing. This CL also converts AudioContext to use BrowserInterfaceBroker. Bug: 718652 Change-Id: I6b24bc802ca482feac1d8ae5fff7e5bf44215fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688547 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#681341}
-
Oleh Lamzin authored
This reverts commit 4154ffb3. Reason for revert: CL interprets handle as shared buffer handle instead of platform handle. These changes break communication between ChromeOS and Chrome. ChromeOS and Chrome use different versions of mojo library with different structures to represent shared buffer handle: [1] vs [2]. [1] https://cs.corp.google.com/chromeos_public/src/aosp/external/libchrome/mojo/edk/system/shared_buffer_dispatcher.cc?type=cs&q=SerializedState&sq=package:chromeos_public&g=0&l=27 [2] https://cs.chromium.org/chromium/src/mojo/core/shared_buffer_dispatcher.cc?type=cs&sq=package:chromium&g=0&l=31 Original change's description: > Remove use of deprecated SharedMemory in chromeos/wilco_dtc_supportd > > Remove use of the deprecated class SharedMemory. Instead use > the new classes: {Write,ReadOnly}SharedMemory{Region,Mapping}. > > The previous code was wrapping the shared memory inside a mojo > handle. Instead, pass directly the ReadOnlySharedMemory to mojo, > this is the preferred way. > > See Chromium Shared Memory Refactor design doc for more details: > https://docs.google.com/document/d/1lk2-7W7Cy7FDqG-6lgS8LRkzXABYTOytf6VUsWNf8-0/edit#heading=h.7nki9mck5t64 > > Bug: 795291 > Change-Id: I7ee031baf80533dac064fc779e31c40fc0eb202f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566307 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Polina Bondarenko <pbond@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667164} TBR=pbond@chromium.org,kerrnel@chromium.org,alexilin@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 795291 Bug: b:138182535 TEST=manual revert CL locally and successfully send handle from ChromeOS and Chrome. Change-Id: Id78383105182bbce1bceebd805b58c9a6625f692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720638Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#681340}
-
Sadrul Habib Chowdhury authored
Report the sequence-length UMA separately for different types, e.g. for scrolling, pinch, animation etc. BUG=790761 Change-Id: Ib1365f443b1d9d4248f1376bc3e25139ac512819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717501Reviewed-by:
Robert Flack <flackr@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#681339}
-
Colin Blundell authored
This CL augments //components/signin with README.md files for various directories. Bug: 970295 Change-Id: If4a550cb5f572b01d740107d276563566ed52c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715697 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#681338}
-
Vasiliy Telezhnikov authored
This CL makes LayerWithRealCompositorTest and SnapshotAuraTest parameterized to run using GLRenderer and SkiaRenderer. It adds new constructor to TestContextFactories with parameter to specify which renderer to use. Old constructor selects renderer based on feature state. Bug: 956144 Change-Id: I153c15359f213f25142b4ae705b78b2bb4d6db7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716924Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#681337}
-
Mei Liang authored
This CL enables "Group tab" menu option only when there are more than one un-grouped tabs in the current TabModel. Change-Id: Ia7a7bde1a32fe5d8411b3a6dfd95cb232df3fa76 Bug: 970266, 987146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717603Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#681336}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7e4835d4345..094fa97a20d7 git log d7e4835d4345..094fa97a20d7 --date=short --no-merges --format='%ad %ae %s' 2019-07-26 treehugger-gerrit@google.com Merge "Perfetto | Userspace slice selection" 2019-07-26 primiano@google.com Merge "Amalgamated SDK: add track event" Created with: gclient setdep -r src/third_party/perfetto@094fa97a20d7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia627e4f929eb1f6c026f85ca6dc65223cbcb61de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721031Reviewed-by:
-
John Budorick authored
This reverts commit 2d82c3a3. Reason for revert: revert applied cleanly but didn't compile cleanly :( Original change's description: > Revert "[PasswordManager] Stop Using Native Backends on Linux systems" > > This reverts commit 6811de35. > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=988010 > > Original change's description: > > [PasswordManager] Stop Using Native Backends on Linux systems > > > > Recent migrations moved all users who have been using the keying to the > > LoginDatabase. This CL forces all users to using LoginDatabase > > instead of native backends on Linux. > > > > TBR=pcc@chromium.org > > > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > > Bug: 950269, 950267 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#681042} > > TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,mamir@chromium.org > > Change-Id: I2a42c76df8380cdaafb3485576e1efb9735f9d8d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721073 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681328} TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org,mamir@chromium.org Change-Id: I4df7c871947ae69a91be947a4665220df7dc1154 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269, 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720737Reviewed-by:
-
Jose Dapena Paz authored
The method UploadForDeepScanning gets a Request as parameter. But Request is an abstract class, so GCC will not allow that declaration (polimorphycs should be passed by reference). Use std::unique_ptr so BinaryUploadService can assume ownership. Bug: 819294 Change-Id: I9e8c75cc92b01abd704d9049b0421555377da5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713550Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#681333}
-
Rijubrata Bhaumik authored
Pan and Tilt Constraints are part of the UVC spec. For Linux/CrOS, we can use V4L2 controls like (V4L2_CID_PAN_ABSOLUTE and V4L2_CID_TILT_ABSOLUTE). Spec: https://github.com/w3c/mediacapture-image/pull/182 Test Page: https://riju.github.io/WebCamera/samples/panTilt/ Putting Pan/Tilt feature behind a flag: chrome --enable-blink-features=MediaCapturePanTilt Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/d/msg/blink-dev/j-Q08QgBipM/F3a5sau1BwAJ Bug: 934063 Change-Id: I552c4c8be717c3b67c4d91f826a1f16850430fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508519Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ec3039253ab8..3575550a711b git log ec3039253ab8..3575550a711b --date=short --no-merges --format='%ad %ae %s' 2019-07-26 sugoi@google.com Faster image sampler fetch from key Created with: gclient setdep -r src/third_party/swiftshader@3575550a711b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I2a263bd4b33e9a02513b3bec31807ef612b61b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721029Reviewed-by:
-
Yue Zhang authored
When user clicks on top tool bar toggle to switch between incognito/ normal mode right after the dialog animation starts, the animation continues and the dialog shows up while the tab model has already changed which causes dialog malfunction. This CL fixes this issue. Bug: 987227 Change-Id: I0e47119ed19627f4227e183454276dbdc5c2db06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717325Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
ssid authored
Creating Profile will create storage partition, which will need mojo initialized. So, move the init to test constructor. Network context also requires local state, so move the local state scope over profile creation. ChromeDataUseMeasurement is never destroyed. So, make the observer leaky. BUG=943354 Change-Id: I6ad76d421bdd2c376117b92abf965857f6f3a2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720124Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#681329}
-
John Budorick authored
This reverts commit 6811de35. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [PasswordManager] Stop Using Native Backends on Linux systems > > Recent migrations moved all users who have been using the keying to the > LoginDatabase. This CL forces all users to using LoginDatabase > instead of native backends on Linux. > > TBR=pcc@chromium.org > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681042} TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,mamir@chromium.org Change-Id: I2a42c76df8380cdaafb3485576e1efb9735f9d8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269, 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721073Reviewed-by:
-
John Budorick authored
This reverts commit 806315e6. Reason for revert: Reverting dependent CL due to https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [Sync::USS] Allow Sync USS Passwords for Linux > > Sync USS Password on Linux has been unblocked by recent migrations > in the PasswordManager team that are concluded in the parent CL. > This CL is enabling the about flags for Linux and it enables it by > default for all linux bots. > > Change-Id: Ic94267ab0e9e4cce2ac2b02f1dfa9a0a9046e902 > Bug: 902349 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718332 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681044} TBR=treib@chromium.org,bcwhite@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: I4e21e1a8652cfc3bdf9f661a2180d42d3372fe5d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721231Reviewed-by:
-
Ted Choc authored
The previous implementation would wait on async task and on certain device that could result in a deadlock. This converts to the new task queuing system, which avoids the need for waiting. BUG=949053 Change-Id: I795df73741e5d8e14255255a81aad6fd7eda6cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715568Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#681326}
-
Mustaq Ahmed authored
Bug: 985914 Change-Id: I8ce9a771eb591cd7eadb93d94af2caa5f6af0e66 TBR: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719444 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Aga Wronska authored
Parent access dialog should show correct title after the error is cleared. The title should be the same as before showing the error and it should match the reason that access code is requested for. Bug: 987792 Test: manually Change-Id: I4ec9a36ee22cfebae85875bbc3f2fb27d601c16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719810Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681324}
-
Peter Kotwicz authored
This CL: - Avoids finishing the WebAPK on Android O+ (the behaviour on pre-O is different) when: 1) The user selects the WebAPK from Android Recents 2) The WebAPK was killed by the Android OS OOM killer - Avoids finishing the WebAPK if the WebAPK was selected from Android recents and the host browser was uninstalled BUG=978716 TEST=SplashActivityTest.* Change-Id: I55927310afc99fa8565ea02533321d6bdcab536f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677687Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681323}
-
Jeremy Chinsen authored
In draw_utils/coordinates_unittest.cc, pp::Rect and pp::Size objects are compared to expected values frequently. This CL adds helper functions CompareRect() and CompareSize() to compare pp::Rect and pp::Size objects, respectively, simplifying the file. Change-Id: I3ff8235a90860a3c8343b18730e5ad1e69b0ba1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719329Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#681322}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: Ie1530f7046b0c8eb76e26adca530fa57c67ed876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720637Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#681321}
-
Takuto Ikuta authored
In addition to remove linux-xenial, I did followings in this CL * change "linux" -> "linux-trusty" * have "linux-xenial" instead of "linux" in some mixins * use "linux-trusty" for * linux-trusty-rel CQ/CI builder * linux_upload_clang CQ builder * WebRTC Chromium Linux Tester CI builder I confirmed that w/ and w/o this CL generates the same flattened config with flatten_buildbucket_cfg. Bug: 954450 Change-Id: I65b5513254b634502aa1a8c4e939717843762886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720359 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#681320}
-
Sinan Sahin authored
Bug: 971514 Change-Id: I48f5e7945690876b5d997f9f40ede57bc9f0637d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716933Reviewed-by:
-
Alex Newcomer authored
Revert "CrOS: Adding new SearchResult flags to dinner for one to allow for future-proof placement of it and other future policy tile apps." This reverts commit 1c673235. Reason for revert: Causes issue 987723 Original change's description: > CrOS: Adding new SearchResult flags to dinner for one to allow for future-proof placement of it and other future policy tile apps. > > Bug: 981023 > Change-Id: I06933a73ffafa91c8388d0325c008d2bd8e436e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687296 > Commit-Queue: Cameron Womack <camw@google.com> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677966} TBR=oshima@chromium.org,khmel@chromium.org,newcomer@chromium.org,camw@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 981023 Change-Id: Ia3e2a571df3050ead665e7184fb128508f244b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721013Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681318}
-
Adam Raine authored
To composite color values cross thread, we must have a specific CrossThreadColorValue, and the only way to know if a CSSStyleValue holds a color value is to create a new color specific style value. This patch adds a new class CSSColorStyleValue for this purpose. Bug: 883721 Change-Id: I83472ffd26bf2eba3312b8578e81222f61bd17c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717189 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681317}
-
Matthew Cary authored
This change adapts media::VideoFrame to the new shared memory API [1]. media::VideoFrame::WrapExternalSharedMemory wraps shared memory in several contexts: sometimes from a shared memory object directly, and sometimes indirected through a VideoCaptureDevice::HandleProvider. The VideoFrame is also created with a pointers to mapped memory, and treats the shared memory handle mostly as an opaque blob, sometimes duplicating for passing across processes, or passing it to wrap it in another VideoFrame. This latter wrapping also complicates ownership, as it implies that the shared memory must be owned externally. Because of this, the ownership of this kind of handle is external to the VideoFrame. The shared memory backing this use of VideoFrame is sometimes claimed to be read-only, and sometimes writable ("unsafe" in the jargon of the current shared memory API). This has lead to bugs (crbug.com/797470 and crbug.com/888153). While there may be a way to refactor so that read-only shared memory can be used where appropriate, that is beyond the scope of this CL. Here we just make the unsafe shared memory usage explicit, and clean up the API in a way that will hopefully make it easier to extend in the future. The core goal of this CL is to refactor VideoFrame to remove use of the legacy shared memory API, which forces permissions and ownership to be explicit. This CL does not change use of the mojo SharedBufferHandle API, which is strongly owned but hides region permissions (although they are strongly checked). A summary of the change is as follows. (1) VideoFrames are explicit about being backed by unsafe shared memory, and VideoFrame creation is cleaned up. Previously, data backed by shared memory was created with a WrapExternalSharedMemory factory, except in some cases where the frame was created with a different kind of external memory (eg, WrapExternalYuvData) and then a shared memory handle was shoved in with AddSharedMemoryHandle. After this CL, a VideoFrame backed by shared memory is first created with the appropriate WrapExternal* call, and then explicitly backed with unsafe shared memory. This makes current usage clear and will allow for different kinds of shared memory (read-only, writable) to be used in the future expressed without causing a combinatorial explosion of factory methods or parameters. (2) Changing the VideoFrame creation API implies changing consumers to use the new shared memory API and to be explicit about shared memory permissions. (3) Remove media::SharedMemoryHandleProvider (an implementation of VideoCaptureDevice::Buffer::HandleProvider). This class effectively confused uses of read-only and writable regions, and practically was used mostly as a utility routine for converting different types of buffer handles. (4) Additional cleanup in code that managed shared memory regions, particularly those that duplicate regions, which now the new permissions used by VideoFrame. TODOs which noted that regions were being duplicated read-write when they should be duplicated read-only are addressed: in some cases, the regions can now be duplicated read-only; in other cases the comment was incorrect and the region in question must be duplicated writable. In these cases an attempt has been made to document the use cases that demand a writable handle. Affected classes that manage shared memory regions are: * VideoCaptureBufferPool * VideoCaptureBufferTracker / SharedMemoryBufferTracker Unfortunately, the nature of these changes makes it impossible to break this change into small pieces. In particular, the shared memory permissions are all inter-dependent, and the strong checking done by the new shared API as well as mojo::ScopedSharedBufferHandle make it impossible to update usage piecemeal. A future change could add read-only shared memory to a video frame, and use that for the encoder input buffer, which in theory only needs read-only access. However, in current practice that is not the case: (a) crbug.com/888153 shows that some hardware encoders require writable shared memory regions. (b) ExternalVideoEncoder passes unsafe regions as the input frame, taken via a CreateVideoEncodeMemoryCallback from a legacy SharedMemoryHandle. The callback is also used to create output regions (which must be writable). Fixing this inconsistency requires a larger refactoring, also because CreateVideoEncodeMemoryCallbacks are passed around in other cases. (c) GpuArcVideoEncodeAccelerator takes a raw handle to create an input frame for VEA::Encode. This is not a read-only region. ArcVideoEncoder is in Android branches for ChromeOS (called pi-arc-dev and arc-nyc-mr1). The file descriptor today is writable because we copy plane data to the fd on the Android side for various reasons (conversion, etc). [1] https://docs.google.com/document/d/1lk2-7W7Cy7FDqG-6lgS8LRkzXABYTOytf6VUsWNf8-0/edit#heading=h.7nki9mck5t64 Bug: 888829, 849207, 843117, 795291, 803136, 793446 Change-Id: I776902f1b82c0b96e9916bcd59afdf4b3df89a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680188Reviewed-by:Bill Budge <bbudge@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681316}
-
