- 22 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f8b6e3fabbd..8c396a9cc4a8 git log 7f8b6e3fabbd..8c396a9cc4a8 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 flibitijibibo@gmail.com Ignore vulkan-loader dependency for GGP 2020-01-21 syoussefi@chromium.org Vulkan: Cleanup device feature query and enabling 2020-01-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 2d6f74c6d431..af8c7e040f93 (11 commits) Created with: gclient setdep -r src/third_party/angle@8c396a9cc4a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1002945 Tbr: timvp@google.com Change-Id: I984bce5adbb35693bcdc2245ba5429322944a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733882}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d339e36642df..6a5aa6680ce4 git log d339e36642df..6a5aa6680ce4 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 gregorynisbet@google.com export PYTHONDONTWRITEBYTECODE instead of just defining constant Created with: gclient setdep -r src/third_party/depot_tools@6a5aa6680ce4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1040314 Tbr: agable@chromium.org Change-Id: Ie3c172e16c093dcd648eaa042ae14670c12c9423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733881}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Idd9762c7fede3326da4f2845f4781d21227a4ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014150Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#733880}
-
Satoshi Niwa authored
There are a few lower priority differences with the CrOS file picker so the flexibility to switch is currently still useful. BUG=None TEST=trybot Change-Id: Ib05ee202726ebe460a2684fbbdbe26b79bdb3ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014200Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#733879}
-
Kent Tamura authored
FileListNameForWidth() implementations of LayoutTheme and LayoutThemeMac were almost identical. This CL does: - Introduce LayoutTheme::DisplayNameForFile() for the uncommon part of FileListNameForWidth() implementations. - Move the common part to FileInputType::FileStatusText() and LayoutFileUploadControl::FileTextValue(). This CL has no behavior changes. Bug: 1040828 Change-Id: I1c8a565380304523128a331cad4ef8abcef49e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012371Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#733878}
-
Naoki Fukino authored
Updating closure externs for Chrome API. (Required by http://crrev.com/c/1989728) I got the latest externs by running roll_closure_compiler, but I keep the compiler jar for now since I got multiple compile errors with the latest compiler. Bug: 1044378 Test: Ran compiler Change-Id: I28d10815253ce67db1de7df4c3f839c8300488ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009600 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733877}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b41dac7d030..fef76e222696 Created with: gclient setdep -r src-internal@fef76e222696 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ied184d303c53036a52aae79a96d4337726de815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014155Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733876}
-
Alexandre Courbot authored
Both decoders are supposed to do the same thing here, but small differences in the code design could make the reader believe that they don't. In particular, the IP is only supposed to be created in IMPORT mode for both cases. Make sure both decoders run the same version. We are going to reorganize and factorize this code, but this little cleanup ensures it is safe to do so. BUG=None TEST=Youtube desktop and Android both play on Hana and Kukui. Change-Id: Ic572763b519f74337adc31714f6fa738d9bce194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011783Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#733875}
-
Dave Tapuska authored
The complex rules come from http://crrev.com/eacad605 where the navigationStart was set after the beforeunload handler. This code no longer exists and the original conditions can be removed. BUG=1040954 Change-Id: Ifeb7c430af1ec31498d916a5dc343ac041ba8d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008074Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#733874}
-
Connie Wan authored
Part 2 of many. With this CL, it should be possible to traverse the tab strip via keyboard and interact with both Tabs and TabGroupHeaders in an expected manner. See Part 1 (crrev.com/c/1998146) for interactions that are still missing. Bug: 1039921 Change-Id: I277a6a9cec78b8677e411e248b4ed9adf872e9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999088 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#733873}
-
Hiroki Nakagawa authored
This CL modernizes clients-matchall-client-types.https.html using ES features (arrow functions, async/await, etc) for code cleanup. This doesn't change functional behavior. Bug: n/a Change-Id: Iaf35d11f1f90ec8e9cf9d41d585a873d7bcd8695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010758 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733872}
-
Anand K. Mistry authored
This will allow discovered IP addresses to be transferred to smbfs as an IP address type (instead of as a string). Bug: 939235 Change-Id: I725f4b8eef26fb361a06586b454cf8e559374648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012365 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#733871}
-
Eleni Dimitriadis authored
New result types have been created for the file and drive quick access results to be displayed in the suggestion chips, with required accompanying modifications. Bug: 1034842 Tests: All cros tests pass Change-Id: Ic694384133b64775ed6295c0e227c657e83db837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984780 Commit-Queue: Eleni Dimitriadis <edimitriadis@google.com> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#733870}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I8f1e02a950199b00f8987493349fe86c4456047e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014063Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733869}
-
Hirokazu Honda authored
We have set coded_size to (E)GLImage. It causes that a green line is shown at the bottom and right edge when playing a video. The correct set size is visible size so that GPU doesn't access non-visible area on compositing. Bug: 1043582 Test: Play a 1080p video on soraka Change-Id: Ide3008bf602be3a4e189af1f6ab18213fca74753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011583 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#733868}
-
Erik Chen authored
This reverts commit e5296dab. Reason for revert: CrOS already links against system libc++ Original change's description: > Enable custom libcxx unconditionally on CrOS. > > Most other platforms either unconditionally, or are moving towards unconditionally > building with custom libcxx. > > This comment suggests that there was always the intention to move > unconditionally to libc++: > https://bugs.chromium.org/p/chromium/issues/detail?id=554841#c3 > > And this bug suggests that we're already paying most of the engineering > cost for making this config work: > https://bugs.chromium.org/p/chromium/issues/detail?id=996754 > > Change-Id: I030f65b5921c4f5572fafcaf975eff24e804f3ed > Bug: 1043560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010226 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733362} TBR=thakis@chromium.org,erikchen@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043560 Change-Id: Ifa073a4dd90f1e260aa0e6981326fea13a5f4c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012366Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#733867}
-
Miyoung Shin authored
This CL cleans up testing codes related InterfaceProvider in Blink. Bug: 990845, 995556 Change-Id: Ifa9a1f5570f7f5bb1a87a461fd0c28332a96c280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007308Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#733866}
-
Tsuyoshi Horo authored
Bug: 1043749 Change-Id: Iaa2e796495d46190d387e3c1bc1245a08f5af843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010756Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#733865}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58c1c280d8f..6b41dac7d030 Created with: gclient setdep -r src-internal@6b41dac7d030 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1016929,chromium:1028270,chromium:1041468 Tbr: jbudorick@google.com Change-Id: Ia0516001f0f956a41d1f4d7b4162a9aae96ba302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733864}
-
Tibor Goldschwendt authored
This makes the realbox favicons similar in size to omnibox favicons. Bug: 1043268 Change-Id: I923856bad6f5b12437eab7e5fb139b1ca10fed4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013904 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#733863}
-
Mounir Lamouri authored
It avoids having the media session unaware of some favicons. Bug: 1030540 Change-Id: I40c8d037ae11bd24cecf4b1c14ad88746fa9cbd1 FIXES: 1030540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955084 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#733862}
-
Alexandre Courbot authored
Using the coded size as the natural size of a frame does not make much sense. Since this parameter is not essential here, use the visible size for consistency. BUG=None TEST=E2E Youtube decoding working on Kukui. Change-Id: I6958cd6d1568941e28bd5ca881a9afb6683c9392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011782 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#733861}
-
James Cook authored
Chrome OS with SplitSettingsSync will use this control to show sync status, just like other platforms. Linux, syncing (unchanged): https://screenshot.googleplex.com/t74uFT5iEsL Linux, not syncing (unchanged): https://screenshot.googleplex.com/SJGC3rbtGnw Chrome OS, pre-SplitSettingsSync (unchanged): https://screenshot.googleplex.com/EKZDSEqVBYy Chrome OS, post-SplitSettingsSync (new): https://screenshot.googleplex.com/fLYerpP60rg Remove some unused references to diceEnabled_. TODO: Make the "turn off" button actually work. Bug: 1013466 Test: browser_tests Change-Id: I2bb50ffdd7bcb408a13885740440ff752ff2fd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003758 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#733860}
-
Jay Harris authored
This will allow us to disable the file handlers for an app on Linux without uninstalling it. This is necessary preparation for the origin trial, as we need to be able to disable/enable the file handlers as the validity of the app's origin trial changes. Bug: 1028448 Change-Id: I63eb6582852ff75d3d88181ede07f0cbd010df2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010234 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#733859}
-
Demetrios Papadopoulos authored
Also renaming CrSettingsCertificateManagerTest.All to CrComponentsCertificateManagerTest.All. This is in preparation of migrating this component and its tests to Polymer 3. Bug: 1042558 Change-Id: I2ebedf55f43d368faf097fe44c5ee3d052c61813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013632 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733858}
-
Andrew Moylan authored
This roll brings the removal of some workarounds for old Mojo, no longer needed on Chrome OS side. Mojoms rolled with: cp ~/chromiumos/src/platform2/ml/mojom/*.mojom \ chromeos/services/machine_learning/public/mojom/ && \ sed --in-place --regexp-extended \ -e 's~^import "ml~import "chromeos/services/machine_learning/public~g' \ -e 's/(GraphExecutor)& request/pending_receiver<\1> receiver/g' \ chromeos/services/machine_learning/public/mojom/*.mojom Bug: 917185 Change-Id: Ib03cfbd6903a935354d2688ab3e09cc7a6853707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012369 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#733857}
-
Andres Calderon Jaramillo authored
This CL creates a simple pixel test that does not rely on WebGL, canvas, or video and that results in multiple render passes. Motivation: https://crrev.com/c/1637737 broke Android compositing of some mixed WebGL/Canvas2D content. The root cause was an incorrect assumption in that CL: that when the framebuffer for the root render pass is bound, we wouldn't try to bind it again before swapping it. This assumption was wrong in the case of drawing a render pass quad onto the root render pass. See [1]. The aforementioned CL would call BeginSharedImageAccessDirectCHROMIUM() upon binding the root render pass' framebuffer and would call EndSharedImageAccessDirectCHROMIUM() only when the buffer is swapped. So, binding the framebuffer multiple times would result in the shared image system thinking that we wanted concurrent access to the SharedImage. When running some of the existing WebGL/Canvas2D pixel tests, I did see artifacts resulting from the wrong assumption, but they don't happen in all frames. The test in this CL reliably hits the issue. It's rendered using multiple render passes. The page is animated with JS to reliably reproduce the problem. I tried running the test before and after the revert of the bad CL (https://crrev.com/c/1963369). Before that revert, the test failed 20/20 times. After the revert the test succeeded 20/20 times. For this test to catch the regression, it must run on Android Q. [1] https://cs.chromium.org/chromium/src/components/viz/service/display/gl_renderer.cc?l=1134-1136&rcl=64245a1d4d5484c33272c0fcb99731eff23b4103 Bug: 958670,1033279 Test: run locally on Pixel 2 w/ Android Q before/after CL:1963369. Change-Id: Id154e45814043e8a47d58b784df3b854b6036693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979059 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733856}
-
Dave Tapuska authored
Change-Id: Ic6b3b590cc3efde171ebc5c4686c384d406310d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013515Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#733855}
-
Dan Beam authored
R=mahmadi@chromium.org Fixed: 1043335 Change-Id: I98b1fbcc0a5b5e0d48334e8eb33a31c66f07a4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008614 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#733854}
-
Sadrul Habib Chowdhury authored
Remove the synthesized BeginMainFrame notifications for the trackers, and enable some of the DCHECKs. BUG=1021963 Change-Id: I6867f5d3dd269bab99e8b468ecc782a8009b7ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995634 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#733853}
-
Tim Song authored
This is a reland of the original fix (see bug), which was reverted due to regressions. This updated version fixes an edge case, which caused a crash when dismissing the message center via accelerator in certian circumstances. BUG=1024100 Change-Id: I525186a7075732946403ebffa5def4631bcde658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013525Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733852}
-
Tsuyoshi Horo authored
And also renames to FrameSerializerDelegateImpl. This class will be used when creating a web bundle. Bug: 1040752 Change-Id: Ia42a374a005ea688003b5ede3f06c596a4c55304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010239Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733851}
-
Luciano Pacheco authored
Currently is hard to debug Files app feedback report because Files app URL is redacted from logs, the URL is similar to: chrome-extension://$EXTENSIO_ID/. Bug: 979779 Change-Id: If08ddae7625c431bfe6ca67ac3dd257f14e8410f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011581 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#733850}
-
John Budorick authored
The ini logic was mistakenly keeping trailing spaces when parsing keys (at least). This CL fixes that and adds tests for ini handling. This also makes `avd.py start` default to starting a read-only AVD, as doing so has been useful in the course of debugging this & other issues. Lastly, this removes the use of org.chromium.base.Log from our hand-rolled Unzip implementation. Log is not available in the chromium_commands dex, and emulators that ran out of space were misleadingly failing with "Aborted" rather than a message about disk space issues. Bug: 922145 Change-Id: I86de27c1b1d4d3628312f26e79db45f6d982a961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013650 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#733849}
-
Demetrios Papadopoulos authored
This is done to pick up new formatting (as well as copyright year). Fixed: 1044302 Change-Id: I9b005bd328f9eca56cb1598468981bf768882d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013633 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#733848}
-
Julien Isorce authored
Fixes "vaInitialize failed: unknown libva error" on Wayland with LIBVA_DRIVER_NAME=i965 VaapiWrapper relies on the GL implementation to decide which display to use. If the GL implementation is none, then VaapiWrapper is likely to do the wrong guess resulting in the above error. Bug: 1041229 Change-Id: I1255a032a5e14b3aaffe3026a886de7e6d9ff0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011640Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#733847}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=michaeldo@chromium.org Bug: 1042208 Change-Id: I859020ffb6010934dd360e4364546c06465d3281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010783 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733846}
-
Demetrios Papadopoulos authored
Specifically porting - cr_policy_indicator_behavior.js - cr_policy_indicator.js This is in preparation of further Polymer3 migrations (certificate manager, Settings). Bug: 1042558 Change-Id: Ia2accbc62ac581eaafbdaaa038b5b92765f53bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008017 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#733845}
-
Dan Beam authored
R=dpapad@chromium.org Bug: none Change-Id: Ifb969cba1b97d54d6aa990cf3598573fcd71bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013919 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733844}
-
Xianzhu Wang authored
Bug: 1035582 Change-Id: I07410021c7e38c641cfc4064443aa5af61454ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013323 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733843}
-