GitLab

Calculate non client hittest values by converting the corresponding system metrics returned via the GetSystemMetrics API on Windows to DIP.

The API returns pixel values which are compared against points in DIP which gives wrong non client hittest
values.

The bug only happens on glass.

BUG=377983
R=sky

Review URL: https://codereview.chromium.org/305623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273124 0039d316-1c4b-4281-b951-d872f2087c98

I notcied this bug while trying to fix the WebGL VAO related regressions
on Linux AMD.

Before the generated ID is not set, so by default it's 0, which
is wrong, because 0 is reserved to unbind instead of bind.

Also, turn on VAO support for majority of tests as the emulated code path
is more isolated and its tests are also more isolated.  I feel it's better
to test with VAO on by default.

BUG=373974
TEST=gpu_unittests
R=vmiura@chromium.org,kbr@chromium.org,piman@chromium.org,jbauman@chromium.org

Review URL: https://codereview.chromium.org/303543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273123 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the autofill integration tests so they no longer need to rely
on snapshots or self-notifications.

Deletes the integration tests around disabling the type or disabling
sync, since we decided in the review of r269198 that those tests are not
valuable.

Introduces KeysMatchStatusChangeChecker, a fairly typical
MultiClientStatusChangeChecker based on the existing KeysMatch()
function.

Introduces ProfilesMatchStatusChecker, which might be the first
StatusChangeChecker to not register as an observer of the
ProfileSyncService.  Autofill profiles are stored and synced on the DB
thread but cached on the UI thread.  There's no guarantee that the UI
thread cache of autofill profile data would be up to date by the time
the sync cycle notificaiton is emitted.  Instead of listening for sync
notifications, the ProfileMatchStatusChangeChecker registers with the
owner of the UI thread cache of autofill profile data, the
PersonalDataManager, so it can be notified directly when the cache is
updated.

Since it uses a new notification mechanism, there is some reason to
believe this could fix issue 152551.

BUG=97780,95742,152551

Review URL: https://codereview.chromium.org/303643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273122 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273121 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174878:174895&mode=html
TBR=alph@chromium.org,esprehn@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/303693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273120 0039d316-1c4b-4281-b951-d872f2087c98

- import checkdeps

BUG=none
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/303503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273119 0039d316-1c4b-4281-b951-d872f2087c98

"image" is specified as a MIME type but is invalid. We should just omit
the MIME type parameter.

BUG=377409

Review URL: https://codereview.chromium.org/303483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273118 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273117 0039d316-1c4b-4281-b951-d872f2087c98

. validate on the client that the node can only be deleted or have its bounds changed by the connection that created the node. note that it's still possible for the client to call the interface directly, but the service will validate also, and then the client's inconsistent state is the client's own fault.
. pass bounds through the INodes array

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/296133012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273116 0039d316-1c4b-4281-b951-d872f2087c98

Use ExtensionRegistry instead.

R=kalman@chromium.org
BUG=376293

Review URL: https://codereview.chromium.org/298253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273115 0039d316-1c4b-4281-b951-d872f2087c98

I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272740

R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272995

Review URL: https://codereview.chromium.org/298703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/300173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273113 0039d316-1c4b-4281-b951-d872f2087c98

Added a histogram "Network.Shill.Wifi.FallbackDNSTestResult" for tracking
the result of the fallback DNS test. The fallback DNS test is performed
when portal detection is failed due to DNS failure.

BUG=chromium:366301
TEST=Start chrome, and browse to chrome://histograms to make sure
this histogram exist after connect to a wifi network without internet
access.

Review URL: https://codereview.chromium.org/291823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373098
NOTRY=true
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/303503009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273109 0039d316-1c4b-4281-b951-d872f2087c98

Omaha configuration parameters now use Wow6432Node (32-bit registry) on 64-bit installs.  GCAPI configuration parameters also use these same accesses since they read/write the same data.

Also, force installation of Win64 into C:\Program Files (x86) until the code is added to support moving the files to the right place during upgrade and downgrade.  Uninstall information will remain stored in the 32-bit registry (even on 64-bit) until the installation location is changed.

This fixes system installs on Win64.

BUG=338706
R=grt@chromium.org

Review URL: https://codereview.chromium.org/300593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273108 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355735

Review URL: https://codereview.chromium.org/296873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273107 0039d316-1c4b-4281-b951-d872f2087c98

glBufferSubData 's second argument type is GLintptr, not GLint. And the third argument type is GLsizeiptr, not GLsizei.
A mistake in glBufferData and glBufferSubData 's arguments.

BUG=

Review URL: https://codereview.chromium.org/291493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264

Review URL: https://codereview.chromium.org/297183010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273105 0039d316-1c4b-4281-b951-d872f2087c98

protocol servers.
++ Net.AlternateProtocolUsage.200Truncated
++ Net.AlternateProtocolUsage.1000Truncated

R=jar@chromium.org

Review URL: https://codereview.chromium.org/301743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273103 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds some extra overloads for CalculateKMeanColorOfBitmap and
CalculateKMeanColorOfPNG to provide a more convenient API. More
specifically, it provides both parameterized and unparameterized
versions of both functions.

BUG=376613

Review URL: https://codereview.chromium.org/291653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273102 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the utilities needed for using the current WebContents when
distilling web pages.

BUG=361939

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272611

Review URL: https://codereview.chromium.org/266073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273101 0039d316-1c4b-4281-b951-d872f2087c98

Change the default parameters for ETLD+1 Rappor metrics.
Allow number of cohorts to be set per metric.
Modify metric names to distinguish from reports with old parameters.

BUG=370599

Review URL: https://codereview.chromium.org/264123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273100 0039d316-1c4b-4281-b951-d872f2087c98

R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/286883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273099 0039d316-1c4b-4281-b951-d872f2087c98

When applying animations we squash the transforms and therefore
end up applying them in reverse order. When we have to calculate bounds
we end up applying them one at a time, so we also have to apply this
in reverse order.

Also modified how we calculate bounds for arcs to simplify the derivation.

R=ajuma@chromium.org

Review URL: https://codereview.chromium.org/297163010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377555

Review URL: https://codereview.chromium.org/302463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273097 0039d316-1c4b-4281-b951-d872f2087c98

Address a TODO: the GetColorProfile() routine is declared but
has no definition and is thus unused, remove it.

BUG=368694

Review URL: https://codereview.chromium.org/300033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/293353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273095 0039d316-1c4b-4281-b951-d872f2087c98

Picked up changes:
2c57b49 Make debug output a run-time configuration instead of compile-time.
88806c2 Fix final content and title extraction.
aab9dc9 Revert https://codereview.chromium.org/290993004/
8c95c16 Restore Title identification.
b98b574 Add debug output for each stage of Boilerpipe.

BUG=367243,375443,375449

Review URL: https://codereview.chromium.org/302553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/291843009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273093 0039d316-1c4b-4281-b951-d872f2087c98

Simple fixes first. First if GPU thread is already executing GL, then
don't schedule and just make sure the GPU flushes before finishing
executing said GL.

Then make sure we don't send repeated and unnecessary RequestDrawGL.

BUG=344087

Review URL: https://codereview.chromium.org/299363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273092 0039d316-1c4b-4281-b951-d872f2087c98

Operations are tested outside of the ProvidedFileSystem class. This CL moves
the last operation which was tested in the deprecated way.

TEST=unit_tests: *FileSystemProviderOperations*Unmount
BUG=373165

Review URL: https://codereview.chromium.org/301633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273091 0039d316-1c4b-4281-b951-d872f2087c98

This should make timeouts more actionable.

BUG=370668

Review URL: https://codereview.chromium.org/296403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273090 0039d316-1c4b-4281-b951-d872f2087c98

The only protocol we need enabled over USB is adb. Anything else is just a
potential source of problems.

BUG=

Review URL: https://codereview.chromium.org/294253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273089 0039d316-1c4b-4281-b951-d872f2087c98

This patch does two things. (1) Always runs callbacks via a PostTask, (2)
fixes an incorrect expression in EOF detection.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=373165

Review URL: https://codereview.chromium.org/307463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273088 0039d316-1c4b-4281-b951-d872f2087c98

This implements an extensions API to abort a stream that has been started. Aborting the stream will cause the original URL request to be cancelled, which may be desired if the client of the API wants to cancel the request before it is completely downloaded.

BUG=348464,303491
R=jam@chromium.org, kalman@chromium.org, mpearson@chromium.org, zork@chromium.org

Review URL: https://codereview.chromium.org/281513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273087 0039d316-1c4b-4281-b951-d872f2087c98

> Add content renderer to the GN build
> 
> Also adds ui/native_theme, third_party/npapi, and some required mojo stuff to make it build.
> 
> BUG=
> R=scottmg@chromium.org
> 
> Review URL: https://codereview.chromium.org/299113002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/302443010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273086 0039d316-1c4b-4281-b951-d872f2087c98

R=friedman@google.com, navabi@google.com

Review URL: https://codereview.chromium.org/302553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/298993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273084 0039d316-1c4b-4281-b951-d872f2087c98

Replace "launch" with "try" for launching ephemeral apps via
search results in the app launcher.

BUG=377353

Review URL: https://codereview.chromium.org/300083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273083 0039d316-1c4b-4281-b951-d872f2087c98

Mojo: Move message pipe types/constants/functions from mojo/public/c/system/core.h to .../message_pipe.h.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/298273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273082 0039d316-1c4b-4281-b951-d872f2087c98