- 01 Nov, 2018 40 commits
-
-
Josh Karlin authored
After the switch to NetworkConnectionTracker, the GetConnectionType call wasn't checking for a synchronous return. In the case of a synchronous return OnConnectionChanged needs to be called. This led to BackgroundSyncManager not getting the correct connection type on startup. Bug: 900943 Change-Id: I21ffcacdea9cca4c0780f40561e55b10fb9866b1 Reviewed-on: https://chromium-review.googlesource.com/c/1312676 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604689}
-
rbpotter authored
Add a CloudPrintInterface interface base class and make CloudPrintInterfaceJS and the CloudPrintInterfaceStub implement it. This will allow adding a new type of cloud print interface later. Bug: 829414 Change-Id: I274bb5e8aabf104eca8a1aac46b9dfd519ed467a Reviewed-on: https://chromium-review.googlesource.com/c/1309223Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604688}
-
Eric Roman authored
The overall design is to decide on the proxies to mark as bad, and when to restart a request as part of the DRP's URLLoaderThrottle. This CL is complete enough to pass fallback browser_tests, however it hacks around one piece of unimplemented functionality: the DRP configuration is not yet synchronized to throttle, so it guesses it. This needs to be addressed in a follow-up. Bug: 721403 Change-Id: If95e52aad825d6e2c3b73fd12fdfeb9e53ae6cc6 Reviewed-on: https://chromium-review.googlesource.com/c/1297238 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#604687}
-
Alexander Timin authored
As a preparation for the MessageLoop/MessageLoopImpl split rename the current files to _impl versions. R=gab@chromium.org BUG=891670 Change-Id: I8fb55b82b1c57de2203b579948ebb922cc72bea6 Reviewed-on: https://chromium-review.googlesource.com/c/1313109Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#604686}
-
Zhongyi Shi authored
Add a histogram to collect how often the signal is detected by QUIC to attempt migration before handshake and how often the new connection is attmped, i.e., an alternate network is available to retry the connection. Bug: 790547 Change-Id: Ibe4630e1fa4d813330d0d7f48f2b4bf99663a3be Reviewed-on: https://chromium-review.googlesource.com/c/1311493 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604685}
-
Scott Chen authored
Bug: 881937 Change-Id: Ia7e27b79ed334ba8811da12ece93a2706bfb1a71 Reviewed-on: https://chromium-review.googlesource.com/c/1309225Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604684}
-
Etienne Bergeron authored
We decided to remove the scheduling category. If we plan to look again on our the scheduler is performing through slow-reports, we gonna add a specific scenario since this is doubling the amoung of events. R=oysteine@chromium.org Change-Id: Id280597bcb41fd1a0765773c4ed42a97dabd83aa Reviewed-on: https://chromium-review.googlesource.com/c/1307893Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604683}
-
David Jacobo authored
This cl fixes a couple of warnings generated by lint. Bug: None Test: git cl lint seems ok now, builds. Change-Id: Ife5ee050bc3896e2243d7af0a25a093801fa2d07 Reviewed-on: https://chromium-review.googlesource.com/c/1311802Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604682}
-
Erik Chen authored
The metric will only measure tasks posted on the UI and IO tasks, not native events. Based on Slow Reports on Desktop, this seems likely to be sufficient to detect jank in the wild on Android as well. Bug: 859155 Change-Id: Ia573e6311d9315597334108955f215be61fc3b07 Reviewed-on: https://chromium-review.googlesource.com/c/1312681Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604681}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a69842065243..7216ea73e7fd git log a69842065243..7216ea73e7fd --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Roll third_party/skia/ 23564b924..fa7df23d8 (940 commits; 44 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 8b354dca8..23564b924 (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 4f94ef6cb..8b354dca8 (137 commits) 2018-11-01 thestig@chromium.org Roll third_party/skia/ b98fb5b08..4f94ef6cb (1 commit) Created with: gclient setdep -r src/third_party/pdfium@7216ea73e7fd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9b26b4eea428980c1c8493de6b4d241474563760 Reviewed-on: https://chromium-review.googlesource.com/c/1313129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604680}
-
Scott Violet authored
The client area is dictated by the bounds of the ClientView. This patch makes DesktopWindowTreeHostMus observe bounds changes of the ClientView, not the non-client-frame-view. BUG=891064 TEST=covered by test Change-Id: Ia96c2be5b9af1bce24d253e01dbf673accc20d3a Reviewed-on: https://chromium-review.googlesource.com/c/1312482Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604679}
-
Xiaohui Chen authored
* Introduce assistant_state_proxy as a convenient mojom proxy client for voice_interaction_controller. * Introduce assistant_state_base as POD that can be shared between assistant_state_proxy and voice_interaction_controller to store state * Change assistant state accessers to base::Optional to reflect the async nature of reading these values. * Remove async Is___Enabled(Callback). The observer now will initialize state after attach. * Fixes assistant_manager_service_impl start up sequence to avoid potential multiple restarts with async assistant pref queries * Fixes a potential race when restarting assistant_manager Bug: b/112281490 Test: locally build and run Change-Id: I7c57adef0919583283f2fb1312f6d6e191bf266a Reviewed-on: https://chromium-review.googlesource.com/c/1303333 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#604678}
-
bsheedy authored
Renames the variables in fake_openvr_impl_api.cc to be consistent with Chromium style guidelines instead of using the original names from openvr.h. Also drive-by fixes a timeout that was flakily getting hit. Bug: 892717 Change-Id: Id6f25826df26212be5e0fae659cc4715c459f093 Reviewed-on: https://chromium-review.googlesource.com/c/1312195Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604677}
-
Sergey Ulanov authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/847fc0b..d0a4800 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I79b19367a340cc2cdeb539c1c06390fb5cf477ec Reviewed-on: https://chromium-review.googlesource.com/c/1306339 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604676}
-
Aleks Totic authored
Bug: 900921 Change-Id: I4ce730d9fefb2b099cacc113d951238d302f8cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1313168Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#604675}
-
Matthew Jones authored
This patch reduces the number of functions independently responsible for changing the visibility of the omnibox suggestions. Since the only visible part of the results container is the list, the visibility of the container should depend on whether the suggestions list visibility. To support this change, a new method has been added to the UrlFocusChangeListener interface: onUrlAnimationFinished. This method triggers after the animation for focusing or unfocusing the omnibox has completed. Change-Id: I110379fd59dd2d54182d03cc91ed75dd3cba765b Reviewed-on: https://chromium-review.googlesource.com/c/1294423 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604674}
-
bsheedy authored
Adds support for the newer histograms format in addition to the older chartjson format to resource_sizes.py and diff_resource_sizes.py. This is a prerequisite for using these scripts with perf dashboard uploading on LUCI, as the chartjson format uses IP whitelisting when uploading, which is no longer practical on LUCI. Bug: 892302, 892344 Change-Id: I1a636ed1476df46cda5313e8c5cbfa18e5cacc83 Reviewed-on: https://chromium-review.googlesource.com/c/1311117Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604673}
-
Alexander Timin authored
To facilitate splitting MessageLoop into MessageLoop and MessageLoopImpl introduce message_loop_forward.h and use it everywhere. - s/message_loop.h/message_loop_forward.h/ in all includes. - Add message_loop_forward.h to base/BUILD.gn. - Add message_loop_forward.h to third_party/DEPS. TBR=gab@chromium.org BUG=891670 Change-Id: Ibac3a24f5bd4291c9d57dd32c627477e4e6ef324 Reviewed-on: https://chromium-review.googlesource.com/c/1313108Reviewed-by:
-
bsheedy authored
Fixes the way the VR instrumentation tests are configured on non-Daydream-ready devices (the chrome_public_test_vr_apk test suite) so that all users have the necessary args instead of adding the args in test_suite_exceptions. This should be both cleaner and help catch future cases of the tests being enabled on bots they shouldn't be, as the tests should immediately fail due to trying to install VrCore without the APK being downloaded instead of having a chance of passing due to VrCore happening to be installed on the test device already. Bug: 900972 Change-Id: I742621ab3696803b5f434a9b841f56cccda28879 Reviewed-on: https://chromium-review.googlesource.com/c/1313072Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604671}
-
Andrew Grieve authored
Change-Id: I3dc425aace4767371b86e1becd2e872c882d1ae6 Reviewed-on: https://chromium-review.googlesource.com/c/1312978Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604670}
-
Jesse McKenna authored
Bug: 900191 Change-Id: I3f90e10c9df4ac6f74355424dd60e52c8c9262be Reviewed-on: https://chromium-review.googlesource.com/c/1307246 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#604669}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/460a43deb18f..6d546b5cd1b6 git log 460a43deb18f..6d546b5cd1b6 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 brianosman@google.com Simplify PMColor preprocessor logic, move it all into SkColorPriv.h 2018-11-01 csmartdalton@google.com Call GrContext::performDeferredCleanup from viewer 2018-11-01 dongseong.hwang@intel.com Disable blend explicitly when the color mask is false. 2018-11-01 brianosman@google.com Remove more unused color functions, and an unused Neon blitter Created with: gclient setdep -r src/third_party/skia@6d546b5cd1b6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/116339546 TBR=herb@chromium.org Change-Id: I20a64bf65a5e556f0a1906e342bae1b867e7b8c4 Reviewed-on: https://chromium-review.googlesource.com/c/1313034Reviewed-by:
-
Tom Sepez authored
We've had a number of surprised/disappointed reporters lately, so although there is no policy change, repeat the language describing the policy closer to where it is referenced. Change-Id: I300bc3e05b5055c66253a4ab8d31d9e82e40dc1e Reviewed-on: https://chromium-review.googlesource.com/c/1312982 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604667}
-
Xiaoqian Dai authored
There might be a race condition between calling InputControllerEvdev::set_has_touchpad() and InputControllerEvdev::SetInternalTouchpadEnabled() functions. So it's possible that we call SetInternalTouchpadEnabled(false) to disable a touchpad, and then set_has_touchpad(false) is called because the touchpad is removed, and then later when the touchpad is re-added to the device, SetInternalTouchpadEnabled(true) is called before set_has_touchpad(true) is called. In this case, SetInternalTouchpadEnabled(true) does nothing. See b/118567558comment#11 for more details. This CL ensures after a touchpad is added or readded to the device, it's properly updated. Bug: b/118317363, b/118567558, b/118633774 Change-Id: I1da3c9c30ad843a761e947ef4687b6ca30b98b49 Reviewed-on: https://chromium-review.googlesource.com/c/1312116 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
The current method of creating the table executes a lot of code at load time. Move the computation to a script spline_constants.py that generates the java constants. Change-Id: Ibf058a8771ec909882922183471938c077403cab Reviewed-on: https://chromium-review.googlesource.com/c/1300393 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604665}
-
Evan Stade authored
These tests pass locally. Some blacklist entries were left over after the bugs were fixed (e.g. https://crbug.com/866991 ) and some were copied from the filter file for OopAsh but work fine in single process Mash. Change-Id: I0eb2087691b2f98e7f50361f6247c92f2afa0603 Reviewed-on: https://chromium-review.googlesource.com/c/1309320 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604664}
-
bsheedy authored
This is a reland of 28c21fa4 Was reverted due to flakes from a bad device. Original change's description: > Re-enable disabled VR tests > > Re-enables all the VR tests that were marked as flaky now that the > root cause has been reverted. > > TBR=mthiesse@chromium.org > > Bug: 894796 > Change-Id: I34c4b8e10edec2e682c450b1b18c2428f3e29473 > Reviewed-on: https://chromium-review.googlesource.com/c/1305211 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603594} TBR=mthiesse@chromium.org Bug: 894796 Change-Id: I7a25bb19ee1164f4960abc2674ac8603b33eaf5b Reviewed-on: https://chromium-review.googlesource.com/c/1313169 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604663}
-
mark a. foltz authored
Cast Setup in Chrome is deprecated and is being removed in M72. This removes the Media Router context menu item to access Cast Setup. This patch also restricts navigation in the chrome://cast WebUI to Cast Offers, which is not being deprecated. Tested by manually navigating to various chrome://cast URLs. Screenshot: https://drive.google.com/open?id=1XRpTGtqiQ458eLdJ0oY72OObmU85XRfQ Bug: 895580 Change-Id: I7c94f00cebe80246c11d17e163f5e92ed1ecbdcc Reviewed-on: https://chromium-review.googlesource.com/c/1308085Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604662}
-
Xi Han authored
In this CL, we move the creates FeatureList and setup field trials from AwBrowserMainParts::PreCreateThreads() to AwMainDelegate::PostEarlyInitialization(). So it happens before ServiceManagerContext is created and the TaskSchedueler starts in ContentMainRunnerImpl::Run(). Bug: 887468,899376 Change-Id: Ie4d3223cf5206d8aadb537b7b80d9e196d4512be Reviewed-on: https://chromium-review.googlesource.com/c/1305876Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604661}
-
Regan Hsu authored
MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Result.FailureReason Add metrics which breaks down the percentages of reasons when failure occurs on SetSoftwareFeatureState. Bug: 870138 Change-Id: I277eeb3f0e0e3fe4418affb91977c7ddf74a9365 Reviewed-on: https://chromium-review.googlesource.com/c/1308979Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604660}
-
Miguel Casas-Sanchez authored
crrev.com/c/1294870 uprev'ed Pixel_CanvasLowLatency2D, this CL now reenables it. To monitor: android-marshmallow-arm64-rel bot. Bug: 865957 Change-Id: I89eb31722c430b0134093a7d9db51ae469b76652 Reviewed-on: https://chromium-review.googlesource.com/c/1306648Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc9857f9b84d..51fdcfba7593 git log cc9857f9b84d..51fdcfba7593 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 perezju@chromium.org [pinpoint_cli] Add command to check status of pinpoint jobs Created with: gclient setdep -r src/third_party/catapult@51fdcfba7593 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: Idc405fc3595cf37011392ee0b745e683ab4435eb Reviewed-on: https://chromium-review.googlesource.com/c/1313029Reviewed-by:
-
Gaurav Dhol authored
Add guard to avoid using x86 header for ARM64 Resolves this error ./base/atomicops_internals_x86_msvc.h(62,3): error: use of undeclared identifier '__faststorefence' __faststorefence(); Bug: 893460 Change-Id: I82b31e0470c63b4465b430768a73071722e16ed3 Reviewed-on: https://chromium-review.googlesource.com/c/1301195Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604657}
-
Peter Kotwicz authored
This CL changes the WebAPK to send the name of the launching activity only for share targets. The goal of this CL are: - In an upcoming CL I will send an intent to Chrome to relaunch the WebAPK. This CL removes the need to send the action which launched the WebAPK to Chrome. (ACTION_SEND can be assumed if the org.chromium.webapk.selected_share_target_activity_class_name extra is set.) - Add a layer of defense in depth for POST share targets. An incoming intent is for a POST share target if: 1) org.chromium.webapk.selected_share_target_activity_class_name is set on the intent 2) The <meta-data> for the passed in activity has a org.chromium.webapk.shell_apk.shareEnctype key. BUG=817263, 885313 Change-Id: I3667d257f711f1e474a44e3fd9aaf5c41552f30c Reviewed-on: https://chromium-review.googlesource.com/c/1307075 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604656}
-
liberato@chromium.org authored
This change affects how overlays are chosen on Android. Previously, DisplayResourceProvider would notify all resources that requested a promotion hint, unless they were scheduled for deletion. The intent was that only the resources that are used for the current frame would receive hints. However, that no longer works. The DisplayResourceProvider was sending hints to resources that weren't considered for overlay, such as resources used by a previous CompositorFrame. The result was that the requestor would be told that the resource wasn't promotable, and would try to switch away from SurfaceView. In reality, it just wasn't supposed to be on the screen. Instead, we now explicitly construct a list of resource IDs that are used by DrawQuads, and limit the hints to those. We do this only if any resource (displayed or not) is requesting promotion hints, which should prevent the overlay processor from doing the extra work except when the results actually will be used. Bug: 900438 Change-Id: Iba56e256b08233c9c05bd299d0ecd4a556807ccd Reviewed-on: https://chromium-review.googlesource.com/c/1310498 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604655}
-
Francois Doray authored
These histograms record the size of the resident memory per process type and in total. Resident memory is influenced by factors we control (e.g. memory that is not accessed can be swapped) and factors we don't control (e.g. an unrelated process using a lot of memory can force memory in our process to be swapped). Histograms are recorded once per UMA ping. These histograms are added to answer the following question: - Do the efforts we make to reduce the amount of memory accessed by frozen renderers has an impact on the size of their working set? Bug: 885293 Change-Id: I7cb3b1b5bd4d927277f5f4c9e96455dc0ff2ef94 Reviewed-on: https://chromium-review.googlesource.com/c/1301847 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604654}
-
Kelvin Jiang authored
The placeholder icon for an extension is the first letter of the extension's name on a grey background. extension->name() (which we currently use) is padded with formatting characters if RTL mode is enabled, and grabbing the first character in that case does not get us the extension's actual name. Fix is implemented by reversing the RTL adjustment of the extension's name before getting the first letter. Bug: 869358 Change-Id: I986c2aade64e981ce634f5d14befd21df759d9cd TEST: This behavior is difficult to automatically test. To test manually: 1) Load an extension without an icon set in the manifest and note the appearance of the placeholder icon. 2) Navigate to chrome://flags and toggle "force ui direction" to RTL (search for rtl to find this flag), then click to relaunch when prompted. 3) The extension placeholder icon's appearance should not change and should show the first letter of the extension's name as defined in the manifest. Change-Id: I986c2aade64e981ce634f5d14befd21df759d9cd Reviewed-on: https://chromium-review.googlesource.com/c/1302633Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604653}
-
Daniel Rubery authored
CheckClientDownloadRequest was using 3 methods to prevent use-after-free (weak pointers, ref counting, and cancelable tasks). This CL replaces all of those with weak pointers, so that CheckClientDownloadRequest can be singly owned by the DownloadProtectionService. Bug: 889986 Change-Id: I098d207df9fccd7842c7fdc65dba94c75ec8b062 Reviewed-on: https://chromium-review.googlesource.com/c/1289956 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#604652}
-
Alex Clarke authored
Now you have to set SetDelayedFenceAllowed in the spec if you want to use delayed fences on a particular TaskQueue. Bug: 897751 Change-Id: I5ca9869ae6999fde264e2553e451c1b08fe90204 Reviewed-on: https://chromium-review.googlesource.com/c/1309776 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#604651}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ab688385cfbd..a69842065243 git log ab688385cfbd..a69842065243 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Update third_party/yasm/BUILD.gn. 2018-11-01 thestig@chromium.org Roll third_party/skia/ edc6ea7a9..b98fb5b08 (131 commits; 1 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ ffbcc3fad..edc6ea7a9 (1 commit) 2018-11-01 tsepez@chromium.org Make CPDF_ContentMarkItem stop caching the properties dict. 2018-11-01 tsepez@chromium.org Remove notion of file writing from CFX_GlobalData Created with: gclient setdep -r src/third_party/pdfium@a69842065243 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:900552 TBR=dsinclair@chromium.org Change-Id: Iaa3e70c669163835e43a0ca57563cd4406d90b3d Reviewed-on: https://chromium-review.googlesource.com/c/1313032Reviewed-by:
-
