GitLab

R=isherman@chromium.org,lcwu@chromium.org
BUG=374763

Review URL: https://codereview.chromium.org/510483004

Cr-Commit-Position: refs/heads/master@{#292068}

Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 of 2)

BUG=401588

Review URL: https://codereview.chromium.org/498773003

Cr-Commit-Position: refs/heads/master@{#292067}

Fix a bug where an AppWindow* was not being properly deleted in the BrowserProcessPowerTest.AppsRecordPowerUsage test.

NOTRY=true
TBR=derat@chromium.org

Review URL: https://codereview.chromium.org/507773006

Cr-Commit-Position: refs/heads/master@{#292066}

BUG=356842
TBR=hubbe@chromium.org

Review URL: https://codereview.chromium.org/506363002

Cr-Commit-Position: refs/heads/master@{#292065}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505913002

Cr-Commit-Position: refs/heads/master@{#292064}

Some sites sniff the Chrome version number, so app_shell needs to
provide one.

BUG=407236
TEST=app_shell_unittests ShellContentClientTest.UserAgentFormat

Review URL: https://codereview.chromium.org/505403003

Cr-Commit-Position: refs/heads/master@{#292063}

- Checking the wrong nodes due to a typo in the previous code review.
- Handle the case of GRD files that do not emit a header file.

NOTRY=true

Review URL: https://codereview.chromium.org/510623002

Cr-Commit-Position: refs/heads/master@{#292062}

Return the device if it exists. Still return the first available device
if getUserMedia() doesn't ask for one in particular.

BUG=407236
TEST=manual

Review URL: https://codereview.chromium.org/514463002

Cr-Commit-Position: refs/heads/master@{#292061}

Now that it's impossible for content to create guests and it's impossible
for a compromised embedder to access a guest it does not have permission to
access from content, BrowserPluginGuestManager::MaybeGetGuestByInstanceIDOrKill
seems a bit heavy-handed. This CL simplifies the API a bit.

This is also a prerequiste to support accessibility in BrowserPlugin.

BUG=226145

Review URL: https://codereview.chromium.org/511643002

Cr-Commit-Position: refs/heads/master@{#292060}

Revert "Split bundle generation steps so that API registration is generated in browser, not common."

Causing build failure in Android due to failed include for extensions/common/api/runtime.h.

This reverts commit 3b70ef14.

BUG=none
TBR=yoz

Review URL: https://codereview.chromium.org/506253003

Cr-Commit-Position: refs/heads/master@{#292059}

In R39, ChromeOS rsyslogd no longer includes the hostname
field. Update SyslogParser accordingly.

While there:
- Update example shill log message to include process ID.
  (ChromeOS syslog recently started recording process IDs
  whenever possible.)
- Add a test log message from the kernel. This message does
  not include a process ID.
- Fix parsing of messages that do not have a process ID.
  Previously, for such messages, the process name would include
  a trailing ':'. With this change, they no longer do. (The
  process name will now be 'kernel', instead of 'kernel:'.)
- Simplify string EXPECTations. (No need for cstr() and STREQ.)

BUG=403558
TEST=unit test (ExtensionSyslogParserTest.ParseLog)

Review URL: https://codereview.chromium.org/486873005

Cr-Commit-Position: refs/heads/master@{#292058}

We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.

Fix a couple of dangling gyp issues also.

BUG=405226
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/489153003

Cr-Commit-Position: refs/heads/master@{#292057}

TEST=WorkspaceLayoutManagerKeyboardTest.AdjustWindowForA11yKeyboard
BUG=407094

Review URL: https://codereview.chromium.org/506133002

Cr-Commit-Position: refs/heads/master@{#292056}

After r283702 DesktopMediaPickerViews is getting parent_web_contents even
when it corresponds to a background extension page.
DesktopMediaPickerViews was always trying to create a modal dialog when
web_contents is specified, and that doesn't work for background pages.
Now it explicitly checks if the web_contents is a background page and
in that case shows the picker in a separate window.

Also updated example for desktop capture API to make it easier to test
this scenario.

BUG=402579

Review URL: https://codereview.chromium.org/501713002

Cr-Commit-Position: refs/heads/master@{#292055}

While looking at mojom files I'm nominally the owner of, I realized
that one had become redundant.  So, I just deleted it and checked the
other to make sure it had the right 'nullability' on the method args.

Also moved around code to build against the de-duped mojom file.

BUG=407673
TEST=build with gyp and gn

Review URL: https://codereview.chromium.org/503363004

Cr-Commit-Position: refs/heads/master@{#292054}

BUG=399084

Review URL: https://codereview.chromium.org/491763002

Cr-Commit-Position: refs/heads/master@{#292053}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/467183005

Cr-Commit-Position: refs/heads/master@{#292052}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/495093005

Cr-Commit-Position: refs/heads/master@{#292051}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/510563002

Cr-Commit-Position: refs/heads/master@{#292050}

Rolled src/third_party/icu
from revision fdf0bb34eaddce23811770b987ecf95ee18572d6     to
revision a4ce5bf56788dbb4835a5ef6143384266bbff5f5

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu52/+log/fdf0bb34eadd..a4ce5bf56788

TBR=thakis@chromium.org
BUG=82385
TEST=Build on Windows with clang and the above warning is not emitted
while building ICU

Review URL: https://codereview.chromium.org/493363005

Cr-Commit-Position: refs/heads/master@{#292049}

BUG=380861
NOTRY=true

Review URL: https://codereview.chromium.org/498393003

Cr-Commit-Position: refs/heads/master@{#292048}

Revert of Improve the ScopedHandle verifier. (patchset #1 of https://codereview.chromium.org/506013004/)

Reason for revert:
All windows perf bots (official builds) crashing.

http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/73062/steps/generate_telemetry_profiles/logs/stdio

	ChildEBP RetAddr
	0022f7c0 6a3ffa19 chrome_69c90000!base::debug::BreakDebugger+0x10
	0022f830 6a400622 chrome_69c90000!CheckIsChromeSxSProcess+0x26
	0022f834 6a400d52 chrome_69c90000!InstallUtil::IsChromeSxSProcess+0x16
	0022f83c 6a400c29 chrome_69c90000!BrowserDistribution::GetSpecificDistribution+0x3b
	0022f844 6a3fe166 chrome_69c90000!BrowserDistribution::GetDistribution+0x7
	0022f930 6a3fe11d chrome_69c90000!`anonymous namespace'::GetChromeChannelInternal+0x2c
	0022f948 6a092c6c chrome_69c90000!GoogleUpdateSettings::GetChromeChannel+0x21
	0022f9b4 6a08f70f chrome_69c90000!chrome::VersionInfo::GetChannel+0x60
	0022f9b8 6a08f65a chrome_69c90000!`anonymous namespace'::UseHooks+0x5
	0022f9dc 6a08eb5a chrome_69c90000!InstallCloseHandleHooks+0x15
	0022fa20 00fb7623 chrome_69c90000!ChromeMain+0x3e
	0022fab0 00fb7026 chrome!MainDllLoader::Launch+0x15f
	0022faf4 00fd936a chrome!wWinMain+0x5a
	0022fb40 766e338a chrome!__tmainCRTStartup+0xfd
	WARNING: Stack unwind information not available. Following frames may be wrong.
	0022fb4c 76f99f72 kernel32!BaseThreadInitThunk+0x12
	0022fb8c 76f99f45 ntdll!RtlInitializeExceptionChain+0x63
	0022fba4 00000000 ntdll!RtlInitializeExceptionChain+0x36

Original issue's description:
> Improve the ScopedHandle verifier.
>
> 1. Automate the selection of the proper channel to enable the verifier.
>    Now the code is enabled at runtime.
>
> 2. Switch to a hash_map to track handles.
>
> 3. Intercept CloseHandle to detect the code that is closing handles owned
>    by ScopedHandles. The initial implementation only covers chrome.exe/dll,
>    but the plan is to extend that in the future to all modules loaded in the
>    process.
>
> BUG=362176
> R=cpu@chromium.org
> R=sky@chromium.org
>
> See https://codereview.chromium.org/490043002/ for the actual review.
>
> TBR=cpu@chromium.org
> TBR=sky@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c928d0383db43f2f4baf8f9b24ed7454bf7eda64

TBR=cpu@chromium.org,sky@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=362176

Review URL: https://codereview.chromium.org/507893002

Cr-Commit-Position: refs/heads/master@{#292047}

The tests actually deadlock in practice.

BUG=407452
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/507163002

Cr-Commit-Position: refs/heads/master@{#292046}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508733002

Cr-Commit-Position: refs/heads/master@{#292045}

AnalysisRaster was needed because we must run the analysis on a separate
thread.  My second attempt placed the analysis in the picturepileimpl,
but, as vmpstr predicted, this caused issues when software rasterizing
since it uses yet another thread.  The way around all of this was to
write another raster function without the:
  DCHECK(raster_thread_checker_.CalledOnValidThread());

We're calling the Analysis before any synchronization occures with impl
so it should be safe to call without the check.

BUG=396908

Review URL: https://codereview.chromium.org/494503002

Cr-Commit-Position: refs/heads/master@{#292044}

It's no longer necessary as I fixed the underlying bug in the recipe
side.

BUG=407419
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/507853002

Cr-Commit-Position: refs/heads/master@{#292043}

BUG=407357
TBR=rsesek@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/510473003

Cr-Commit-Position: refs/heads/master@{#292042}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/488463005

Cr-Commit-Position: refs/heads/master@{#292041}

This version of the dll seems to be causing a disproportionate number of
crashes, so we fall back to software decoding if that is the version of
the DLL on the user's machine.

BUG=403440

Review URL: https://codereview.chromium.org/502183002

Cr-Commit-Position: refs/heads/master@{#292040}

https://skia.googlesource.com/skia/+log/76db31a2ca11da4dd45016e964b2e49f39f3dd49..2a65a238b0e688356aee09d08f3f8a317359b4d2

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/504223004

Cr-Commit-Position: refs/heads/master@{#292039}

* AppActivity is now base class. There will be one for chrome
* Moved content_activity_factory.h from public to impl as ther eis no need to expose header.
* Added CreateAppActivity that takes apps::Window. Chrome
 impl will use this to create an activity. This simply returns NULL for app_shell version.

BUG=397167
R=mukai@chromium.org
TBR=jamescook@chromium.org
TEST=no functional change. all tests must pass.

Review URL: https://codereview.chromium.org/505273002

Cr-Commit-Position: refs/heads/master@{#292038}

It was hitting a DCHECK when attempting to copy the CopyOutputRequest whenever navigating between pages.

BUG=

Review URL: https://codereview.chromium.org/511603002

Cr-Commit-Position: refs/heads/master@{#292037}

There's really no reason to have these in the same file, and it's cluttering it
up.

Bonus:
- Convert ExtensionActionStorageManager to use a BrowserContext.
- Remove ExtensionActionStorageManager's ExtensionService dependency.
- Remove ExtensionActionStorageManager's public weak ptr interface
- Consolidate extension_misc:: ExtensionAction icon stuff and ExtensionActionAPI
  icon stuff.

BUG=407290

Review URL: https://codereview.chromium.org/502033003

Cr-Commit-Position: refs/heads/master@{#292036}

After processing a batch of requests, our IDB transaction initiates an
inactivity timer; if the timer fires before any further requests
arrive from the front-end we assume the front-end is wedged and abort
the transaction. The timer is be stopped on any new request, including
a signal to commit or abort. During the introduction of blobs, the
"stop timer on commit signal" ended towards the end of the commit
flow, but it should be towards the start so it doesn't fire if the
back-end is busy.

Speculative fix for frequent timeouts of W3C web-platform-tests seen
on slow bots.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/502643003

Cr-Commit-Position: refs/heads/master@{#292035}

The crash was caused by a dangling pointer to a deleted observer
registered by MostVisitedSites.

BUG=406996

Review URL: https://codereview.chromium.org/501973004

Cr-Commit-Position: refs/heads/master@{#292034}

BUG=394352
TEST=NONE

Review URL: https://codereview.chromium.org/433513008

Cr-Commit-Position: refs/heads/master@{#292033}

System dialog shows only properties of selected printers, no system dialog with printers.
Removed global Ctrl+Shift+P shortcut on windows.

BUG=374321

Review URL: https://codereview.chromium.org/480303002

Cr-Commit-Position: refs/heads/master@{#292032}

Take over of https://codereview.chromium.org/232003002/, which
instead utilizes the seemingly new cache timeout logic.

All partial requests which hit net::ERR_IO_PENDING will now be
immediately timed out.

BUG=31014
TEST=layout tests, net_unittests, new unittest, manual.

Review URL: https://codereview.chromium.org/478763004

Cr-Commit-Position: refs/heads/master@{#292031}

One special request for mygadgetguardian.lookout.com and an additional
Google domain.

Cr-Commit-Position: refs/heads/master@{#292030}

This allows us to set the icon title (used for hovertext) independently
of the window title (which is empty for Settings windows).

BUG=406954

Review URL: https://codereview.chromium.org/507003002

Cr-Commit-Position: refs/heads/master@{#292029}