GitLab

If the text content of one node who share fingerPrint with others changed,
the multipiler of this node might be different from others.
This's the reason of this inconsistent problem.

The solution:
     1. Make superclusters across layouts
     2. Mark superclusters if needed
         2.1 new roots are added to superclusters
         2.2 old roots add some new contents
     3. Recalculate the multiplier of the marked superclusters during the first beginLayout().

BUG=612119

Review-Url: https://codereview.chromium.org/2299213003
Cr-Commit-Position: refs/heads/master@{#439093}

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Review-Url: https://codereview.chromium.org/2557533005
Cr-Original-Commit-Position: refs/heads/master@{#438148}
Cr-Commit-Position: refs/heads/master@{#439092}

Thanks to Sigbjorn's CL (https://codereview.chromium.org/2577053002/),
we can now obtain a pointer to ScriptWrappable from ActiveScriptWrappable.
This CL removes ActiveScriptWrappableBase::m_scriptWrappable and
reduces sizeof(void*) from each ActiveScriptWrappable object.

BUG=

Review-Url: https://codereview.chromium.org/2578193004
Cr-Commit-Position: refs/heads/master@{#439091}

On file system operations, ArcDocumentsProviderAsyncFileUtil
will look up a corresponding ArcDocumentsProviderRoot instance
from ArcDocumentsProviderRootMap and delegates operations to
it.

ArcDocumentsProviderRootMap is owned by
ArcDocumentsProviderBackendDelegate because the delegate will
also use the root map to implement its methods soon.

BUG=chromium:671511
TEST=unit_tests --gtest_filter='Arc*'
TEST=trybot

Review-Url: https://codereview.chromium.org/2572683004
Cr-Commit-Position: refs/heads/master@{#439090}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9ec20b18..1d9e2948

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2581123002
Cr-Commit-Position: refs/heads/master@{#439089}

It didn't make sense to use 'runtime_enabled_function_name'
to group runtime enabled features.
Plus, 'runtime_feature_name' was also used in few places. It
was so confusing.

So this CL unify them to use feature names to group contexts
and remove runtime_enabled_function_name() function.
This CL does not change generated code.

BUG=None

Review-Url: https://codereview.chromium.org/2578943002
Cr-Commit-Position: refs/heads/master@{#439088}

BUG=674858
TBR=junov@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2583863002
Cr-Commit-Position: refs/heads/master@{#439087}

This will ensure that all the tab items have enough space.

BUG=674409
R=dgozman

Review-Url: https://codereview.chromium.org/2584643003
Cr-Commit-Position: refs/heads/master@{#439086}

 - Remove a fulfilled TODO.
 - Remove unused methods.
 - Move implementation details to private / to .cc file.
 - Avoid unnecessary std::string/GURL allocations.
 - Push URL to the navigation chain only for main frame.

BUG=609747

Review-Url: https://codereview.chromium.org/2580903002
Cr-Commit-Position: refs/heads/master@{#439085}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/94faac75..9ec20b18

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2582783002
Cr-Commit-Position: refs/heads/master@{#439084}

Since tab_manager manages whether a renderer is suspended or not, there is no need to keep the state in RenderThreadImpl.

BUG=607077

Review-Url: https://codereview.chromium.org/2564833002
Cr-Commit-Position: refs/heads/master@{#439083}

The method setManageAccountLinkVisibility_ was removed in
https://codereview.chromium.org/1396403004 but slipped back in during a wrong
rebase in https://codereview.chromium.org/1193143003. The method is not
referenced anywhere, it is an easy case of ded code. This CL removes that
method.

BUG=480552
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578063002
Cr-Commit-Position: refs/heads/master@{#439082}

Performance object is on Oilpan's heap, so its destructor is not allowed to touch
other on-heap objects.

Also we don't need to call performanceMonitor()->unsubscribeAll() because it is
just unregistering a back pointer Member to the Performance object from the map
in PerformanceMonitor.

BUG=

Review-Url: https://codereview.chromium.org/2584733003
Cr-Commit-Position: refs/heads/master@{#439081}

[Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/25231a97c1a3eba9e26ff8fa5601e29b21672b73
Review-Url: https://codereview.chromium.org/2570823002
Cr-Original-Commit-Position: refs/heads/master@{#438477}
Cr-Commit-Position: refs/heads/master@{#439080}

Direct comparison of the enum is error-prone since users can easily
forget about the qualifier bits. The available helper functions should
be used instead as documented in the comment.

Most occurrences were addressed in earlier patches and a few leftovers
are updated here, together with the change in page_transition_types.h
that causes compiler errors if [in]equality operator is used for the
enum.

BUG=

Review-Url: https://codereview.chromium.org/2562993002
Cr-Commit-Position: refs/heads/master@{#439079}

Review-Url: https://codereview.chromium.org/2570013002
Cr-Commit-Position: refs/heads/master@{#439078}

Data from the autocomplete predictor wasn't deleted immediately when deleting browsing history. The cleanup method DeleteOldEntries() only deleted the data on next start because the corresponding history entries didn't exist anymore.

The problem is that the AutocompleteActionPredictor unsubscribes from HistoryService events and doesn't get notified about history deletion.

The deletion method was added in this cl: http://crrev.com/773103004 but it was never called as OnHistoryServiceLoaded() removed the subscription after initialization.

The same issue exists and is fixed in the ResourcePrefetchPredictor code.

BUG=668715

Review-Url: https://codereview.chromium.org/2538763002
Cr-Commit-Position: refs/heads/master@{#439077}

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298

Review-Url: https://codereview.chromium.org/2580773002
Cr-Commit-Position: refs/heads/master@{#439076}

The two histograms replace PasswordManager.SignInPromoCountTilClick. It used to record the same number for both buttons.

BUG=672163

Review-Url: https://codereview.chromium.org/2578923003
Cr-Commit-Position: refs/heads/master@{#439075}

Infra side: https://chromium-review.googlesource.com/#/c/421286/

BUG=674796

Review-Url: https://codereview.chromium.org/2581933002
Cr-Commit-Position: refs/heads/master@{#439074}

BUG=667567

Review-Url: https://codereview.chromium.org/2537243002
Cr-Commit-Position: refs/heads/master@{#439073}

Instead of directly observing the Window's vsyncs, RWHVAndroid now
observes a BeginFrameSource provided by the DelegatedFrameHost (clank)
or WindowAndroid (webview). To enable this, the BeginFrameSource
originally provided by CompositorImpl moves into WindowAndroid.

The patch also makes some changes to the BeginFrameSource's observer
iteration that are necessary to support
SynchronousBrowserCompositorFilter.

BUG=401336

Review-Url: https://codereview.chromium.org/2564403002
Cr-Commit-Position: refs/heads/master@{#439072}

BUG=674133

Review-Url: https://codereview.chromium.org/2583823002
Cr-Commit-Position: refs/heads/master@{#439071}

This CL adds msarda@ as owner for the most of the sign-in code as his team
owns now the Chrome sign-in feature in Chromium.

BUG=NONE

Review-Url: https://codereview.chromium.org/2583533002
Cr-Commit-Position: refs/heads/master@{#439070}

BUG=570441

Review-Url: https://codereview.chromium.org/2584783002
Cr-Commit-Position: refs/heads/master@{#439069}

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAudioWorklet needs to clear
m_audioWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2567243005
Cr-Commit-Position: refs/heads/master@{#439068}

So, I didn't actually try the last CL because Chrome is harder to build
that Chromium.  BUT, I did actually try it today and it totally didn't
work.  So here's a working CL that

1) works
2) actually works
3) combines with another handler that does basically the same thing
4) I've actually tried and written a test for

R=tommycli@chromium.org
BUG=621702
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true  # telemetry_unit_tests are unrelated-ly try failing

Review-Url: https://codereview.chromium.org/2577003002
Cr-Commit-Position: refs/heads/master@{#439067}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/eb5390d22252..a95071710cf8

$ git log eb5390d22..a95071710 --date=short --no-merges --format='%ad %ae %s'
2016-12-15 aiolos Roll the Chrome reference build for Canary/Dev.
2016-12-15 benjhayden Rename TelemetryInfo.addToValue() to addToHistogram().
2016-12-15 benjhayden Add BuildbotInfo Diagnostic.
2016-12-15 benjhayden Rename RelatedValueSet, RelatedValueMap to RelatedHistogramSet, RelatedHistogramMap.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2584453004
Cr-Commit-Position: refs/heads/master@{#439066}

Cr-Commit-Position: refs/heads/master@{#439065}

Reland of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset #1 id:1 of https://codereview.chromium.org/2585543003/ )

Reason for revert:
Relanding this. The real culprit was https://codereview.chromium.org/2578893003/.

Original issue's description:
> Revert of Getting rid of CompositorFrameMetadata::satisfies_sequences (patchset #17 id:380001 of https://codereview.chromium.org/2537943002/ )
>
> Reason for revert:
> Suspected cause of ChromiumOS compile failure.
> https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81640
>
> Original issue's description:
> > Getting rid of CompositorFrameMetadata::satisfies_sequences
> >
> > This CL helps unify the way we destroy references to surfaces.
> > We currently have two code paths for satisfying a surface sequence.
> > One is through calling the satisfy callback which is given to the
> > reference holder, and the other one is through populating
> > satisfies_sequences in CompositorFrameMetadata and letting
> > Surface::QueueFrame do the rest of the work. Eventually they both do
> > the same thing: they call SurfaceManager::DidSatisfySequences. This CL
> > gets rid of satisfies_sequences in CompositorFrameMetadata and from now
> > on the only way for satisfying a sequence is through the callback. This
> > is a necessary change because we are phasing out SurfaceSequence and
> > exposing it in CompositorFrameMetadata is not a good idea.
> >
> > BUG=659598
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Committed: https://crrev.com/d0de6cf72a25d789a507d6eb904a8f1ae314d00b
> > Cr-Commit-Position: refs/heads/master@{#439043}
>
> TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chromium.org,dtrainor@chromium.org,jam@chromium.org,samans@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659598
>
> Committed: https://crrev.com/f0983129357f6a46b29756ed183115b8dc8e371e
> Cr-Commit-Position: refs/heads/master@{#439051}

TBR=fsamuel@chromium.org,danakj@chromium.org,dcheng@chromium.org,jbauman@chromium.org,dtrainor@chromium.org,jam@chromium.org,samans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659598

Review-Url: https://codereview.chromium.org/2583803002
Cr-Commit-Position: refs/heads/master@{#439064}

Revert of Converts chrome to aura-mus (patchset #4 id:60001 of https://codereview.chromium.org/2578893003/ )

Reason for revert:
Broke Linux ChromiumOS Builder (dbg) build.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/81640

Original issue's description:
> Converts chrome to aura-mus
>
> aura-mus has a different environment than mus, so WMHelperMus (in exo)
> was updated accordingly.
>
> This breaks switches::kUseMusInRenderer. I'll fix that next.
>
> BUG=672932 663525
> TEST=covered by tests
> R=reveman@chromium.org, sadrul@chromium.org
>
> Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
> Cr-Commit-Position: refs/heads/master@{#439044}

TBR=reveman@chromium.org,sadrul@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672932 663525

Review-Url: https://codereview.chromium.org/2577963006
Cr-Commit-Position: refs/heads/master@{#439063}

SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary.
This patch refactors code to remove it.

This shouldn't have any behavior changes because
|ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is
being dragged. Likewise when the selection handle dragging stops there shouldn't be
a touch scroll in progress.

Review-Url: https://codereview.chromium.org/2581863002
Cr-Commit-Position: refs/heads/master@{#439062}

This is a requirement for adding a full saturated type implementation.

BUG=672489
NOTRY=true

Review-Url: https://codereview.chromium.org/2578613002
Cr-Commit-Position: refs/heads/master@{#439061}

Revert of Set number of shards for telemetry_unittests to be 2 (patchset #1 id:1 of https://codereview.chromium.org/2579793002/ )

Reason for revert:
telemetry_unittests failing on chromium.linux/Linux Tests (dbg)(1) and linux_chromium_rel_ng.
https://crbug.com/674788

Original issue's description:
> Set number of shards for telemetry_unittests to be 2
>
> This suite currently occasionally is timed out (its usual runtime is 20 minutes total), causing flaky failure
>
> BUG=661434
>
> Committed: https://crrev.com/45cada6244d0cc9c8798e6531d2c1ea0b90a5668
> Cr-Commit-Position: refs/heads/master@{#438859}

TBR=dpranke@chromium.org,maruel@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661434

Review-Url: https://codereview.chromium.org/2583703003
Cr-Commit-Position: refs/heads/master@{#439060}

Review-Url: https://codereview.chromium.org/2379773002
Cr-Commit-Position: refs/heads/master@{#439059}

It's easy to change in the web interface, and I forgot hitting ":wq"
in vim for several minutes several times now.  Uploading without prompt
seems like the better tradeoff to me.

BUG=

Review-Url: https://codereview.chromium.org/2581113002
Cr-Commit-Position: refs/heads/master@{#439058}

BUG=

Review-Url: https://codereview.chromium.org/2585613002
Cr-Commit-Position: refs/heads/master@{#439057}

This CL skips the focus test that is likely the cause of failures and
reenables the test on all platforms.

BUG=640862

Review-Url: https://codereview.chromium.org/2582543005
Cr-Commit-Position: refs/heads/master@{#439056}

Many paint properties depend on piant offset but paint offset changes
currently only cause a local paint property update. The paint
invalidation system ensures the prepaint tree walk is not stopped
so this doesn't result in a bug today. This patch will prevent
paint offset changes from being missed in the future.

This patch also moves the paint offset check to PaintPropertyTreeBuilder.
Additionally, localContext has been renamed context to improve
readability.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2578393002
Cr-Commit-Position: refs/heads/master@{#439055}

These are now type-checked by compiler.

BUG=none

Review-Url: https://codereview.chromium.org/2580673002
Cr-Commit-Position: refs/heads/master@{#439054}