GitLab

This CL aims to remove all the references to SadTab (thus slim it down)
by factoring the related methods out to a separate class SadTab. It is
managed as Tab UserData, and takes care of creating/showing sad tab view
on ContentView. Also got SadTabFactory folded into it.

Note: Tab still has references to SadTab (isShowingSadTab) from
handleTabCrash/notifyContentChanged. Removing them involves somewhat
side-tracked changes as big as  the main one. Will handle it in
a follow-up CL.

Bug: 877878
Change-Id: I94a03e8f9999809cf690339a16570cc538e0e18c
Reviewed-on: https://chromium-review.googlesource.com/1235490
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594950}

This is a step toward supporting multiple remote apps and widgets. We
need this for browser windows under single-process-mash.

Under mash the ash process is responsible for top-level window creation
for remote apps. It will need to route accessibility actions (like hit
testing) to the correct remote app. Likewise it manages window frames
and focus. Therefore it should own the mojo AXHostService, not the
browser.

Accessibility events from the remote app must be routed out of ash
into chrome to the accessibility extension. For now we do this with
the in-process AccessibilityDelegate. I didn't introduce a new delegate
because the mojo service is lazily created and it's hard to connect
a new delegate at startup. Subsequent CLs will:
* Always create the service at ash startup
* Convert the delegate methods to mojo

See go/mash-ax-node-tree for the full plan.

Bug: 888147
Test: ash_unittests, manually use ChromeVox and STS with shortcut viewer
Change-Id: Ia9e63689a8cb407b66397778be4617479fdf6c92
Reviewed-on: https://chromium-review.googlesource.com/1249920
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594949}

LocationLine assumes DRIVE_OTHER entries will be of the form
/other/path/to/file. With DriveFS, they are instead of the form
/.files-by-id/<id>/path/to/file. Support correct breadcrumbs for
directories within shared with me by treating /.files-by-id/<id> as the
prefix instead of /other when the path starts with that pattern.

Bug: 854481
Tbr: slangley@chromium.org
Change-Id: I91b55c6fbae3458b4f0f4599fc969b3c1b1fa2e8
Reviewed-on: https://chromium-review.googlesource.com/1245343
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594948}

LogStore through TreeDumper depends on chrome.automation (which is only available in the background page).

Unfortunately, NavBraille and ConsoleTts require LogStore and are still currently included in the injected content script which pulls in all LogStore deps. This change:
1. removes ConsoleTts from the content script. Logging within a content script might have been useful in the past, but doesn't seem relevant today.
2. NavBraille logging was moved to BackgroundBraille.

Test: load  a page. Verify no errors come from access to automation api being undefined. Ensure there are no references to 'automation' in the compiled page script(s).
Change-Id: Ief450600f4a23588900843678c40baf5efdfbf8b
Reviewed-on: https://chromium-review.googlesource.com/1249270
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594947}

This patch affects tests only.

We want to cache the |network_context_request_| to avoid triggering
connection error handler infinitely.

(Also organized unrelated BackgroundFetchBrowserTest.* tests)

Bug: 889965
Change-Id: I9fc67b03f19b8a9575db7714ea57ec41fc0a7711
Reviewed-on: https://chromium-review.googlesource.com/1249727
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594946}

 - capture unittest_util.js's use of commandLinePrivate
 - audit remaining things using command_line_private.js unnecessarily
   (Only files in file_manager/common/js and file_manager/foreground/js
    use it directly.)
 - Remove an annoying dep that piex_loader_unittest.js has on webui
   (Use a custom element instead: cr/ui.js dislikes strictCheckTypes.).

Bug: 882750, 879958
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I70c9e16b1ba7b9af64e0ce01b7177ef02500c948
Reviewed-on: https://chromium-review.googlesource.com/1245079
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594945}

This simplifies many conditions around the code in
chrome/chrome_cleaner.

Bug: 561800
Change-Id: I4918b2ba3d6de0c4dac47e5e79c684a1b5430020
Reviewed-on: https://chromium-review.googlesource.com/1248522Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#594944}

This change moves the logic for installing the Android Messages PWA into
a helper class which is a HostStatusProvider::Observer. This allows it
to install the PWA when a host is set and also when signing into a new
Chromebook if the account already has a valid host.

Bug: 887775
Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b
Reviewed-on: https://chromium-review.googlesource.com/1248130Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594943}

TBR=fs@opera.com
BUG=529345

Change-Id: If867ae6936ccfadfd99e4cff4ea209c686f99382
Reviewed-on: https://chromium-review.googlesource.com/1249395Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594942}

This was accidentally dropped from crrev.com/594134

Bug: 859152
Change-Id: I159af36686ce07300969f2eaf79796be85f012e5
Reviewed-on: https://chromium-review.googlesource.com/1244886
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594941}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I6aef4b11f6610e2edff6e4e9a685a360ba3e314e
Reviewed-on: https://chromium-review.googlesource.com/1250110Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594940}

If a GPU channel cannot be established, a WebMediaPlayerImpl can be
constructed without a |context_provider_|. Handle that case correctly
in CopyVideoTextureToPlatformTexture().

Bug: 819914
Change-Id: I620b602ee0c092cc31273b4f513133bf8af7e1d0
Reviewed-on: https://chromium-review.googlesource.com/1250137
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594939}

BUG=889703

Change-Id: I901c546c8329ea7082e11eaaae0bced60f376bf4
Reviewed-on: https://chromium-review.googlesource.com/1242763
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594938}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0e1056a6c8e..de84e41c85f9


Created with:
  gclient setdep -r src-internal@de84e41c85f9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I4bf04887e364c799a01818399939c4e27f7ff5a2
Reviewed-on: https://chromium-review.googlesource.com/1250107Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594937}

This reverts commit 35b382aa.

Reason for revert: crbug.com/890100

Original change's description:
> [css-flexbox] Apply min-height: auto to nested flexboxes again
> 
> To avoid the previous regression (see analysis in bug), we force
> layout in the case where we otherwise would get an outdated result.
> 
> Bug: 596743
> Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756
> Reviewed-on: https://chromium-review.googlesource.com/1246730
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594752}

TBR=cbiesinger@chromium.org,eae@chromium.org,mstensho@chromium.org

Change-Id: I8ef1e6a3e5f191c495c0b36d32366de3f0323a39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 596743
Reviewed-on: https://chromium-review.googlesource.com/1250207Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594936}

Cloud queries are being retried indefinetely in drivefs backend when
offline, which is a separate bug, but at least we shouldn't even try if
we know that it won't work.

BUG=chromium:854481

Change-Id: I5b1f182bf532864d01fc2c47740e72af0feddad4
Reviewed-on: https://chromium-review.googlesource.com/1249425Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594935}

This adds the VP8/9 frame quantizer to the stats for each frame.
This will enable the website to show a graph of these values over time.

This also adds new FrameStats unittests, and fixes a capturer_id
initialization bug discovered by the unittest.

Bug: 888833
Change-Id: I2c48f9c024a0e64a6a5756a3371717d3491a8474
Reviewed-on: https://chromium-review.googlesource.com/1242398
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594934}

Declarative Net Request API requires extensions to have access to both the
request url and initiator to block/redirect a request. Currently any requests
with an opaque origin as the initiator can't be intercepted by extensions.
Correct this.

BUG=889713

Change-Id: Ie86bf745da652d6f076e9d3076e06ec0c202f4d1
Reviewed-on: https://chromium-review.googlesource.com/1248541
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594933}

This will make Select-to-Speak appear more reactive when
the page updates during speech.

Bug: 830887
Change-Id: Iffd09d486686fa39d34f9188a6238719e71e92c7
Reviewed-on: https://chromium-review.googlesource.com/1248134Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594932}

Add QWAVE/DSCP support for unconnected sockets.  Create a helper class for maintaining remote addresses that have been configured for dscp.  Adapted from cl 682456.

Bug: webrtc:5836
Change-Id: I2ded915e82a7e967962ff3b1f4027b422d055157
Reviewed-on: https://chromium-review.googlesource.com/1191925
Commit-Queue: Tim Haloun <thaloun@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594931}

Change-Id: I01bd0c17fffd5160ab0c6d82201cf43221821744
Reviewed-on: https://chromium-review.googlesource.com/1250099
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594930}

https://chromium.googlesource.com/catapult.git/+log/8e0212945b13..920acc565706


git log 8e0212945b13..920acc565706 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 mattm@chromium.org netlog_viewer: Apply chromium changes up to 6d4874c7


Created with:
  gclient setdep -r src/third_party/catapult@920acc565706

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I236df94bd38152f14b03350f6f03552903da6844
Reviewed-on: https://chromium-review.googlesource.com/1250105Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594929}

https://webrtc.googlesource.com/src.git/+log/377b26ec65be..b5c6dd434907


git log 377b26ec65be..b5c6dd434907 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 buildbot@webrtc.org Roll chromium_revision f87ef787..2985a247 (594716:594820)


Created with:
  gclient setdep -r src/third_party/webrtc@b5c6dd434907

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I27730f1fe896c5df01bcb50a704ff2001229043f
Reviewed-on: https://chromium-review.googlesource.com/1250104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594928}

/OPT:REF is currently stripping the constructors needed by sancov
clients (such as libFuzzer). Disable it for fuzzing builds until
this issue is resolved on the Clang/libFuzzer side.

Bug: 884545
Change-Id: I9c12295020e6a2efc2ade268b25a555975e71c85
Reviewed-on: https://chromium-review.googlesource.com/1249151
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594927}

This CL adds a page for the MultiDevice setup flow to OOBE when
associated flags are enabled. Currently, page is a placeholder with no
content except for two buttons which move the user to the next page in
the OOBE/login flow.

A follow-up CL will integrate the actual page logic into OOBE.

Bug: 884061
Change-Id: Ie3bafefc736c25484e9b421648a090e9c1aa6906
Reviewed-on: https://chromium-review.googlesource.com/1223028
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594926}

Use swarming mixins for webrtc experimental bots.

Bug: 880973
Change-Id: I51e386a78f8616a94c9c8a0d67de5bdf096dfe2b
Reviewed-on: https://chromium-review.googlesource.com/1246946
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594925}

Five extnesions are whitelisted for enterprise.rerpotingPrivate permission.

Bug: 882461
Change-Id: Ic81d5dbdd45110225ebcbe2fcfac5e8827a58fc5
Reviewed-on: https://chromium-review.googlesource.com/1216843Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594924}

The tag had already been closed, so the extra tag was unneeded.

Change-Id: Ia933f018873167fa201c2d4fc3a1d2b4a0d39053
Reviewed-on: https://chromium-review.googlesource.com/1250056Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594923}

BUG=889703

Change-Id: I3280a573a6d13c9dc386758b1c177e07bec84e7c
Reviewed-on: https://chromium-review.googlesource.com/1247603
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594922}

This is a reland of e6f5eba3

Addresses a case of null handling and an incorrect check.

Original change's description:
> Download Shelf : Connect OfflineItem to the shelf
>
> This CL connects offline item with the download shelf. Some of
> the OfflineItemModel methods are still not implemented.
>
> Bug: 881499
> Change-Id: I2f0cd71815a08bcddfca753378543749389d78db
> Reviewed-on: https://chromium-review.googlesource.com/1239875
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594471}

TBR=carlosk@chromium.org

Bug: 881499
Change-Id: I313f0b34e95c4761fe54d5aa4296fd60643ab888
Reviewed-on: https://chromium-review.googlesource.com/1250100
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594921}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ad0232dee5f5..6ff2f64702dc


git log ad0232dee5f5..6ff2f64702dc --date=short --no-merges --format='%ad %ae %s'
2018-09-27 webmaster@khronos.org Update LICENSE


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@6ff2f64702dc

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I889399d2353f7face54ebb634845bdb87ad5d28d
Reviewed-on: https://chromium-review.googlesource.com/1249516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594920}

The zip archiver component extension already handles lazy loading of the
NaCl module, but it was also unnecessarily loading it on startup.

BUG=889703

Change-Id: I7346a13d4a317cd62e6b7a0f3e41870b723be28e
Reviewed-on: https://chromium-review.googlesource.com/1248343Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594919}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1814174dbc2e..c0e1056a6c8e


Created with:
  gclient setdep -r src-internal@c0e1056a6c8e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia00ea5654a91c7e5dee53583509bad22fdba581b
Reviewed-on: https://chromium-review.googlesource.com/1249520Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594918}

This reverts commit dbca191e.

Reason for revert: It broke the build.

Original change's description:
> Package Crashpad's handler into various APKs
>
> For Chromecast, Content Shell, and non-monochrome Clank/Webview:
>
> The Crashpad handler is a standalone executable, packaged like a
> loadable module and named libcrashpad_handler.so in order to not be
> ignored by Android's APK installer.
>
> For Monochrome:
>
> The Crashpad handler is linked into libmonochrome.so. At crash-time
> /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java
> which loads libmonochrome.so and runs the native HandlerMain().
>
> This strategy is not used for non-monochrome APKs (i.e. pre-N) because
> on L, Android's loader is not yet capable of loading native libraries
> from the APK. This is normally performed by the Chromium linker which
> can't be used by CrashpadMain.java because /system/bin/app_process
> doesn't initialize the process like a normal Android application
> (specifically, no ContextImpl has been created, so any calls to e.g.
> appContext.getApplicationInfo() will segfault).
>
> Binary-Size: MonochromePublic.apk increases in size by 100 KB.
> ChromeModernPublic.apk increases in size by 203KB (587 KB
> increase in install size because libcrashpad_handler.so is extracted
> from the APK). Possible mitigations for this increase are TODO:
>
> For J, K: We could link the handler directly into libchrome.so and let
> that be our handler executable. This would de-dup portions of libbase
> that are currently linked into both libchrome.so and
> libcrashpad_handler.so.
>
> For L, M: It might be possible to get the chromium linker (or Bionic's
> linker on M) to dlopen libchrome.so from the APK for a trampoline
> libcrashpad_handler.so to de-dup libbase.
>
> Bug: crashpad:30
> Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65
> Reviewed-on: https://chromium-review.googlesource.com/1150774
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594853}

TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,halliwell@chromium.org,jperaza@chromium.org,mark@chromium.org

Change-Id: I585aea87e7d52fa51097ae9b00a38eddf3a25679
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/1250134Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594917}

The TabGridConsumer API makes no guarantee that an |-insertItem:| is
called before a |-replaceItem:| is called. In cases where |-replaceItem:|
is called with an unknown identifier, the consumer should ignore the call.
When |-insertItem:| is called later, it is guaranteed to have the latest
information.

Bug: 889685
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I56cfde3d400b8d6f93296bd9a0e21060dc3e9aa7
Reviewed-on: https://chromium-review.googlesource.com/1247424
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594916}

The test was converted into testharness.js test in
crrev.com/c/1246902, but its LayoutNG text dump expectation
was left unremoved, causing failure. This CL removes it.

Bug: 887148
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia2cef89f1097519991e1638b0972d3b930030b60
Reviewed-on: https://chromium-review.googlesource.com/1249517
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594915}

ChildProcessSecurityPolicy::CanCommitURL() is a security check that's
supposed to tell whether a given renderer process is allowed to commit
a given URL.  It is currently used to validate (1) blob and filesystem
URL creation, and (2) Origin headers.  Currently, it has scheme-based
checks that disallow things like web renderers creating
blob/filesystem URLs in chrome-extension: origins, but it cannot stop
one web origin from creating those URLs for another origin.

This CL locks down its use for (1) to also consult
CanAccessDataForOrigin().  With site isolation, this will check origin
locks and ensure that foo.com cannot create blob/filesystem URLs for
other origins.

For now, this CL does not provide the same enforcements for (2),
Origin header validation, which has additional constraints that need
to be solved first (see https://crbug.com/515309).

Bug: 886976, 888001
Change-Id: I743ef05469e4000b2c0bee840022162600cc237f
Reviewed-on: https://chromium-review.googlesource.com/1235343
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594914}

R=zmo@chromium.org, kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I66f54c28838b8935e250c6c42d5dfaff74df960a
Reviewed-on: https://chromium-review.googlesource.com/1250050Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594913}

The test depends on ordering of IPCs across unassociated Mojo channels. This
ordering is not deterministic.

Bug: 889952
Change-Id: I23f9d69a5b2fc3e43eefe4241a151ccf1f20cfc1
Reviewed-on: https://chromium-review.googlesource.com/1250008Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594912}

This CL is part of adding precursor origin support to url::Origin which
nick@ started in https://crrev.com/c/1028985. It changes the Mojo
representation of url::Origin to use the nonce as an indicator for
whether the origin is opaque or not instead of keeping a boolean.

Bug: 882053
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If260a09a66cf62b870f15d52f5aabc27a3f73823
Reviewed-on: https://chromium-review.googlesource.com/1227393
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594911}