GitLab

BUG=404836

Review URL: https://codereview.chromium.org/556083004

Cr-Commit-Position: refs/heads/master@{#294312}

Followup to CL 506043002: remove unneeded c++11 enum scope for
consistency (and since we haven't officially switched to c++11 yet).

BUG=398355

Review URL: https://codereview.chromium.org/560993002

Cr-Commit-Position: refs/heads/master@{#294311}

R=vitalyp@chromium.org
BUG=393873
NOTRY=true

Review URL: https://codereview.chromium.org/559273002

Cr-Commit-Position: refs/heads/master@{#294310}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/564503002

Cr-Commit-Position: refs/heads/master@{#294309}

BUG=413044

Review URL: https://codereview.chromium.org/556323004

Cr-Commit-Position: refs/heads/master@{#294308}

This CL fixes and issue where the experimental app list would not
reset to the start page on Windows and Linux.

BUG=412227

Review URL: https://codereview.chromium.org/552743005

Cr-Commit-Position: refs/heads/master@{#294307}

Add my email in src/authors file

R=kouhei@chromium.org
BUG=

Review URL: https://codereview.chromium.org/561663002

Cr-Commit-Position: refs/heads/master@{#294306}

BUG=405859
TEST=manual

Review URL: https://codereview.chromium.org/542623002

Cr-Commit-Position: refs/heads/master@{#294305}

media::BufferedResourceLoader needs HTTP protocol and header information
in the HTTP responses so that it can properly detect live streams and
whether Range: headers are supported. This patch provides the missing
functionality needed by the media code.

Review URL: https://codereview.chromium.org/566453002

Cr-Commit-Position: refs/heads/master@{#294304}

Prevents looping, soundless videos from preventing system sleep if they're
in a background tab. We don't want soundless videos in the main tab to
allow sleeping as they'll impact the muted video + captions use case.

Reworks WebContentsImpl to track active media players and whether the
attached WebContents is visible. When visible and there's an active video
player, it will create a power save blocker. One blocker is shared for all
active media players for simplicity.

Reworks AudioStreamMonitor to handle the PowerSaveBlocker for audio
such that one is only created when non-silent audio is present.

To prevent splitting power blocking duties across chrome/ and content/,
AudioStreamMonitor now lives in content/.  WebContents exposes a
WasRecentlyAudible() method for the existing tab audio indicator.

BUG=43667,367785
TEST=manual.

Review URL: https://codereview.chromium.org/478543003

Cr-Commit-Position: refs/heads/master@{#294303}

This patch wraps the debug on start checkbox on service worker internals page into a label element
to allow clicking on the text near the checkbox as well as the checkbox itself.
R=horo

Review URL: https://codereview.chromium.org/558353002

Cr-Commit-Position: refs/heads/master@{#294302}

https://chromium.googlesource.com/chromium/blink/+log/9d49ffe0fa4d942757e3ed296fb8653f1b812ae5..ed7de93f3c7434f11196f45486e9cda62e52a21d
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/558383002

Cr-Commit-Position: refs/heads/master@{#294301}

Move app.window section of _api_features.json and _permission_features.json from chrome/common/extensions/api to extensions/common/api

BUG=387288

Review URL: https://codereview.chromium.org/546683002

Cr-Commit-Position: refs/heads/master@{#294300}

https://skia.googlesource.com/skia/+log/d9ec549071581d9d1dc2e5fac3163305ae935a39..97bf60ff7f3dd7d6e782b706ec94efb2b414b27e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/566443002

Cr-Commit-Position: refs/heads/master@{#294299}

It's not launched nor are there plans to do so. The last commit
was Dec, 2012 and there was a thread about removing it on chromium-dev in May.

My immediate use-case is to quelch the periodic idle wakeups
due to the performance monitor, but at this point, simply removing it seems
preferable to digging in to fix the timer.

BUG=411488,130212

Review URL: https://codereview.chromium.org/547063003

Cr-Commit-Position: refs/heads/master@{#294298}

 This CL removes redundant widget created by Activity, and use NativeAppWindow instead.

Activity APIs needs to some cleanup and I'll look into it once hashimoto-san finished app_window transition.

step3 will replace ChromeAppNativeWindowViews with athena's impl.

BUG=410448

Review URL: https://codereview.chromium.org/558243002

Cr-Commit-Position: refs/heads/master@{#294297}

This gets 3 views_unittests passing:
 - ViewTargeterTest.HitTestCallsOnView,
 - ViewTest.CanProcessEventsWithinSubtree,
 - ViewTest.GetEventHandlerForRect.

These were failing because the size of the RootView was being reset to
the Widget size when first added. This happened because NativeWidgetMac
was not ensuring the RootView was set up properly immediately after a
call to Widget::Init() for all Widget types (i.e. those without a
NonClientView).

When there _is_ a NonClientView, Widget::Init() calls SetContentsView()
which would eventually trickle down to
NativeWidgetMac::ReorderNativeViews(), which is where NativeWidgetMac
would set up the root view.

BUG=378134

Review URL: https://codereview.chromium.org/559873002

Cr-Commit-Position: refs/heads/master@{#294296}

Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always
removing all old transmissions.

When truncated acks start arriving, they don't stop until least_unacked
is raised, which takes an entire RTT, so this is the eventual effect of
all those truncated acks.  Instead, remove all of them the first time.

Merge internal change: 74881713
https://codereview.chromium.org/556103002/

Discard old packets from the QuicSentPacketManager which are only
present for RTT purposes(typically acks) when the map exceeds 200 packets.

Merge internal change: 74814618
https://codereview.chromium.org/551223002/

Fix a flaky QUIC end_to_end_test when the socket was suddenly unwritable
and the connection closed, but CanWrite returned true.

Merge internal change: 74798317
https://codereview.chromium.org/550703003/

Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived.

Merge internal change: 74792668
https://codereview.chromium.org/554993002/

Send an ack when it 20 packets have been received since the last ack was
sent.

This allows the peer to discard data from the SentPacketManager.

Merge internal change: 74741188
https://codereview.chromium.org/555653002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/561513003

Cr-Commit-Position: refs/heads/master@{#294295}

Noto Sans CJK {Japanese,Korean,Simplified Chinese,Traditional Chinese}
are renamed Noto Sans CJK {JP,KR,SC,TC} to make their names
future-proof (to work around the length restriction on another
platform).

We want to minimize the potential confusion (on the
part of developers) due to this name change
by adding the fonts with new names in the trunk and Chrome OS 38 branch
asap.

This CL will be landed  along with the corresponding Chrome OS CL to
actually update the font files and a Skia CL.

Skia CL: https://codereview.chromium.org/554943002/
CrOS CL: https://chromium-review.googlesource.com/217290

BUG=412151
TEST=Once the fonts are updated on Chrome OS, Noto Sans CJK {SC,JP,KR}
fonts are used in {zh,ja,ko}.wikipedia.org. They can be checked with
DOM Inspector.
TEST=`data:text/html,<span style="font-family:sans-serif;"
lang="ja">&#x4E00;</span>` uses 'Noto Sans CJK JP`.
TEST=Same as above with lang={ko,zh-CN,zh-TW} and font="Noto Sans CJK
{KR,SC,TC}" as indicated in the DOM Inspector.

Review URL: https://codereview.chromium.org/551963003

Cr-Commit-Position: refs/heads/master@{#294294}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/546303003

Cr-Commit-Position: refs/heads/master@{#294293}

Flickering no longer evident on Note 3 Device.

BUG=317928

Review URL: https://codereview.chromium.org/560123002

Cr-Commit-Position: refs/heads/master@{#294292}

This removes the DCHECK from PepperTryCatch which checks that the current
context is equal to the plugin context. This assumption is not always true.
In particular, if we call into the plugin directly from another frame (which
is in the same origin) the current context will differ. The same is true for background scripts. This should be ok; we should always use the calling context so as to not leak v8 objects across contexts.

BUG=412062

Review URL: https://codereview.chromium.org/555583003

Cr-Commit-Position: refs/heads/master@{#294291}

This doesn't yet do the most interesting test--whether or not scroll-bars
work correctly when connected to a host--but that should be simple to add
once a ClientPlugin mock is implemented.

Review URL: https://codereview.chromium.org/552923002

Cr-Commit-Position: refs/heads/master@{#294290}

Get the android_webview_glue DEPS entry back in sync with the
aosp_manifest.xml.

BUG=

Review URL: https://codereview.chromium.org/560023003

Cr-Commit-Position: refs/heads/master@{#294289}

It is safer to hold a handle to v8 context in PepperTryCatchVar than to try
retrieving it again on destruction from the frame (through the plugin instance) which has
a chance of being torn down.

BUG=411445

Review URL: https://codereview.chromium.org/562763005

Cr-Commit-Position: refs/heads/master@{#294288}

- show 'More options' section only if there are more than 6 sections
  avaialble
- add ARIA labels for the color, copies, margins, layout and paper
  settings
- group Paper size section with other collapsible sections
- adjust Advanced options button size to fit the text

BUG=397741

Review URL: https://codereview.chromium.org/556363003

Cr-Commit-Position: refs/heads/master@{#294287}

BUG=412713

Review URL: https://codereview.chromium.org/560823003

Cr-Commit-Position: refs/heads/master@{#294286}

On the BrowserOptions page, sections that are supposed to hide with an upward sliding transition instead hide instantly.

This is apparently because the style recalc that adds the CSS transition also sets the new section height (i.e., the first style recalc usually doesn't happen before the setTimeout is triggered in animatedSectionHeightChange_). To work around this, force a recalc before setting the new height.

BUG=394053
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/393943003

Cr-Commit-Position: refs/heads/master@{#294285}

These histograms are used to analyze the performance of the
data reduction proxy.

BUG=412461

Review URL: https://codereview.chromium.org/553273002

Cr-Commit-Position: refs/heads/master@{#294284}

Windows that have a shape applied via AppWindow.setShape lose
their shape after being minimized. This is because minimizing
invokes HidingWindowAnimationObserverBase::DetachAndRecreateLayers.

BUG=408737

Review URL: https://codereview.chromium.org/547283003

Cr-Commit-Position: refs/heads/master@{#294283}

Now that views widgets can be rendered with transparency there is no
need to shape the widget for the visual effect, and the impact on hit-
testing is negligible, so there's really no point shaping the widget.

BUG=408728

Review URL: https://codereview.chromium.org/547673003

Cr-Commit-Position: refs/heads/master@{#294282}

This CL fixes resize, focus and cursor issues for interstitial pages inside
Browser Plugin.

Interstitial page RenderViewHosts are not a part of the main page's WebContents. Thus, BrowserPluginGuest's (a WebContentsObserver) OnMessageReceived method will not catch IPCs coming from interstitials. However, guest interstitials have RenderWidgetHostViewGuests.

By hanlding focus, resize, cursors and the like through RenderWidgetHostViewGuest, we ensure that interstitial pages get the same treatment inside a BrowserPlugin as RenderViewHosts that belong to the guest WebContents.

BUG=273089

Review URL: https://codereview.chromium.org/549323002

Cr-Commit-Position: refs/heads/master@{#294281}

This patch adds an occlusion checker to get the state of
occlusion tracker for permanent checks. That is, occlusion
checker does not have to be queried during a layer walk.

BUG=410932
R=danakj

Committed: https://crrev.com/1af780529157c94a9e0f05bcf478543b85714f6b
Cr-Commit-Position: refs/heads/master@{#294205}

Review URL: https://codereview.chromium.org/547723002

Cr-Commit-Position: refs/heads/master@{#294280}

Add tests for new functionality.
Surround single-line blocks with curly braces in CastSocket for consistency/safety.

R=mfoltz@chromium.org
BUG=

Review URL: https://codereview.chromium.org/505453002

Cr-Commit-Position: refs/heads/master@{#294279}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/560903003

Cr-Commit-Position: refs/heads/master@{#294278}

This also removes some null checks for the now non-nullable fields.

BUG=407683

Review URL: https://codereview.chromium.org/562563002

Cr-Commit-Position: refs/heads/master@{#294277}

This call isn't meaningful with a null ServiceProvider&.

BUG=407683

Review URL: https://codereview.chromium.org/555373003

Cr-Commit-Position: refs/heads/master@{#294276}

Observation 1: It was discovered in crbug.com/410402 that deleting
the GL textures bound to IOSurfaces before releasing the CGL context
from the CAOpenGLLayer can result in crashes.

Observation 2: It was discovered in crbug.com/411782 that not deleting
the GL textures bounds to IOSurfaces before destroying the CGL context
can result in crashes.

As way speculative workaround for this, retain the CGL context when the
texture is created (when it is known to be valid), and the post a task to
- make that CGL context current
- delete the GL texture
- make no CGL context current
- release the CGL context
- release the IOSurface used by the GL texture

The theory here is that by doing this in a posted task, having a fresh stack
and having manually retained the CGL context when it was known-valid
will work around the crash in Observation 1, and manually destroying the
texture while its IOSurface is still retained and before the CGL context is
destroyed will work around the crash in Observation 2.

BUG=411782

Review URL: https://codereview.chromium.org/558803002

Cr-Commit-Position: refs/heads/master@{#294275}

The lock mouse operation invoked by plugins or pages hides the mouse cursor and ensures that the cursor stays within the bounds
of the webpage. To ensure that the mouse stays within the bounds of the page, the SetCursorPos operation is executed by the host.
In ASH, the SetCursorPos API is executed by the viewer process for historical reasons.

As a result on Windows 8 there is a faint possibility that the user may move the mouse to the charms section of the OS, which causes the cursor to
become visible.

Fix for this is to track if the mouse changed from what was last set in the viewer process and restore it.

The other change is in the RemoteWindowTreeHostWin class where the member ignore_mouse_moves_until_set_cursor_ack_ has been changed to a count
from a bool flag. This is because the RemoteWindowTreeHostWin::MoveCursorToNative function can be called multiple times before the acks are received
causing DCHECKs to fire on the ignore_mouse_moves_until_set_cursor_ack_ flag.

BUG=398792

Review URL: https://codereview.chromium.org/560633002

Cr-Commit-Position: refs/heads/master@{#294274}

https://chromium.googlesource.com/chromium/blink/+log/d500af4bd27fde579b1dfbe4f2a42c93ec702066..9d49ffe0fa4d942757e3ed296fb8653f1b812ae5
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/560093003

Cr-Commit-Position: refs/heads/master@{#294273}