GitLab

BUG=114644
R=asargent@chromium.org
TEST=Docs should no longer show up as a default app for new profiles

Review URL: https://chromiumcodereview.appspot.com/10332206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137486 0039d316-1c4b-4281-b951-d872f2087c98

Two fixes are added. 1) We stay in the loop only if we will call
DoPayloadRead or DoPayloadWrite in the next iteration. 2) Don't call
BufferRecv again if BufferRecv has reported EOF before.

Each fix alone prevents the infinite loop.  The second fix is less risky.
If necessary, we can go with just the second fix.

R=rsleevi@chromium.org
BUG=127822
TEST=SSLServerSocketTest.WriteAfterPeerClose in net_unittests

Review URL: https://chromiumcodereview.appspot.com/10382186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137485 0039d316-1c4b-4281-b951-d872f2087c98

Move compilation thread into its own class to make future multiple 
implementations easier. Also split LocalTempFile into its own file to break
circular dependency.

R= sehr@google.com,jvoung@google.com,robertm@chromium.org
BUG=none
TEST=nacl_integration


Review URL: https://chromiumcodereview.appspot.com/10377157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137481 0039d316-1c4b-4281-b951-d872f2087c98

On ARM without libpci, vendor_id and device_id will return 0, and we should not disable GPU features because of this.

BUG=
TEST=ARM bots
TBR=sheu
Review URL: https://chromiumcodereview.appspot.com/10406011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137480 0039d316-1c4b-4281-b951-d872f2087c98

This makes ImporterHost use the cross platform function instead of using the one
that is Windows specific.

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10391097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137479 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9425014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137478 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, if we were to delete a newly-created item before
informing the sync server of its existence, it would end up in an
unusual state.  We do not commit deleted items unless they were known to
sync server.  However, these items were still considered to be
'unsynced' (ie.  waiting to be committed to the server) and therefore
impossible to entirely remove from the sync directory.  They remain
forever both IS_DEL and IS_UNSYNCED.

This had a few side-effects.  The most serious is that this behaviour
could cause directory corruption.  If we created a folder and a bookmark
within it, then deleted that bookmark before it had a chance to sync,
the bookmark would remain in a zombie state.  When we finally got around
to committing its parent folder, the folder's ID will change.  The
zombie bookmark's PARENT_ID will not be updated, leaving us with a
dangling reference that will be detected as directory corruption the
next time sync is loaded.  See crbug.com/125381 for details.

Another effect is that locally deleted, never synced UNIQUE_CLIENT_TAG
could have strange effects later on. If a foreign client were to create
an item with the same UNIQUE_CLIENT_TAG and sync it, this client would
conflict-resolve the update against the zombie entry.  The zombie entry
would win, the newly created item would be deleted, and the deletion
synced back to the server.  This may not be an entirely bad thing, but
it is a behaviour that's changed following this patch.  From now on, the
deleted item will be overwritten (if it still exists, which it probably
won't).

Finally, we now have a mechanism for permanently deleting these items.
With this patch applied, these items will no longer have the unsynced
bit set, so they will be deleted on restart by DropDeletedEntries().

This patch changes PutIsDel() to clear the IS_UNSYNCED bit of entries
which were never committed to the sync server.  The remainder of the
changes either add or update existing tests.

BUG=125381
TEST=SyncerTest.ClientTagUncommittedTagMatchesUpdate,
SyncableDirectoryTest.ChangeEntryIDAndUpdateChildren_DeletedAndUnsyncedChildren


Review URL: https://chromiumcodereview.appspot.com/10389103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137476 0039d316-1c4b-4281-b951-d872f2087c98

Update gtalk version. Note -- skipping presubmit since this is just swapping binaries (no code change) and the upload fails because the change is too large.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128199
TEST=aura_shell_unittests passed


Review URL: https://chromiumcodereview.appspot.com/10382178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137474 0039d316-1c4b-4281-b951-d872f2087c98

In case of LT2P-IPsec VPN configurations, the code would read the
Recommended flags for username and password from the wrong dictionary,
resulting in the corresponding text boxes being disabled inadvertently.

BUG=chromium:128097
TEST=See bug.


Review URL: https://chromiumcodereview.appspot.com/10377168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10382193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137472 0039d316-1c4b-4281-b951-d872f2087c98

The NaClIPCAdapter was not leaking, but the Channel deletion is posted as a task that the test was not running. This makes all the NaClIPCAdapter test cases do RunAllPending on shutdown to delete stuff. Unfortunately, one of the tests results in calling "Close()" on the channel in one of these tasks, and that fails for IPC::TestSink, because IPC::Channel::Close dereferences channel_impl_ unconditionally, and the channel_impl_ is NULL for TestSink. So this patch also makes Channel::Close() do nothing if channel_impl_ is NULL.

BUG=127954
TEST=


Review URL: https://chromiumcodereview.appspot.com/10383167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137471 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit e9c5d5d4.

TBR=fischman@chromium.org
BUG=None
TEST=vmtests go green

Review URL: https://chromiumcodereview.appspot.com/10386176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/apptest.py


Review URL: https://chromiumcodereview.appspot.com/10386144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124269
TEST=Enable ash-notify in chrome://flags and ensure that ash system notifications for low batter appear instead of desktop notifications
TBR=ben for ash/

Review URL: https://chromiumcodereview.appspot.com/10406010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128388
TEST=See issue

Review URL: https://chromiumcodereview.appspot.com/10389175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137464 0039d316-1c4b-4281-b951-d872f2087c98

suspect the page is closing the constrained dialog, which deletes the
delegate so that if the dialog attempts to use the delegate we crash.

BUG=127370
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10383213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126682
TEST=See issue + ensure failing to connect to a wifi or VPN with bad credentials re-displays the connect dialog.
TBR=jhawkins for webui

Review URL: https://chromiumcodereview.appspot.com/10392097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137461 0039d316-1c4b-4281-b951-d872f2087c98

CID=103929
TBR=kalman@chromium.org

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10387143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137459 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=nacl_integration


Review URL: https://chromiumcodereview.appspot.com/10391164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137458 0039d316-1c4b-4281-b951-d872f2087c98

DnsConfigWatcher is installed at NetworkChangeNotifier and provides signals to DNSObservers.
DnsConfigService becomes a DNSObserver.

BUG=114827,114223,128166
TEST=./net_unittests --gtest_filter=DnsConfigService*

Review URL: https://chromiumcodereview.appspot.com/10377092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137457 0039d316-1c4b-4281-b951-d872f2087c98

Remove unnecessary ';' that's messing with xcode 4.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10389158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137456 0039d316-1c4b-4281-b951-d872f2087c98

A follow-up CL will send those items to the client.

The approach used in this CL will do nothing on OSes earlier than Vista.

BUG=117473


Review URL: https://chromiumcodereview.appspot.com/10381115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137455 0039d316-1c4b-4281-b951-d872f2087c98

Adding protobuf headers that will be used by upcoming continuous speech recognition classes (Speech CL2.2)


BUG=116954
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10384153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85132
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10083059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137453 0039d316-1c4b-4281-b951-d872f2087c98

Extensions send calls via SendRequestNatives::StartRequest. It is necessary to support undefined v8 values to express optional parameters.

This CL exposes the functionality to configure support for Undefined, Date and Regex data types in content::V8ValueConverter and uses it to enable Undefined values in SendRequestNatives::StartRequest.


BUG=127533
TEST=error messages on console are gone, see bug report


Review URL: https://chromiumcodereview.appspot.com/10387055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121469
TEST=Valgrind base_unittests
TBR=mark@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10386168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107048


Review URL: https://chromiumcodereview.appspot.com/10243016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137445 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137444 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10310169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108238
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10407003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124636,124637
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10381132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137440 0039d316-1c4b-4281-b951-d872f2087c98

We need to pass the timestamp as a double rather than as a long to avoid
overflow.


Review URL: https://chromiumcodereview.appspot.com/10392128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137438 0039d316-1c4b-4281-b951-d872f2087c98

That way, a WebContentsDelegate gets to handle the keyboard events also for widgets spawned by the WebContents

BUG=none
TEST=what could possibly go wrong?


Review URL: https://chromiumcodereview.appspot.com/10377158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137436 0039d316-1c4b-4281-b951-d872f2087c98

Remove the last UITest in interactive_ui_tests which was disabled and is not necessary now since there are cross-platform tests. Remove the dependency on UITest code to prevent new UITests creeping in.

Also move ConstrainedWindowViewTest and InspectUITest tests to browser_tests since they don't need to be interactive.

BUG=121574,89583
Review URL: https://chromiumcodereview.appspot.com/10382189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128337
TEST=The "Protected Content" section is not visible in the content settings dialog (ChromeOS only)

Review URL: https://chromiumcodereview.appspot.com/10383211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127471
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10392108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137433 0039d316-1c4b-4281-b951-d872f2087c98

Frontbuffer drop was hinged onto the discardBackbuffer message.  Since only a single discard mess is sent now, and since discarding backbuffer comes first, a message frontbuffer drop was waiting for would never come.

This cl just refactors to decouple the two allocations and should be functionally equivalent to current behaviour, except it does not make assumptions about when discard messages should come through.

BUG=126542
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10388010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137432 0039d316-1c4b-4281-b951-d872f2087c98

Revert 137423 - Revert 137165 - Added CSP to GAIA auth extension. Needs to land after https://gerrit.chromium.org/gerrit/#change,22663.

Reason: Manifest error + CSP issues still remain
http://crbug.com/128261#c8

BUG=chromium:127221
TEST=make sure ChromeOS auth + autotests still work


Review URL: https://chromiumcodereview.appspot.com/10398031

TBR=zelidrag@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388162

TBR=nkostylev@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137431 0039d316-1c4b-4281-b951-d872f2087c98