- 10 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/IVemt3pOQOKoaDEDMgqmUBfRju4WJsHWYff7SymNScAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159394333,b/159394534,b/159964708,b/160646592,b/160930327,b/161170553,b/161179660,b/162901119,b/163099117 Tbr: help-app@grotations.appspotmail.com Change-Id: I6879e2d711d88064544f2f94459621a93305a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796462}
-
Ben Pastene authored
It's green now: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome/2555 But keep the sanity test experimental. Bug: 1092973 Change-Id: I18085bf954fd512a1a4d0099a292f864a0ea02c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346946 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#796461}
-
Ella Ge authored
The non-virtual one also times out on Linux Leak bot Tbr: hiroshige@chromium.org No-try: true Bug: 1068175 Change-Id: I3b7be7d8d067449f6a811241bbf863a59b8d43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346851Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796460}
-
OlivierLi authored
This scope object can be used to disable hang watching when it is known an operation can run in unbounded time. HangWatchScope is renamed to HangWatchScopeEnabled as part of this change also for symmetry. This is done through the introduction of a new persistent flag kHasActiveHangWatchScopeDisabled that can ensure that new HangWatchScopeEnabled instances do not count towards hang watching. Bug: 1034046 Change-Id: I9d8d8b2812a31fe29ba7980d64567798ada3b432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288195Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796459}
-
Elly Fong-Jones authored
Bug: None Change-Id: If52c1528ba8cd0f6f3461bf6bb20ba7d3b5b605b Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346791Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796458}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/577cc158d1e2..01e0ccdc9b8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1f31db9279c9b7e848ccefc510aec1001074f43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796457}
-
Andrew Grieve authored
This reverts commit 67fc091c. Reason for reland: Writing both build_vars.json & build_vars.txt Original change's description: > Revert "build_vars.txt: Changed to build_vars.json" > > This reverts commit 6e002e1f. > > Reason for revert: Official build failure crbug.com/1114609 > > Original change's description: > > build_vars.txt: Changed to build_vars.json > > > > And moved helper function into gn_helpers.py > > > > It was only ever in .properties format so that it > > could be easily parsed by bash, but we no longer need > > that. > > > > Also fixes default_android_sdk_version to be a string. > > -next builds need it to be a string. > > > > Bug: None > > Change-Id: I99541f18510de93dae4c0d68b734638564f74ee2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340673 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#796020} > > TBR=dpranke@google.com,agrieve@chromium.org,mheikal@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: Iad8597f6af00c534245fd1a40d1809d952758f47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344626 > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796387} Bug: 1114750 Change-Id: I1019351a294e54701c093911f67a1fb6b7bd34d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346965Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796456}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0fa91d0f3563..03b15131d393 2020-08-10 saagarsanghavi@google.com [Backward Compatible] Timing and RDB for Lower-level checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106943 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: If67abb7c3a127bd417e95fee9d44904c2b6baa2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346870Reviewed-by:
-
Chris Harrelson authored
This is replaced with CompositingInputs + CompositingAssignments. Bug: 1112350 Change-Id: I3dfc709ddf7826c7a9b49950d25509c1e22efe70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343537 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#796454}
-
Gary Tong authored
Bug: 1106950 Change-Id: I620b2e38047f9f5ea89afc9cd764d908b8ad677f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343486Reviewed-by:
-
Dan Harrington authored
- If the surface is hidden, close FeedStreamSurface. This frees resources, and corrects metrics logging done in components/feed - Fixed problem where toggling the feed back on might 'open' a feed surface even though it's not shown. And a couple tangential changes: - Added DVLOGing of load latencies, for debugging. - Fixed a crash where GetSliceIndexFromSliceId was called with a null model_. Bug: 1044139 Change-Id: I2838eb925ef47e8bbdba82ae9875ee1bf6b15a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343640Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#796452}
-
Katie Dillon authored
Removing two full updatePolicy calls as they aren't necessary when only changing the compositor priority. We DCHECK that there is only one compositor task queue so directly changing the policy and computing the new priority for just the compositor task queue is sufficient and avoids the extra steps of a full policy update. Change-Id: I7f8226e01b42032ea893a5347a1a0fdad2bf5c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302971 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#796451}
-
Fergus Dall authored
This is a reland of 6d67f881 Original change's description: > Start setting StartVmRequest.vm > > This is currently ignored by concierge when starting termina, but > since termina can now be installed in multiple different locations we > need concierge to start taking the value that chrome sets. > > Bug: 953544 > Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Cr-Commit-Position: refs/heads/master@{#795346} Bug: 953544 Change-Id: Ib741759a5b61dc810d66c9d182131766247a5a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341224 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#796450}
-
Mohamed Heikal authored
AGSA queries an apps icon by name and thus fails on collapsed names. The fix is to not collapse mipmaps (application icons). This also fixes an old layering bug where chrome only resources were listed under android_webview by allowing multiple config files for use by Monochrome and Trichrome. Additionally the directive no_obfuscate has been deprecated with no_collapse as its replacement. TBR=boliu@chromium.org # noop change to webview config file. Bug: b/161564466 Change-Id: Idb735cd07e9e95ab572297c8dc4848451d8d52bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343755Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#796449}
-
Xianzhu Wang authored
This makes it clear to callers that it is never null to avoid unnecessary null checks. Change-Id: Ia21728e2931b9147041581b94337e00ffa2d495c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343586 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796448}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/32d36b08379e..12bc13e26d28 2020-08-10 jacktfranklin@chromium.org Add enum parsing support to component bridges If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05ab898798c3ef8a05004b088b56ec17458aca4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346866Reviewed-by:
-
Fergus Dall authored
This is a reland of d539d683 The previous attempt broke a couple of browser tests which used RunUntilIdle to wait for the uninstall to finish. This worked fine as long as the uninstall process ran entirely on the UI thread, but it now posts a blocking task to the thread pool. This causes the UI thread to become idle while waiting for the response, causing the test to continue prematurely. This patch replaces this with explicit usage of QuitClosure. Original change's description: > Allow termina to be installed via dlc > > Also refactor the current installer code out of CrostiniManager > > Bug: 953544 > Change-Id: Iad0850ffba616ac3f45adff63a5e21d57d3b5e7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330111 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795336} Bug: 953544 Change-Id: I1e53391eef80fada087d7bd22ee16ff01aaccf20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341223Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Nate Fischer authored
This lets java_cpp_enum and java_cpp_strings treat "WebView" like one word. This also fixes an existing test in java_cpp_strings_tests.py. Fixed: 1112005 Test: vpython build/android/gyp/java_cpp_strings_tests.py Change-Id: Id9f1ca904b4d6c90ccc1a810033c5614a0514492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337735Reviewed-by:
-
Scott Violet authored
it's flaky. BUG=1114752 TEST=test only change Change-Id: Ie28ea8bc048d3286d748bace5b0c560bd866b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347046 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#796444}
-
Scott Violet authored
In WebLayer incognito profiles are not backed by a real profile. This means there is no FaviconService to use in this case. This makes FaviconHandler/Driver work with a null service so that WebLayer can still offer favicons in incognito mode. BUG=1076463 TEST=none Change-Id: Idc049f37c469576720847ed817453b17ec519aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339550Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796443}
-
Miguel Casas authored
Many moons ago, DisplayConfigurator::SetColorMatrix() / SetGammaCorrection() were only called once after parsing a hypothetical ICC file -- those days CrOS didn't manipulate the display's color characteristics, so we configured either / both, and cleared the ColorSpace to avoid overwriting those two DRM tables unnecessarily. Note that the matrix/de/gamma tables were loaded after every wake up. Time after that came Night Light and other color mgmt projects, and this code path started being used when coming out of sleep/hibernate etc, with the caveat that after applying their matrix/de/gamma tables, the cached colorspaces was/were still cleared and lost. The fix is then simple: since we need the |color_space| to stick around, this CL avoids clearing it. RunColorCorrectionClosureSync() is then superfluous and can be removed, making evident that searching for |display_id| in |cached_displays_| is only for verification purposes: Bug: b:159224397, 1091552 Change-Id: I553646217c1012221844242c96148b8526657217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342583Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796442}
-
Nela Kaczmarek authored
Bug: 1108279 Change-Id: I0d50e041c78f871fa9167ff157aa301559c6ff91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341646 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796441}
-
Wan-Teh Chang authored
For the tests that iterate over multiple image formats, swap the loop so that instead of one test that loops over image file extensions, it creates multiple tests that each test one image file extension. Stephen McGruer outlined this change in https://crrev.com/c/2304961. Test: third_party/blink/tools/run_web_tests.py -t Default \ external/wpt/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html Bug: 1099028 Change-Id: Iac122b5aee4fecd66962e75ed4bd7ddca55b0add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346828Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fb57bbd19358..a1d5ae72b241 2020-08-10 teddy.wang@siliconmotions.corp-partner.google.com usergroup_baseline: Add smdisplay user to video group 2020-08-09 manojgupta@google.com chromeos_config: Only keep base/test images for sanitizers 2020-08-08 andrewlassalle@chromium.org dlc_lib: Add allowlist for test boards 2020-08-08 andrewlassalle@chromium.org dlc_lib: Check for lsb-release file before opening it 2020-08-08 tcwang@google.com afdo: Fix breakage due to renaming of Chrome debug binary 2020-08-08 lamontjones@chromium.org SysrootService: use package_indexes list when present. 2020-08-08 saklein@chromium.org service/test: Fix ebuild test metrics. 2020-08-08 vapier@chromium.org gerrit: add a help-all subcommand 2020-08-07 saklein@chromium.org service/sdk: Change argument from proto to string. 2020-08-07 erikchen@chromium.org Add lacros support to deploy_chrome.py 2020-08-07 lamontjones@chromium.org api: freshen python bindings. 2020-08-07 sanikak@chromium.org auto_updater_transfer: remove fallback devserver calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id47fb717106272df57d047f3106d159b96764c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346885Reviewed-by:
-
Avi Drissman authored
It is undefined behavior in C++ to access memory of one type with a pointer of another type. Use bit_cast to safely do it. Bug: none Change-Id: I170c81e0cc7dc5b7bcf63b0776758c4c65a748bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340180 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796438}
-
Jérôme Lebel authored
The goal of those 5 patches is to remove const on the following methods: * IsValidIdentity() * GetIdentityWithEmail() * GetIdentityWithGaiaID() * GetCanonicalizeEmailsForAllIdentities() * HasIdentities() * GetAllIdentities() * GetAllIdentitiesSortedForDisplay() This is required for crrev.com/i/3208484, to not start async identity fetch in ChromeIdentityServiceImpl instance when the cache is not populated. => crrev.com/c/2345305 Add temporary methods * crrev.com/i/3201649 Switch to the temporary methods * crrev.com/c/2345146 Remove const in the methods * crrev.com/i/3201650 Switch back the original methods * crrev.com/c/2344467 Remove temporary methods Bug: 897470 Change-Id: I96ee862b20081858732fc4d12024bc45d56c3ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345305 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796437}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d5099cc1545f..8956bfb9c99d 2020-08-10 nguyenmh@google.com Use striping when making test batches If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id99f0f1555ce5f41b8639ed5545b0d463523c499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346945Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This also fixes crbug/1112417 since the added test catches the multi FCM responses case and the extra report of crbug/1113213 Bug: 1113213, 1112417 Change-Id: I91083a8abc8452bc7983bc35214ffa6ded7af7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339282 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#796435}
-
Liquan (Max) Gu authored
Description: PaymentRequestImpl(PRImpl) and ComponentPaymentRequestImpl(CPRImpl) will have mutual reference starting from their constructors. Change: * Before - PRImpl was created at PRFactory#createImpl. After - PRImpl is created at CPRImpl#init. * Rename ComponentPaymentRequestDelegate BrowserPaymentRequest, and make it an individual file. This gives the interface independent semantics (no longer just part of CPRImpl) - "the browser part of the PaymentRequest implementation" Bug: 1102522 Change-Id: I19a5144c23f0f45a8ef7ce3d72752a2b90bef296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340402 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796434}
-
Ryan Daum authored
* Change the TTS extension API to use the upstream TTS controller now that it's been moved out of chrome/ and into content/. * Requires downstream changes in internal/ to rework the platform, until those changes land, TTS will become a no-op. * Using upstream TtsController instead of our fork automagically makes it possible to enable and use the Speech Synthesis API Bug: internal b/162974460 Merge-With: eureka-internal/434822 Test: manual, on device Change-Id: I3acde313d177b74408394046a283b2da02dbff41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340703Reviewed-by:Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#796433}
-
Brandon Goddard authored
This Cl adds new histograms to track experiment usage in the devtools. Explainer: https://docs.google.com/document/d/1pcvN11C4onSXqOE0dTjUUHodMj55bRVl_5_e3kMg_rs/edit?ts=5f2329dc#heading=h.ezo3vjjctj8wz Corresponding Frontend CL: https://crrev.com/c/2341950 Bug: 1107636 Change-Id: If7ecaef09bdf97452a2309f30121674206e02e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341215Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796432}
-
David Maunder authored
Now with fields such as Title being migrated to UserData objects we enforce that the attribute cannot be acquired after destroy() has been called. Unfortunately, in PseuoTab getTitle() was called after destroy() causing the app to crash which is an invalid assumption. This CL adds an isInitialized() check before the getTitle() call. Bug: 1114564 Change-Id: I064ae7d3601d45116cb198885ef64ff42a2aac7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346785Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#796431}
-
David Roger authored
To fix issues with SAML signout, the signout flow was changed to go through Gaia (http://crbug.com/1068978). However, this does not work when the account is already invalid (Gaia signout is a no-op in this case). As a result, when signing out from an invalid account (i.e. in Sync paused state), the account was not immediately removed from the device, and would linger until the next reconcilor run. This CL explicitly removes the account if it's invalid. Fixed: 1114646 Change-Id: Ibd7b4466ecb7d0ac6951d6b30814ef2e5c521bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346245Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#796430}
-
Alice Wang authored
This CL adds |Signing in...| string for the sign-in in progress screen title of the web sign-in bottom sheet. Screenshot: https://crbug.com/1102784#c3 Bug: 1102784 Change-Id: I9c3e33da3986bcb7156ef67e27dbe088342cbce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309700 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796429}
-
Xinghui Lu authored
Bug: 1114761 Change-Id: Id46125f5a1d28c4af39be7bbd75d08172c1a1490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345715Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796428}
-
Lei Zhang authored
When calling chrome.fileSystem.chooseEntry() to save edited PDFs, there is an option for the file types to accept. For each file type, the description is optional. The API documentation [1] says "if not present, a description will be automatically generated", but the generated description ended up being an empty string in this case. Fix this by manually setting the file type description. [1] https://developer.chrome.com/apps/fileSystem Bug: 1114127 Change-Id: If3440fcd13a152bb55e8f80193b4960103776cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343782Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796427}
-
Jesse McKenna authored
This change makes IdleWakeups count the cumulative number of processes created and destroyed with the target executable name during the monitoring period, and display these counts in its final summary. This enables the measurement of process turnover resulting from operations of interest, which would otherwise not be reflected in total process count (as a destroyed process and created process that both occur in between polls would cancel each other out and go undetected). Note that it is still possible to miss a process if its lifetime is so short that it is created and destroyed entirely between samples. Counting is done by comparing the previous snapshot's set of process IDs with the target executable name against the new snapshot's. The accuracy of the counts added by this change was verified by comparing against those collected by an ETW trace (System Activity > Processes) over the same period. In this comparison, IdleWakeups identified all created and destroyed Chrome processes apart from a utility process with a lifetime of only 0.08 seconds between samples. Change-Id: I93d674377906f6bd543da2c7b65792bb811fd91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342251 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#796426}
-
Peter Wen authored
Lint no longer requires manifest_package to be specified, so remove this arg from lint.py as well as the gn templates. Bug: 1108791 Change-Id: I4b48dc1ce3eb40ef8b4e703ca4ece475f2d28c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339929 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Bo Liu authored
Need to ensure AwBrowserProcess.start isn't called multiple times for a single process. Also add an annotation to disable batching and use it for app cache tests, since app cache can only be set once and the setting is global. Bug: 989569 Change-Id: I360230ac612a004bda94dded1d9dd6cb2e3f14cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335673Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796424}
-
Peter Kotwicz authored
BUG=None Change-Id: I03c770a9f06ebdb310cf1ace86cfc3b76b897e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345487Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796423}
-
