- 25 Sep, 2020 40 commits
-
-
Sebastien Lalancette authored
Only doable on iOS 14+ since on iOS 13 we're using a different "page size", resulting in a page with different width (and height). Bug: 1131558 Change-Id: Idf3f10d77787f2513ed37b258a69901e6891cb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426963 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#810596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c7f5c3e. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." 1117bd9f "Revert "FontAccess: Sort fonts in lexicographical order"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I33f7f5899a7601d6c6d91ed89976a6adc62999f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430506Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600991906-65f7bfb49ebbe3e14bdc8eed995291d523852457.profdata to chrome-win32-master-1601013503-f38bea78afe4f518e60cb51c463a620d383ff0cc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I871d64d8005510cc32f4c61c6e8db9b67631ea46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431184Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810594}
-
François Doray authored
This reverts commit 11b3502f. Reason for revert: Suspect for compile failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/171087 Original change's description: > Change DLP rules policy to dict type > > - Changed DataLeakPreventionRulesList type to > dict and to use SchemaValidator instead of a simple > list. > > Bug: 1131904 > Change-Id: Ia7268abd7003856e26eee19bb4cb7970320392eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428984 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810582} TBR=emaxx@chromium.org,poromov@chromium.org,nikitapodguzov@chromium.org,ayaelattar@chromium.org Change-Id: I01303c77c5da61b801fa42c21a8aaa4fd19a7e12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431784Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810593}
-
François Doray authored
This reverts commit 1546f3b4. Reason for revert: Suspect for compile failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/171087 Original change's description: > Add policy logic to clipboard dlp controller > > 1. Changed EnterpriseClipboardDlpController logic > to be based on the policy logic in DlpRulesManager. > 2. Added DlpRulesManager::IsAnyRestrcitedComponents > to decide if any component is restricted. > > Bug: 1102332 > Change-Id: Ib1abc64c71540cb431f94d4dfae44212ef8d3597 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416451 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810586} TBR=poromov@chromium.org,nikitapodguzov@chromium.org,ayaelattar@chromium.org Change-Id: I547458826e6144e8d8c205926bf31cd95d0659a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431446Reviewed-by:
-
Gayane Petrosyan authored
Update user selection range so that first and last words are complete words, otherwise TextFragmentFinder will not find a match. For example, where '[' and ']' indicates user selection. "samp[le text that user sel]ected" will be changed to "[sample text that user selected]" Bug: 1129647 Change-Id: I5e2274b0e1ed0cc240fcea39ffcc369ab29ce171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424541 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810591}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I56e86e2752c0750003ca4ea34d6708eace705ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430224Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I68e843e59e240a597998f7280667e675eded8985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426770Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#810589}
-
Jamie Madill authored
Bug: b/168744561 Change-Id: I9b177ba46c2c9668d68d4812697b713c75f8324b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419032Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#810588}
-
Roman Sorokin authored
As a part of the COIL effort I found this file. Looks like it's not used anywere. Bug: none Change-Id: Id9abea74ae6b64abde531a2d2c8a12eabee3ca87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428973 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#810587}
-
Aya ElAttar authored
1. Changed EnterpriseClipboardDlpController logic to be based on the policy logic in DlpRulesManager. 2. Added DlpRulesManager::IsAnyRestrcitedComponents to decide if any component is restricted. Bug: 1102332 Change-Id: Ib1abc64c71540cb431f94d4dfae44212ef8d3597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416451 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810586}
-
Tim van der Lippe authored
This test has been replaced by the cross_tool_integration e2e-tests that live in the DevTools frontend repository. R=aerotwist@chromium.org Change-Id: Id6eb3c0e000c9ca5d2e61efefb3bd3e9d740aa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429024 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810585}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600991906-91a7adfbdc345922f7abfd948645ae0f618ee88b.profdata to chrome-win64-master-1601013503-170d2d1d55cdbd64ec85654eee6bce6ad2a17ca2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibb78d800ec923b622a31ac877b028730f50681d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429219Reviewed-by:
-
Elizabeth Popova authored
Initially when the usage of test clocks was unified [1], there was an exception for Next* functions in autofill_test_utils that used base::Time::Now instead of AutofillClock::Now. However later, probably because of presubmit suggestion, it was replaced with AutofillClock::Time as well [2]. Also unified usage of Next* functions. Might be the cause of test flakiness. [1]https://chromium-review.googlesource.com/c/chromium/src/+/1850434 [2]https://chromium-review.googlesource.com/c/chromium/src/+/2103654 Bug: 1108232 Change-Id: I025075126f7cc387d5744b21f1199ddb22d00f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428986 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#810583}
-
Aya ElAttar authored
- Changed DataLeakPreventionRulesList type to dict and to use SchemaValidator instead of a simple list. Bug: 1131904 Change-Id: Ia7268abd7003856e26eee19bb4cb7970320392eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428984 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810582}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df53732e1b69..8f47f320f6f3 2020-09-25 hjd@google.com Merge "Reland: Make GuessTraceType more selective about proto traces" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I67788c97e9da1ae6641c763dd76ad8f6f3735fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430862Reviewed-by:
-
Nico Weber authored
As far as I know, chrome-for-chromeos no longer links with gold, so we can clean up the code a bit here. No intended behavior change. Bug: none Change-Id: Idc0ee540b2ec8031cf33e483e161c118bebb4035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429442 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#810580}
-
Yi Gu authored
The test used to count on base::StatisticsRecorder::FindHistogram() to test the metric is not logged. However, FindHistogram() is static and it may observe values from previous test runs. The proper way should be using ExpectTotalCount(0) [1] which takes this situation into consideration. [1] https://source.chromium.org/chromium/chromium/src/+/master:base/test/metrics/histogram_tester.cc;l=70 Bug: 1132038 Change-Id: I3134c6bccba0670a583e3ec97972a358f68fef9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430123 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#810579}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I08d46bb90a1b958e0e14e9ed9c23cb716313748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430089Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810578}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f1c8428..c325a422 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ece51ff6a4d95ff0f62bec56237782eb2b01e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428731Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810577}
-
Maksim Ivanov authored
Change tests in webview_login_browsertest.cc to calculate the expected fingerprint dynamically at runtime, rather than hardcode it as hex strings in the test code. This simplifies the tests maintenance and also makes them more readable, by replacing magic hex blobs with human-readable cert file names. The main purpose of these tests is anyway the login-screen behavior, and not the cert fingerprint calculation, therefore it's presumably not very important to have "golden" data hardcoded in these tests. Bug: 905994 Change-Id: Ie8ee63d6a54087fa77ae64e7c487b19b0c884be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426705Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810576}
-
Reda Tawfik authored
1. Sends the origin of current focused field from native to Java. 2. Shows a warning message in a `ModalDialog` when 'Use other password' button is clicked. 3. Adds a controller test for the warning dialog. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1129351#c7 Bug: 1129351, 1104132 Change-Id: I921b679898ac9c0e84dd9310c38d957d3f31e294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416358 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810575}
-
Miguel Casas authored
Encoding for Vaapi has 4 parts: (1) copying the video frame contents, (2) submitting some buffers, (3) executing the encode, and finally (4) downloading the encoded chunk. During crrev.com/c/2344526 I was taking a look at the chrome traces for it and reckoned it'd be good to split out some of them, namely this CL adds more targeted metrics for: - In part 1, for the libyuv copy-conversion that takes the majority of the time. - In part 4, for the SyncSurface (largest part), with a smaller share taken by copying the encoded chunk out. No new functionality intended. Bug: b/166646505 Change-Id: Id0f6dbcb4c119e2692c2fa7ab999100e1cac77b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427069Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810574}
-
Mikel Astiz authored
These tests experience setup slowness on Mac leading to flakiness, so let's add a few traces to confirm this hypothesis and narrow down the source of the slowness. Bug: 1131588 Change-Id: Idc077fab344c17d64a98cdc4146dd049d37b02f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431026Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810573}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: Ia20915a0be0be09ef6567c9d418b8778f7887437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424291Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810572}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ib94a4fb458f271ab2e4ec9f9d20844c46cbbf175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430204Reviewed-by:
-
Bence Béky authored
Bug: 1113661 Change-Id: Id9f1ed865f308c30b7b3279c0f2f25da81d32754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427062Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810570}
-
Gyuyoung Kim authored
This CL changes all uses of PointerType|HoverType to ui::PointerType|HoverType directly in order to reduce unnecessary type conversions. Additionally this CL fixes the layer violation in //third_party/blink/common by this replacement. It should not have //third_party/blink/public/web dependency. Bug: 1097943 Change-Id: I552e477965bbbbbc7cbcf6ac7300b12767f6115a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430447 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810569}
-
Jérôme Lebel authored
Set no milestone expiration for force-startup-signin-promo flag. This flag is used to test the startup sign-in promo . Change-Id: Ie0bd4655afd66cb6c1a75220f4ee5bec489e99e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421657Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810568}
-
jchen10 authored
The workaround doesn't actually work as DWM still performs the NV12->RGB conversion indicated from the presentation history. Bug: 1131041, 1079393 Change-Id: I3549a4410af5ba6c6210a4c52511c2708988d00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427152 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#810567}
-
Ulan Degenbaev authored
The result of performance.measureMemory() now includes the memory usage of dedicated workers running in the same site-isolated renderer process. Example entry of the result: { bytes: 1000000, attribution: [], userAgentSpecificTypes: ["DedicatedWorkerGlobalScope","JS"] } The worker URLs are not available in this implementation because it does not go through PerformanceManager in the browser process. Instead, it directly queries V8WorkerMemoryReporter implemented in renderer/controller/performance_manager. Since renderer/core cannot depend on renderer/controller, V8WorkerMemoryReporter is injected during initialization. The upcoming mojo-based implementation will add URLs. Bug: 1085129 Change-Id: I53f34c1136192c9156e2bb74e41327b5a60e0f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421707Reviewed-by:Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Prevent the extension background page from undergoing a navigation away from its initial url since this effectively makes the extension non-functional. Note this doesn't prevent navigations for which the NavigationThrottles are skipped (e.g. crbug.com/1036603). BUG=1130083 Change-Id: Ieba83f16520d8631662969c07402e0a49c2bce0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419659 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810565}
-
Fredrik Söderqvist authored
Check if the container has a filter effect property (with a reference filter) before ensuring a paint chunk. This both robust against paint-from-prepaint (crbug.com/848056) as well as achieving the goal of the SelfWillPaint() check. This also eliminates the last user of SelfWillPaint() so it and SVGLayoutSupport::HasFilterResource() which it uses can be removed. Bug: 109224, 848056, 1131498 Change-Id: Ic3da600c011d0a48bf562d9fea013e258d436e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424187 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810564}
-
Mikel Astiz authored
This scenario verifies that, if a user ends up with corrupt data consisting of tabs without their corresponding header entity, nevertheless those tabs will eventually be subject to garbage collection. Change-Id: I50cec71a46e02731580b2c1ddb2a448533a0757c Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431024 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I66416d90a4e228cf06bca9903699a2700808536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430860Reviewed-by:
-
Koji Ishii authored
|CurrentFragment| is known to return |nullptr| if |IsSingleUse|, which is set in multicol, and that it does not recalculate ink overflow at all. This patch fixes |LayoutBlockFlow::RecalcInlineChildrenVisualOverflow| by replacing it with |PhysicalFragments|. Note, all other callers have the same risk, but replacing all of them failed many tests. We need to look into each of them. This fix is required not to regress ~600 tests in `virtual/layout_ng_block_frag` for <crrev.com/c/2428530>. Bug: 1061423, 829028, 1130856, 1128199 Change-Id: I78149f0dde7fe8bcf532fc6a335109b97daef789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428516 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810561}
-
David Bertoni authored
Bug: 1093066 Change-Id: I678072e496d37812aad610fdef4772e7bb5621db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408212Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810560}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I989bed9f38ab5528d92cb9196026d6b2c2b4e544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431104 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600905490-fdb2e7b3449a423d26d1d15a08c032508e6d13fa.profdata to chrome-mac-master-1601013503-1a040f21faaa1854749ef6dccdae69339bbb905f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic6f1eed11bb093bdcffd1f124867b24e842e2b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430863Reviewed-by:
-
Chong Gu authored
If port is not defined, don't use it when running ssh commands. Bug: 1113300 Change-Id: I14681d2b7576f20bc66362cd37cec8cb1dae5137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417464 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810557}
-
