- 02 Oct, 2018 40 commits
-
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/apps/app_shim/app_shim_host_manager_mac.mm. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 874080 Change-Id: I449d164d700298ec166451458a5f9b135514156d Reviewed-on: https://chromium-review.googlesource.com/1190933Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#595857}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/73d117f64ebb..1ac95546dd12 git log 73d117f64ebb..1ac95546dd12 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 eladalon@webrtc.org Include optional.h in rtc_event_log_parser_new.cc 2018-10-02 nisse@webrtc.org Delete VideoReceiveStream::EnableEncodedFrameRecording 2018-10-02 danilchap@webrtc.org Add RtpPacket::GetRawExtension function Created with: gclient setdep -r src/third_party/webrtc@1ac95546dd12 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3266b39da17f5a3fd64798d6874dc1a39a197049 Reviewed-on: https://chromium-review.googlesource.com/1256904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595856}
-
Stephane Zermatten authored
Before this patch, scripts were checked for the url from DidFinishLoad. This generally works, because most URLs loaded from a page belong to the same domain, but not all. In some cases, depending on loading order, this resulted in the set of runnable script being cleared unexpectedly. With this patch, the controller always uses the page URL. In most cases, since DidFinishLoad reports loading resources, this reports the same URL, wehich is a no-op for GetOrCheckScripts. The set of runnable scripts should now be stable on a given page. Bug: 806868 Change-Id: Ifb8f5955c00396a9d2165eb0bacf73c8c825f76d Reviewed-on: https://chromium-review.googlesource.com/1257002Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#595855}
-
Max Morin authored
Reasonably, nullptr isn't a frame, so it cannot be deleted. This call also isn't necessary, since the destructor of |factory_| is going to clean everything up soon anyways. Adds a DCHECK to ForwardingAudioStreamFactory::FrameDeleted to assert that |render_frame_host| is non-null. Bug: 734672 Change-Id: Ide1679e93923b70182498f57b92eb21f08f8e5f6 Reviewed-on: https://chromium-review.googlesource.com/1256962Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595854}
-
Daniel Bratell authored
In some builds there were duplicate symbols because a cc file was compiled twice and linked with itself. This happened because some code accidentally included the cc file instead of the header. Change-Id: Ifa145ce13190a9fa855e06986ca60605005aa9fc Reviewed-on: https://chromium-review.googlesource.com/1255824 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595853}
-
Theresa authored
Rather, wait to record until the user exits the tab switcher to try to record. The user must exist the tab switcher on the tab for which results were returned. Also logs a histogram indicating whether results were returned while the user was in the tab switcher so that we can ballpark estimate adjustments needed to M69 metrics. BUG=890366 Change-Id: Ic5726907911df15d4bc6a5cbd97633fcf7415595 Reviewed-on: https://chromium-review.googlesource.com/1252627Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595852}
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/bookmarks. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 809610 Change-Id: I465d088e3eba92a29a1c03b1e73fb4ceb920a1e3 Reviewed-on: https://chromium-review.googlesource.com/1245730 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595851}
-
Alexandr Ilin authored
GpuMemoryBufferHandle::offset and GpuMemoryBufferHandle::stride are not initialized in the default constructor. These uninitialized members may be serialized later by mojo that makes MSAN bot unhappy. Bug: 890930 Change-Id: I0663de62997d673b97907a8bd470e9834bdaf638 Reviewed-on: https://chromium-review.googlesource.com/1256786Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595850}
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/google. This CL was uploaded by git cl split. R=isherman@chromium.org Bug: 809610 Change-Id: I43fdd2d998182d420a2ccce7f9c9bc268f02a779 Reviewed-on: https://chromium-review.googlesource.com/1245714 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595849}
-
Alex Clarke authored
Bug: 826902 Change-Id: Ic79292edea1d7d92935797103ded169cb114e1cf Reviewed-on: https://chromium-review.googlesource.com/1254542 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#595848}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d082819ca2ad..38f24ee666e1 git log d082819ca2ad..38f24ee666e1 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 geofflang@chromium.org Fix missing query for GL_NUM_REQUESTABLE_EXTENSIONS_ANGLE. Created with: gclient setdep -r src/third_party/angle@38f24ee666e1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890689 TBR=cwallez@chromium.org Change-Id: I74d70fb5e07b1a6a62f67034497f5d2bcc7bc159 Reviewed-on: https://chromium-review.googlesource.com/1256905Reviewed-by:
-
Thomas Tangl authored
This a follow up to crrev.com/c/1251627. The method for showing the cookie exception for signed-in and syncing users has been corrected. The problem was that, when Dice is enabled and the user signs into Gmail, they are also signed into Chrome, so the signed-in/syncing message was shown even though the user is not syncing. Screenshot before: https://drive.google.com/file/d/117tFXEA7WaokpHlghypqWGL3fTQMpC6n/view?usp=sharing Screenshot after: https://drive.google.com/file/d/188Pu7XAHUJm39fpzY9lNqD6CgQAVi24I/view?usp=sharing Bug: 889137 Change-Id: I60ab697e4774842258dfc47ba6a53a2b34765650 Reviewed-on: https://chromium-review.googlesource.com/1256944 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595846}
-
stkhapugin@chromium.org authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I674ed55abf3313a7e93b5d7404aebcf9609ca621 Reviewed-on: https://chromium-review.googlesource.com/1235933 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595845}
-
Andrew Grieve authored
Change-Id: I34e8872d1011d143810a2f6b53a238e517785bf2 Reviewed-on: https://chromium-review.googlesource.com/1255045Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#595844}
-
Tetsui Ohkubo authored
Focus ring around MessageView should be painted on top of all the children. TEST=manual BUG=887366 Change-Id: I5667aff33196a5f3f8792b4e936e7da1cdda1057 Reviewed-on: https://chromium-review.googlesource.com/1255750Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595843}
-
Emily Hanley authored
I have confirmed with the test case in https://github.com/catapult-project/catapult/issues/4490 that the navigation id in document loader is the correct id. Adding an id to the document itself is not the same between navigation and fcp. Bug: 850258,catapult:4490 Change-Id: I4028bcb13d90a5a1a765890fe02e346d496fab7a Reviewed-on: https://chromium-review.googlesource.com/1249533 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595842}
-
Sylvain Defresne authored
TestingFactory is a base::Callback<> while TestingFactoryFunction is a function pointer. Convert UserCloudPolicyManagerFactory to the callback based type. Bug: 809610 Change-Id: If041d74cf623b29672c90351460f23be9a5fb24d Reviewed-on: https://chromium-review.googlesource.com/1245713 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595841}
-
Hans Wennborg authored
../../third_party/blink/renderer/core/loader/image_loader.h:257:5: warning: explicitly defaulted move constructor is implicitly deleted [-Wdefaulted-function-deleted] DecodeRequest(DecodeRequest&&) = default; ^ ../../third_party/blink/renderer/core/loader/image_loader.h:252:25: note: move constructor of 'DecodeRequest' is implicitly deleted because base class 'GarbageCollected<blink::ImageLoader::DecodeRequest>' has a deleted move constructor class DecodeRequest : public GarbageCollected<DecodeRequest> { ^ ../../third_party/blink/renderer/core/loader/image_loader.h:262:20: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] DecodeRequest& operator=(DecodeRequest&&) = default; ^ ../../third_party/blink/renderer/core/loader/image_loader.h:252:25: note: move assignment operator of 'DecodeRequest' is implicitly deleted because base class 'GarbageCollected<blink::ImageLoader::DecodeRequest>' has a deleted move assignment operator class DecodeRequest : public GarbageCollected<DecodeRequest> { ../../third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h:36:27: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] P2PQuicTransportConfig& operator=(P2PQuicTransportConfig&&) = default; ^ ../../third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h:41:33: note: move assignment operator of 'P2PQuicTransportConfig' is implicitly deleted because field 'packet_transport' is of const-qualified type 'blink::P2PQuicPacketTransport *const' P2PQuicPacketTransport* const packet_transport; ^ Bug: 890307 Change-Id: I5bcb4e343ae96f26d20f1e772d1442d1edbdb105 Reviewed-on: https://chromium-review.googlesource.com/1256942 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: -
Eric Orth authored
Moving to a new dns_config.cc/h to separate the public struct from the component-private DnsConfigService. Creates a better place for a new DnsConfigOverrides struct that I'll be adding soon for the servicified DNS config manipulation work. TBR=mef@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I5e02cc29b47851ea5295d2ec7d17b381b124d97a Reviewed-on: https://chromium-review.googlesource.com/1255783 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595839}
-
Daniel Bratell authored
input_predictor_unittest.cc is used purely as a header file so it should have the .h suffix. Now it looks like some .cc files are trying to include another .cc file. The class was too large to have an implicit inline constructor/destructor so those remain in a cc file. This presubmit check didn't work before because the file was named *.cc. Change-Id: I67740f4181ea60d02cd3149ce57b0d4e8c36aaf2 Reviewed-on: https://chromium-review.googlesource.com/1255638Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595838}
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/safe_browsing/incident_reporting. This CL was uploaded by git cl split. R=robertshield@chromium.org Bug: 809610 Change-Id: Id58fcdc5a649e33a68effc8e774be09beb930ed0 Reviewed-on: https://chromium-review.googlesource.com/1246169 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#595837}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/16c9216905c1..9e92782016c4 git log 16c9216905c1..9e92782016c4 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 caryclark@skia.org fix path addrrect example in docs Created with: gclient setdep -r src/third_party/skia@9e92782016c4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I6272354423f082e3a79bd64c4cbb386734ce04de Reviewed-on: https://chromium-review.googlesource.com/1256240Reviewed-by:
-
Pam Greene authored
Eliminating email notifications and code reviews that are no longer relevant. Bug: N/A Change-Id: Ida73132009087c43440fc3e324d8852f096bcf5d Reviewed-on: https://chromium-review.googlesource.com/1255724Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Pam Greene (Please send IM for reviews) <pam@chromium.org> Cr-Commit-Position: refs/heads/master@{#595835}
-
Sorin Jianu authored
This reverts commit 46f49dac. Reason for revert: reverting the original change breaks other bots, such as https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29 an it does not fix the problem on WebKit Mac 10.13 Retina anyway. Original change's description: > Revert "remove SK_SUPPORT_LEGACY_SVG_ARC_TO" > > This reverts commit 05ee0393. > > Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina. > See https://crbug.com/891230 > > Original change's description: > > remove SK_SUPPORT_LEGACY_SVG_ARC_TO > > > > Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd > > Reviewed-on: https://chromium-review.googlesource.com/1254341 > > Commit-Queue: Mike Reed <reed@chromium.org> > > Reviewed-by: Florin Malita <fmalita@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#595627} > > TBR=fmalita@chromium.org,reed@chromium.org > > Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 891230 > Reviewed-on: https://chromium-review.googlesource.com/1256825 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595805} TBR=fmalita@chromium.org,clamy@chromium.org,reed@chromium.org Change-Id: If0cd979dc3772397f1631d01efc8e08911ecd98c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891230 Reviewed-on: https://chromium-review.googlesource.com/1256375Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595834}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59297c6f73a6..48348e91f2d7 git log 59297c6f73a6..48348e91f2d7 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 achuith@chromium.org oobe: Catch the right WebSocketException. Created with: gclient setdep -r src/third_party/catapult@48348e91f2d7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879353 TBR=sullivan@chromium.org Change-Id: Ie2201501881dfd170f964cf9312fecef7f48e59e Reviewed-on: https://chromium-review.googlesource.com/1256238Reviewed-by:
-
Nico Weber authored
Bug: 832676 Change-Id: Iaac83b8248816993554baeefc03740d21f870370 Reviewed-on: https://chromium-review.googlesource.com/1256145Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595832}
-
Findit authored
This reverts commit 3efff7c9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595787 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vM2VmZmY3YzlkOGMxZTUzYTg5NGE5YmY1MTY2MTVhNWM3ZjliMjU2Ygw Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/106570 Sample Failed Step: sync_integration_tests (with patch) on Windows-10-15063 Sample Flaky Test: USS/SingleClientWalletSyncTest.ClearOnStopSync/1 Original change's description: > Consistently clear server credit cards with USS > > AutofillWalletDataTypeController is used (pre-USS) for both AUTOFILL_WALLET_DATA > and AUTOFILL_WALLET_METADATA. When Sync is stopped, it calls > PersonalDataManager::ClearAllServerData. Since there are two instances of the > controller, that happens twice (which is unnecessary but doesn't hurt). However, > when AUTOFILL_WALLET_DATA is on USS, then the remaining ClearAllServerData call > (for the metadata controller) still happens, which brings Sync into a bad state > since the data is now gone, but the progress marker is still there (see bug 885211). > > This CL changes AutofillWalletDataTypeController to only call ClearAllServerData > for AUTOFILL_WALLET_DATA (i.e. it won't be called anymore if Wallet is on USS). > Instead, AUTOFILL_WALLET_DATA gets special-cased in ModelAssociationManager to > clear even in the STOP_SYNC case. This achieves the same "clear data on stopping > sync, but *not* on browser shutdown", but without requiring a special side channel > to the SyncService. > > One consequence is that with AUTOFILL_WALLET_DATA on USS, the clearing now happens > asynchronously (because it goes through the DB), which requires some test changes. > > Bug: 889941 > Change-Id: I54c36050c81fa862acfc0052f355ff1645a8b292 > Reviewed-on: https://chromium-review.googlesource.com/1251041 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Florian Uunk <feuunk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595787} Change-Id: I429e5ef10c8d5b858f36ce69cc2b41b30e318fd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889941, 891254 Reviewed-on: https://chromium-review.googlesource.com/1255573 Cr-Commit-Position: refs/heads/master@{#595831}
-
Carlos IL authored
BundledConnectionHelp is ready to launch, flipping flag to enabled and cleaning up fieltrial_testing_config.json before submitting the new variations config. Bug: 803178 Change-Id: Iee7297e4d58b073126585a2143412b6dadf41510 Reviewed-on: https://chromium-review.googlesource.com/1255383Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Valeriya Sinevich authored
Set mode to UPDATE for Mirror and log it. Needed for CL on logging which has a higher priority than the one where mode will actually be used. Use VLOG(1) to make variable and used somewhere. Change-Id: I0eb3def674b510a5a5ca433f62540a027fa1cc25 Reviewed-on: https://chromium-review.googlesource.com/1255823 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#595829}
-
Evan Stade authored
This re-implements functionality Ash would normally provide via WorkspaceEventHandler (double click/tap on frame for maximize) and WmToplevelWindowEventHandler (drag). Dragging by gesture is a TODO, and may be more complicated. (It doesn't work for tab-initiated drags either.) Change-Id: Ie9eff39915dd6ea68dcc69ac9b46d6edda78f23f Reviewed-on: https://chromium-review.googlesource.com/1246417Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Misha Efimov authored
Add disable_histogram_support gn argument. If set to "true", then GetHistogramDeltas() support is disabled, and Cronet size is reduced by about 200 kilobytes. Bug: 830005 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I34806415bc08e700e8753e728572da896f1edf04 Reviewed-on: https://chromium-review.googlesource.com/1256122 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595827}
-
Jordan Demeulenaere authored
This is a reland of e195437f The first version of this change was broken because ActionDelegate::StopCurrentScript() was not abstract (pure virtual). This was fixed in this CL by adding "= 0"; at the function declaration in action_delegate.h. Original change's description: > [Autofill Assistant] Add StopCurrentScript() in ActionDelegate. > > Bug: 806868 > Change-Id: Ic3deb3353377e950fadc0d011c75f7ed91ca5366 > Reviewed-on: https://chromium-review.googlesource.com/1250923 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595445} Bug: 806868 Change-Id: Ic57f8607844267c98d0ab5ece8a253ae853ec325 Reviewed-on: https://chromium-review.googlesource.com/1256184Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa730bd6. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" 8c84af9b "Update beacon WPTs" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25750 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iadde7e4f5b043b863122ad6c11c78e2f14bc8d7e Reviewed-on: https://chromium-review.googlesource.com/1256237 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595825}
-
Chris Lu authored
Every file has been moved to AppBarViewControllerPresenting. Safe to delete AppBarPresenting now. Bug: 874471 Change-Id: I5c1edc13f1b9a8288c99fcb7b6e13f4ef7e70066 Reviewed-on: https://chromium-review.googlesource.com/1251762Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#595824}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/895ce82cabc8..73d117f64ebb git log 895ce82cabc8..73d117f64ebb --date=short --no-merges --format='%ad %ae %s' 2018-10-02 brandtr@webrtc.org Split WebRTC-UseShortVP8TL3Pattern field trial in two. 2018-10-02 philipp.hancke@googlemail.com getStats: add relayProtocol 2018-10-02 aleloi@webrtc.org Reduce digital adaptive AGC2 gain in some situations. Created with: gclient setdep -r src/third_party/webrtc@73d117f64ebb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd5ada35335256725d83210eb85a0032af7ff85f Reviewed-on: https://chromium-review.googlesource.com/1256236Reviewed-by:
-
chrome://dinoEdward Jung authored
New content to the offline page will mean it's currently possible to scroll down the page and inadverently activate the offline dino game. This change ensures the game canvas is mostly in the viewport before allow the game to start. Bug: 873343 Change-Id: I04d874f71480b3aac20a24373466626e3372f246 Reviewed-on: https://chromium-review.googlesource.com/1240339Reviewed-by:
-
Rakina Zata Amni authored
Previously custom element default style is passed to the constructor, adding a CSSStyleSheet parameter to multiple parts of code. This change removes that and instead sets the default style after the definition has been built, in CustomElementRegistry::DefineInternal Bug: 824684 Change-Id: Ic544561830cced77e946ae43491e6ee989511117 Reviewed-on: https://chromium-review.googlesource.com/1256263Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595821}
-
Daniel Bratell authored
Both some Win32 headers and OpenSSL/BoringSSL defines some constant macros like X509_NAME. To avoid that clash we have a wrapper for <wincrypt.h>, crypto/wincrypt_shim.h Use that one in chrome/chrome_cleaner/os/system_util.h too since that header might be used close to OpenSSL code. Change-Id: I678b5aa1658e8436eed4b431e6c2950ce7acfb3b Reviewed-on: https://chromium-review.googlesource.com/1255825Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595820}
-
Yi Su authored
If the device's size class has changed from RegularXRegular to another or reversely, the find bar should switch between regular mode and compact mode accordingly. Hide and then reshow the findbar in BVC.traitCollectionDidChange if the size class changed. Bug: 883672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38872c3fd0911e0e99ffae87f51f90c0cf9082fb Reviewed-on: https://chromium-review.googlesource.com/1256690 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Camille Lamy authored
This reverts commit e186dbf7. Reason for revert: Introduced flakyness in virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html. See https://crbug.com/891155 Original change's description: > Convert middleClickAutoscroll.js to use gpu benchmarking > > This cl converts middleClickAutoscroll.js and the middle click autoscroll > layout tests that are using it to use gpu benchmarking. > > Bug: 875945 > Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6 > Reviewed-on: https://chromium-review.googlesource.com/1251901 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595596} TBR=nzolghadr@chromium.org,sahel@chromium.org Change-Id: I108620182b4466997df7734f01718e102628fcf6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875945 Reviewed-on: https://chromium-review.googlesource.com/1256923Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595818}
-
