- 28 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3906f655f40c..d9709fb4b440 git log 3906f655f40c..d9709fb4b440 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chonggu@google.com [Telemetry] Add fuchsia_ssh_port Option Created with: gclient setdep -r src/third_party/catapult@d9709fb4b440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I8548ecafab6cd867e99c8f025fa8717a8b1addcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024584Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735794}
-
Makoto Shimazu authored
The service worker's idle timeout is triggered when the service worker is idle for a certain period of time. Previously, the idleness is checked periodically on UpdateStatus() in ServiceWorkerEventQueue. However, the periodic check prevents us from introducing arbitrary delay of idle timeout because the delay is quantized by the interval of the periodic check. This CL re-implements the idleness check by using delayed cancellable callback. In the new implementation, the idle callback is scheduled immediately after the worker has no inflight event. If we get another event before calling the scheduled callback, it's cancelled. Bug: 1043845 Change-Id: I0d8950ced2e2465ef3d1bd88c7c499fb2c78f609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019142 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735793}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b97057e7f747..1b3441036a8f git log b97057e7f747..1b3441036a8f --date=short --first-parent --format='%ad %ae %s' 2020-01-24 syoussefi@google.com Fix chromium build (#3152) 2020-01-24 dneto@google.com Clarify mapping of target env to SPIR-V version (#3150) 2020-01-24 greg@lunarg.com Use dummy switch instead of dummy loop in MergeReturn pass. (#3151) 2020-01-23 alanbaker@google.com Fix structured exit validation (#3141) 2020-01-23 dneto@google.com Add spvParseVulkanEnv (#3142) 2020-01-23 jaebaek@google.com Handle conflict between debug info and existing validation rule (#3104) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1b3441036a8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: Ic32ead37384c4a4e5b28553673bcbde9fb3a48e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735792}
-
Colin Blundell authored
This CL starts the componentization of CaptivePortalTabHelper, itself a prerequisite to the componentization of SSLErrorHandler for sharing with WebLayer. In this CL, we move the functionality of opening a new tab via interaction with //chrome's Browser object out of CaptivePortalTabHelper into ChromeSecurityBlockingPageFactory. The latter is a good landing place for this functionality as it in fact already needed to invoke this functionality as part of the configuration of CaptivePortalBlockingPage. Bug: 1030692 Change-Id: I3fc447a1fe74c8cc7c8172f6bd8433e68d4c854f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017488Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735791}
-
Sylvain Defresne authored
Change remoting code to only link with MaterialComponents.framework if the code is compiled as a framework (this will allow removing the fake targets that exists in ios/third_party/material_components_ios/BUILD.gn). If using MaterialComponents.framework, then bundle it with the app. Bug: 1040871 Change-Id: I05af4bc9a0f80a83f42a2113e01f4c5f0dc09eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020960Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735790}
-
Md. Hasanur Rashid authored
Bug: 788604 Change-Id: I879b5307fe17aae16ab900d1e86781982d15db36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023713Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#735789}
-
Dominik Röttsches authored
Analogously to the fix in [1], use Skia's makeClone method for applying variable font axis parameters to a previously decoded and instantiated (as SkTypeface) web font. This avoids the workaround of instantiating the variable instance from a duplicated SkStreamAsset. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1911758 Bug: 1034906 Change-Id: I80406cfd67c60251404bd80b2f99bc59b891dcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970618 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735788}
-
David Roger authored
Dice is now always enabled, these checks are unnecessary around #edit-profile. The sync-overview section can be completely removed, because it is only shown when dice is disabled and signin is allowed, which is no longer a possible state since dice was enabled by default. The test suite DiceUITest can now be removed and merged with the general test suite. Bug: 891781 Change-Id: Ida75b66481d8a29ed983864aa5da24f0e1d835a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019447Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#735787}
-
Yoshifumi Inoue authored
This patch makes accessibility/aom-relation-list-properties.html to pass test instead of hitting |DCHECK()| about |LayoutText| has |NGAbstractInlineTextBox|. Before this patch, detaching |NGAbstractInlineTextBox| from |NGFragmentItem| associated to |LayoutText| is happened at |LayoutObjectChildList:: InsertChildNode()| after changing parent of |LayoutText| to new parent. This prevents us to use next for same layout object list because start of list is hold by previous containg block flow of |LayoutText| and new parent doesn't have it. After this patch, we call |InvalidateInlineItems()| to detach |NGAbstractInlineTextBox| in |LayoutObjectChildList::{Insert,Remove}ChildNode()| before changing parent to use next for same layout object list. Bug: 982194 Change-Id: If36223d434cfda16f8270e2e7759249e4bcdc015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024389 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#735786}
-
Aleksey Kuznetsov authored
Invoke OnReceiveRedirect() method asynchronously, because there is way to use this code and get uninitialized variable: We want to create our |loader| variable from static function CreateLoaderAndStart(). But in this function there is way to invoke OnReciveRedirect() from our client code. And in our client code we do not expect, that |loader| variable is not costructed (uninitialized). Bug: 1043752 Change-Id: I5c0722d89ed9f849c0b82281ad6ceb5febfc467b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011221 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#735785}
-
Oriol Brufau authored
LayoutNGListItem::FindSymbolMarkerLayoutText is supposed to return the LayoutObject* of the symbol text inside a ::marker. This was working fine if the parameter was a list item, the method just retrieved the marker of that list item (whether outside or inside) and then relied on ListMarker::SymbolMarkerLayoutText. It was also working fine for outside markers by a combination of ToLayoutNGListMarker and ListMarker::SymbolMarkerLayoutText. However, it was returning nullptr for inside markers. It doesn't seem this was causing any issues, but this patch makes the method behave properly. The code is also simpler this way. This patch also removes LayoutNGListItem::SymbolMarkerLayoutText since it had no other caller. BUG=457718 Change-Id: I57dea247e0f8a638c251eff6d71788a5465d74b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022946Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#735784}
-
Patrick To authored
When the visibility state is hidden, which is the case when the Windows Mixed Reality Portal is closed or the headset is sleeping when a session is requested, Blink stops requesting frames from the XR runtime. This prevents the OpenXR backend from polling events, thus missing the eventual visibility state change once the headset is ready. This change ensures events are constantly being polled by having a timer run every 1 second that polls events if significant time has passed since the last event poll. Bug: 1043209 Change-Id: Ifb607e393b6eebae3cadf28e4a31db9c9054b90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018186 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#735783}
-
Eriko Kurimoto authored
This CL adds use counter. When SharedWorker constructor is called with 'classic' type, ClassicSharedWorker is counted. If not, ModuleSharedWorker is counted. If type attribute is not defined, it is regarded as ClassicScript. Bug: 1023338 Change-Id: Ia126a51df040d363c66cbe0a7ff91a5e59849eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018354 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735782}
-
Eriko Kurimoto authored
This CL modernize WPT for cleanup. This doesn't change the test behavior. Change-Id: Ic9213ec517ac50601805a69d38d5a6c02db6310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016522 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#735781}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/067755621ca9..9f8c6ea7afc8 git log 067755621ca9..9f8c6ea7afc8 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 82459860..77c4d4c4 (425 commits) Created with: gclient setdep -r src/third_party/skia@9f8c6ea7afc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I4d1d42030127292d39eeccb663f8dee3221e0e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735780}
-
Tim Song authored
BUG=1013251 Change-Id: Ib68dfd00adca4af4bafccc3532681901887d566d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024076Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735779}
-
Rakesh Soma authored
previous state of user tos acceptance. Bug: 1045536 Change-Id: Ib87942148d1b7cd82309edb03c8eb8c6e4680f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021332 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#735778}
-
Hirokazu Honda authored
Bug: 1033799 Test: image_processor_test on kukui Change-Id: I5857332393313e5f6aa33fbc1ac505279dd9bc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007802 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735777}
-
Hirokazu Honda authored
This adds the GMB-backed VideoFrame support on input and output. Both input and output VideoFrames are mapped every Process() by using VideoFrameMapper if their storage types are GPU_MEMORY_BUFFER. Bug: 1033799 Test: image_processor_test on kevin Change-Id: Idea3cf4b0fca5e53ed758a5f7a25440933090095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021784 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735776}
-
Hirokazu Honda authored
LibyuvIP supports Dmabuf-backed VideoFrame on input. This adds the Dmabuf-backed VideoFrame support on output. Both input and output VideoFrames are mapped every Process() by using VideoFrameMapper if their storage types are DMABUF. Bug: 1033799 Test: image_processor_test on kevin Change-Id: I30f5e48027081a6ff7c6debc747543678586c776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016526 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735775}
-
Ionel Popescu authored
Prior to this CL when opening a popup, the focus ring was drawn in two places: one on the original form and the other on the focused element inside the popup. This CL updates the behavior to draw a single focus ring on the focused element inside the popup. After the popup is closed, the focus ring is going to be drawn on the selected in-page element. Node::ShouldHaveFocusAppearance is changed for the affected elements (select, input-date related types and color) to avoid drawing the focus ring for the in-page element when its associated popup is open. Bug: 1041708 Change-Id: I9394900034241dbb9b309196eacfa903370426b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023361 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Dan Clark <daniec@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#735774}
-
Takashi Toyoshima authored
Since CrElementsPolicyPrefIndicatorV3Test.All depends on OOR-CORS as some other WebUI tests do, we need to flip the OOR-CORS to be enabled explicitly to run the test. This is a followup change for the Polymer3 test migration, https://chromium-review.googlesource.com/c/chromium/src/+/2021335. Bug: 1042558 Change-Id: I463b82e52af59d403aed0eb79aa1f767f945d5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023712 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735773}
-
Hirokazu Honda authored
Bug: 1033799 Test: video.EncodeAccel* on kukui Change-Id: I837660038fdb37b700642c857560484d8208cdb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010509 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735772}
-
Hirokazu Honda authored
LibyuvIP checks the configured fourcc is supported by comparing the fourcc value. It causes the LibyuvIP supports single-planar fourcc only. LibyuvIP is able to process multi-planar fourccs. This fixes the bug by comparing the configured fourccs and supported fourccs as single planar formats. Bug: b:147411004 Test: image_processor_test on kevin Test: media_unittests --gtest_filter=FourccTest on kevin Change-Id: I7bbc6953bdf1bbd9c73deaf82beab743ce147cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016543 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735771}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::FirstLineBoxTopLeft()| to use |NGInlineCursor| for prepration of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I37d5f298056f4141de824f8eee38e88cbd49721b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021566 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735770}
-
Hirokazu Honda authored
gfx::Rect is a more reasonable struct to stand for a dimension to be encoded in VideoEncodeAccelerator than gfx::Size. It is because the area of VideoFrame to be encoded does not necessarily begin with (0, 0). This CL basically changes the type to gfx::Rect keeping the logic of V4L2VEA and the assumption about the area origin. Bug: 1033799 Test: video.EncodeAccel* on kukui Change-Id: Ie7a0b6bbdb9a66bfd1b85c9afa5bfff80779ee81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010508 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#735769}
-
Koji Ishii authored
Following bot results are included. 1159 1160 1161 1163 1164 1165 1166 1172 5 lines were removed and 4 lines were deflaked by consecutive results since 1136. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ifeb167ca0218fdb34a12ba28fb7b9d13bdb4cd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022566Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735768}
-
David Trainor authored
- Remove dependencies on the offlinepages package by passing in an ObservableSupplier for whether or not prefetch is enabled. - Remove dependencies on DownloadSettings (which has dependencies that cannot be moved yet) by passing in a Callback<Context> to launch the settings screen. - Remove a dependency on the OfflineContentAggregatorFactory (which should stay as glue code) by passing in the OfflineContentProvider interface. Bug: 1046032 Change-Id: I5d8935661be63e452f08578f18cc33ed735b0536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023505 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735767}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for GetSafe()/SetSafe(). However, secialization is not really necessary here with templates and can be moved into GetSafe()/SetSafe() methods without changing generated code. Bug: 819294 Change-Id: Ib6d7b7760b7b1f3f88a395f5ab3fb4788defbb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010793Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#735766}
-
Jeremie Boulic authored
Extend storage handler's tests by checking my files size computation. The "My files" row on the setting's storage page displays the size of My files and android play files (excluding apps). The Downloads folder is bind mounted on [android files path]/Download. The files in these folders shouldn't be counted twice. This test registers a temporary location for My files and Android files, for a given profile, and tests that the size computed under "My files" produces the expected output. Bug: 1013459, 1044495 Change-Id: Ib5f6b58a73eb6b732f88c9117bbfefbcdc179f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016689 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#735765}
-
Takashi Toyoshima authored
This is a reland of 6e293feb Original change's description: > OOR-CORS, WebView: Add CORS tests for requests from custom schemes > > Behaviors have been unclear, but if requests are made from a custom > scheme, the Origin header in outgoing requests should be set to > "<scheme>://" without containing the host:port part those are > officially required to be a proper origin for such special cases > in WebView. > Servers can use "Access-Control-Allow-Origin: *" or > "Access-Control-Allow-Origin: <scheme>://" to permit such accesses. > > This patch adds tests to verify these behaviors to keep compatible > behaviors. > > Bug: 1035366 > Change-Id: Ia08e7b4ed764225566c3b09edef2980cfa1b1b70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010591 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735332} Bug: 1035366 Change-Id: Ic63d48287fa789dfb1697426dd47168068a97127 TBR: torne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024649Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735764}
-
Takashi Toyoshima authored
Update the plan to remove it at m84. This is because there is an agreement that 4 milestones notice will be provided prior to removing the policy. https://www.chromium.org/Home/third-party-developers Bug: 1036230 Change-Id: I7e8a710a116df37ea6099a2036f7f471b4394f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022363 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#735763}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7ee8ca5a321c..067755621ca9 git log 7ee8ca5a321c..067755621ca9 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 748ad200897b..34e16df059f8 (6 commits) 2020-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fcef6dcb6ab2..086aded3cb74 (9 commits) Created with: gclient setdep -r src/third_party/skia@067755621ca9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I923b79be89a026e7478243f1b2228b1846d297d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735762}
-
matterchen authored
Port forwarding in Cros will allow users to add new ports and activate, deactivate and remove existing ports. When any of the utilities are called, the port forwarding library will invoke the permission broker client to change the ChromeOS port forwarding settings. In future work we will also save port forwarding preferences such that a user's preferences will persist over container shutdown. Revert CL comment: Reason for revert: CrostiniPortForwarderTest.AddPortDuplicateFail failing on Linux Chromium OS ASan LSan Tests (1) First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36750 Failure example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890488549187658624/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniPortForwarderTest.AddPortDuplicateFail__status_CRASH_/0 Actions taken: Built tests and ran with address sanitizer, confirmed existence of issue. Made appropriate changes and confirmed address sanitizer does not raise issues anymore. everything builds Bug: chromium:848127 Test: crostini_port_forwarder_unittest.cc (+Address Sanitizer) and Change-Id: Ib1d1b901b9f9e45fb7e85feaa0b97be026feabac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018363Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#735761}
-
Hitoshi Yoshida authored
Adding it misleads as if the interface is originally defined in core/. For example, ServiceWorker is defined in modules, and includes a mixin AbstractWorker which is defined in core. Then ServiceWorker's |components| returns both core and modules. This CL skips adding component information in merging mixins to prevent such troubles. Bug: 839389 Change-Id: I63dd8cdb3c75f56bfa5ba22d06042de42712b6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024230 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735760}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/11b66cf1103c..8a6f9a03f020 git log 11b66cf1103c..8a6f9a03f020 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 steveanton@webrtc.org Export IceParameters::Parse for use in Chrome Created with: gclient setdep -r src/third_party/webrtc@8a6f9a03f020 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044521 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7785fc63d9476cad6ef8f29e9fed1ec54017d970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735759}
-
Clark DuVall authored
Some of the menu items were showing up as @<id> because the wrong Resources were used to resolve IDs from the menu. This is fixed by overriding getTheme() if we have a resources override context, so anybody who uses the resources from the theme will get the correct object. Bug: 1046158 Change-Id: I3e22f385ba01eb5cc9bc49c7cf9d98e98386ccf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024151Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#735758}
-
John Chen authored
Includes tests in virtual/text-antialias directory. TBR=wangxianzhu@chromium.org Bug: 1028242 Change-Id: I4f4148a990c193a1405e81a954b17341bed365e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023524Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735757}
-
Morten Stenshorne authored
BreakBeforeChildIfNeeded() needs to make the block-offset relative to the fragmentainer, so passing an offset that's relative to the BFC gives less work than passing one relative to the containing block. This is just cleanup - no behavior changes. Change-Id: I49fa3415e37191e285c2d4844465862d46ebc58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023887Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#735756}
-
Findit authored
This reverts commit 2fe77415. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 735748 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJmZTc3NDE1NjI3YjAzZGEwYWYwZWRhZjA3Y2ZmOWNjY2MzYTI4MzYM Sample Failed Build: https://ci.chromium.org/b/8890045091910242336 Sample Failed Step: compile Original change's description: > [Structured metrics] Add metric collection and upload logic. > > This is the final CL for the core of the structured metrics system. It > ties together the KeyData class (for managing keys and computing hashes) > with the metrics provider, and implements logic to: > > 1. Hash and store incoming structured metrics events. > 2. Provide stored metrics events for upload. > > It also adds integration tests for the system, checking that an event > created through the public API is correctly prepared for upload. > > Other misc changes: > > - Some minor refactoring of event_base.{h,cc} and equivalent changes > to events_template.py, to fix some bad style. > - Added a missing RemoveObserver call to the metrics provider dtor. > > Bug: 1016655 > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735748} Change-Id: I49a0897dee3a1a5df3b07f60abdf53da74c568c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024575 Cr-Commit-Position: refs/heads/master@{#735755}
-