- 26 Sep, 2017 40 commits
-
-
Marc Treib authored
This stuff was a LOT of plumbing, all to eventually determine "is the current tab an NTP?". That can be had MUCH simpler :) Before: SearchTabHelper (per-tab) has a SearchModel and updates that with the "isNTP" state. The state for the active tab gets propagated via SearchDelegate to BrowserInstantController's SearchModel instance. InstantController listens for changes to that, and on non-NTP->NTP transitions sends the "Instant info" (i.e. MV tiles and theme) to the Instant process. After: InstantController watches for relevant navigations itself and just checks the "isNTP" state directly. Several kilometers of plumbing are removed, and there is much rejoicing. Manually tested the following cases: - Navigating regular page <-> remote NTP - Navigating regular page <-> local NTP - Navigating local NTP <-> remote NTP All these for regular and forward/back navigations, and for Google and third-party DSE. Bug: 627747 Change-Id: Id55b1f28550b4aeee1e5472ac0e8eebd0ee0d65c Reviewed-on: https://chromium-review.googlesource.com/678719Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504342}
-
David Roger authored
Bug: 767004 Change-Id: I809d651345d4c5ae376c2967c58a11c5c1dd94b4 Reviewed-on: https://chromium-review.googlesource.com/674870 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#504341}
-
Alexandr Ilin authored
This CL modifies PreconnectManager to use a host instead of full URL as a key for active PreresolveInfo. The CL also adds several DCHECKs to ensure that the PreconnectManager uses only shortened GURLs (origins) to issue requests. Bug: 699080 Change-Id: I9938de1fa5ad908c1df181b0cf88bac9691a9e06 Reviewed-on: https://chromium-review.googlesource.com/677455Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504340}
-
Juan Antonio Navarro Pérez authored
This reverts commit 9aa706c8. Reason for revert: Mistakenly disabled on wrong configuration. Original change's description: > //tools/perf: Disable long running gmail story for memory_mobile > > TBR=rnephew > > Bug: 764924 > Change-Id: I1ca8db7fc360daf57f216c11c32470489f76928d > Reviewed-on: https://chromium-review.googlesource.com/666060 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: rnephew <rnephew@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501778} TBR=rnephew@chromium.org,martiniss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 764924 Change-Id: Id97802a417b6a7e1364f8a2cef48f7b1c056086c Reviewed-on: https://chromium-review.googlesource.com/681354Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#504339}
-
Koji Ishii authored
This patch splits the "ordinal value" logic[1] to a separate class, ListItemOridinal, so that we can re-use the logic in LayoutNG. The logic is mostly DOM operations that moving them out of layout is reasonable from the layering perspective too. It still relies on layout tree to provide the storage, and events for insertions and deletions, since any elements with 'display: list-item' can be list items. [1] https://html.spec.whatwg.org/multipage/grouping-content.html#ordinal-value Bug: 591099 Change-Id: Ia61ee764db83203ac8a4006cbab534b5ccf56606 Reviewed-on: https://chromium-review.googlesource.com/678415 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#504338}
-
Yutaka Hirano authored
async_test can be executed out of order, which leads to flaky console output. This CL splits the file to avoid the issue. Bug: 705125 Change-Id: I3dda81b84e05a6c50e786030d1a883e085fb80a0 Reviewed-on: https://chromium-review.googlesource.com/677165Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#504337}
-
Henrik Kjellander authored
It's no longer used and the same functionality can be accomplished by adding variable defaults to the .gn default_args dict. Bug: 768723 Change-Id: I5f6723c2831fb0a5c9eba24ba53b3152ed3c8352 Reviewed-on: https://chromium-review.googlesource.com/684175Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#504336}
-
Tatsuhisa Yamaguchi authored
The button currently says the mode after view change, like "thumbnail view". It is not clear if it's current mode or the other mode. This was especially confusing when using screenreaders. Bug: 755271 Change-Id: Ie305971a32224d6ea715df5ab0fc1e0dd6e2aa91 Reviewed-on: https://chromium-review.googlesource.com/684096Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504335}
-
Andrey Kraynov authored
Inside Editor.cpp expression |GetFrame().Selection()| used at many call sites and can be replaced by shortnamed helper. No changes in behavior. No new tests. Bug: Change-Id: I906eeea10e9e5e9a303c27a8fdc29b6e738eeaa8 Reviewed-on: https://chromium-review.googlesource.com/667378 Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504334}
-
Naina Raisinghani authored
Given sample css as follows: .foo::before { display: inline; content: attr(bar); color: red; } We can now parse the content of the .foo::before block. We maintain whether or not the block to be parsed has ::{before,after} in its prelude on CSSLazyParsingState If the block's prelude has ::{before,after} and the properties in the block contain CSSPropertyContent, we update invalidation sets for that block and mark the CSSGlobalRuleSet as dirty. The document will then update the CSSGlobalRuleSet. Bug: 642722 Change-Id: Id6094fbb201b4eb3463ddd34dce32f09c4c1478b Reviewed-on: https://chromium-review.googlesource.com/662084Reviewed-by:Rune Lillesveen <rune@opera.com> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#504333}
-
Yuta Kitamura authored
This patch separates the ability to supplement missing traits functions from Complete*d*ContainerTypeOperations<T>. It turns out the upcoming changes will require the ability to complete arbitrary ContainerTypeOperations implementations, not just ContainerTypeOperations<T>. BUG=715430 Change-Id: I49828fd8e8f68ff97eb5f5117e6bdf0351ddcc9b Reviewed-on: https://chromium-review.googlesource.com/681534Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#504332}
-
Patrik Höglund authored
The fix is now in the Firefox nightly; verified the test passes locally. Depends on https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/3401. R=ehmaldonado@chromium.org Bug: 751211 Change-Id: I191db39747711b09a0c36e367e8e08fac0c53ea5 Reviewed-on: https://chromium-review.googlesource.com/681701Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#504331}
-
Michael van Ouwerkerk authored
* Capture the default thumbnail. * Scroll down to first card. * Scroll down to more button. Bug: 761813 Change-Id: I168833ee7abb3519504eb6ec93465257ecaffc2c Reviewed-on: https://chromium-review.googlesource.com/681476 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#504330}
-
Mikhail Pozdnyakov authored
This CL makes WTF::Vector::erase() semantics identical to the stl::vector::erase(), i.e. it accepts an iterator and returns an iterator. Rationals: 1) This semantics is expected by developers 2) Compatibility with std algorithms, e.g. auto it = std::lower_bound( sorted_vector.begin(), sorted_vector.end(), item); active_frequencies_.erase(it); 3) Allows to create template classes (e.g. algorithms) theat call erase() and can operate with both WTF and std vectors. The old version of WTF::Vector::erase() is renamed to WTF: :Vector::eraseAtIndex() Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2677541d3ed188d89035c6a11a0312d5cd248080 Reviewed-on: https://chromium-review.googlesource.com/620649Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#504329}
-
Vitalii Iarko authored
Due to Chrome Home, we have multiple features, which are enabled conditionally on Chrome Home. This was achieved by having helpers checking both features. However, these helpers were not available outside of the factory. In this CL: 1) Move these helpers into a separate file |dependent_features.{h,cc}| 2) Use the moved helpers in snippets_internals 3) Disable ForeignSessionsProvider in Chrome Home 4) Add a comment to components/ntp_snippets/features.h to not depend on these features directly. Bug: 754260 Change-Id: Idf91f8a934c94048b0de1be459fe6004396e12a8 Reviewed-on: https://chromium-review.googlesource.com/681515Reviewed-by: -
Dominik Röttsches authored
When a run ended in a grapheme cluster consisting of a least two characters, and this grapheme resulted in not being shaped with the current font and needed fallback, then the full run from the beginning was incorrectly rendered in the fallback font. This is because one state transition between shaped and not shaped was not recognized, as the last_change_position had been advanced too far. To fix this, I clarified the shaping loop and moved the logic for commiting glyphs and queueing characters for reshaping into separate functions. When reaching the end of the glyph run, transitions between shaped or unshaped are detected for the last grapheme cluster and added to the ShapeResult or the reshaping queue accordingly. inspector-protocol/layout-fonts/prefix-fallback-multi-character-grapheme.js svg/text/combining-character-queries-expected.svg Bug: 758380 Tests: EmojiZWJSequence in HarfBuzzShaperTest.cpp, Change-Id: I95d536c488ac602cb4bdfd4e1ac4a729f92b1462 Reviewed-on: https://chromium-review.googlesource.com/657977 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: -
Andrey Kraynov authored
It seems that after https://codereview.chromium.org/2566583002 it isn't needed anymore. No change in behavior. Bug: Change-Id: I9676e8e98a8d289e84ac65c34614e0f3d18c2767 Reviewed-on: https://chromium-review.googlesource.com/590247Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Matt Giuca authored
Previously it would DCHECK if any share target in the Preferences file had a blank or invalid manifest URL, which could be caused if the share target was previously installed using an app banner. Since this is corrupted user data, we should recover, not DCHECK, in these cases. Also adds a DCHECK to catch cases that would write this corrupted data into the preferences. This doesn't yet fix the issue, but it does report it to developers. The DCHECK only fires if the manifest has a share_target and the --enable-experimental-web-platform-features flag is enabled (so it won't be too annoying). Bug: 762388 Change-Id: Ibd800dc529510d4755068f7bb0c55f8ca083bc7e Reviewed-on: https://chromium-review.googlesource.com/652011 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Matthew Cary authored
crrev.com/c/668373 seems to have eliminated the flakiness of NoStatePrefetchBrowserTest.AppCacheRegistered on linux and windows platforms. This CL renables the test on Mac as well. Bug: 733504 Change-Id: I0bae4b3eea4220dc70e8189b4c3b20bde1d4e754 Reviewed-on: https://chromium-review.googlesource.com/684334Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#504324}
-
Friedrich Horschig authored
The mock data contains no favicon URLs and mislead several testers to believe that the icons wouldn't work. As there is already real data available (by setting country to IN and version to 6 in chrome://ntp-tiles-internal), we should just drop the test data. Alternatively, we could also add favicon urls. Change-Id: I6fadf9b89d82d094ae0a7b152a4696238d877e94 Reviewed-on: https://chromium-review.googlesource.com/682054Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#504323}
-
Mike West authored
Intent to Deprecate: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/0sJ8GUJO0Dw/iMmcXLIGBAAJ Bug: 767813 Change-Id: I29868952df3e9c8d5cef85fa39c43a85d850b9e9 Reviewed-on: https://chromium-review.googlesource.com/678723 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#504322}
-
Owen Lin authored
The callback is used for only once. There is no need to keep it in the callback map. Bug: None Test: None Change-Id: I0a40faa323b1c9f98ad05f15bcb8451fe28041c2 Reviewed-on: https://chromium-review.googlesource.com/683915 Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504321}
-
tzik authored
The upcoming unification of WTF::RefCounted and base::RefCounted causes compile errors around AdoptRef, Bind, Passed due ADL. This CL converts them to fully qualified names before it happens. Bug: 763844 Change-Id: Ib2361e02e70de193f3b6d0401ff626426d0a162c Reviewed-on: https://chromium-review.googlesource.com/684095 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/030de5515608..639e972bf15c $ git log 030de5515..639e972bf --date=short --no-merges --format='%ad %ae %s' 2017-09-25 yukiy Add tab.StopAllServiceWorkers() Created with: roll-dep src/third_party/catapult BUG=736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7e1d0b5fa661a50b05e839ccce96b4b732f7936c Reviewed-on: https://chromium-review.googlesource.com/684194 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504319}
-
Mattias Nissler authored
This reverts commit 2ade99c3. Reason for revert: Breaks compile on Closure_Compilation_Linux, see https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClosure_Compilation_Linux%2F120458%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Add TPM firmware update option to about page. > > BUG=chromium:742985 > TEST=New webui test case in CrSettingsAboutPageTest.AboutPage > > Change-Id: Ie5d5d4f61efb56aa8fe61988bfdbdc44450a34b7 > Reviewed-on: https://chromium-review.googlesource.com/678728 > Commit-Queue: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504315} TBR=xiyuan@chromium.org,stevenjb@chromium.org,mnissler@chromium.org Change-Id: I974a2ff1b144fc912444d41d98c6421270f81987 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:742985 Reviewed-on: https://chromium-review.googlesource.com/684374Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504318}
-
Akari Asai authored
Modify HandleElementNode() and add HandleChildren() to make SelectionSample Parser traverses on DOMTree with shadow contents. testing/SelectionSample.{cpp, h} is a utility class for C++ to take HTML style inputs with template tages,build a pure DOM tree with shadow roots and return the shadow dom tree. This patch modifies HandleElementNode() and HandleChildren() in this SelectionSample to make SelectionSample Parser traverses over a DOM tree with single or multiple shadow roots, since the current implementation assumes the dom tree doesn't have any shadow root, and only traverse over body content. This change is for making SelectionSample class to take HTML style inputs with template tags. This patch also add some tests to check if SelectionSample actually traverses over a DOM tree with single or multiple template tags, template with slots. Bug: Change-Id: Id3e1935335a3468ed39ec2e0a65c0bca4e07657e Reviewed-on: https://chromium-review.googlesource.com/671165Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Akari Asai <akariasai@google.com> Cr-Commit-Position: refs/heads/master@{#504317}
-
Philip Jägenstedt authored
fullscreen-pseudo-class-manual.html is written in such a way that the failure message still prove that it works, except that like :-webkit-full-screen it doesn't match an inner fullscreen element when nested. This will be fixed separately. Bug: 402378 Change-Id: I556d0dbd868119da309456cce6c9b3a08cf7b40f Reviewed-on: https://chromium-review.googlesource.com/681356Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#504316}
-
Mattias Nissler authored
BUG=chromium:742985 TEST=New webui test case in CrSettingsAboutPageTest.AboutPage Change-Id: Ie5d5d4f61efb56aa8fe61988bfdbdc44450a34b7 Reviewed-on: https://chromium-review.googlesource.com/678728 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504315}
-
Marc Treib authored
This reverts commit fed2d25e. Reason for revert: Breaks compile on chromium.webkit Android Builder: https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/121292 Original change's description: > Basic image content based approach added to HighContrastImagePolicy. > > To correctly decide if an image should be inverted or not for high- > contrast view, a very simple classifier is added under kFilterSmart > HighContrastImagePolicy and the decision on an image is stored in the > blink::Image objects for next references. > > Bug: 685242 > Change-Id: I47242c237e7f34291bba53a7a02a9d6c9ef632a1 > Reviewed-on: https://chromium-review.googlesource.com/654644 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504305} TBR=dmazzoni@chromium.org,chrishtr@chromium.org,rhalavati@chromium.org Change-Id: I181904195ec796271c14b1e1664ed0c575c5214c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 685242 Reviewed-on: https://chromium-review.googlesource.com/684314Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#504314}
-
Marc Treib authored
This reverts commit 5b37246c. Reason for revert: hover-after-affected-by-change.html consistently fails on WebKit Linux Trusty Leak: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak Original change's description: > Store new ComputedStyle object if style did not change. > > The comparison of ComputedStyle does not take additional flags into > account. For instance, the AffectedBy* flags used for updating pseudo > classes like :hover. We used to call SetStyleInternal, but this was > removed because the previous comment said it was because of style > sharing which is now removed. > > The display:contents case (768406) never worked because the code path > for StoreNonLayoutObjectComputedStyle() was always skipped when > computed style compared to be equal. > > Bug: 768406, 767832 > Change-Id: Iac4708e3cd3a6451d99c1bb2bb69efb74289b8eb > Reviewed-on: https://chromium-review.googlesource.com/681755 > Reviewed-by: nainar <nainar@chromium.org> > Commit-Queue: Rune Lillesveen <rune@opera.com> > Cr-Commit-Position: refs/heads/master@{#504285} TBR=rune@opera.com,nainar@chromium.org Change-Id: I34a54b694bb719b278426f9a76076fa77cd9e82f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768406, 767832 Reviewed-on: https://chromium-review.googlesource.com/684275Reviewed-by:
-
Doug Turner authored
Bug: None Change-Id: I434055fd471e6fcd3579999df7379c42313133ec Reviewed-on: https://chromium-review.googlesource.com/683834Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#504312}
-
Doug Turner authored
Bug: 703369 Change-Id: Icbab14a1d81201cde6d21a9ccf73e6ac9bd0286a Reviewed-on: https://chromium-review.googlesource.com/678439Reviewed-by:
-
Rune Lillesveen authored
We used to update counters on every layout as long as there was at least on LayoutCounter in the rendered document. Also, the update was triggered by marking the changed element for layout. We need to update counters when we add/remove LayoutCounter, or when computed counter directives change on rendered elements during style recalc. We update counters immediately after style recalc and layout tree rebuild in Document::UpdateStyle(). Bug: 768357 Change-Id: I32693fefaa7bdb74cf959ef5ead4256d2ec2d0da Reviewed-on: https://chromium-review.googlesource.com/678676 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Marc Treib authored
...and into BrowserInstantController. This reduces the number of "Instant things" that Browser has to know about from 4 to 2. Bug: 627747 Change-Id: I1d9dbfe37bda88e59ce6fa4759f8b3a8428eaacc Reviewed-on: https://chromium-review.googlesource.com/678502Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Dominick Ng authored
The required icon sizes for adding a site to homescreen or desktop are constants per platform. However, for legacy reasons, these sizes are currently passed as parameters to InstallableManager::GetData. This requires every caller of InstallableManager to know about icon sizes, which isn't really necessary since every caller uses the same sizes on desktop and on Android. This CL consolidates all installable icon size specifications in InstallableManager. Custom icon sizes can no longer be requested. BUG=767767 Change-Id: Iee36e14854b3dd80d597e0c0d9370b6ebea46911 Reviewed-on: https://chromium-review.googlesource.com/678695 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#504308}
-
Yoichi Osato authored
Bug: Change-Id: I918ea9781189c3aeba223e4ef0af7085e4e78c19 Reviewed-on: https://chromium-review.googlesource.com/683975Reviewed-by:
-
Mike West authored
koto@ added [`TrustedScriptURL`][1] to the explainer as a mechanism to distinguish URLs that directly lead to script execution (e.g. via assignment to `<script>`'s `src` attribute). This patch is a first pass at an implementation, along with restrictions on `script.src` so we can test it out. [1]: https://github.com/mikewest/trusted-types/commit/834163e519b579e5566908cafcedb2efe24be6da Bug: 739170 Change-Id: Ie784ff3992dbcf750521fd55710befe3ed26036c Reviewed-on: https://chromium-review.googlesource.com/677390 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#504306}
-
Ramin Halavati authored
To correctly decide if an image should be inverted or not for high- contrast view, a very simple classifier is added under kFilterSmart HighContrastImagePolicy and the decision on an image is stored in the blink::Image objects for next references. Bug: 685242 Change-Id: I47242c237e7f34291bba53a7a02a9d6c9ef632a1 Reviewed-on: https://chromium-review.googlesource.com/654644 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#504305}
-
Daniel Bratell authored
The two implementations of ToV8 for testing collided in jumbo builds so to avoid having to exclude some files in bindings tests from jumbo this patch moves the template to a shared header. Bug: 745732 Change-Id: Iaa7cf7e19d987e7a048fc606eafaedb49606959a Reviewed-on: https://chromium-review.googlesource.com/677394Reviewed-by:
Jens Widell <jl@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#504304}
-
Yafei Duan authored
Fix msan test. TBR=fgorski@chromium.org Bug: NONE Change-Id: I1a8083af308fc0869e0f20d22155d6a97f986f5e Reviewed-on: https://chromium-review.googlesource.com/683601 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#504303}
-
