- 27 May, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7228caa9292..d81fad6de554 2020-05-27 wolfi@chromium.org Reland "Port IssuesModel to TypeScript" 2020-05-27 tvanderlippe@chromium.org Fix es_modules_import to handle `.mjs` files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic2d37587ec471a350de26b3da531b5cfc7c9da60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218327Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772247}
-
Vladimir Levin authored
This patch removes style containment checks from stacking context computation since whether containment has an effect depends on the type of layout object created: - Rename ComputedStyle::IsStackingContext to IsStackingContextWithoutContainment. - Remove containment checks from UpdateIsStackingContextWithoutContainment. - Add LayoutObject::IsStackingContext/IsStacked that checks. style values without containment and also containment values that apply. - Updates code to use the new functions where appropriate. R=futhark@chromium.org, pdr@chromium.org Fixed: 1068596 Change-Id: I6bc09d8e1087394227a1bf2cee8d7c9c69b0ac7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204316 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772246}
-
David Van Cleve authored
I guess the French TV I've been watching recently has had an effect on my spelling. TBR=csharrison Change-Id: I6fea013a281ec9675ab7071f480653ce1809c7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217728Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772245}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/014197b581a3..df95f5d43f28 2020-05-27 danilchap@webrtc.org Add parametrized unit tests for av1 to check scalability structures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f13bc411be686e94f247af1409b26d82a7a94d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214060Reviewed-by:
-
Wez authored
When the Frame used by a web-based component self-terminates, the web component will now report the status code passed to the channel's error- handler as the component's OnTerminated() exit-code. The Frame implementation is updated to close the channel with ZX_OK if the web content itself triggers teardown (e.g. via window.close()). In addition to reporting the exit-code via OnTerminated(), instances of CastComponent will report the exit-code to their ApplicationContext. Bug: fuchsia:51028, b/148594115 Change-Id: Ib3543782d81e276372f9163e4c2e51454f9fc280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207389 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772243}
-
Reilly Grant authored
This may be the first time that a function from Netapi32.dll has been called and so the dynamic loader lock may be held while this library is initialized. Since this call occurs on a low priority background thread this can cause other threads which need to load libraries or look up function addressed to hang while they wait for the lock. Noticed in crash/b4a7bd8445afe9f3. Bug: 973868 Change-Id: I6604971ac9d95f626690ed043141631d5a907995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216716 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772242}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fffa2ecdc7fc..609c36d7e6ea 2020-05-27 fmayer@google.com Use SOCK_CLOEXEC when possible. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2753b4e1c20f22d264472fc1d1391183d8c7efae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214059Reviewed-by:
-
Jihwan Marc Kim authored
Disallow duplicate payment method identifiers as specced in https://github.com/w3c/payment-request/pull/908 Bug: 1085712 Change-Id: I9cb2d8d0960f248d1cbad83140ba6d6be92fbbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214868 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772240}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0edc2a3f0892..3c1f483205d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jdoerrie@google.com Change-Id: I2ae4b83082c575a928005241bac92de4091eaf90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214056Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772239}
-
Balazs Engedy authored
On Android, add a `Learn more` link to the abusive flavor of the quiet notification permission infobar. Bug: 1086518 Change-Id: I8843a0514acb4286821e9e7819744bc40b78dfb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216078Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772238}
-
Hiroki Nakagawa authored
This CL adds following UMAs for navigation requests. PageLoad.Experimental.NavigationTiming.* - NavigationStartToFirstLoaderCallback - NavigationStartToNavigationCommitSent - FirstResponseStartToFirstLoaderCallback FirstLoaderCallback is the timing that the loader callback was invoked for the first time. NavigationCommitSent is the timing that navigation commit message was sent to a renderer process. We decided not to add FirstLoaderCallbackToNavigationCommitSent that does not seem very useful. Instead, we are going to add LastLoaderCallbackToNavigationCommitSent in a separate CL. See the design doc for more details about these UMAs: https://docs.google.com/document/d/16oqu9lyPbfgZIjQsRaCfaKE8r1Cdlb3d4GVSdth4AN8/edit?usp=sharing Bug: 1068843 Change-Id: I23b83da68c2ce0a2ec9c856675737225d347a32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198528 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#772237}
-
Gauthier Ambard authored
This CL adds the CriOS tag + the major version to the User Agent used to request the desktop version of websites for Chrome. It also don't change anything for the other embedder of ios/web. Bug: 1083999 Change-Id: Ief1bd073d4a664e3f02a3b3459ea34bd35152558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207314Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#772236}
-
Jan Wilken Dörrie authored
TBR=petermarshall Bug: 1046784 Change-Id: I53b500ac0a602fc509bac5a1f49a061ded4ee876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218268Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772235}
-
Rohit Rao authored
BUG=1086653 Change-Id: Id91956ebcf96d1058e987b025c3dddc6620916de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216590Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772234}
-
Nate Fischer authored
No change to logic. This adds 'android_channel' to the AOSP integration doc, since the default no-channel build is typically meant for local developers. Fixed: 1085710 Test: Upload to gerrit > open file > click "gitiles" Change-Id: If45f36523a9b01315815257467bfd52c54bcf7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213926 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772233}
-
David Van Cleve authored
I accidentally included a VLOG statement from local debugging in a prior change; this CL removes it. R=jbroman Bug: None Change-Id: If942046836e306696547e163c18c6a0d84f5805b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218229 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#772232}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=torne@chromium.org Bug: 1026641 Change-Id: I6b36b810dac8ee0af5b4c80f46b24d5505bacd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217202 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
-
Reilly Grant authored
An upcoming lint check will flag calls to toLowerCase() that do not specify a locale. Since these strings are being compared to those entered by the user the default locale is used. Bug: 1085466 Change-Id: I4cbc60d99b02d34f741947c2ec8bd719b8843253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216684 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#772230}
-
Alice Wang authored
This CL fixes the ConfirmSyncDataStateMachine crash related to the DialogFragment update to androidx. Bug: 1083833 Change-Id: I7f78f491f1b8e66668b1f5552c1483ac68c48624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216070 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772229}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590522742-b76e1162c3da480ee6f6075020dc3e74b538d7b3.profdata to chrome-win64-master-1590580498-39ab72543da7a96a4f695b1a54bce8558b65f184.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If31a9601813b30ec290885dcad03d6b68c9a26e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214057Reviewed-by:
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: Icc977b9c8bbfaba8c322a82ff6388886aee83941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212997Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772227}
-
Bruce Long authored
Some languages (Chinese, Japanese, ...) have no Windows or Hunspell dictionary support, but a user will often have English spellchecking enabled. In this case, when Windows spellchecking is enabled, all editable content composed in the unsupported spellcheck language will be red squiggled as misspelled, since the words aren't recognized by the Windows spellchecker. This is a pretty ugly experience and differs from what was seen when there was only Hunspell. The fix is to check if a word that is flagged as misspelled by the Windows spellchecker is written in a script associated with any of the enabled spellchecker dictionaries (either Windows or Hunspell). If not, ignore the word as a misspelling. Bug: 1076677 Change-Id: I072a783d84a981e8f5f0316e8957d7ab93979ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210796 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#772226}
-
Akihiro Ota authored
Bug: N/A Change-Id: I41626e917bf140bc6f13cd47910b8c452af70fd2 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216370Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#772225}
-
Anastasiia Nikolaienko authored
Move account_manager_* and account_migration_* files to ui/webui/chromeos/account_manager. Bug: 1083147 Change-Id: I2f61237cf4b781a8ddd0ed8837e690e7f59adac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207226 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#772224}
-
Charlie Hu authored
FeaturePolicyFeature::kStorageAccessAPI is present in feature_policy_feature.mojom and feature_policy.cc, but is missing in feature_policy_features.json5. This CL sync storage-access-api to feature_policy_features.json5. Change-Id: Iad1a20a59fe8c08fa39e93fb661d89bfed7987ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210735Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#772223}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f9826008618a..4a81e3dba0fd 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 79dcb2a5abbd to 9e718f962f87 (1 revision) 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 9cb2571a184c to d3d89bb90cbd (2 revisions) 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 3e390a159761 to 006586926ade (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I49ecb58d2dab2eac998c4cf60d9909b9e870dedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214050Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72edaabd..d0a8b04f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a5dc8e8f03a25c5d9ad2bafb78ad45534624678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217869Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772221}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590566295-b6fe751361b0ee5373100e3cddc0b82fdbd8c8ba.profdata to chrome-win32-master-1590580498-31d289ff4006e295949604b3b99c516a32499368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic826470e765ff0a4a5732bf8d3dc1b867147e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214058Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d4ee009038b..b7228caa9292 2020-05-27 changhaohan@chromium.org e2e test for media query inspector; add canDock option in ReloadDevTools 2020-05-27 pfaffe@chromium.org Remove protobuf dependency in the symbol server 2020-05-27 janscheffler@chromium.org Enable TypeScript for DOMDispatcher 2020-05-27 alexrudenko@chromium.org Position object popover after live location is updated 2020-05-27 kimanh@chromium.org Remove 'this' from local scope for wasm debugging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1043034,chromium:1069467,chromium:1079233,chromium:1082696,chromium:1086159 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6e12ce181b8685034b3a96ffa6a879f76cdbe490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214054Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ba864348bde..1303a1a15c88 2020-05-27 bryct@amazon.com Fix CanvasKit generated documentation to work with emscripten 1.39.16. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I153a93c01fd22a8e786fa27dac8af2b9ac21dae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214053Reviewed-by:
-
Nicolás Peña Moreno authored
UKM collection review: https://docs.google.com/document/d/1ZaqRqI2c6LiRTrT12f8RLhuzpT-NQ5mkSLoFN5RzZ7c/edit# Bug: 1086681 Change-Id: I2a54e4e54694377cebcc48b6c538118b803b5680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216677Reviewed-by:
-
Maksim Ivanov authored
Change-Id: I0495931f6b8826f2668b08a95ca06449d0df8cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215860 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772216}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for TraceImpl. Move TraceImpl implementations into different nested classes and select implementation using std::conditional. Bug: 819294 Change-Id: I8feea5f2aa6e1f87daad61f496d6b53b1bbc49ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217887Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#772215}
-
Sylvain Defresne authored
Recent changes to this value demonstrated the value of having all the bots provide an explicit value (avoid breaking them when the default is changed). Bug: 1086389 Change-Id: I89902abe5d0e2b69931ce7396efca0c8fc884265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214549Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772214}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e309651f3330..014197b581a3 2020-05-27 danilchap@webrtc.org In modules/ replace mock macros with unified MOCK_METHOD macro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6adf7f51fade73d1659a3a513c0f4ff4813c9f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214052Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I89dfd3a21537a537c8953e5953760ab10c204553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215187Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772212}
-
Jan Wilken Dörrie authored
Following the rename of `autofill::PasswordForm::origin` to `url` this change renames the `origin` fields of PasswordStore::FormDigest and autofill::PasswordFormFillingData to `url` as well. Furthermore, this change also renames PasswordFormManagerForUI::GetOrigin() to PasswordFormManagerForUI::GetURL(). Bug: 1081389 Change-Id: I907f85711f773518bbacfbb1f142ee1c344da29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207113 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
Bug: 1082234 Change-Id: I6c5c8c7ce492f99fb1c27ff31179684a8e2bf213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199147 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#772210}
-
Richard Knoll authored
This class manages the lifetime and profile affinity of the sandbox process that runs Nearby Connections. Only one instance of the process will run at a time and it will be associated with one profile only. A profile can be set as the active profile (usually via an explicit user action) after which it gets access to the mojo interfaces running in the sandboxed process. Bug: 1084576 Change-Id: I50c8c61e1b7b85a078f4fdea96e0ecda1ac57123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196486Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772209}
-
Leonard Grey authored
This reverts commit 8cc706be. Reason for revert: (Sheriff) "checkdeps" failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/90719 Looks like a few files still include these Original change's description: > Remove 'ash/keyboard/ui/public' from DEPS files. > > It no longer exists. > > Change-Id: I4f6f08d6b2ae3c3bdafccf71b03f91e6d68bc47b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215547 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772190} TBR=thakis@chromium.org,yhanada@chromium.org Change-Id: I47b2aef7e5cc21dcac92311aca4a377968103780 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218248Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772208}
-
