- 19 Sep, 2020 40 commits
-
-
Renjie Tang authored
This will be used to understand why exactly did packet serialization failed. Change-Id: Idf12365e50301c07f8d4d82974ec80e2a160f339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419716 Auto-Submit: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808646}
-
Michael Thiessen authored
Fix autotest so autotest.py -C <dir> /CurrentPageVerifierTest.java won't run tests for other classes like WebApkCurrentPageVerifierTest Change-Id: I0370b507ac21009676d9e27c109b90d7223b7ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419267 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808645}
-
Hwanseung Lee authored
the menus used a checkbox to change value. it is more user-friendly to use switch-toggle in this case. Bug: 1112076 Change-Id: I0621f3e5d8382a4272c844158673113bc8ec1f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398033Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#808644}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fbab23e18687..d79db25910ff 2020-09-18 jmadill@chromium.org Vulkan: Optimize Attribute Change Perf (3/5) 2020-09-18 jmadill@chromium.org Test Runner: Fix sharding and --bot-mode. 2020-09-18 jmadill@chromium.org Vulkan: Optimize Attribute Change Perf (2/5) 2020-09-18 jmadill@chromium.org Vulkan: Optimize Attribute Change Perf (1/5) 2020-09-18 ianelliott@google.com Vulkan: Additional "invalidate" white-box tests 2020-09-18 courtneygo@google.com Vulkan: lock around accesses to mSharedGarbage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Test: Test: DrawCallPerfBenchmark.Run/vulkan_attrib_changeTest: Test: angle_unittests with --bot-mode, sharding, and filter Change-Id: Ia4bae6088f2a770e52175bd3a65b4a4a21ce7c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808643}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4a7d9d9c. With Chromium commits locally applied on WPT: b943d006 "[COOP] Access reporting with 2 reporters." 82ad19e1 "sensors: Cleanup iframe-related tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia84e3447511b25b5a72c25da14209f0d9b9cb6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419480Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808642}
-
Eliot Courtney authored
The mojo file uses an optional, and also avoids use of base::Optional by using nullable_is_same_type. SetNull is defined for GpuFenceHandle StructTraits, but not IsNull. This still compiles, however. Define both methods here to avoid trouble. Bug: 1129680 Test: lacros runs Change-Id: I4d2dbdf83a293062c25f57ce76e573bec832ee51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416155Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#808641}
-
Kunihiko Sakamoto authored
FirstMeaningfulPaint is deprecated in favor of LargestContentfulPaint. We cannot completely remove FirstMeaningfulPaint yet, but this derived metric (added for crbug.com/729951) is not actively used and can be removed. Bug: 1117109 Change-Id: I86178ad03c92711df3575b5181deb991e05674c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415748Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808640}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600451996-5d0e4e7b2c6ce44a4ee6fbde79bf678531b4af8e.profdata to chrome-linux-master-1600473589-0284648b60b048a9480df82252a20ea2669cd66b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ie649141899f40ae467c056a16da94fc26376c684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419784Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1da25e510364..dcd37fa4f476 2020-09-18 enga@chromium.org Rolling 5 shader dependencies 2020-09-18 enrico.galli@intel.com Handle debug markers commands on command encoder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I8b3e31530689c31fe1600ad5949ab8cc3260bbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419814Reviewed-by:
-
Simeon Anfinrud authored
Some downstream chromecast code intends to use this. Bug: None Test: build with downstream patch Change-Id: I1d8c71ea236160a95d105a1aa82787b1091b0cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419508 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL makes the feature_compiler support non-default toolchains by avoiding assuming that the gen directory is always gen/. Bug: 1129223 Change-Id: I2a361cbb1ce4a220fca03c8db6457f2fb03d81d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419815 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#808636}
-
Andrey Kosyakov authored
Bug: 1116444 Change-Id: Ic50dfc144f8024870131e7586b9dce2dff591e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419712Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808635}
-
Yulun Wu authored
Bug: 1110766 Change-Id: I2da47ccab1bdb00274ab2224c40efd3a137a5f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417241Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808634}
-
Yuke Liao authored
This CL supports user provided ash-chrome to make it easy to test crosapi tests that depend on changes made in ash-chrome side. Bug: 1129223 Change-Id: I1be43c760222ed25f0423e7ca05c5e6965441ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415220 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#808633}
-
Min Qin authored
This CL implements the time decay for tile score. The equation is score = original_score * exp(-0.099 * time_passed). BUG=1096224 Change-Id: Id623232a7510f2ca63f854e75846bc6119fdba03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417497 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808632}
-
Jonah Ryan-Davis authored
Because OS_LINUX includes OS_CHROMEOS, passthrough was accidentally launched on ChromeOS by default. This was eventually refactored to explicitly include OS_CHROMEOS, but we want to exclude that. Bug: chromium:976283 Bug: chromium:1095700 Change-Id: I61f83056f91a174352cdddabce1d35b70ee3728a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419541Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#808631}
-
Meilin Wang authored
This CL adds the connection error UI that pops up when the Phone Hub feature is not available due to connection issues. Remaining work includes implementing the button click handler. Demo: https://screenshot.googleplex.com/6VSGgicU284Z4Ts.png Misc: updates the comment for |PhoneHubInterstitalView|. BUG=1106937,1126208 Change-Id: I12c05c2bf47dd017af801874170aba29aa3554c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417296 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808630}
-
Sergey Ulanov authored
crrev.com/808041 disabled SkiaRenderer on all low-end devices. This broke graphics on Fuchsia (low-end devices with Vulkan is enabled). That change was Android-specific, so it doesn't make sense on Fuchsia. Moved corresponding code to #ifdef OS_ANDROID, so it doesn't break other platforms. TBR=backer@chromium.org Bug: 1126490, 1130036 Change-Id: I10842de84e64eca16d8e904b3b1139ca7ad5abdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419555Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808629}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/788480dcff70..14dbf82961c3 2020-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ed1b071..f294a94c (808365:808500) 2020-09-18 titovartem@webrtc.org Move SampleStatsCounter to public API 2020-09-18 sprang@webrtc.org Fix flag parsing for lazy pacer starting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I74667abab796865f5e828fa54a99f868241ddcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419628Reviewed-by:
-
chinsenj authored
As a part of making the window cycle list more interactive, mouse behavior has been added. This CL adds to this ongoing effort by making user clicks outside of the list close it. MousePressOutsideOfListCancelsCycling Test: InteractiveWindowCycleControllerTest. Bug: 1067327 Change-Id: I25b3696a96ff5834a68bc503ed805a005b52e4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414125Reviewed-by:Jun Mukai <mukai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808627}
-
Aaron Colwell authored
Removing is_empty() method and updating callers to use the explicit lock state methods is_invalid/allows_any_site/is_locked_to_site instead. Bug: 1085275 Change-Id: Id08adaca960368de16943710c5a35c9a6fb5a350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414764 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#808626}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1e4781e5ec2..5a2819e1a971 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fdegans@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1077274,chromium:1085419,chromium:1085603,chromium:1099917,chromium:1099982,chromium:1105693,chromium:1109276,chromium:1117068,chromium:1117069,chromium:1117244,chromium:1126301,chromium:1126891,chromium:1127088,chromium:1128632,chromium:1128770,chromium:1128990,chromium:1129342,chromium:1129402,chromium:1129540 Tbr: fdegans@google.com Change-Id: Ia977b3d5dd2347c9f8589db0e469b3f573e159e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419773Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808625}
-
Yuke Liao authored
These proto files are generated per toolchain, so this change makes the action work correctly when compiled inside a non-default toolchain. Bug: 1129223 Change-Id: I3d040de0f264f92b63e3aa44c63d9f43578ddb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419696Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df123b290f75..244d77022cb2 2020-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I80b8effb211c490a47f3ab7a92f0954087a5be40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419627Reviewed-by:
-
Yuke Liao authored
libmojo_core.so is generated by the a shared_library rule, which always outputs the .so file inside: ${root_build_dir}/${toolchain_used_to_compile} directory. Bug: 1129223 Change-Id: Ib2937510363ccc4db7df09d000d260d344aed4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419149Reviewed-by: -
David Maunder authored
In backShouldCloseTab we should not try to close the Tab if the Tab is not initialized. Bug: 1117396 Change-Id: I7ef0b4e50315ddc9560b438c66a7f66161c5e1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410920Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#808621}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/31d58940..80dc1e80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I93b541c612609ea2142019bc9a219c2684e42f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419475Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808620}
-
David Schinazi authored
This change cleans up the codebase and prepares us for using multiple versions in DefaultSupportedQuicVersions(). Our current plan is to eventually set it to (h3-29,h3-Q050) if our latest experiments in Stable go as planned. R=renjietang@chromium.org Change-Id: Ie1f6b35b42df07f65a8d800616e8f34427282913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419150 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808619}
-
Moe Ahmadi authored
Frequency component must be multiplied by recency decay in numerator. See: http://shortn/_bW5Qq2zTHM Bug: 1096615 Change-Id: I5138dce685607c44289dcab8b42a22968fc8ea0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419533 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808618}
-
Daniel Murphy authored
The WebAppProvider can be uninitialized. Dependencies should use the on_registry_ready() signal. This change is a quick & mergeable fix for a related crash, after which the codepaths will be turned async if possible. TBR-ing dominick so this change can get a canary roll, and they can look at it when they get in on Monday. Patch is very low-risk - resolving crash when there used to be a crash. R=pwnall@chromium.org TBR: dominickn@chromium.org Bug: 1129921 Change-Id: I57c6d4f181f28c178df85c60626423a5619f9494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419537 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808617}
-
Sophie Chang authored
Bug: 1086227 Change-Id: I6e144c0d858e88206b768293ca237d5aa56efc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417532 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#808616}
-
Yuke Liao authored
out_camera_app_dir is constructed by: 'out_camera_app_dir = "$root_out_dir/resources/chromeos/camera"', which already has a toolchain name inside the path if compiled by non-default toolchain. 'out_camera_app_dir' in the grit_flags is supposed to be relative to the target_gen_dir according to grit_rules.gni, therefore, when rebasing, it needs to be rebased against root_out_dir instead of root_build_dir so that the toolchain name bits can be stripped off. Bug: 1129223 Change-Id: Ib2a5bf62f2f5957613398e03e20402c95896801e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419658Reviewed-by:
-
Brian Sheedy authored
Sets --expected-vendor-id for info_collection_tests on the ARM-based Mac DTKs, as we don't currently request a specific GPU for tasks and thus cannot determine it automatically during JSON generation. Bug: 1105656 Change-Id: I0f9a527bb1797dcc8af293b6fed9405bae9732dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419542 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808614}
-
wutao authored
Changes: 1. When get settings fails, we will use backoff policy until max retries. 2. However, we will request settings immediately if the request is called from Settings UI. Bug: b/152921891 Test: added new tests Change-Id: Ied3f02b7dcb24d6fb95b528bac932987b9ee3ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410299 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#808613}
-
David Maunder authored
Bug: 1060181 Change-Id: I57ab52c6a8113370829a902d53a1544e9a6a0cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382734Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL supports also_build_ash_chrome arg to allow building ash-chrome in an alternate toolchain. A few other fixes are required to work, but they will be landed in separate CLs because they could affect existing builds, so landing them separately will make it easier to reason and detect potential breakages. Bug: 1129223 Change-Id: I94dc3dc1ca2bc96f029fea3c4f4d6e41d018e2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416999 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Mark Mentovai authored
This enables x86_64 Chrome to run under Rosetta binary translation on arm64 macOS systems. The system page size is no longer considered a compile-time constant on macOS. It may be determined dynamically at run time through the vm_page_size variable. The related vm_page_shift and vm_page_mask variables are also available. On arm64, the system page size is currently 16kB. On x86_64, it’s 4kB. x86 code running translated on currently available arm64 systems (the Apple Developer Transition Kit) is subjected to the arm64 system’s native 16kB page size, meaning that code built with an expectation of 4kB pages, previously correct for native x86_64, will not work correctly in the translated environment. This is significant because the DTK is the only mac-arm64 system available for testing now, and it’s become important to test x86_64 Chrome under Rosetta translation on arm64. To overcome this limitation, the system page size and related constants are, on macOS, made to be determined at run time on the basis of the variables provided for this purpose by the system. In order to make this change without violating Google’s and Chrome’s prohibition against load-time initializers, the variables that had been used to convey page size information need to become functions. On all platforms except for macOS, the functions remain constexpr, are marked to be always inlined, and continue to return the same compile time-determined value they had in the past, so while it appears invasive, this change is in fact physically a no-op on these platforms. On macOS, it is a functional no-op change, except when running x86_64 code on arm64 under Rosetta translation, where it causes correct values to be used for the run-time environment. Adopting a compile-time 16kB page size on mac-x86_64 was considered but rejected due to the potential for memory footprint and performance impact. That approach would result in a behavior change for native x86_64 users, which constitute the vast majority of consumers of the x86_64 build, for the benefit of the comparatively small number of arm64 users running x86_64 Chrome under translation. This is undesirable, particularly for a change that may need to be merged to more stable branches. Apple documentation links: https://download.developer.apple.com/Documentation/Universal_App_Quick_Start_Program_Resources/DTK_Release_notes.pdf “Rosetta 2 Behaviors…Applications that depend on a 4K memory page size will not run. Examples of this may include some web browsers and language runtimes.” Also: https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code#3616877 https://developer.apple.com/videos/play/wwdc2020/10214/?time=544 (9:04) Bug: 1102194 Code-Word: disaster CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I143f38f06444f96eb8a82ede34f2a44ea48318fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361202 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#808610}
-
Mike Wittman authored
This configuration solely controls the ThreadProfiler, so rename it to be consistent with the naming of that class and with future code in support of enabling the ThreadProfiler on a per-thread basis. Bug: 1129939 Change-Id: I20d19abe579cabaf7a355182f164898c12861c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418675 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808609}
-
Nico Weber authored
- Mention that we now have a tester bot and link to it - Put actual build instructions to top of the "Building" section - Add some text about copying files to the DTK, and mention quarantine error messages, so that search engines can index them Bug: none Change-Id: I5b5f042280b6077ad89e217e4bf907f4b4c12fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418984 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#808608}
-
Yue Li authored
Bug: b/150034512 Test: Manual Test Change-Id: I87a02b3d0ef65a2e6a26c663fe2ee66d43331423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419263 Commit-Queue: Yue Li <updowndota@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
-
