GitLab

AdjustMaxTasks() must be scheduled there are pending MAY_BLOCK
ScopedBlockingCalls *and* the current concurrency limits are not enough
to accommodate all pending tasks. Entering a WILL_BLOCK
ScopedBlockingCall cannot make this condition become true.
Therefore, MustScheduleAdjustMaxTasksLockRequired() should always
return false in WillBlockEntered(). This CL adds a DCHECK to
enforce this.

Bug: 813857
Change-Id: I2397ab30bd5800e972ee7fba994b31e4357f2202
Reviewed-on: https://chromium-review.googlesource.com/c/1456679
Commit-Queue: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630517}

The term "background" is confusing as it refers to a thread with a
specific priority. Use worker_pool instead to refer to
non-main-thread scheduler.

R=haraken@chromium.org,gab@chromium.org

Change-Id: Ia72090e39a3354cd14c539e64475cf661db15cd7
Reviewed-on: https://chromium-review.googlesource.com/c/1282396
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630516}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/43ecc6793a5c..6b5dce060865


git log 43ecc6793a5c..6b5dce060865 --date=short --no-merges --format='%ad %ae %s'
2019-02-08 linben@google.com Move kevin-arcnext P Android PFQ to kevin


Created with:
  gclient setdep -r src/third_party/chromite@6b5dce060865

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I11e7262d469f664d6cc8cfc4027c1c9df98a4e5f
Reviewed-on: https://chromium-review.googlesource.com/c/1461154Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630515}

Using wpt-import in Chromium bb29edd5.
With Chromium commits locally applied on WPT:
c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html."
14c11107 "Implement `Sec-CH-Lang`"
c49d046d "Initial support for WorkletAnimation.playbackRate"
70938d55 "Fix remaining preload tests flaking on wpt.fyi"
af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org:
  external/wpt/payment-handler

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I576ff901701a4767a8dc4b25c5e0f9ab17c485b1
Reviewed-on: https://chromium-review.googlesource.com/c/1461259Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630514}

The former non-overloaded variants are deprecated.
Removed casts where they are now unnecessary.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I43577068160b171779166b1795b22dd69137b4a6
Reviewed-on: https://chromium-review.googlesource.com/c/1461376
Commit-Queue: Raul Tambre <raul@tambre.ee>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630513}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I23306df06e8c761d22616ca3f9a341ca79f8c19d
Reviewed-on: https://chromium-review.googlesource.com/c/1461035
Commit-Queue: Raul Tambre <raul@tambre.ee>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#630512}

TextAppearanceSpans report font size in pixels, giving an odd effect of
inflated answer on high density screens.

Bug: 920396
Change-Id: Ice9810f5157f3276042462ca0ff379444c6afea6
Reviewed-on: https://chromium-review.googlesource.com/c/1457471
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Auto-Submit: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#630511}

Several web_tests define the value of the gesture source being used.
A common definition is available in resources/gesture-util.js, so we
use that.

Bug: None
Change-Id: Iea4767be229572d6e3555cc45d5f9caa00e5e7d4
Reviewed-on: https://chromium-review.googlesource.com/c/1457465
Commit-Queue: David Bokan <bokan@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630510}

sendThemeInfoToEditCustomLinkIframe should only postMessage for Google
NTPs, otherwise the edit custom link iframe will not be present.

Change-Id: I7119ab9061130a1245b23d8fa0f384cbf94de438
Reviewed-on: https://chromium-review.googlesource.com/c/1460297
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630509}

Consent for Google service is no longer unified. This CL is removing the
AllGoogleServices of the UnifiedConsentService as it is now obsolete.

Bug: 929372
Change-Id: I3762d27078b4d04280869c3226a087da53145c76
Reviewed-on: https://chromium-review.googlesource.com/c/1461020
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630508}

During caret navigation, certain contents should be ignored:
- Anything that's not text, control or atomic inline
- Generated contents
- ZWS and <wbr>

This patch does so and adds relevant tests. A new layout test that runs
both in legacy and bidi caret affinity is added to ensure that this is
not a new behavior.

Bug: 894651
Change-Id: Idcc6a662afd05a440b67b09d1189b2fec23eadca
Reviewed-on: https://chromium-review.googlesource.com/c/1460183
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630507}

Also, refactor the logic to combine how we handle
allowed_to_be_default_match and how we handle entity suggestions. The
former was added in https://crrev.com/c/1174860. Then I added similar
entity suggestion handling but in a totally different way in
https://crrev.com/c/1376322.

When looking to update this logic to fix the issue in bug 922662, I
realized that these were doing very similar things despite going about
them in different ways. So this CL combines all the logic in the method
that chooses between two candidate matches.

Bug: 922662
Change-Id: I290573e4669360904bf049d252e4a4175ea6c499
Reviewed-on: https://chromium-review.googlesource.com/c/1403062
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630506}

Enables manual fallback in incognito by getting the original browser
state.
Fixes the double input view by resetting the reference to the view
when the keyboard hides on iPad.
Reverts: https://chromium.googlesource.com/chromium/src.git/+/15f7cf85bc1fb76e51e58cea68e6fc183aa5fbde

Bug: 923857, 923857, 905720
Change-Id: I253c4b25650cf6be184c59caa7285dc1ecdc8900
Reviewed-on: https://chromium-review.googlesource.com/c/1461080
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630505}

This is a reland of c0cf050d

Original change's description:
> Add remoting FTL API key
>
> Add API key for remoting to use during the signaling process. Note that
> this key is only used by Chrome Remote Desktop and will not be used in
> the Chrome browser.
>
> Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973
>
> Bug: 927962
> Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f
> Reviewed-on: https://chromium-review.googlesource.com/c/1450409
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Auto-Submit: Yuwei Huang <yuweih@chromium.org>
> Commit-Queue: Roger Tawa <rogerta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630352}

TBR=rogerta@chromium.org

Bug: 927962
Change-Id: I63c2e7e16621a01827609fab0c8969fd85b2399c
Reviewed-on: https://chromium-review.googlesource.com/c/1461306
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630504}

This patch removes the chrome flag enable-settings-shortcut-search, but
keeps the feature app_list_features::kEnableSettingsShortcutSearch for
future development.

Bug: none
Test: manual
Change-Id: I2d2c4310f9750d334dc0fa84cb3207e04a8d560a
Reviewed-on: https://chromium-review.googlesource.com/c/1460425Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630503}

//chrome/third_party/mozilla_security_manager: Convert base::(U)Int(64)ToString(16) to NumberToString(16)

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I67125c3d5067dc1b64aa89e2625de24fd5ca5d9c
Reviewed-on: https://chromium-review.googlesource.com/c/1461131
Commit-Queue: Raul Tambre <raul@tambre.ee>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630502}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

We also need to refer to the global persisted storage area via a different path
when calling SCP to the path we use from within the applications we run on the
device.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast

Bug: 930182
Change-Id: Ie927ac82959345f2605fcbf604c90409b4853f88
Reviewed-on: https://chromium-review.googlesource.com/c/1461307
Commit-Queue: James Robinson <jamesr@chromium.org>
Reviewed-by: James Robinson <jamesr@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630501}

AnimationWorkletGlobalScopeTest::SelectGlobalScope tests the behavior
of AnimationWorkletProxyClient::SelectGlobalScope but it uses a mock
client. Move this test to AnimationWorkletProxyClientTest to use a
complete proxy client.

Since we have used CreateAnimationAndPaintWorkletThread in three tests
with duplicating most of the implementation, this patch also creates
a helper file to handle this problem.

Change-Id: Id86bd3c2cb796565a84fc8c30d14f46a3958ff17
Reviewed-on: https://chromium-review.googlesource.com/c/1459924Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630500}

This change introduces two SetContext() methods for CastContentWindow;
SetActivityContext() is used to supply common data for all activities,
while SetHostContext() provides data about the code that is hosting the
activity instance.

Merge-With: eureka-internal/239993

Bug: internal b/123538348
Test: CQ
Change-Id: I7cb4a313de78b0d511f4423dd5af4595a2866a7e
Reviewed-on: https://chromium-review.googlesource.com/c/1457722Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630499}

The Autotest component extension is used to launch Android apps. It
should be whitelisted in Demo Mode (which is implemented as public
sessions).

Bug: 870049
Change-Id: I31628dc5c659818990c1d280d6744112867db34a
Reviewed-on: https://chromium-review.googlesource.com/c/1441795Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630498}

These started failing on Linux bots after a WPT auto import.

BUG=930297
TBR=jsbell@chromium.org
No-Try: true
NOTRY=true

Change-Id: I8c9546510fe603db6dd9a4566dbbc90d6412eaa0
Reviewed-on: https://chromium-review.googlesource.com/c/1461348Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630497}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I4ee6af43ac4b62ac09892774faba366f4f78e271
Reviewed-on: https://chromium-review.googlesource.com/c/1461380
Commit-Queue: Raul Tambre <raul@tambre.ee>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630496}

Some of the GestureSourceType enum values are defined on
chrome.gpuBenchmarking. We define the rest of them and then use them
to define GestureSourceType values for web_tests.

Bug: None
Change-Id: I4e9eb85850fbfdda490b84ac665b7ae397e68a50
Reviewed-on: https://chromium-review.googlesource.com/c/1460121Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630495}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de578cdd6b58..295aca65583b


Created with:
  gclient setdep -r src-internal@295aca65583b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I4ef1452efd1e2891508a781faf945dd5065553ac
Reviewed-on: https://chromium-review.googlesource.com/c/1461151Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630494}

Navigator.language can return either a language only ('en') or a full
locale ('en-US'). If a locale is not found ('ru-RU'), then fall back to
using only the language ('ru').

Bug: 922088
Change-Id: I215071e55a9a01a97348491603a4bdabe739ff87
Reviewed-on: https://chromium-review.googlesource.com/c/1460479Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630493}

There is a regular bug being filed by ClusterFuzz about a CHECK when
converting an infinity value to base::Value. I fixed a regular issue
for duration. Folding the different events into the same entry guarantees
that we don't repeat this work.

Bug: 927634
Change-Id: I4d8833e8430d42036e6501db65cf4b5349772b07
Reviewed-on: https://chromium-review.googlesource.com/c/1461305
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630492}

Drag-and-drop into a web page is obviously handled by the web page.  If
the drag-and-drop started from outside the web page and contains a URL,
then it needs to trigger a top-level navigations to that URL.  Examples
of such navigation-triggering drags are: dragging a Chrome bookmark into
a web page;  dragging a file from an platform-specific file viewer (e.g.
Windows Explorer) into a web page.

The navigation above needs to use a unique origin as the initiator of
the navigation:

1. This matches other navigations initiated outside of a web page
   (e.g. omnibox navigations).  Here also we have a navigation initiated
   by a user, to a destination chosen by a user (not by the webpage
   handling the navigation).

   One could argue that drag-and-drop started from another web page (say
   foo.com) should use the origin of that web page as an initiator.
   Unfortunately, drag-and-drop data doesn't have this information - it
   only has the destination URL (which can be a different site - say
   bar.com).  I think treating this situation consistently with drags
   started from outside the browser is fine (at least for now).  At the
   very least, using a unique origin is safer than using the destination
   origin (which might not always match the origin of the source of the
   drag).

2. The renderer process handling the drag-and-drop might be locked to a
   specific site or origin (and therefore not able to use arbitrary
   origin as the initiator).  This has led to renderer kills in
   https://crbug.com/930049.

A regression test will be authored and landed separately - please see
https://crrev.com/c/1461339.

Bug: 930049
Change-Id: I9c16ea30086d78dc010c8479ea528b0cb3181158
Reviewed-on: https://chromium-review.googlesource.com/c/1460424
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630491}

The override of RegisterListPref taking a std::unique_ptr<base::Value>
is never used, so remove it.

Bug: 646113
Change-Id: I0267d0ac034f3d8c59c40f20b6e77b534e960184
Reviewed-on: https://chromium-review.googlesource.com/c/1460932
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630490}

The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value>
is never used, so remove it.

Bug: 646113
Change-Id: I72b981b2bd9f92394be65eddde1ad3d269552552
Reviewed-on: https://chromium-review.googlesource.com/c/1459538
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630489}

Details:
* Add 2 classes and 1 helper function to rel32_utils.h.
  * Rel32ReaderArm: ReferenceReader for ARM.
  * Rel32WriterArm: ReferenceWriter for ARM.
  * ArmCopyDisp(): Copies displacement data from one ARM instruction to
    another (of the same type) to make them more similar. This will be
    used for ReferenceBytesMixer.
* These funtions take ADDR_TRAITS template argument, which matches
  ArmAddrTraits in arm_utils.h.
* Add extensive tests.

Bug: 918867
Change-Id: I7e7f8bee8cb2a8b49f7fd0e7115b39c49f576398
Reviewed-on: https://chromium-review.googlesource.com/c/1452780
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630488}

Add the Hardware Accelerated VA-API based VP9 Encoder support
in chromium.

The vp9 specific webrtc metadata to make the encoding work with
appr.tc is added by  Erik Språng<sprang@webrtc.org>.

BUG=811912
TEST=run the video_encode_accelerator_unittest on supported devices(eg: soraka)
VEA:
./video_encode_accelerator_unittest --gtest_filter=SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/0 --test_stream_data=bear_320x192_40frames.yuv:320:192:12:bear.ivf:100000:30  -v=0 --disable_flush --single-process-tests --ozone-platform=gbm

TEST=appr.tc/?debug=loopback&vsc=VP9&vrc=VP9

Change-Id: I50b77d642684a03f7ecc35befd5442d35b41e3ae
Reviewed-on: https://chromium-review.googlesource.com/c/1383540Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Cr-Commit-Position: refs/heads/master@{#630487}

We have received a few crashes indicating that failures to access the pref
store but none were related to asynchronous loading. This looks like a red
herring.

TBR=holte@chromium.org

Bug: 859477,930274
Change-Id: I71a0653471a102ea310be5c225bd0539b2449e03
Reviewed-on: https://chromium-review.googlesource.com/c/1459624
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630486}

Add unit test for CrostiniPackageService. Also fixes a corner case found
by unit test (queuing uninstalls while install starts up).

BUG=822514
TEST=Ran unit test

Change-Id: Ieede7119febda6a2fb67ca9835e8d859ddf08400
Reviewed-on: https://chromium-review.googlesource.com/c/1401611
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630485}

This CL adds differentiating between searching text and navigating to
a url from the search action widget. As the text from the clipboard is
displayed to the user, it uses recent_clipboard_content to add an
expiration time to the text for privacy reasons.

Bug: 915220
Change-Id: I3d70c65301f811a78955db6340df0836ca6150c3
Reviewed-on: https://chromium-review.googlesource.com/c/1378101
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630484}

It's been commented out for a while and isn't very useful. See bug.

Bug: 397639
Change-Id: I675ab74725c193b9cc5fcd5ecd74e591f9dc033f
Reviewed-on: https://chromium-review.googlesource.com/c/1456350
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630483}

We can use this metric to validate estimates about the time it takes to
extract screenshots.

Bug: 922226
Change-Id: I26c6429a3f902a6f45b5366e2a9ab1ea44647e77
Reviewed-on: https://chromium-review.googlesource.com/c/1454634Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630482}

There are various places in the video capture stack where frames can be
silently dropped. The browser-side stack already emits events from code
sites where frames are dropped, which get counted via UMA and produce
log entries that can be collected by applications such as Hangouts.

This CL adds event emitting code to 10 frame drop sites in the
renderer-side video capture stack. For reference, here is an overview
of how the frame drop events travel from their various origins:

MediaStreamVideoTrack::OnFrameDropped()
 MediaStreamVideoSource::OnFrameDropped() <- Defaults to no-op
  MediaStreamVideoCapturerSource::OnFrameDropped() <- Overrides
   media::VideoCapturerSource::OnFrameDropped() <- Defaults to no-op
    LocalVideoCapturerSource::OnFrameDropped() <- Overrides
     VideoCaptureImplManager::OnFrameDropped()
      VideoCaptureImpl::OnFrameDropped()
       --- IPC to Browser Process ---
       VideoCaptureHost::OnFrameDropped()
        VideoCaptureController::OnFrameDropped()

MediaStreamVideoRendererSink::FrameDeliverer::OnVideoFrame()
 MediaStreamVideoSink::OnFrameDropped()
  MediaStreamVideoTrack::OnFrameDropped()
   same as above

MediaStreamVideoTrack::FrameDeliverer::DeliverFrameOnIO()
 MediaStreamVideoTrack::OnFrameDropped()
  same as above

VideoTrackAdapter::VideoFrameResolutionAdapter::DeliverFrame()
 MediaStreamVideoSource::OnFrameDropped()
  same as above

VideoTrackAdapter::VideoFrameResolutionAdapter::DoDeliverFrame()
 MediaStreamVideoSource::OnFrameDropped()
  same as above

VideoTrackAdapter::DeliverFrameOnIO()
 MediaStreamVideoSource::OnFrameDropped()
  same as above

Bug: 924182
Change-Id: Icf990cab84e01a406c488cff48d7e94c5ef7355c
Reviewed-on: https://chromium-review.googlesource.com/c/1437181Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630481}

Bug: None
Change-Id: I056cfdc91089b63ad20336ff9124f67bb2087e19
Reviewed-on: https://chromium-review.googlesource.com/c/1461304
Commit-Queue: Ken Rockot <rockot@google.com>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Auto-Submit: Ken Rockot <rockot@google.com>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630480}

Tablet.AppWindowDrag.CountOfPerUserSession:
The number of the app window drag from top in tablet mode per user
session.

Tablet.AppWindowDrag.InSplitView.CountOfPerUserSession:
The number of the app window drag from top in tablet mode when
splitview is active per user session.

Tablet.TabDrag.CountOfPerUserSession:
The number of the tab drag in tablet mode per user session.

Tablet.TabDrag.InSplitView.CountOfPerUserSession:
The number of the tab drag in tablet mode when splitview is active per
user session.

Tablet.TabDrag.DragType:
The type of the tab drag in tablet mode.

Tablet.WindowDrag.OpenedWindowsNumber:
The number of windows in overview when app window drag happens.

Tablet.AppDrag.EndWindowState:
The end state of app window drag from top, e.g, in overview, splitview
or back to maximized or fullscreen.

Tablet.WindowDrag.DragEndEventType:
Window drag end event, normal end, revert or fling.

Tablet.WindowDrag.OpenedOverview:
Count the times that overview has been opened when drag a window from
top in tablet mode. Used to compare with "Tray_Overview", which count
tapping overview button to open overview.


Bug: 916830
Change-Id: Ida204a02445f8fbef6c0f0c7040117dfa99bde13
Reviewed-on: https://chromium-review.googlesource.com/c/1388556Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630479}

The code review for the Mac chooser led to some changes that are also
applicable to the Linux chooser.

Bug: 679313
Change-Id: I301f9c08aa6afcbf356023b9c0eaea39e171b435
Reviewed-on: https://chromium-review.googlesource.com/c/1457480Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630478}