- 19 Oct, 2020 40 commits
-
-
Marc Treib authored
This field is unused except for displaying it in chrome://sync-internals, and apparently it also always empty in practice. Bug: 1139903 Change-Id: Ib5345594dc6d5bc0bd5d967c8dd9d08ba3781e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484593Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818470}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603087080-212b8c940037ae1d78d2bd42956b635be6add59e.profdata to chrome-linux-master-1603107412-6ef156ac52bac5f4e53402d26e81a7a7c88be584.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I10e3f128fa47147078a9d9e0b48e10f080e6b667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818469}
-
Andrew Grieve authored
The component lookup logic uses dirname(source_path), so we should not use directories as source_paths. Bug: None Change-Id: Ibbfd6670a68ce5016912b4ad1390226cbc25b339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484045 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#818468}
-
Anders Hartvoll Ruud authored
This adds various invalidation reftests for things that I felt were missing. Bug: 568705 Change-Id: Iebc9bbbc4184c6b2420ab9a0042b16fbe4721241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479367 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#818467}
-
Olga Sharonova authored
Reduce the frequency of dynamic memory allocation in blink::MediaStreamWebAudioSource::ProvideInput() which runs on a real-time audio thread. With the fix it's one-off allocation, rather than on each call. Bug: 1137778 Change-Id: Ibd33bc3fc8715c1cd9f49033476b97138fbfa027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471397 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#818466}
-
Olga Sharonova authored
Bug: 1137718 Change-Id: Ia7108d84d09bc3f48058fc15989612389abd7664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470567 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/16b862bdf547..a8b477dc553d 2020-10-19 wolfi@chromium.org [TS] Port BackgroundServiceModel.js to TypeScript 2020-10-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-19 jacktfranklin@chromium.org Breadcrumbs: don't reset user scroll position on update 2020-10-19 tvanderlippe@chromium.org Typecheck resources/IndexedDBModel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1138492,chromium:1138767 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I617143a77228a5aec097ba334d621b97fe886c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483921Reviewed-by:
-
Yunke Zhou authored
Bug: 1011324 Change-Id: I4ae9d7cd8524ddfc294ea249d9992ad9a1a8b3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482263 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818463}
-
sauski authored
Enables sizing of the HaTS Next native window automatically based on the desired size of the WebContents. To achieve this, the HaTS Next dialog is modified to inherit from WebView rather than WebDialogView. Bug: 1110888 Change-Id: I107d05843095e53f73aee65dfa40ab04f5c157ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456108 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#818462}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1253aea08e5f..4b18e249672f 2020-10-19 danilchap@webrtc.org Support layer skipping in key svc structures 2020-10-19 jakobi@webrtc.org Add NetEq decision logic unit tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ae915f4431723223b55244fcc23f9afd5555c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483918Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603087080-138c0bc7a94d51e9caaa7300e866d8f7233b285e.profdata to chrome-mac-master-1603107412-fb64dfead80726fe49a6a8dd27a12a049b69e6ae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I68afa8fa6e97544d32bfd43ffd94806e9547b3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484892Reviewed-by:
-
Mikel Astiz authored
The class is only used under sync/engine_impl and in fact shouldn't be used outside, so let's move it away from base/. While moving it, a few minor things are refactored, such as a few functions being renamed for clarity. Change-Id: Ibaf6e662551eeb78e2b7c7cbc88778b54cf31ee2 Bug: 1129782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484697Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818459}
-
Alice Wang authored
This CL removes the invisible views in the sign-in in progress screen to decouple this screen from others. This helps us to refactor the web sign-in screens later. Bug: 1139236 Change-Id: I2824266f4d856a68404b2db16df462a9b80a0e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484425Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818458}
-
Luca Hunkeler authored
Currently, if an element check is being performed the chips will not be correctly hidden when the keyboard is shown. This happens because after the periodic element check we reset the visibity to the default value (true). This change reworks how we hide the chips and fixes that problem. Bug: b/171179162 Change-Id: Icb3149fb31449d2ad2dedc114b710f195275ff57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484696 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#818457}
-
Melissa Zhang authored
Make copy of display name before std::move target so value is not null. Bug: 1097623 Change-Id: I949002b09c022d7d1cb7bda67f4932829406167c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483548 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#818456}
-
Sky Malice authored
TBR: gogerald@google.com Bug: 1139515 Change-Id: I11bb4ed067a760763f96cca37d44ceab2c9794cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481748 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818455}
-
Andrew Grieve authored
These by nature pick up transitive deps, so it doesn't really make sense to require per-team OWNERS when a //build .py gains a new dep. Bug: None Change-Id: I98be08e3c40ae5d4913d7806379cd38434a6363a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484264 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#818454}
-
Greg Thompson authored
These GoogleUpdate. metrics will be useful through 2021 while Omaha 4 is being deployed. BUG=1138415 R=waffles@chromium.org Change-Id: Ife9baf6a1d3391741bc5b4f2ce944aace56019a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484442 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#818453}
-
Christian Biesinger authored
Because flexbox passes in LayoutUnit::Max(), ng_length_utils used that as the minimum block size, so effectively we ignored the aspect ratio. The test was incorrect. See also https://github.com/w3c/csswg-drafts/issues/5406 R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010, 1045668 Change-Id: I2ed30cb6d9539ea82ac5c22b34c45770fa9a60a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479802 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818452}
-
Andrew Grieve authored
Build rules in //build should not reference things outside of //build. java_strings_grd() was breaking this rule, and so I'm fixing it here by moving it to live alongside the other grit() templates. Bug: 1136507 Change-Id: I575c8e6636a86602b8c3eee557ce990e7fa00eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477093Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#818451}
-
Andrew Grieve authored
Noticed this when doing binary size review. Bug: None Change-Id: Ic98d5dce26c2574340e86763518099b2cf85c825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484047 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/935a915963e1..7411aeba4d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie13dae9eb2147b5035f26d913345f6e03a6451f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483383Reviewed-by:
-
Ian Kilpatrick authored
Previously we had special logic within ng_absolute_utils.cc which simply checked if we had an element with display:table for some table specific logic. This was incorrect, and should have been checking for the LayoutObject type instead. This caused some incorrect layout of replaced elements when OOF. This patch uses the NGBlockNode::IsTable instead to apply this logic. Bug: 1138851 Change-Id: Id428df4f48c48ad949bd3d8ffce70827e8809081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483962Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#818448}
-
Monica Basta authored
Bug: 1063856 Change-Id: I718631d454bcd8df2dda8f2d8e55533cb59f2f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480566 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818447}
-
Andrew Grieve authored
Likely pretty innocuous, but it's possible a GC could happen between the two weakRef.get() calls. Bug: None Change-Id: I345fac7f72a70cef8aed80a834b47f3514d7f51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477048 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#818446}
-
Illia Klimov authored
Track permission auto-revocation event. Track whether all blocking lists data is loaded before an abusive origin verification started. Track blocking lists data version. UKM review doc: https://docs.google.com/document/d/1TVSMLfnyNusIn6kaAbHL8oBgUnQRj5TYEYa-ikjvTa4/edit Bug: 1134233 Change-Id: I864b224a4098b7fbdf1a2b708b2b15ad61fcd99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443290Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#818445}
-
Titouan Rigoudy authored
These tests might not live very long, depending on the outcome of the related issue: https://github.com/web-platform-tests/wpt/issues/26166. In the meantime, they serve to document the existing spec intent, and hopefully undergird discussions around address space inheritance. Bug: chromium:1138905, chromium:1138906, chromium:1134601 Change-Id: I7d8d0e7cf8e70cfdf3bdc044e748ee384f3418dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475875 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#818444}
-
sandromaggi authored
Bug: none Change-Id: I3e17122036375f5738afdeeee7944bb12b2648c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484599 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#818443}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5118dae088e4..7b572a466a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I34813afdf55a749eac02094a45fc41e13de57f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483916Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818442}
-
Monica Basta authored
Bug: 1089332 Change-Id: I6c699b26f1bb92126552e401f39993441e6d8283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478986Reviewed-by:
-
Viktor Semeniuk authored
Since new Passwords Details screen is used test should no longer fail. Bug: 1109644 Change-Id: I391ed31618ef69b5913e50b449dee50e5da1ad11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476275Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#818440}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/efd1e44d0df7..16b862bdf547 2020-10-19 aerotwist@chromium.org TypeScriptify LighthouseStatusView 2020-10-19 alexrudenko@chromium.org Enable TypeScript for NetworkPriorities.js 2020-10-19 sigurds@chromium.org Display isolation status in FrameDetailsView 2020-10-19 pfaffe@chromium.org TypeScriptify PresentationConsoleMessageHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I43622e2f4573b0d26c86c337bb4f685faa03d78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483917Reviewed-by:
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2484717 R=sigurds@chromium.org Bug: 1011811 Change-Id: Ibbd4a5a822d4f06fca89cbdf9376127a6ce30327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484702 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818438}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e706198..94e1f5b2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cbf5ba9dfa4de01f5f563957271b57991fa78e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484283Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818437}
-
Andrew Shulaev authored
Change-Id: I23657194899a2258e39596056b03a53b2082aa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403484 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818436}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f7eab68c0ce..1253aea08e5f 2020-10-19 mbonadei@webrtc.org Revert "Reland "Remove placeholder Obj-C headers and use angle-bracketed headers."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6c116a8e936e7fb25942e47a133f3b7d2de672d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484310Reviewed-by:
-
Antia Puentes authored
This CL migrates the legacy IPC message out of view_messages.h to {Local,Remote}MainFrameHost mojo interfaces from Blink. The ViewHostMsg_Focus IPC method has been migrated both into the LocalMainFrameHost and RemoteMainFrameHost interfaces, and Blink will route the message through the correct channel depending on whether the renderer's main frame is a LocalFrame or a RemoteFrame. ChromeClient calls to WebView to send the message, previously this went through the RenderView. Method TakeFocus has been added to the WebView and methods Focus{Next/Previous} were removed from the RenderView and WebViewClient. Bug: 1135180 Change-Id: I6ac1ac344b9863ad685abca369ad14997b27be0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475116Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antia Puentes <apuentes@igalia.com> Cr-Commit-Position: refs/heads/master@{#818434}
-
Kushagra Sinha authored
EduAccountLoginHandler currently uses |signin::ConsentLevel::kSync| for fetching the account to be used for initiating the parental reauth in EDU co-existence flow. Since this account is guaranteed and must be the Device Account, we should use that regardless of Sync consent status. Fix this by supplying |signin::ConsentLevel::kNotRequired| while fetching the access token for the Device Account in EduAccountLoginHandler. Bug: 1123844 Change-Id: I002f20b754dc63378a4b1b086efbf8cd6b7b3485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484698Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2320bb8402d66f17f78b5edf68118efe29ca1abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484313Reviewed-by:
-
Fabian Sommer authored
Add two policies that govern behavior for users that authenticate with a security token (e.g., smart card) and remove it while in session. One policy determines what happens then (nothing/logout/lock), the other determines if and how long a notification of this appears. Add SecurityTokenSessionController that monitors those two policies. Actual behavior (such as displaing the notification or locking a session) will be implemented in follow-up CLs. Bug: 1131450 Change-Id: Ibb7827010b1d6af4127406afe61b261e234b7326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426044 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818431}
-
