- 27 Jul, 2018 40 commits
-
-
Hiroki Nakagawa authored
On PlzWorker, AppCacheHost is created before starting worker script loading from a renderer process. This CL teaches the precreated AppCacheHost's ID from the browser process to the renderer process in order to associate worker script loading with the host. This fixes DCHECK failures on appcache-worker.https.html caused by host mismatch, the test still times out though. DesignDoc: https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing Bug: 715632 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I16c17447bbb0f4b154c5a7e9393afdea2d0e29d6 Reviewed-on: https://chromium-review.googlesource.com/1150941 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578547}
-
Xiaocheng Hu authored
The layout test was introduced to verify the ability to select text on certain elements (*). Incidentally, it hit tests the 1px gap between two lines on Linux, which results in different behaviors between legacy and NG due to different line box sizing. This patch explicitly sets font metrics and line-height to stablize its behavior. (*) crrev.com/20a8d9a8 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I44918bf049607110572fc479548f3c958770c8ba Reviewed-on: https://chromium-review.googlesource.com/1152216 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578546}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac8c0c3138b7..a1e31db3c6b7 git log ac8c0c3138b7..a1e31db3c6b7 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 nednguyen@google.com Regenerate startup args for each time trying to start the desktop browser Created with: gclient setdep -r src/third_party/catapult@a1e31db3c6b7 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865895 TBR=sullivan@chromium.org Change-Id: I9666a5d8bd09b8eb2765b4f407b5e1c2f2fc77fb Reviewed-on: https://chromium-review.googlesource.com/1152608Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578545}
-
Chris Lu authored
If Clear Browsing Data is presented when History attempts to dismiss itself, nothing will happen. Need to dismiss Clear Browsing Data First. Video: https://drive.google.com/open?id=1KUKsgv8OSQc_1301ff2XMgK2_hi6dd1- Bug: 867329 Change-Id: I1cd5f242ef410267ed5d4ab0e006884a3288eafe Reviewed-on: https://chromium-review.googlesource.com/1150620 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#578544}
-
Bruce Dawson authored
Switch from double to float in color_utils.cc. The HSL struct and CalculateBoringScore still use double in their API because changing those requires enough changes to justify being done in a different CL. Note that SkColorToRgbaString intentionally uses a double precision constant for 255 so that the calculation is done to double precision so that spurious rounding in the result string is avoided. Bug: 863135 Change-Id: Id5b678ed6e1c40475ec516bde2c902ba27bb783d Reviewed-on: https://chromium-review.googlesource.com/1135550 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578543}
-
John Abd-El-Malek authored
Update test expectations of PDFExtensionLoadTest.Load since one pdf doesn't crash anymore after r577739 Bug: 856161 Change-Id: I68207ae97c8b0e863169991e541126f0854264cf Reviewed-on: https://chromium-review.googlesource.com/1152532Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#578542}
-
Renee Wright authored
Currently, when updating an existing Crostini App, the associated CrostiniAppItem's ordinal and folder id are not preserved. This is because a new CrostiniAppItem is added to replace the old one. This leads to icons which users had previously removed from the Linux Apps folder to return to the folder, for example. This CL saves the item ordinal and folder id from the old app item, and re-sets them on the new app item. This CL also changes process for inserting a newly installed app so that it removes the app before adding it. This is needed for the case that the user reformats their Chromebook without uninstalling Crostini, which leaves residual app info in their preferences. Bug: 822488 Change-Id: Id7442c6563851ad4997578da65340a5c2eeef3f5 Reviewed-on: https://chromium-review.googlesource.com/1150955 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578541}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7af2637c. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 408f60ca "Remove Shared Worker WPT for WebUSB" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21754 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record meade@chromium.org: external/wpt/web-animations yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=lukebjerring No-Export: true Change-Id: If2941ba3b50e2d16da967b93f9d7beecbb2d4223 Reviewed-on: https://chromium-review.googlesource.com/1152529 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578540}
-
Yoichi Osato authored
This reverts commit 365f6904. Reason for revert: UkmBrowserTest.SingleSyncSignoutCheck is Flaky Findit identified the culprit r578386 with confidence 74.4%. Original change's description: > Migrate gcm to network service's socket APIs > > With network service, net:: C++ socket access will need to be changed to using > network service's socket APIs. This CL changes gcm to using > proxy_resolving_socket.mojom instead of the C++ ProxyResolvingClientSocket. > > GCM files that are changed: > - google_apis/gcm/engine/connection_factory_impl.cc > This will request and own a network::mojom::ProxyResolvingSocketPtr > - google_apis/gcm/engine/connection_handler_impl.cc > This will pass the mojo read/write pipes to socket streams. > - google_apis/gcm/base/socket_stream.cc > SocketInputStream/SocketOutputStream will read from/write to mojo data pipes > instead of the C++ socket. > > Network service changes > - services/network/public/mojom/proxy_resolving_socket.mojom > Peer address is surfaced directly when connection is established. This is > needed to support GCM's use case. They need the peer address synchronously > when connection is done. > > Browser changes: > - NetworkContext raw mojo pointer has to be queried on the UI thread on demand. > Therefore changes are added to pass through a callback and ui task runner. > > Bug: 862608 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ic0c72c8ee7d9bc7deb6e8109234227f80ea3bbe3 > Reviewed-on: https://chromium-review.googlesource.com/1142344 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578386} TBR=dcheng@chromium.org,peter@chromium.org,jam@chromium.org,sdefresne@chromium.org,xunjieli@chromium.org,morlovich@chromium.org Change-Id: I5951169891854c5d441d897dcb2e849f1ef7ace9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862608, 868220 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1152589Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578539}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/079812cefdd9..f12600a8ba80 git log 079812cefdd9..f12600a8ba80 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 vadimsh@chromium.org [cipd] Update cipd and vpython to v2.2.3. Created with: gclient setdep -r src/third_party/depot_tools@f12600a8ba80 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:821194 TBR=agable@chromium.org Change-Id: Iaed9e09a7529bea16abd810add67b3b61484b48c Reviewed-on: https://chromium-review.googlesource.com/1152269Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578538}
-
tzik authored
ModelLoader is a ref counted type, and its first reference used to be taken in its constructor through base::BindOnce. The reference was passed to a task runner, and released after the task has run. However, if the PostTask failed or the posted task ran soon before the construction had completed, the ModelLoader instance can be destroyed before another reference is made on the original sequence. So, `new ModelLoader` can return a stale pointer. This CL adds a static constructor to ModelLoader, and makes the first reference on the original sequence before passing a reference to the other sequence. Bug: 866456 Change-Id: I4d3c954ca39b7187fbd651c498e17273024c9968 Reviewed-on: https://chromium-review.googlesource.com/1151173 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578537}
-
Nicholas Verne authored
This increase is temporary and should be reverted once LXD startup code has been edited to remove unnecessary crypto calculations. These take much longer on Kevin than Eve at present. Bug: 863190 Change-Id: Ib2a004c46ecbf45c097bf3d6843e930b5edec7f9 Reviewed-on: https://chromium-review.googlesource.com/1152334Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578536}
-
Martin Kreichgauer authored
This changes IsUserVerifyingPlatformAuthenticatorAvailable to return false in incognito mode, and disable platform authenticator instantiation for MakeCredential/GetAssertion in incognito. Also change IsUVPAA to not return true on platforms where Touch ID is enabled but the embedder does not not provide a configuration. Bug: 678128 Change-Id: I2fc6b0182fcb9ae718acd842f1247baee81c5281 Reviewed-on: https://chromium-review.googlesource.com/1149115 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#578535}
-
Koji Ishii authored
Following bot results are included. 8340 8342 8347 8355 8360 8368 8379 8387 8389 0 lines were removed and 4 lines were deflaked by consecutive results since 8322. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iba47345c85b9ae81c4229ac137f0757b1393c219 Reviewed-on: https://chromium-review.googlesource.com/1150956 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chrome://conflictsPatrick Monette authored
Now prefer to show that the group policy is disabled instead of saying that the feature is disabled Change-Id: Ibcfa4a72bce47ad6a98ea6c1fb120117b6705aa8 Reviewed-on: https://chromium-review.googlesource.com/1151544Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#578533}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/203b26f27d00..dbd1612782f5 git log 203b26f27d00..dbd1612782f5 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 geofflang@chromium.org EGL: Implement EGL Image extensions. Created with: gclient setdep -r src/third_party/angle@dbd1612782f5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie36028e0842e1ee560ece98ece793c7b9458577a Reviewed-on: https://chromium-review.googlesource.com/1151209Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578532}
-
Sahel Sharify authored
This is a follow up path for https://chromium-review.googlesource.com/615144 The original patch adds scrollbar flashing logic in the first two cases but skips the last case: 1- All scroll updates other than the first one in a seuqence (the case that scroll node exists). 2- The first GSU while scrolling viewport. 3- The first GSU while scrolling on anything but viewport. This cl covers the third case. Bug: 746342 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62aafdc68df361fee56b3513a2a09250e3092b32 Reviewed-on: https://chromium-review.googlesource.com/1150436Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578531}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/933672b6cfa1..ac8c0c3138b7 git log 933672b6cfa1..ac8c0c3138b7 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 nednguyen@google.com Log browser state iniside Browser.__init__ upon startup failure Created with: gclient setdep -r src/third_party/catapult@ac8c0c3138b7 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865895 TBR=sullivan@chromium.org Change-Id: I6874a9352991d535b83b4fa8047762a3b3583f83 Reviewed-on: https://chromium-review.googlesource.com/1152271Reviewed-by:
-
edchin authored
This CL adds metrics for snapshotting at the moment when the user enters the tab switcher. The following are possible results of snapshotting: - A snapshot is not attempted if the page is still loading, since the snapshot would be stale. - A snapshot may be attempted but fail. Some known failure cases include when certain videos and video ads are shown on the page. (crbug.com/711455). - A snapshot is successfully taken. Bug: 853569 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iec3fdb87fe6f3008879a24507558fef1757813f9 Reviewed-on: https://chromium-review.googlesource.com/1150769Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578529}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e83d89c060cd..1d201c0289f2 Created with: gclient setdep -r src-internal@1d201c0289f2 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852038 TBR=mmoss@chromium.org Change-Id: Ibbf899b982866bb65858f197a284d1afcb8e1e85 Reviewed-on: https://chromium-review.googlesource.com/1152272Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578528}
-
Stuart Langley authored
SearchMetadata is used to query for recents and file system searches. There are a number of folders under <drive> that are hidden by default, and to be searched needed to be whitelisted. This adds team_drives to the whitelist and adds unit tests to verify that team drives results are returned in searches. Bug: 866575 Change-Id: I583ba06672f3d6a8112680ff22124b65048b74a7 Reviewed-on: https://chromium-review.googlesource.com/1149669Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#578527}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I74b59be8df653f27f4cfb38a24194329067df379 Reviewed-on: https://chromium-review.googlesource.com/1152479Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578526}
-
Koji Ishii authored
This patch changes OffsetForPosition and PositionForOffset functions to accept its source string, and let callers to pass them. The given strings are not used yet in this patch, other than DCHECK with the number of characters in the ShapeResult. Computing grapheme cluster list for all ShapeResult turned out to be not cheap enough for LayoutNG that this patch is the preparation to compute them when needed. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6dc22fda781f63219fba74381da87f1f0b33e85f Reviewed-on: https://chromium-review.googlesource.com/1118062 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578525}
-
Jeffrey Kardatzke authored
This adds support for sending a D-Bus message to Chrome so it launches a terminal connected to a Crostini container. Arguments to be executed in that terminal can also be passed as well. Bug: chromium:853560 Test: Verified with manual testing Change-Id: Ib0126e6fba94e210d9376d57c0f6edb85e667484 Reviewed-on: https://chromium-review.googlesource.com/1149188 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Move google_util from components/google/browser to components/google/common so that it can be called in the renderer. Bug: 841313 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I751bf47bf452e6dc365939131fd1e95ceee64d50 Reviewed-on: https://chromium-review.googlesource.com/1152502Reviewed-by:
-
Christopher Cameron authored
We've previously disabled this, but now try reverting all of the code back to the way it was prior to compositor recycling being possible. TBR=lgrey (revert of files from https://crrev.com/574738) Bug: 863817 Change-Id: I1b933e17c523fb14860284f06631cb2af0c4bf98 Reviewed-on: https://chromium-review.googlesource.com/1152548Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#578522}
-
Yuki Awano authored
- Update kAccessibilityFocusFallsbackToWidgetKey depending on whether ChromeVox or TalkBack is used for the window. - This CL fixes the logic to update window properties. AxTree can arrive to the helper bridge after a window is activated. This CL adds a logic to fix it. confirm that it works. Bug: 866793 Test: Navigate Android window with TalkBack by using keyboard and Change-Id: I911c77229c9a6f338fcdadd81ea5642aaefae084 Reviewed-on: https://chromium-review.googlesource.com/1148099Reviewed-by:David Tseng <dtseng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#578521}
-
Adam Rice authored
Create watch lists for Blink Streams, net/server and net/websockets. Add ricea@chromium.org to these watch lists, along with blink_websockets. Change-Id: I3f6e9da15b9710a30686597e5d8212f3ada93ac8 Reviewed-on: https://chromium-review.googlesource.com/1151180Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#578520}
-
Adam Rice authored
It is a static method which returns a constant ", " string, and which is only used inside the implementation of DOMWebSocket. Replace it with a compile-time constant. Change-Id: I1bb9ab48421394e6b3f759536d53a56888a3af8f Reviewed-on: https://chromium-review.googlesource.com/1151170Reviewed-by:
-
Yeol authored
So it replaced AddHeadersFromString with SetHeader in the unit tests. Bug: 862175 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia29ed00a158d1dd37fd0aea28cb71b50320daa8e Reviewed-on: https://chromium-review.googlesource.com/1146411Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#578518}
-
Ross McIlroy authored
This is the default, and doing so prevents passing --no-opt via other means. BUG=chromium:865913 Change-Id: I017d940809020d4015e245e9cb4ac3b166ad67b8 Reviewed-on: https://chromium-review.googlesource.com/1148730Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578517}
-
Jeffrey Kardatzke authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/e0781f23b9e8..2e6185093997 $ git log e0781f23b..2e6185093 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 jkardatzke Add owner/vm/container fields for TerminalParams proto 2018-07-20 smbarber vm_cicerone: add cid to NotifyVmStarted 2018-07-18 smbarber vm_concierge: add more keys to ContainerSshKeysResponse 2018-07-13 xiaochu dlcservice: add service constants 2018-07-13 reillyg system_api: Remove permission_broker RequestPathAccess method 2018-07-18 ljusten authpolicy: Add ERROR_OU_CONSTRAINT_VIOLATION 2018-07-09 ljusten dbus/login_manager: Add "ListStoredComponentPolicies" 2018-07-02 chirantan vm_concierge: Add field for seneschal server handle 2018-06-08 chirantan seneschal: Steward of the user's /home Created with: roll-dep src/third_party/cros_system_api Change-Id: I4d869302f28c1ae0736789973f76b98c8252f9a9 Reviewed-on: https://chromium-review.googlesource.com/1151710Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#578516}
-
Darren Shen authored
We previously added a setHitTestBounds API that allows IME to indicate what area on the keyboard is clickable. However, if IME forgets to set it when the UI changes (e.g. when the container type changes), then the UI may be unusable because it is using another container type's hit test bounds. This patch resets the hit test bounds when we change the container type. Bug: 866380 Change-Id: Ia02d958e8aa8505c82a82121e00647702da4df69 Reviewed-on: https://chromium-review.googlesource.com/1152327 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#578515}
-
Johannes Henkel authored
Add the following abstractions: - A mojom struct, DevToolsSessionState, which is used to send the state to the inspector session in the renderer, and to receive incremental updates from it (see agent_state.mojom). - InspectorSessionState, which interprets the session state received from the browser so that individual properties in the agents (modeled as fields, see below) can be initialized. This object also collects the updates incurred during field mutations. - InspectorAgentState, which connects the fields in the agents to the session state. - Fields in the inspector agent classes. These fields are Boolean, Integer, Double, String, and 1 level maps from String to any of these. For now I've only modified InspectorPageAgent, so the old session state is still there in parallel. Will work on editing the remaining agents. This is a variant of https://chromium-review.googlesource.com/c/chromium/src/+/1147929 which uses protocol::Value to encode the fundamental values stored in the session state. Change-Id: I2c2aa1354884ab6420bac764fbca8497f4785ad1 Reviewed-on: https://chromium-review.googlesource.com/1149201 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578514}
-
Noel Gordon authored
Call it getUnzippedFileListRowEntries, ie. add the FileList part to be consistent with zip helper getZipSelectionFileListRowEntries. Minor: more consistency, use !!result everywhere. Test: browser_tests --gtest_filter="ZipFiles/FilesApp*" Bug: 867738 Change-Id: I448442ac959e44da162fca0c6c15f230fa4bc1dd Reviewed-on: https://chromium-review.googlesource.com/1151587Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a0d5f35..7399ae5d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic0bbb135b76415e58f73b9ee1cc3e2e1f7ee1d8f Reviewed-on: https://chromium-review.googlesource.com/1152421Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578512}
-
Antoine Labour authored
http://crrev.com/c/1105466 changed the precondition for CommandBuffer::DestroyTransferBuffer to only require an OrderingBarrier rather than a full flush, but the implementation in PpapiCommandBufferProxy wasn't fixed to handle that. This change ensures we issue the flush before the DestroyTransferBuffer IPC if one is pending. Bug: 866644 Change-Id: I6d6a3b6a752c4bfcd32f66153c84829140ed2b5f Reviewed-on: https://chromium-review.googlesource.com/1152149Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578511}
-
Oksana Zhuravlova authored
Bug: 861923 Change-Id: If70fbe3e56d9e6e11841bf694fb45041fdcc7a38 Reviewed-on: https://chromium-review.googlesource.com/1150624Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#578510}
-
Wenzhao Zang authored
1) |getLaunchableApps| should only return launchable apps, but not all of the apps would necessarily be ready. (Non-ready apps becomes ready normally after ~10s after user session starts.) 2) |launchApp| can be used to launch non-ready apps. A spinner will be shown on the shelf and the app will launch after it becomes ready. Bug: 819404 Change-Id: I6569043226f38b6905687defb4be95554a5e5511 Reviewed-on: https://chromium-review.googlesource.com/1141349 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578509}
-
Donna Wu authored
This is a preparing CL for USB servicification which introduced WebUsbDeviceManager and its unit test. As designed, all permission management for USB devices will be consolidated within //chrome. Permission checking code in //device/usb will be moved out to this new class WebUsbDeviceManager. BUG=699790 Change-Id: I60580152ec31d1962dfdce616bd5b3729a3e60cc Reviewed-on: https://chromium-review.googlesource.com/1121971Reviewed-by:
-
