- 27 Jun, 2018 40 commits
-
-
danakj authored
While trying to remove WebLayerTreeView this file confused me greatly so try to simplify and clarify things a bit. TestWebViewWidgetClient was-a TestWebWidgetClient, but you can get a WebWidgetClient from a WebView directly by calling WidgetClient(), so no need for this adapter. AllowsBrokenNullLayerTreeView() is for when InitializeLayerTreeView() returns null, which these classes don't do, so remove it. R=dcheng@chromium.org Bug: 838693 Change-Id: I65c258d0eaedb55de70edecffa134f5bf050cb76 Reviewed-on: https://chromium-review.googlesource.com/1115901Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570883}
-
Mike Dougherty authored
TBR=eugenebut@chromium.org Bug: 857129 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909 Reviewed-on: https://chromium-review.googlesource.com/1117300 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570882}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/32dc063f6647..3f423e75215c git log 32dc063f6647..3f423e75215c --date=short --no-merges --format='%ad %ae %s' 2018-06-27 hjd@google.com Merge "perfetto-ui: Temporarily disable browser tests on Travis" 2018-06-27 hjd@google.com perfetto-ui: Temporarily disable browser tests on Travis Created with: gclient setdep -r src/third_party/perfetto@3f423e75215c The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If5a14daf322982a18ba585cbe136b30e5ad67da4 Reviewed-on: https://chromium-review.googlesource.com/1117142 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570881}
-
Eric Karl authored
Many of our current issues turned out to be due to missing shutdown logic which caused the GPU thread to shutdown before the compositor, leading to a number of DCHECKs, and a hang if those were removed. This change allows the CompositorImpl to tear down before the GPU proc. Bug: 851643 Change-Id: Ieb96da9b7132e4ccf8ebf71dc0ee920bfbeb4217 Reviewed-on: https://chromium-review.googlesource.com/1115875Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570880}
-
Adithya Srinivasan authored
Using double to represent time is error prone as the units are unclear. Change-Id: Id3a6ce23e684643f424dcbc84e2cca708faeda3c Reviewed-on: https://chromium-review.googlesource.com/1115904Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#570879}
-
Mark Pearson authored
These are requests to delete a personalized query suggestion that came from Google's servers. Tested by looking for X-Chrome-Data header using about:net-internals before and after this change on the delete request. Bug: 848992 Change-Id: I900b80891fde655d87c88d2de060728d976688b2 Reviewed-on: https://chromium-review.googlesource.com/1105463Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570878}
-
Clark DuVall authored
This was suggested in crbug.com/789636 so this logic can run in production before the launch of the network service. Had to keep the tab notification logic in each delegate, since the way NetworkServiceNetworkDelegate maps the request back to the original tab (using the URLLoader set as user data on the request) does not work if network service is disabled. Bug: 789636, 789632 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I22395f914639d8ce83457a63062927e876caeaa9 Reviewed-on: https://chromium-review.googlesource.com/1113903Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#570877}
-
Tom Anderson authored
Clusterfuzz has marked bug 821704 as fixed, though it's possible adding the logging perturbed the timing just right so that this bug is no longer triggered. Or the bug may actually be fixed. Either way, we should remove the logging to make sure the bug doesn't resurface. Bug: 821704 Change-Id: I4fb5a1394162e814ef28b2a5834af2bc13304ce0 R: gab Reviewed-on: https://chromium-review.googlesource.com/1117304Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570876}
-
Tarun Bansal authored
This reverts commit 69c98ffc. Reason for revert: The field trial experiment was turned down since it did not show any improvement (see http://shortn/_3N4YH2mKyq). Besides, the perf bots showed a regression. Original change's description: > Add ThrottleDelayable 4G params to fieldtrial_testing_config.json > > Bug: 746640 > Change-Id: Ie312a7756f5e6917a4d7c2bd107951f4928e97d0 > Reviewed-on: https://chromium-review.googlesource.com/1024054 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552765} TBR=jwd@chromium.org,tbansal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746640, 838443 Change-Id: I349ed4bdafedeadb8e80af332472937babb7b820 Reviewed-on: https://chromium-review.googlesource.com/1117220Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570875}
-
Joshua Bell authored
Chrome supports a non-standard "priority" option for cookies, which is used to prioritize eviction when the cookie jar is full. Since the document.cookie setter just passes the cookie string through IPC to RenderFrameMessageFilter::SetCookie and, after various hops, into the net::CookieStore, the option is implicitly supported even though it was intended primarily for use by the Set-Cookie HTTP header. Add test coverage so we don't unintentionally regress support for this if, for example, we change the way document.cookie passes cookies into net::CookieStore. Change-Id: I0084d2f177ca7dac88a3f20603198c689351c4a2 Reviewed-on: https://chromium-review.googlesource.com/1116059Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
Pre-Refresh a maximized window had a very condensed tabstrip, so it made sense to set Windows 10's caption button height to (slightly less than) the tabstrip height. Refresh tabs are much taller though, so now they look way too big. This patch caps their height at the restored height, since that's what Windows does in the same case. Bug: 855802 Change-Id: I305491442462a8979388cb78e0be3975d9f1c88f Reviewed-on: https://chromium-review.googlesource.com/1116188 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570873}
-
Mark Pilgrim authored
Bug: 844933 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0f23e77a0907b8def0c4f962cea7910fbc75469f Reviewed-on: https://chromium-review.googlesource.com/1113669 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#570872}
-
Mike Wasserman authored
Views mojo apps (eg. Keyboard Shortcut Viewer) will use these switches. Bug: 856341 Test: cros KSV (Ctrl-Alt-/) respects --force-[ui|text]-direction=rtl Change-Id: I7f0a2577c6c8dab362125f385305521cd624705f Reviewed-on: https://chromium-review.googlesource.com/1116003Reviewed-by:
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic1e940122133416ac7384d1a7ba117589eaab542 Reviewed-on: https://chromium-review.googlesource.com/1117466Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#570870}
-
Muyuan Li authored
Bug: b/109875600 Test: Debug build and run Change-Id: I751611b7617e1683bd17307ad971f4b9ae1bb4a0 Reviewed-on: https://chromium-review.googlesource.com/1116289 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#570869}
-
Michael Spang authored
Bug: 851997 Test: ozone_demo --enable-vulkan on vulkan-enabled eve Change-Id: I08164f47a83387e4d9311cf5271b410402c5f1ec Reviewed-on: https://chromium-review.googlesource.com/1115569 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570868}
-
Tarun Bansal authored
Change-Id: I7a2ca94e6778f93226b2a8c10faa7c62ea1a4235 BUG: 856240 Reviewed-on: https://chromium-review.googlesource.com/1114210Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570867}
-
Wenzhao (Colin) Zang authored
This reverts commit 43112301. Reason for revert: There's occasional decoding failure on login screen. Will have to revert this CL first and find a better fix for the original bug. Original change's description: > cros: Change wallpaper decoding format to default > > This issue did not show up earlier because the old wallpaper picker > only contained jpeg images. > > Also changes |shrink_to_fit| to true. > > Bug: 852844 > Change-Id: Ia26a091ee38a6de43454eda0243ff24386e77da8 > Reviewed-on: https://chromium-review.googlesource.com/1101400 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567435} TBR=wzang@chromium.org,weidongg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852844 Change-Id: Iede6a0c39b14ea7a69f980ea6d47d39628ba31ac Reviewed-on: https://chromium-review.googlesource.com/1117398Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570866}
-
David Tseng authored
- backward selections were previously not implemented/supported. Add that feature in this change. - suppress hints during selection. chromevox_tests --gtest_filter=BackgroundTest.Selection Test: manually select forwards and backwards in all possible granularities. Bug: 854872 Change-Id: Ic26a9e2d1426e8fcea31323c33c42c3476b1bc4c Reviewed-on: https://chromium-review.googlesource.com/1115913Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570865}
-
sczs authored
- Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new flag received on init. - Some minor refactoring to stop calling self on init in SigninPromoView. Screenshots: https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6 https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0 https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM Bug: 805188 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1268388da06c57eb9c1610c3547314929bb8c107 Reviewed-on: https://chromium-review.googlesource.com/1107216 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570864}
-
Mina Almasry authored
Disabled on some platforms in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1100173 Bug: 110226305 Test: Run cast_audio_unittests on desktop, internal CQ Change-Id: Ib1f3c275a53a47539d66c085d6b7c1a3d4708268 Reviewed-on: https://chromium-review.googlesource.com/1102981Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#570863}
-
Ryan Sleevi authored
In the long-ago times, OCSP stapling at the TLS layer was only enabled if the certificate verification layer would be able to use these OCSP responses as part of verification - which was true on Windows > XP and 'bleeding edge' versions of NSS at the time. However, this conditional enabling at the TLS layer has been long replaced with unconditional enabling, to support both Certificate Transparency (~2015) and Expect-Staple experiments. As a result, it's no longer necessary to report the platform capabilities to enable this optimization. BUG=none TBR=mmenke@chromium.org, bartfab@chromium.org Change-Id: Ia3c0d4cb161da47738ccb287a8286d6ce6248162 Reviewed-on: https://chromium-review.googlesource.com/1117034 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570862}
-
Andrew Grieve authored
Noticed that when d8.jar was updated recently, the dex was not rebuilt. This is because d8.jar was missing from the inputs list for md5check. Since inputs to dex.py are all generated files, it does not benefit from using md5check anyways (the main point of it is to not rebuild files when timestamps change to to changing git branches). Change-Id: Ia429556911bd6f9f0d276845ec614befea92dde0 Reviewed-on: https://chromium-review.googlesource.com/1117120Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570861}
-
Andrew Grieve authored
The "overhead" symbols are often larger than most other individual symbols in a diff, but are completely unactionable. This moves them to the bottom of a diff so that they draw less attention. Bug: 702625 Change-Id: Iddb4f2a75a8807cafce62e223a64a69886f1d0b2 Reviewed-on: https://chromium-review.googlesource.com/1116071Reviewed-by:
-
Sadrul Habib Chowdhury authored
Add some more flow trace-events for the various stages during a frame. For example: . [client] Reception of BeginFrame (ReceiveBeginFrame). . [client] Generation of RenderPass, DrawQuad etc (GenerateRenderPass). . [client] Generation of CompositorFrame (GenerateCompositorFrame). . [client] Submission of CompositorFrame (SubmitCompositorFrame). . [server] Aggregation of surfaces from various clients in the DisplayCompositor (SurfaceAggregation). An example screenshot: https://imgur.com/a/ZJGfq2J BUG=855328 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iccb7b61d485b20256cc8f35a5a4efef4c8ed63ea Reviewed-on: https://chromium-review.googlesource.com/1116345Reviewed-by:Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570859}
-
Peter Mayo authored
Revert "Truncate string attributes in the accessibility tree" This reverts commit db409e20. Reason for revert: <INSERT REASONING HERE> Original change's description: > Truncate string attributes in the accessibility tree > > Adds the helper function > BlinkAXTreeSource::TruncateAndAddStringAttribute, which truncates string > attributes when Blink's tree is serialized for accessibility. String > attributes are truncated at BlinkAXTreeSource::kMaxStringAttributeLength > bytes, currently set to 10000 bytes. > > Bug: 644805 > Change-Id: Ibd1af03a77814aa524dcb067ad1be3f3f4291c8b > Reviewed-on: https://chromium-review.googlesource.com/1113946 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570818} TBR=dmazzoni@chromium.org,dtseng@chromium.org,jamwalla@chromium.org Change-Id: Id8d54a3a1767d8fa75f54a9c0d954c44c376018f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 644805 Reviewed-on: https://chromium-review.googlesource.com/1117222Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570858}
-
Peter Mayo authored
Revert "[chrome_elf, third-party block support] Pass file path in registry." This reverts commit ea1974d4. Reason for revert: <INSERT REASONING HERE> Original change's description: > [chrome_elf, third-party block support] Pass file path in registry. > > Due to rare case of install_static::GetUserDataDir() path expansion, > this API cannot be used inside DllMain(). The full, expanded path to > the packed blacklist file will be dropped into install_static::GetRegistryPath(), > in the kThirdPartyRegKeyName subkey, in the kBlFilePathRegValue REG_SZ value. > This has no other impact on existing functionality. > > - This change includes comments, constants, and tests. > > - LogLoadAttempt() will now include the section path for any 'blocked' logs > as well. Friendly reminder that log.AddEntry() will still not add duplicate > 'blocked' logs, to protect against spammy logging. > > - Removed old bit of uninstaller touching old blacklist. > > Test: chrome_elf_unittests.exe, ThirdParty* > Bug: 769590 > Change-Id: Id9ada49215aa110db9fb72a4712da9d3fb7ccf31 > Reviewed-on: https://chromium-review.googlesource.com/1109600 > Reviewed-by: Robert Shield <robertshield@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570849} TBR=robertshield@chromium.org,tsepez@chromium.org,pennymac@chromium.org Change-Id: I8f734013213e0fa1e1321e3b573172ed9a85a649 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769590 Reviewed-on: https://chromium-review.googlesource.com/1117399Reviewed-by:
-
Dmitry Gozman authored
This is the only case when we don't even ask the client to decide the navigation policy, and it breaks a very nice assumption that DecidePolicyForNavigation is always called for renderer-initiated navigations. For reference: this was introduced [1] in 2002 (sic!) and being copied around since then. [1] https://chromium.googlesource.com/chromium/src/+/80834d145816195289a30e4168a0659380a00d75%5E%21/ Bug: 789577 Change-Id: Ic4a4671bcc34db46f70d53d4281d2ce68017ec1a Reviewed-on: https://chromium-review.googlesource.com/1114199Reviewed-by:
-
Jacob Dufault authored
Change-Id: I1abf5400e9c3dea53d22e6c0142887d37ca5e5e3 Reviewed-on: https://chromium-review.googlesource.com/1115429 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570855}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/81f51975125c..42f0d78f1ee8 git log 81f51975125c..42f0d78f1ee8 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 titovartem@webrtc.org Roll back checking in the third_party directory 2018-06-27 mhoro@webrtc.org Revert two instances of num_active_spatial_layers. 2018-06-27 alexnarest@webrtc.org Allows audio bitrate allocation in video calls without enabling TWCC (Transport Wide Congestion Control as defined at https://tools.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01.html) for audio stream. Created with: gclient setdep -r src/third_party/webrtc@42f0d78f1ee8 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icdc652eb9deb1f121940060d7f912dc8bf492587 Reviewed-on: https://chromium-review.googlesource.com/1117139Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570854}
-
Nicolas Pena authored
This CL adds a browsertest to ensure that performance.memory is not bucketized when sites are isolated. Change-Id: Icd6b1ee73a5f4e03f9e27c5f60d0cf741f66ba5c Reviewed-on: https://chromium-review.googlesource.com/1106306Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570853}
-
Torne (Richard Coles) authored
Don't print an error message if the address is invalid on Android, because Android uses UNIX domain sockets, which don't have an IP address. Bug: 854472 Change-Id: I169450b658fb22e036e70182dabc4e6193feacad Reviewed-on: https://chromium-review.googlesource.com/1108754 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570852}
-
Nasko Oskov authored
The DebuggerNotAllowedOnOtherExtensionPages test navigates to non-existing URL and threfore results in an error. This CL fixes it to succeed and unblock isolating error pages. Bug: 838161 Change-Id: I38a8bb656fab0992d9343ba39a2c5f3da497c7fb Reviewed-on: https://chromium-review.googlesource.com/1117262 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570851}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bdf3f682d14d..2d7cb9267899 git log bdf3f682d14d..2d7cb9267899 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 tsepez@chromium.org Use unowned ptr for IFWL_ delegates Created with: gclient setdep -r src/third_party/pdfium@2d7cb9267899 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib724b6598fd450565305eac5f292548f2992412e Reviewed-on: https://chromium-review.googlesource.com/1117141Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570850}
-
Penny MacNeil authored
Due to rare case of install_static::GetUserDataDir() path expansion, this API cannot be used inside DllMain(). The full, expanded path to the packed blacklist file will be dropped into install_static::GetRegistryPath(), in the kThirdPartyRegKeyName subkey, in the kBlFilePathRegValue REG_SZ value. This has no other impact on existing functionality. - This change includes comments, constants, and tests. - LogLoadAttempt() will now include the section path for any 'blocked' logs as well. Friendly reminder that log.AddEntry() will still not add duplicate 'blocked' logs, to protect against spammy logging. - Removed old bit of uninstaller touching old blacklist. Test: chrome_elf_unittests.exe, ThirdParty* Bug: 769590 Change-Id: Id9ada49215aa110db9fb72a4712da9d3fb7ccf31 Reviewed-on: https://chromium-review.googlesource.com/1109600Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#570849}
-
Bence Béky authored
Use CompletionOnceCallback instead of CompletionCallback in //net/quic/chromium. Most of these changes are private member types and method signatures, some are temporaries passed into already changed APIs, and in one instance an unused member is removed. In another instance, CompletionRepeatingCallback is used for a member that is expected to be used multiple times. Most affected callback members are already always run through ResetAndReturn, making it clear that it is safe to change type to CompletionOnceCallback. Bug: 807724 Change-Id: I94b57cec2db22bd91a09478b494185a48614266a Reviewed-on: https://chromium-review.googlesource.com/1116898 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#570848}
-
Tommy C. Li authored
This reverts commit 0830cdf0. Reason for revert: UX direction change. Original change's description: > Omnibox UI Refresh: Align Omnibox text to new Suggestion text > > The goal of the CL is to re-align the Omnibox text to match the new > Refresh spec. > > In the new Refresh spec, the text has a different indentation depending > on whether or not the popup is open, so this CL resets the insets > of the OmniboxViewViews whenever the popup opens or closes. > > It also updates LocationBarView to no longer ignore the left-inset > value of the OmniboxViewViews. We used to also ignore the right-inset > value, but we stopped doing that recently [1]. > > After no longer ignoring the left-inset value, we update the > non-Refresh value to the correct value of 0 (to keep things looking > the same), and update the Refresh value to 2, which matches mocks. > > We are updating the inset of the OmniboxViewViews textfield instead of > the bounds of the textfield because we want the whole area to remain a > clickable I-beam, even if we indent the text a bit. > > [1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc > > Bug: 849779, 823535 > Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4 > Reviewed-on: https://chromium-review.googlesource.com/1096491 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566834} TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 849779, 823535 Change-Id: Icf9e2f004042be6f25b9a86d23f269f5ebf0fd90 Reviewed-on: https://chromium-review.googlesource.com/1117218 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#570847}
-
bsheedy authored
Updates the framebufferScale used by WebXR performance tests to correspond to the recommended scale and the 1:1 pixel mapping scale. The implementation was changed recently, but these values were not updated at the same time, causing the perf tests to render WebXR scenes at significantly lower resolution than before. Bug: 853400 Change-Id: I247682ea97ac5910d0195fdba1004698c4c0679b Reviewed-on: https://chromium-review.googlesource.com/1116190Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570846}
-
Tarun Bansal authored
The hints are expected to get a bit more complicated, so move them to a separate file instead of an inner class. There is no loss in test coverage, but I am planning to add separate unittests file in a subsequent CL. Change-Id: I8c94ffc93de2e4b0e7e88c9c50344f499ab03cf3 Bug: 856243 Reviewed-on: https://chromium-review.googlesource.com/1116518Reviewed-by:
-
Bence Béky authored
Use OnceCallback instead of Callback, and CompletionOnceCallback instead of CompletionCallback, in ChannelIDService. Also restructure ChannelIDService::JoinToInFlightRequest() to use early return if in flight request in not found. Bug: 807724 Change-Id: I45b55b0713ca9460fda8480d4f8ac14d5ead4435 Reviewed-on: https://chromium-review.googlesource.com/1117029Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570844}
-
