- 01 Nov, 2019 40 commits
-
-
Avery Musbach authored
When you long press an overview item in clamshell mode with only one virtual desk, you shall be gracefully prevented from dragging it, instead of getting a DCHECK failure. Test: ash_unittests DesksTest.LongPressOverviewItemInClamshellModeWithOnlyOneVirtualDesk Bug: 1020339 Change-Id: I9fc2a6f587fea8487f11819645e68dcb8bfa5cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894531 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#711742}
-
Caroline Rising authored
This reverts commit 184873e8. Reason for revert: This is causing compile failures on linux-chromeos-google-rel. Original change's description: > Clean up old uses of AssistantAudioDecoderFactory > > This CL replaces the last use of old Mojo type of > AssistantAudioDecoderFactory interface with > mojo::Remote. > > Bug: 955171 > Change-Id: I16778198e4dc1b7a7693dbbc0f7b85ae4a3d6bbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890454 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#711712} TBR=rockot@google.com,wutao@chromium.org,gyuyoung@igalia.com Change-Id: Ibc3450e2774d5d71df873358b393f6a400ea7a3d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895735Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#711741}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7669da7bf27..5e1ef7e22ff0 git log a7669da7bf27..5e1ef7e22ff0 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 eseckler@google.com Merge "processor: Support disabling json importer separately from export_json" Created with: gclient setdep -r src/third_party/perfetto@5e1ef7e22ff0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: If7d2768917dbb20e58c371d9e89531133ec5b322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711740}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I196bc206e14e1a316abd892eef6518753109864f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894920Reviewed-by:
-
Antonio Gomes authored
This reland adds two extra sanity checks for when sending WTF::String over mojo, in case they were generated from std::string instances with String::FromUTF8(). Null WTF::String passed over mojo from renderer to browser can cause mojo validation errors as seen on [1] and [2]. This is bug [3] [1] https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280 [2] https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/53971 [3] https://crbug.com/635987 BUG=1020525, 787254 Original change's description: > Fix about:webrtc-internals "Stats Tables" > > This is a fixup CL of [1] spotted and report by hbos@chromium.org > on [2]. > > [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences) > [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1 > > Basically the original CL was supposed to replace the code > that used to bound PeerConnectionTracker to its associated > mojom::Receiver instance in [3] by the corresponding code in > Blink. > However, the replacement code got accidentally missing while rebasing > the CL over and over. > > [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777 > > This CL amends the original CL with the proper code in > blink/renderer/modules/modules_initializer.cc@RegisterInterfaces(). > > TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \ > --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001 > > Manual test= Open Chromium load about:webrtc-internals and [4]. > It is expected that WebRTC statistics appear. > > [4] https://codepen.io/anon/pen/JQLEqR?editors=1010 > > R=haraken@chromium.org > TBR=guidou@chromium.org, hbos@chromium.org > > BUG=787254 > > Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711647} R=armax@chromium.org, haraken@chromium.org Bug: 787254 Change-Id: Ie8936038788c9bc05610fcf3684375712bedae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895393Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#711738}
-
Vlad Tsyrklevich authored
In https://crrev.com/710460 I deprecated the use of base::ProtectedMemory in download_status_updater_linux.cc but forgot to apply NO_SANITIZE("cfi-icall") to one function, introducing a crash on download for Ubuntu clients. Fix that crash by marking EnsureLibUnityLoaded with the same attribute. Bug: 1020468, 1018834 Change-Id: I904372a3df7828787adfdd9041fa739e89ddc787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895373 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711737}
-
Yuly Novikov authored
A new waterfall for testing ANGLE running on top of SwiftShader on VMs instead of real HW GPUs. 12 CI bots: linux-swangle-tot-angle-x64 linux-swangle-tot-angle-x86 linux-swangle-tot-swiftshader-x64 linux-swangle-tot-swiftshader-x86 linux-swangle-x64 linux-swangle-x86 win-swangle-tot-angle-x64 win-swangle-tot-angle-x86 win-swangle-tot-swiftshader-x64 win-swangle-tot-swiftshader-x86 win-swangle-x64 win-swangle-x86 12 Try bots: linux-swangle-try-tot-angle-x64 linux-swangle-try-tot-angle-x86 linux-swangle-try-tot-swiftshader-x64 linux-swangle-try-tot-swiftshader-x86 linux-swangle-try-x64 linux-swangle-try-x86 win-swangle-try-tot-angle-x64 win-swangle-try-tot-angle-x86 win-swangle-try-tot-swiftshader-x64 win-swangle-try-tot-swiftshader-x86 win-swangle-try-x64 win-swangle-try-x86 Not running any tests at this point, to be added in following CLs. Bug: 1007018 No-try: true Change-Id: Ia1c954a3da4bcee371093e6d91a6b3a02738a1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881984 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711736}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=nparker@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Ib62b09b24e40615b3f5853d3da1c056250fe446b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895646 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711735}
-
Chris Lu authored
This matches the behavior in bannerInfobarButtonWasPressed Bug: 1019508 Change-Id: I32c4c43ec39da89067abd0122cd08ba0286b8469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894411Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#711734}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fb03935bedd7..c5e06a5d9f0d git log fb03935bedd7..c5e06a5d9f0d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 enga@chromium.org Fix result units in perf tests Created with: gclient setdep -r src/third_party/dawn@c5e06a5d9f0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic4fe45ad3d8b7146dcc494a4a6613a39d95c0402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894919Reviewed-by:
-
Tibor Goldschwendt authored
We write the list of PAK files in a module to the module's Java descriptor and load those PAK files when first accessing the module via the autogenerated module class. This gets rid of the whitelist in Module.java. Going forward DFM authors simply have to specify pak_deps and paks in the module_desc. APKs do not have proper Java module descriptors. Therefore, we add all resources of modules that are packaged into the chrome APKs to the APK's main resources.pak. Change-Id: Iaa555de0682894397ee40e6a12c3681dfd0542eb Bug: 986960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877139 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711732}
-
Yuzu Saijo authored
Currently, if all the pages for a service worker version are in bfcache, the activation of the new version is blocked. This is not desirable because page in bfcache should not conceptually exist. This CL fixes the problem by checking the pages' status upon activation, and if all the controllees for the version are in bfcache, evict them from bfcache and unblock activation. Design doc: https://docs.google.com/document/d/1_AdqUvCAZffWbYlZjmfHF-EogtFjl6jfqNmSCCHNptc/edit# Design doc: https://docs.google.com/document/d/1GynjukIwZdoA9lJyYUzUL3bejS5CXbWLw4eEts5ZKaI/edit# Bug: 1001354 Change-Id: I22c338fe9de3d1bc615c5ebc66d3534abb44c76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782247 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#711731}
-
Scott Violet authored
It's flaky TEST=test only change TBR=cduvall@chromium.org Bug: 1020065, 1019948 Change-Id: I4b5c9950e05118590fd04e83638d3545a4daee1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895383Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#711730}
-
Ben Pastene authored
Instead of pulling all of /var/log/ from the device after tests, this will pull only logs we realistically care about. This will help prevent us from pulling massive files like: https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=feb62a5316e66179b97b2e422e49ded65dd77ccb&as=system.journal Bug: 1018990 Change-Id: Ie9e901ee921bc8c45ae78f493776cecf0d2fd21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891131Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#711729}
-
Bruce Long authored
The accessibility event was not being fired when moving the caret or changing the selection when in caret browsing mode. The fix is for method BrowserAccessibility::HasVisibleCaretOrSelection to return true when in caret browsing mode and element has focus. Test coverage was also added to content_browsertests: DumpAccessibilityEventsTest.AccessibilityEventsCaretBrowsingEnabled DumpAccessibilityEventsTest.AccessibilityEventsCaretBrowsingDisabled Bug: 1014648 Change-Id: I7de70dce479fff286dd632e1acb48fb64a24d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875279Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711728}
-
Fergal Daly authored
It was thought to be fixed by https://crrev.com/c/1883352 but has been failing on the bots since that CL (which removed the filter). https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-debug/846 https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-debug/1337 TBR=rakina@chromium.org Change-Id: I297603be1ad8804a93ef6ec4aeccc85fe1edd766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892975Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711727}
-
Armando Miraglia authored
TBR=dalecurtis@chromium.org Bug: 1020131 Change-Id: Ia35dc8a8543590e45095737ab09aadc10f295d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894002Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/204286b6942e..0451e3cb7336 git log 204286b6942e..0451e3cb7336 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 perezju@chromium.org [Telemetry] Remove some unused properties in PageTestResults Created with: gclient setdep -r src/third_party/catapult@0451e3cb7336 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973837 Change-Id: Ib52b6237dd859b34a679331c9b6e27f2471f48ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895302Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=peter@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I90eed14a6f9831c6fe9317a645bfd78398855a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894886 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711724}
-
Christopher Cameron authored
Separate the code that MacViews uses to draw scrollbars into a location that can be included by Blink. Make a handful of updates to the MacViews scrollbar drawing code - Add dark mode support - Make the track paint transparently when in overlay mode - Blink expects the track to paint transparently - MacViews uses layer opacity (and so make MacViews only use the non-overlay opaque path) - Update the non-overlay scrollbar width to be 15 dips instead of 12 dips (to match Cocoa) - Update the inset of the thumb to be different in overlay vs non-overlay mode - Change the scrollbar track colors to be a less pronounced gradient (to better match Cocoa) Bug: 961835 Change-Id: Ic87a3482280864ad2067ecdacace521b40c8c62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892423Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#711723}
-
Jan Krcal authored
This CL updates removed suffixes for sync data types and expands instructions to do so on an ongoing basis. The WIFI_CREDENTIAL type has been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1823849. Bug: 1007293 Change-Id: Ib70e0a2ef132270f84a7b55e5017a5aedc3837e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890080Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711722}
-
Tommy Steimel authored
This CL introduces a platform-agnostic System Media Controls API that MPRIS, System Media Transport Controls, and Now Playing will all implement. It moves just the Windows implementation into it for now. Public design doc: https://docs.google.com/document/d/1_UjhXdXzQlPEwFKpogTZm-ILylKid4lTiOomqHv-IPg/edit?usp=sharing Bug: 949596 Change-Id: Ie453c38b15f9739d44ed7f2b4ba6eb9b6dde3270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891456Reviewed-by:
-
Jeremy Roman authored
If we want to allow this to be refused by the browser due to conflicting navigation, we will need more than a boolean here. This changes it to an enum and adds the skeleton of handling this distinction between results from the successor renderer and result generated by the browser. Bug: 1013389 Change-Id: I0944d0bf962e523a5037f99207a1f955a7f1b1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887668 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711720}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0a260d789fe9..9e349b7d76cd git log 0a260d789fe9..9e349b7d76cd --date=short --no-merges --format='%ad %ae %s' 2019-11-01 rharrison@google.com Add flag for updating invalid expecations and rewrite end logic (#856) Created with: gclient setdep -r src/third_party/shaderc/src@9e349b7d76cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I4f202c785da4018b39d9b8aff2a76450f3216f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895299Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c3d1f9b0cd99..26452ff7db33 git log c3d1f9b0cd99..26452ff7db33 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 srte@webrtc.org Cleanup of TransportFeedbackAdapter. Created with: gclient setdep -r src/third_party/webrtc@26452ff7db33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I1b0278680a8b5e290a86200efe59270e3769a182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895300Reviewed-by:
-
Sammie Quon authored
TBR=newcomer@chromium.org Test: none Bug: none Change-Id: I4c0781099586610bf3f58dbb270bf4c18d612427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895374Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711717}
-
Dominic Mazzoni authored
Change http://crrev.com/c/1161322 modified the Android accessibility bounds computation to account for use-zoom-for-dsf. However, there's another place in the code where this computation is needed - when computing character bounds, for the API used by select-to-speak to highlight individual words. This was still unscaled, so the bounds were incorrect. Bug: 870230, 933119 Change-Id: Ic0d80436895b9fb9b7586b73f55719c94621cdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894317Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711716}
-
Ian Barkley-Yeung authored
We are still seeing lots of flakes on tast test ChromeCrash[Not]LoggedIn.broker because it cannot find a broker process to kill. My current hypothesis is that sometimes the broker process's call to setproctitle() is failing. setproctitle() will silently fail if something goes wrong, which is normally fine (it's just to make `ps` output better) but which messes up the integration tests. Add some VLOGs to confirm or deny. In particular, by logging the PID of the broker process, I can compare to ps.txt and see if that process exists with a different title. Change https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1888317 will activate the VLOGs during the tests. BUG=chromium:984807 TEST=Ran tast -verbose run --extrauseflags chrome_internal my_crbook ui.ChromeCrashLoggedIn.broker with change 1888317. Saw expected output in logs. Change-Id: I5ab77ff36194cd3fe7e2b7d69e7426738baae33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888870 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#711715}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f062cdaa7fd..2540704a38af git log 8f062cdaa7fd..2540704a38af --date=short --no-merges --format='%ad %ae %s' 2019-11-01 borenet@google.com [infra] Update git, make [Canvas|Path]Kit et al use git from CIPD 2019-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 841b01678c49..e96039218e9d (6 commits) Created with: gclient setdep -r src/third_party/skia@2540704a38af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I9f48132a8dcbc8edda39d64d14711bda41d9c632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895009Reviewed-by:
-
haozhe authored
Both firefox and chrome failed with the bug filed: https://crbug.com/995349 Bug: 900581 Change-Id: I037f772aa391de65cefc2267390d28f40e0bdde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891435 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711713}
-
Gyuyoung Kim authored
This CL replaces the last use of old Mojo type of AssistantAudioDecoderFactory interface with mojo::Remote. Bug: 955171 Change-Id: I16778198e4dc1b7a7693dbbc0f7b85ae4a3d6bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890454Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#711712}
-
Livvie Lin authored
Bug: 1008219 Change-Id: I7517202a58ab3d363d9f8f6ba354f7c2a6dd08e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884428Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711711}
-
Matvey Larionov authored
Bug: 330260 Change-Id: I93b00f0c992d879c26f883132eece92a382bb3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890413 Auto-Submit: Matvey Larionov <matthewtff@yandex-team.ru> Reviewed-by:
-
Fredrik Söderquist authored
When 'end' changes so that we need to discard/prune our current interval, and said interval is the first interval, revert back to waiting for a first interval again. Bug: 1020163 Change-Id: I7185253474e23a3a58294043102c91e1a59fe10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895335Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#711709}
-
Etienne Bergeron authored
This CL is adding a fuzzer for RenderText API. The stream of bytes is used to drive which API is called and with which parameters. Bug: 1019913 Change-Id: I7a3e6ed2f881a228619d50eefff35cc7093bcc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890958 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#711708}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7870e6996a1..a7669da7bf27 git log a7870e6996a1..a7669da7bf27 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 primiano@google.com CI: Don't run benchmarks under sanitizers and debug Created with: gclient setdep -r src/third_party/perfetto@a7669da7bf27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic94f9b06f7c4f96e7cd54fd5492c4a484b57f660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894759Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 8e4bd238. Reason for revert: want to verify that workarounds to https://crbug.com/869227 inside vpython itself are actually useful plus to read more logs. The original can re-landed any time if new occurrences of https://crbug.com/869227 manifest themselves. Original change's description: > Remove SpawnedTestServer timeouts. > > These timeouts are ancient. The test infrastructure has its own > timeouts, which should make these obsolete. Also, this may help with > https://crbug.com/869227, where starting the Python test server > times out. > > Bug: 869227 > Change-Id: I9ea4f3174bcaa86daf09b965c82921432d8d556a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869717 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707894} TBR=davidben@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869227 Change-Id: Ic11c2e9a78568738a7712a1141876840f8a63740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893789 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#711706}
-
dpapad authored
CL produced with ESLint's --fix command line flag. Not sure whether those violations existed before ESlint checks were applied to this folder, or whether they were added later. Bug: 1019312 Change-Id: I36c6c6fd1bda88f69b9823ec0dbaec64b09729bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892216 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711705}
-
gogerald authored
Bug: 982018 Change-Id: I6d9bb134e4d98fbd7ebae7a889afd14f880dbfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894139 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711704}
-
Nico Weber authored
This reverts commit dfd0e0a0. Reason for revert: This reverted half the change, leaving trunk broken, see https://crbug.com/1020524 Original change's description: > Revert "Make AppMenuModel keep most submenus in a vector." > > This reverts commit 849315dd. > > Reason for revert: [sheriff] does not build on Mac per builder (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/125702) > > Original change's description: > > Make AppMenuModel keep most submenus in a vector. > > > > They are only needed for ownership, so no need to give them names and concrete > > types. Removes some forward declarations from the header and serendipitously > > happens to remove GOOGLE_CHROME_BUILD from the header as well. > > > > No intended behavior change. > > > > Bug: 961769 > > Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032 > > Commit-Queue: Robert Sesek <rsesek@chromium.org> > > Auto-Submit: Nico Weber <thakis@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711431} > > TBR=thakis@chromium.org,rsesek@chromium.org > > Change-Id: Id7abf98d32a424fdf3d8d0638c9967931eec30a8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 961769 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893867 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711663} TBR=thakis@chromium.org,rsesek@chromium.org,armax@chromium.org Change-Id: Iae16e60dadcda2a91ff8207e214f18989caf5a53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895640Reviewed-by:
-
