- 27 Mar, 2019 40 commits
-
-
Krishna Govind authored
R=kariah@chromium.org Change-Id: I155ba406dc0952193ca37dbdb8f8d865cbfba592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539830Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#644662}
-
Salvador Guerrero authored
ProtoDatabaseProvider had an unused refptr to a TaskRunner, this CL removes it and updates some comments. Bug: 870813 Change-Id: I3980842c4741f2e84f93dcd8070c338b08cf3b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538996 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#644661}
-
Tetsui Ohkubo authored
StaticKCM was launched in M74. TEST=manual BUG=b:122704772 Change-Id: I445e4b019ac570b5728e589deef139298f1391d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535468Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#644660}
-
Daniel Cheng authored
This reverts commit 596ae5a1. Reason for revert: breaks code search, which indexes generated files Original change's description: > [clang] Drop generated files in compilation database. > > Generated files (e.g. bind_unittest_nc.cc) are less interesting than regular > human-written files, e.g. it doesn't make sense to apply clang-tidy FixIts to > them; clangd indexer are not interested in indexing them. > > And these files are usually not generated when running clang-based tools. > > size of compilation databse: 204M => 176M > number of entries : 44450 => 38198 > > Change-Id: I32c639562187f814a9286f945b9dfcfbc4ab21d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526264 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Haojian Wu <hokein.wu@gmail.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644005} TBR=dcheng@chromium.org,hokein.wu@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id57f162675df0bb274690868f9436edf80c4a0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540148Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644659}
-
Peng Huang authored
Bug: 932614 Change-Id: I8a0618eaddc4d192c605763e5cac37f7e73d3024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536115 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644658}
-
Hwanseung Lee authored
Use enum class instead of enum for MouseEventType. enum class is more type safety. Bug: 940736 Change-Id: I0fae2ab027041bbe1bb8e100f35a2c5220a47026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530277Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#644657}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1a9f8ed9bf54..49191a7ef481 git log 1a9f8ed9bf54..49191a7ef481 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 thestig@chromium.org Get rid of XFA_LOGIC_TYPE. Created with: gclient setdep -r src/third_party/pdfium@49191a7ef481 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1ec255f8d2ac52504f9e36aa0b7380b163694062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540142Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644656}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b7cca4cd8e4..bf341ae88c83 git log 2b7cca4cd8e4..bf341ae88c83 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 csmartdalton@google.com Revert "Add MSAA and non-aa modes to GrFillRRect Op" Created with: gclient setdep -r src/third_party/skia@bf341ae88c83 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Iff3870ce6d49b8980b299cb5255353c35c0f0d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540716Reviewed-by:
-
Peter Kasting authored
Bug: 946022 Change-Id: I19b3a232b0cf4ed2d874b7c115ed8db3562f5ee6 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540677 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644654}
-
Daniel Murphy authored
Locks were assumed to be granted synchronously when all previous locks were destructed. This isn't the case when there is a chain of dependent locks, as granting a lock posts a task. Since the delete code doesn't need a transaction to work (yet), remove the locks here, and refactor this area for the new Scopes integration. R=pwnall@chromium.org Bug: 945370 Change-Id: Ifce3163852db6b2eae2127ee7062e788a19b9546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539211Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#644653}
-
Dana Fried authored
Pulled the event handler that spies on the root window's event stream (pre target event handler) into a separate class. Intrinsic BubbleDialogDelegateView behaviors were marking some events as handled which prevented them from being passed to the appropriate browser views. The net result was that drag no longer worked if hover cards were active; there were probably other problems as well. Bug: 910739 Change-Id: I747f5ff2ab492367b07ca26a96ea5a5329acb871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540681 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644652}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/91e949292f59..5490e9aca17e git log 91e949292f59..5490e9aca17e --date=short --no-merges --format='%ad %ae %s' 2019-03-27 jiawei.shao@intel.com Fix clip space on D3D12 and OpenGL Created with: gclient setdep -r src/third_party/dawn@5490e9aca17e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id06a6c3b7f30e86733bcfc85a3f2b1e1a1a4c6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540573Reviewed-by:
-
Yeol authored
collection of string vectors. Instead it should take a single vector of expected value structs. FormAutofillTest: :ExpectLabelsAndTypes() took an ever expanding Bug: 896682 Change-Id: I1ddbf1fd27c6f397965292c1685fcceda7c0adae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539326Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#644650}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c8bd9e358dfd..ffb1c9fdaf5e git log c8bd9e358dfd..ffb1c9fdaf5e --date=short --no-merges --format='%ad %ae %s' 2019-03-27 sadrul@chromium.org telemetry: Fix thread-pool usage on mac. Created with: gclient setdep -r src/third_party/catapult@ffb1c9fdaf5e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:946072 TBR=sadrul@chromium.org Change-Id: I2eb5a949d916d14a696f6f0bd4e68787966ceaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540717Reviewed-by:
-
Manu Cornet authored
Allow arrow key navigation in the overflow bubble as well, so that app reordering also works and integrates smoothly with keyboard navigation in there too. This does not yet support reordering of app across the "overflow border" (e.g. last app of main shelf with first app of overflow). Also refactor a simple |IsArrowKeyCode| function in a place where it's easy to reuse. Some places in app_list could also use this but that part of the code has a slightly unusual namespace pattern usage and I didn't want to mess with BUILD.gn and deps too much. See this "in action" at: https://bugs.chromium.org/p/chromium/issues/detail?id=888637#c28 Bug: 888637 Change-Id: Icfa22870bd603093cd4889ffdea10d91c01abbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535304Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#644648}
-
BUG=762641 TBR=malaykeshav@google.com Change-Id: If9f176972e542a5165364b0e75af87b92e4e1b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534415Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed0cd5dc2078..261711304bcc Created with: gclient setdep -r src-internal@261711304bcc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:944789,chromium:942819 TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I343e495598b70d03a00e9487cd317d6b7be77a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538755Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644646}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d732177c04f..c74cce1e7a8c git log 5d732177c04f..c74cce1e7a8c --date=short --no-merges --format='%ad %ae %s' 2019-03-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c74cce1e7a8c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic0c65790188506955e20cc60e148cb90105ba3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538754Reviewed-by:
-
Victor Costan authored
Chrome patches SQLite to remove two features from the FTS3 extension. This CL adds LayoutTests verifying that the features are not available to WebSQL. The tests ensure that we won't accidentally expose the features as we shed our SQLite patches. Bug: 945204 Change-Id: I50364520c33bdfbbbc9b5521fcf6dff37d9fe419 Tested: Ran the blocked commands in a vanilla sqlite3 shell. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538864 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644644}
-
Luciano Pacheco authored
Currently <cr-menu-item> don't have tabindex at all by default so it can't be focused, making cr.ui.Menu.focusSelectedItem less useful. Tabindex=-1 is focused only via JS not via Tab key, if a tabindex is specified like tabindex=0 which receives focus via Tab key, this value is preserved. Bug: 889153 Change-Id: I32339c936ad01e67d1214bc2f721168ef24219d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535319 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#644643}
-
rajendrant authored
With network-servicification, 407 failures bypass the proxy for a random duration of 1-5 minutes, which leads to drop in data saver usage. This CL reduces that bypass duration. This CL also reduces initial delay for fetching the client config. Bug: 945419 Change-Id: Ifc297a3ee7b681e76ce752612a6b05feba642ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539210Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#644642}
-
Dean Liao authored
TransmissionEncodingInfoHandler is used to handle MediaCapabilities.encodingInfo() API with "transmission" type. Also updates corresponding web_tests. BUG=817382 TEST=Test MediaCapabilities.encodingInfo() API on CrOS devices. Pass content_unittest: out/Debug/content_unittests \ --gtest_filter=TransmissionEncodingInfoHandlerTest.* Pass web_tests: 1. autoninja -C out/Debug blink_tests 2. python third_party/blink/tools/run_web_tests.py --debug \ third_party/blink/web_tests/media_capabilities/encodingInfo.html \ third_party/blink/web_tests/external/wpt/media-capabilities/encodingInfo.html Change-Id: Ideda536f5193d84d5a668445cca9c725b6a2e829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472410Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#644641}
-
Ehsan Karamad authored
This CL hooks up post messaging API for frame-based MimeHandlerView. A current post message test which runs only for BrowserPlugin version is now modified to run for frame-based MimeHandlerView as well. Bug: 659750 Change-Id: Ie58fa733f463e697e38a100f78e0e50e7431b983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539869Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#644640}
-
Peter Kasting authored
Bug: 946024 Change-Id: I62b07d3899814007a6ba3331c4888b9475f29033 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539133Reviewed-by:
-
Renjie authored
https://quiche.googlesource.com/quiche.git/+log/60e6ed1b3d4e..9132654c7968 $ git log 60e6ed1b3..9132654c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-25 quiche-dev Use 'bytes' instead of 'string' for holding binary data 2019-03-23 quiche-dev Add a QUIC_BUG to ensure that whenever an ACK cannot be written, the writer is write blocked. Protected by existing flag gfe2_reloadable_flag_quic_use_uber_loss_algorithm. 2019-03-23 quiche-dev Add a test making sure ACK alarm is canceled on write blocked when supporting multiple packet number spaces. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I92ab51e46327e3fce41f6540dcf6382d2f5dbc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538880Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#644638}
-
Peter Kasting authored
This reverts commit efbe41b8. Reason for revert: Mac bots are failing consistently, see e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/40949 Original change's description: > Change unoptimized-images feature policy to unoptimized-lossy-images. > > This makes it more clear that this policy applies only to lossy image > types (for now, just JPEG). This patch also makes the implementation > more generic in order to make the policy compatible with parsed > policy values and to pave the way for implementing a > lossless-enforcing version of the unoptimized-images policy as well. > > These changes have been pulled from a larger partially reviewed CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1524869 > > Bug: 942659 > Change-Id: I0242ac900b1653b89d6d8dbd63616003dcaaba62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531354 > Commit-Queue: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644488} TBR=flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,paulmeyer@chromium.org,iclelland@chromium.org Change-Id: I0dc0449dc2d07c5dafa84c7123ec664c902a73fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540145Reviewed-by:
-
Brian Sheedy authored
Fixes flakiness in VrBrowserNativeUiTest#testVoiceInputUnavailableIfSiteUsingMicrophone caused by not waiting for residual animations from navigating before attempting to display the permission prompt. Change-Id: Ie530f12d9595869ea56cf351652665043f377d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540685Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#644636}
-
Xianzhu Wang authored
This reverts commit 24025d13. Reason for revert: crbug.com/945152 has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1536992. Original change's description: > Revert "[BlinkGenPropertyTrees] Paint frame overlay in correct property tree state" > > This reverts commit c656dcba. > > Reason for revert: crbug.com/945152 > > Original change's description: > > [BlinkGenPropertyTrees] Paint frame overlay in correct property tree state > > > > Frame overlays should use the device emulation transform node if exists > > as the transform state. > > > > Because the node is ready only after PrePaint, we need to let frame > > overlays update graphics layer status at the end of PrePaint, instead of > > previously unclear (maybe during layout, or paint etc.) > > > > Bug: 934300 > > Change-Id: Ic6e2fe5d29f444dba1a3bf206ffa1775df4adc3d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525199 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#642184} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 934300, 945152 > Change-Id: Ie50c55532da20dbe44da94c90f93a3ed20bd2a6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536912 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643731} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I2c7b123bdd6ddf0d813008196864425d9daed8e8 Bug: 934300, 945152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537780 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644635}
-
Matt Menke authored
This CL makes it so that WebSocketTransportClientSocketPool no longer inherits from TransportClientSocketPool. Since it has almost no shared logic, this inheritence was unnecessary and a little confusing. Bug: 944097 Change-Id: I5c70257e3b48bf05bf5e7e9c5732cedb24166904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532919 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#644634}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the seventh clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I12a1a76762791edb72c893a4ed73c93ea1a5cf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539325Reviewed-by:
-
Simon Que authored
Bug: 945731 Change-Id: Iebda88878c34687f4d60172b2ba07141a54d5cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539632Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#644632}
-
Oksana Zhuravlova authored
This change adds annotations for mojom entities in the generated headers. These annotations will be used for creating codesearch-related metadata. They are only generated if enable_kythe_annotations build flag (also added by this change) is true (it defaults to false). Bug: 943856 Change-Id: I94a16fc8fb95045ec80e893157b733b4cb8da0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534342 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#644631}
-
Yusuf Ozuysal authored
1) Routes swipe down through a delegate OverviewModeController passed during construction in LayoutManagerChrome. This keeps default behavior as is but swipes down to the Grid when Grid or TabGroups is enabled. 2) Gets back swipe to side for both grid and tab groups. This was disabled while looking for a solution to 1) above. Now the only caveat is swipe to side scrolls between tabgroups if there are tabgroups which is WAI. 3) Disables both side swipe and swipe down from the bottom toolbar for the tab groups case where tabstrip needs the swiping gesture as it technically can become long enough that it needs to scroll BUG=941676 Change-Id: I706a3aa778ab08c5e46fbbcaaec40eb7f69c56fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537250Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644630}
-
Maksym Onufriienko authored
Bug: 912323 Change-Id: I15aa8fe90fff81bdec97ba03eea07b57b4c280e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529622Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#644629}
-
Taylor Bergquist authored
Tabs opened from a link with middle click, shift middle click, or'Open in new tab' from the link's context menu will open in the current tab's group. This CL is part of the prototype of the above-described tab groups feature. The prototype will allow users to create and manipulate groups primarily via tab context menus, and will display tab group affiliation in the tabstrip. Future work will include persisting and syncing groups, manipulating groups via tab dragging, and a dropdown menu for the group headers. See go/chrome-tab-groups-design Bug: 905491 Change-Id: Ibc75d39ca3bfb30bcd0ff34de9db2a8a841d57ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441493 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the fifth clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibf76598bef9077f26622619ad93ca96820acae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538264Reviewed-by:
-
Peter Kasting authored
Bug: 946023 Change-Id: Ia8873635b8c1363eeca69ab0600eb8a8a656cbc8 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540680Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/de253137e334..1a9f8ed9bf54 git log de253137e334..1a9f8ed9bf54 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 tsepez@chromium.org Tidy some warnings from clang-tidy 2019-03-26 thestig@chromium.org Avoid 0 byte reads in ParseAndAppendCrossRefSubsectionData(). 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::GetNameExpression() a member of CXFA_Node. 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::NodeIsTransparent() a member of CXFA_Node. Created with: gclient setdep -r src/third_party/pdfium@1a9f8ed9bf54 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945624 TBR=dsinclair@chromium.org Change-Id: I7b42a886ae518b8649d6dc4e8365f8960596827c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540537Reviewed-by:
-
Staphany Park authored
Bug: 918293 Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#644624}
-
Nico Weber authored
Else they'll hang around and slowly fill up bot disks. TBR=hans Bug: 464945 Change-Id: Iecb8e3b24dd1585e89567025614389296f895d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540481Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644623}
-
