- 02 Feb, 2018 40 commits
-
-
Hector Carmona authored
CL adds slot="<appropriate slot>" to all users of paper-input container who are using polymer from: chrome://resources/polymer/v1_0/paper-input/paper-input-container.html R=dpapad@chromium.org Bug: 807475 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I15d7e7d7c24776855e99c8764a296357e459d235 Reviewed-on: https://chromium-review.googlesource.com/898268Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#533901}
-
Peter Boström authored
Fixes several missing entries, also removes a couple of instances of trailing punctuation from titles as well as add "In Title Case: " to a couple of existing message descriptions. Bug: chromium:807886 Change-Id: I9a184f0cfd2e27f332a2b118af8663990ed36f65 Reviewed-on: https://chromium-review.googlesource.com/898484Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533900}
-
Aseem Garg authored
R=nednguyen@chromium.org,bradnelson@chromium.org BUG=v8:5558 Change-Id: Ib2b285e2dd487a974e76e2e930291b9cff8250be Reviewed-on: https://chromium-review.googlesource.com/890116 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#533899}
-
Hayato Ito authored
Prevent a possible wrong usage of {First,Last}AssignedNode(). Bug: 776656 Change-Id: I5d84b062c92cd89e40e3c051ae08bcefea658d25 Reviewed-on: https://chromium-review.googlesource.com/896725Reviewed-by:Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#533898}
-
Kyle Horimoto authored
This CL adds additional enum values to tether.proto and updates HostScannerOperation to accept these updated enum values when GmsCore notifications are disabled. Note: This CL's contents were already landed in https://chromium-review.googlesource.com/c/chromium/src/+/894729. However, this CL needed to be merged to the M-65 branch, so I'm landing two separate CLs and only merging this one to the M-65 branch. Bug: 793936, 672263 Change-Id: If04c1a2e2f5123c2a156a4925c19d3f801b45877 Reviewed-on: https://chromium-review.googlesource.com/897411Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#533897}
-
Yuke Liao authored
This CL implements a feature to display code coverage by components. The high-level structure of this change contains three different views: - directory_view: organizing by top level directories under src/. - component_view: organizing by components. - file_view: organizing by each single file. The directory_view is the default view to which index.html redirects to, and each html report contains links to toggle between the three views. Bug: 799632 Change-Id: I3df09fef2dfa0c8da2535f03d02d478b9c51bc8c Reviewed-on: https://chromium-review.googlesource.com/894992 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#533896}
-
Jun Choi authored
Add support for parsing response received from authenticator to corresponding CTAPResponse objects. Bug: 804626 Change-Id: I3030125371c4ac66c443a6bae938f63757066db7 Reviewed-on: https://chromium-review.googlesource.com/850815 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#533895}
-
Khushal authored
Canvas currently uses cc's ImageDecodeCache in at-raster mode, i.e, all images are locked only for the duration of a draw op. For cases where a small set of images are used repeatedly across ops, this causes a lot of lock/unlock churn on GPU discardable which can be expensive. This change ensures that we unlock images only at the end of a canvas frame. This includes the deferred raster mode where the canvas maintains a PaintRecord that is flushed during the main frame and at the end of a script task that mutates the canvas. In addition, the cache maintains a memory budget to ensure that we purge regularly if the budget is exceeded. R=ericrk@chromium.org, junov@chromium.org Bug: 804325 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic5a1f65993ca9af874a0351215fb9aa6ca41140f Reviewed-on: https://chromium-review.googlesource.com/884881Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533894}
-
Pavel Feldman authored
Change-Id: Ie9e792d2a191aa65c3ff6a0ac49175bc9957fb42 Reviewed-on: https://chromium-review.googlesource.com/894604 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533893}
-
Sasha Morrissey authored
Bug: 800349 Change-Id: I4555b66e001907803ec47597cdc2111cc62807bd Reviewed-on: https://chromium-review.googlesource.com/895230Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#533892}
-
Theresa authored
Compilation on some bots started failing due to the removal of a broad lint suppression for values-v17/styles.xml. This CL adds back lint suppression for a conditionally used VR theme. BUG=806060 TBR=wnwen@chromium.org Change-Id: I7756f07f35c272937a9fbbeae22500d0f73944a6 Reviewed-on: https://chromium-review.googlesource.com/898410 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533891}
-
bsheedy authored
Deduplicates most WebVR/WebXR tests into one test implementation that takes different arguments for WebVR and WebXR. Bug: 804043 Change-Id: I1486a4d8e75d91fe98c1298f3b528df4bc01d938 Reviewed-on: https://chromium-review.googlesource.com/896800 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#533890}
-
David Tseng authored
Typically, Output prefers roleDescription when an output rule specifies $role. However, for some roles e.g. group, we explicitly don't include the role in the output rule since it is not helpful. In the case where role description is available, we should use it. In other cases, a message string e.g. @describe_radio, already includes the role, so we don't explicitly include the role description. In these cases, simply include role description in addition to the native role. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I943560019eb3529cc9199f27985c243d3b9758e7 Reviewed-on: https://chromium-review.googlesource.com/897998Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533889}
-
Adithya Srinivasan authored
All these caches only return nodes that are in the Document tree. They only need invalidation when a changed node is in/previously in the Document tree, so they don't need to be separately invalidated at the Document level. They will automatically be invalidated when the ancestors of a node are invalidated in InvalidateNodeListCachesInAncestors, because the Document is an ancestor. Change-Id: I3da315c77e0afe8c82822ea25b8df8099535eded Reviewed-on: https://chromium-review.googlesource.com/890704Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533888}
-
Evgene Gubernatorov authored
In media picker dialog on Mac, when sharing tab, when selected tab is deleted, there was no "Share" buttun state update (which should disable it). That caused crash, report was auto uploaded from Chrome Canary 66.0.3334.0: Bug: 807811 Change-Id: I6cf29087b5cf0926b03b2c27e404fe0d57edcf21 Reviewed-on: https://chromium-review.googlesource.com/895529 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533887}
-
Hector Carmona authored
Screenshot in Bug. Bug: 800149 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic439125d601f66904ec3c5dfb30d71b1a45fec5f Reviewed-on: https://chromium-review.googlesource.com/884998Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#533886}
-
Martin Sramek authored
ConsentAuditorFactory used CR_DEFINE_STATIC_LOCAL to define a singleton. In single-process tests, this results in the factory surviving between subsequent test runs. Instead, use base::Singleton which is destroyed and recreated with the test fixture. Bug: 781765 Change-Id: I46374d6c28ece58eec764db3ff4fa5cffd43216b Reviewed-on: https://chromium-review.googlesource.com/897947Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533885}
-
Jonathan Backer authored
This is the start of autogenerating code for the client side to use a raster command buffer. The methods that I chose to autogenerate are unchanged in crrev.com/c/895868 Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I44d7187c45718ab1f5a9b32a047af95edccebb80 Reviewed-on: https://chromium-review.googlesource.com/897750 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#533884}
-
Vladimir Levin authored
This patch ensures that the transformed table parts that act as containing blocks also do so for percent width/height children. R=wangxianzhu@chromium.org, chrishtr@chromium.org Bug: 804952 Change-Id: Idf01cd98094e59639f2833f42909eac2dccaac3b Reviewed-on: https://chromium-review.googlesource.com/896822 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#533883}
-
https://webrtc.googlesource.com/src.git/+log/bc3b7828139c..5f94aa2c013e $ git log bc3b78281..5f94aa2c0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I26d3b47c6371fd6ef6c46601c26039fbb8f7bc78 Reviewed-on: https://chromium-review.googlesource.com/898248 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533882}
-
CrystalFaith authored
Print sample extension was still functional, but outdated. Updated the manifest: Background script is now non-persistent. Changed "tabs" permission to "activeTab". Bug: none Change-Id: I8755cd905e3f45aed584c3f23c356517fde25705 Reviewed-on: https://chromium-review.googlesource.com/885066Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/fb25606e584e..59790cef1a09 $ git log fb25606e5..59790cef1 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 tsepez Make CFXJSE-created contexts refer to their CFXJS counteparts. 2018-02-01 hnakashima Change internal usages of GetPageIndexDeprecated() to new method. 2018-02-01 tsepez Introduce CXFJS_Engine::EngineFromContext/SetEngineInContext helpers Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icd96b5a757862630eeaa541a5811caa304bd5925 Reviewed-on: https://chromium-review.googlesource.com/898431Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533880}
-
Theresa authored
This reverts commit ffc93ab8. Reason for revert: This change broke It broke components_unittests on multiple bots. See crbug.com/808260. Original change's description: > Reland "Remove influence of group name on NTPPopularSites studies" > > This is a reland of 1a544c78. > > Original change's description: > > Remove influence of group name on NTPPopularSites studies > > > > Recently, a misnamed study (see deleted test config) caused the feature > > to fall back to the default popular sites. This isn't a big problem but > > when it was finally named correctly, the names of the groups disabled > > all popular sites. > > > > Popular sites should not be so easy to disable. Therefore, remove the > > group name condition. > > > > A forced cmd line flag should cover all possible cases and make the > > intention very clear. This is already in place and remains untouched. > > > > Bug: 794329 > > Change-Id: I71458d41de6d0e0d5f0d8fcde1b636b0fe18618c > > Reviewed-on: https://chromium-review.googlesource.com/827072 > > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#528301} > > Bug: 794329 > Change-Id: I0c391668095cd66be012f0d1d483ff0970cbb018 > Reviewed-on: https://chromium-review.googlesource.com/888560 > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533690} TBR=treib@chromium.org,gayane@chromium.org,mastiz@chromium.org,fhorschig@chromium.org Change-Id: I2ca9733fc9fbb2efa667e44af25ab204f24c2efd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 794329, 808260 Reviewed-on: https://chromium-review.googlesource.com/898494Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/7a13705e03b7..e45d32abe132 $ git log 7a13705e0..e45d32abe --date=short --no-merges --format='%ad %ae %s' 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5c5d7deef..95ed19473 (1 commit) 2018-02-01 mtklein avoid using tmpnam() in Lua 2018-02-01 ethannicholas updated SkSL README 2018-01-26 herb Consolidate all the id handling and caching code. 2018-02-01 reed check matrix for SkFixed32.32 compatibility 2018-02-01 bsalomon More sample count cleanup: 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 9dbaeba89..5c5d7deef (1 commit) 2018-02-01 reed signal on bad picture op, simplify other ops 2018-02-01 bsalomon Revert "Revert "Redefine the meaning of sample counts in GPU backend."" 2018-02-01 halcanary SkQP: skia_skqp_global_error_tolerance 2018-02-01 robertphillips Fix SkSurfaceCharacterization unit test for DDL 2018-02-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ c0db9adde..9dbaeba89 (1 commit) 2018-02-01 halcanary SkQP: README: note need java8 not other version 2018-02-01 reed detect truncated pict streams Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I356ef0cdd122bada160b20ba42ebf5f4516564f1 Reviewed-on: https://chromium-review.googlesource.com/898430 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533878}
-
Mohamad Ahmadi authored
Fixes the histogram names for the autofill keyboard accessory view on iOS in histograms.xml to match what's being recorded in components/autofill/core/browser/keyboard_accessory_metrics_logger.mm Change-Id: I98094280f8586164be3e6aa5d1393d321605a1c9 Reviewed-on: https://chromium-review.googlesource.com/898044Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533877}
-
Emil A Eklund authored
Move the logic in NGInlineNode that populates the legacy layout tree out of NGInlineNode and into the new NGInlineNodeLegacy class. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7d228a1c9b1c28f301838336ecc1348eacb6e663 Reviewed-on: https://chromium-review.googlesource.com/898003Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#533876}
-
Ethan Kuefner authored
This page is the only page subject to some hairy filtering logic in smoothness.py that we're trying to clean up. This CL removes the page and the aforementioned filtering logic. Bug: catapult:#4215 Change-Id: I43bcb12aef218fc5aaa00d801af3924dd44a0a55 Reviewed-on: https://chromium-review.googlesource.com/897970 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Bug: 672263 Change-Id: I1979e2726617f566684b373f5051cdbf32bf3120 Reviewed-on: https://chromium-review.googlesource.com/884322Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#533874}
-
Kouhei Ueno authored
This CL adds support for "byte string" keys in map. We plan to use this to encode signed exchange "Canonical CBOR". Bug: 803774 Change-Id: Ia10a64781d66c66665a7b3c9749e93b46b30b108 Reviewed-on: https://chromium-review.googlesource.com/892939 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
For HTML pages, fixed-position elements are laid out incorrectly if fullscreen is implemented using contentInsets, so they are implemented by updating the frame of the entire WKWebView. For PDFs, however, the page indicator UI is laid out incorrectly for frame adjustments on some versions of iOS. This CL updates the web view proxy's setting so that contentInsets are used. Bug: 808202 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3ed57cc160fdea9edcdd85430b41ff3ff4171dac Reviewed-on: https://chromium-review.googlesource.com/898383Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#533872}
-
Chris Hamilton authored
This adds plumbing of NOTIFICATION_LOAD_STOP to a "Loaded" signal on the PageCU, and modifies the PAI logic to consider period of network and CPU quiescence after the loaded signal has fired. This also moves state tracking machinery related to the PAI signal out of the PageCU and directly into the PageSignalGenerator as a cleanup. BUG=800903 Change-Id: Ia3461c831c3427c8b01afedd4aaa1033c8083b2c Reviewed-on: https://chromium-review.googlesource.com/879225Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
lpy <lpy@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#533871}
-
Parastoo Geranmayeh authored
Sometimes websites change the format of the placeholders. This makes us detect the second one as a value entered by the user, and then we miss the field. Solution: While filling the form in the renderer, compare the placeholder value with the element value case-insensitively. Fixes: www.cargurus.com, etc. Bug: 807747 Change-Id: Id97a2b9978818ed22dacfd9ee427886562bf6f41 Reviewed-on: https://chromium-review.googlesource.com/898072 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533870}
-
Matt Falkenhagen authored
This tests that a canvas is tainted when the video had multiple responses from a service worker, if any of the responses were opaque. Bug: 780435 Change-Id: Ifef394c87921cb646b1728a9079908264673fdd4 Reviewed-on: https://chromium-review.googlesource.com/897165Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533869}
-
Evan Stade authored
This should be functionally identical. It's pretty simple to move as nothing in it depends on //chrome/. Chrome may need to replace it with something else that tracks metrics for non-message center notifications (i.e. native notifications), but this class was already not tracking those. Also note there are separate metrics-collecting codepaths specifically for web and extension notifications which overlap with the functionality of this and may be good enough for the platforms which don't use MessageCenter. Bug: 578868 Change-Id: I83bc3484d0ec524e13813aea0e9c7ce0a62600a6 Reviewed-on: https://chromium-review.googlesource.com/895825Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#533868}
-
Dmitry Gozman authored
Bug: none Change-Id: Ibd8f22a4f484ca375043576d46af521b8ae5bfc1 Reviewed-on: https://chromium-review.googlesource.com/898186Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533867}
-
Kyle Horimoto authored
This reverts commit affdaea5. Reason for revert: This patch is being split into two so that one can be submitted with string changes and one can be submitted without string changes. See https://bugs.chromium.org/p/chromium/issues/detail?id=793936. Original change's description: > [CrOS Tether] Update "enable GmsCore notifications" UI. > > This UI is shown on the settings page when a phone tells the Chromebook > that it does not have GmsCore notifications enabled. > > This CL: > (1) Updates HostScannerOperation to accept an additional enum value > indicating that GmsCore notifications are disabled. > (2) Updates the settings page to show an extra step which is needed in > some cases to enable notifications. > > Bug: 793936, 672263 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I65f34db384956189e6ea3c157a57f48bc4701fe4 > Reviewed-on: https://chromium-review.googlesource.com/894729 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533167} TBR=stevenjb@chromium.org,khorimoto@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 793936, 672263 Change-Id: I95c7c434b2eecce7b5462f495bab936c2ab082fe Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/897471Reviewed-by:
-
Peter Boström authored
This left-aligns Username / Password labels for Harmony and also matches mocks for future dialog updates. Bug: chromium:654115 Change-Id: I42efa789a09d6f6845535e94bb65fa789bdc19fa Reviewed-on: https://chromium-review.googlesource.com/898074Reviewed-by:
-
Kurt Horimoto authored
When drags occur, the scroll view's content is tracking the pan gesture, so the model is not decelerating. This is helpful to reset state, as |-scrollViewDidEndDecelerating| is sometimes not called for small pixel adjustment deceleration animations. Bug: 807992 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2de2a6354c836247c02c72332a429d0b19ffae21 Reviewed-on: https://chromium-review.googlesource.com/898034 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533864}
-
Saman Sami authored
If a CompositorFrame arrives that has a size of zero, we already issue surface invariants violation. Just block such CompositorFrames at IPC boundary. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6b79c9de5ed7fb8492d9128d7fcd07d8f1b66f8b Reviewed-on: https://chromium-review.googlesource.com/896559Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533863}
-
Yash Malik authored
This CL: - moves the common text editing bits from TextInput into UiElement so that they can be reused from ContentElement. - adds the notion of "pause until acked" to GvrKeyboardDelegate (rationale explained in comments). - adds keyboard plumbing from UI to Browser which will actually do something useful in a follow up patch (https://chromium-review.googlesource.com/c/chromium/src/+/867513) Bug: 641470 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I53690b8068e777297bc7c2dfd7a92eac42966ff9 Reviewed-on: https://chromium-review.googlesource.com/895290Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#533862}
-
