- 15 Oct, 2018 40 commits
-
-
Sammie Quon authored
Test: manual Bug: 881483, 891366 Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21 Reviewed-on: https://chromium-review.googlesource.com/c/1279356 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599778}
-
Sky Malice authored
Bug: 894178 Change-Id: I4883559139110accab3646cbd0a4dc5ab9dfdf85 Reviewed-on: https://chromium-review.googlesource.com/c/1278465Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599777}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I90108e14ed0c8efab2fad7cce2d1bd693b1f0ff1 Reviewed-on: https://chromium-review.googlesource.com/c/1282107Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#599776}
-
rbpotter authored
MediaRouterElementsBrowserTest.MediaRouterContainerCastModeList MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1 Bug: 875463 Change-Id: I6037ea16e264307a801840964197c058f33ab2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1279415Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599775}
-
Aleksey Kozyatinskiy authored
This reverts commit 9c39f918. Reason for revert: break breakpoint in minified sources. Original change's description: > [DevTools] removed Breakpoint._currentState > > Current state on breakpoint shared between different models is hack > that should never work. > > R=lushnikov@chromium.org > > Bug: none > Change-Id: I60a0e5774c47c38a0f5f251f9e9d5f2437ceb9b4 > Reviewed-on: https://chromium-review.googlesource.com/1179262 > Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583934} TBR=lushnikov@chromium.org,kozyatinskiy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: Id6a170405c0d07658ff5741142dc2b35b7f89c6b Reviewed-on: https://chromium-review.googlesource.com/c/1281688Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#599774}
-
Dominick Ng authored
The IntentPickerBubbleView is provided with a list of app candidates to display to the user for them to choose to open a link. If Chrome can handle a link, it is included in the list of candidates, but it is erased in IntentPickerBubbleView::Init(); users use an independent button in the UI to open the link in Chrome. This led to a browser crash bug in the ArcExternalProtocolHandler, where it was possible for Chrome to be the only candidate available, e.g. in the case of a geo:// URI scheme link. On clicking a geo:// link on a Chrome OS devices with Play enabled and no Android apps available to handle the geo:// URI scheme, the intent picker would try and select the 0th index app candidate during its initialization, but this would be null since the only candidate (Chrome) was erased. This CL fixes the bug by not creating the intent picker at all if the only app candidate is Chrome. The external protocol dialog can only be triggered if Chrome originally decided it couldn't handle the URL, so in this case we simply fall back to the Chrome OS standard dialog (which says that Chrome OS can't handle the URL). BUG=893042 Change-Id: I171d547e51a4dfb37d51c3e71a88a8c84539a8fa Reviewed-on: https://chromium-review.googlesource.com/c/1280090 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599773}
-
Darren Shen authored
Currently, KeyboardUI has a weird interface where |GetKeyboardWindow| will start loading the keyboard web page if it is called the first time. So this resulted in a lot of places where we were calling GetKeyboardWindow and didn't know whether it would cause a load or not. We change the KeyboardUI interface a bit to explicitly state when we are creating / loading a keyboard window, vs just getting an already loaded one. This removes ChromeKeyboardUIWebContent's dependency on KeyboardController as well. We tried to keep the same behaviour for existing KeyboardUI subclasses. Bug: 845780 Change-Id: I3178c81c382f2c3cd8217eda5a0c9b9d489df5be Reviewed-on: https://chromium-review.googlesource.com/c/1264336 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#599772}
-
Michael Spang authored
This class doesn't support overlays, so "return false" is actually correct. Bug: none Test: run_content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu Change-Id: I8768c2d5cdb3de8b4ce9f50a4efd18848e321bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1281686Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599771}
-
Scott Violet authored
Now that there is serialization code for mouse/touch, this code should no longer be needed. BUG=895619 TEST=covered by tests Change-Id: Ia439067d35dd239e914b8bace1164f97bba5c26e Reviewed-on: https://chromium-review.googlesource.com/c/1282032Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599770}
-
Joel Einbinder authored
This adds the new properties: invisible editable focusable focused settable Bug: 887173 Change-Id: Iaa9dc346d10648ada9d16c6a3568f83fdd83f397 Reviewed-on: https://chromium-review.googlesource.com/c/1244548Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#599769}
-
Luum Habtemariam authored
The use of the IppValidator chrome service has been iterated until it now just a secure parser that passes the rigorously formatted result to the validator. This name change of IppValidator --> IppParser reflects that. Bug: None Test: Behavior N/A and unchanged Change-Id: I3369b59973bb0f55200ed450c8558a8616f92355 Reviewed-on: https://chromium-review.googlesource.com/c/1278585Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#599768}
-
Albert J. Wong authored
This is just a starter file without much in it yet. It came out of a thread on the principles for how one gets added to //base/OWNERS. The summary was originally written by danakj@ and later resummarized and posted by gab@ in to https://chromium-review.googlesource.com/c/chromium/src/+/1216602 Bug: none Change-Id: I4dcb438226c84020de77e4d6873ab9330d891bee Reviewed-on: https://chromium-review.googlesource.com/c/1220677Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#599767}
-
Morten Stenshorne authored
NG does this more correctly than legacy. This is quirks mode, and legacy doesn't drop the block-end margin on the P inside the table cell, like it should. https://html.spec.whatwg.org/multipage/rendering.html#margin-collapsing-quirks In quirks mode, any p element that is the child of a td or th element and has no substantial following siblings, is expected to have a user-agent level style sheet rule that sets its 'margin-block-end' property to zero. TBR=dgrogan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I075b56d439056546da737b1c08fa80b24dd33314 Reviewed-on: https://chromium-review.googlesource.com/c/1281423 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599766}
-
Peter Boström authored
An earlier refactoring set zero-insets for touchable AvatarToolbarButton instead of insets for TOOLBAR_BUTTON. This API was confusing to use so SetLayoutInsets was changed and renamed to SetLayoutInsetDelta to make it easier to use. Callers no longer need to include the call to GetLayoutInsets(TOOLBAR_BUTTON). CastToolbarButton having incorrect ink-drops was not a regression but has always used a 16dp icon in both touchable and non-touchable modes. This change also calls SetInsetDelta to make up for the missing 8dp. Bug: chromium:895263 Change-Id: I30595913dfb8a19358d198d9f4e0dbcb37993117 Reviewed-on: https://chromium-review.googlesource.com/c/1281903Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599765}
-
Michael Spang authored
Add a note that explains how to capture device capabilities for tests to avoid errors in manually entered data. Also make the script capture all devices if none are specified, so that it's easier to run. Bug: 895553 Test: ui/events/ozone/evdev/capture_device_capabilities.py Change-Id: I84ca174077cd77a89e8adf59570e9e33e1fd04a9 Reviewed-on: https://chromium-review.googlesource.com/c/1281232 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599764}
-
Guohui Deng authored
When appropriate, AudioOutputStream uses MixerService for lower latency audio playback. Bug: internal b/29571387 Test: Play a lasting sin wave audio on two devices, to make sure the AudioOutputStream plays fine whether or not MixerService is used. Change-Id: Ieebd53ee5ecdc1c6e249601366d82de30c5d9119 Reviewed-on: https://chromium-review.googlesource.com/c/1271007Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599763}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I293419ed726feb3a05ac85ab3d9150744535c285 Reviewed-on: https://chromium-review.googlesource.com/c/1281865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599762}
-
Peter Boström authored
Moves color derivation to GetInkDropBaseColor() and removes ripple and highlight overrides. This change also makes use of the newer FocusRing class instead of using a FocusableBorder. FocusRing automatically follows the highlight path and has a more consistent style with the rest of the UI. This change also removes an override of AddInkDropLayer which clipped the layer to the view bounds. This is not required for this ink drop as it only paints within the highlight path which is within the view bounds. Bug: chromium:888204 Change-Id: I7b388f1fe52aea6b14c32d27c0f39d5e2cff527e Reviewed-on: https://chromium-review.googlesource.com/c/1279289Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599761}
-
Shakti Sahu authored
1 - Download home looks black on tablets for certain views such as storage header, date header etc. This is fixed by adding the default background color to the main view, which was also present in old download home. 2 - Share crashes when there is no activity to handle it. Fixed it by wrapping with an intent chooser intent. 3 - Changed images on tablets to use fixed 240dp width instead of going full screen. Bug: 889723 Change-Id: Ib9d582f7f81debd2b588dc901ddfede36829ef33 Reviewed-on: https://chromium-review.googlesource.com/c/1278143 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599760}
-
gogerald authored
This CL also records script's running status. Bug: 806868 Change-Id: I36adaffce7718d875a2bd0497dc281dd795b12f1 Reviewed-on: https://chromium-review.googlesource.com/c/1281722 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599759}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I51c3a93e47157e5b203fc39f72d5f083b305cc80 Reviewed-on: https://chromium-review.googlesource.com/c/1281233Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599758}
-
Mike Wasserman authored
Bug: NONE Change-Id: I7616d84159788203ebd0016ba745867d3f09f711 Reviewed-on: https://chromium-review.googlesource.com/c/1281179Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599757}
-
Scott Violet authored
KeyboardController adds a pre-target handler, but it never removes it. I'm going to add some DCHECKs to ensure there are no pre-target handlers when an object is destroyed, so this needs to be fixed. BUG=867035 TEST=none Change-Id: Ic8700f1b2433380afaa0fbdff428baf51bfda49b Reviewed-on: https://chromium-review.googlesource.com/c/1281163Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599756}
-
Michael Spang authored
Add some tests for quirks to force USB devices to probe as internal devices. Bug: b/116723180 Test: events_unittests Change-Id: Ic044d3db80034bf972f7099a569251f21d3da9ce Reviewed-on: https://chromium-review.googlesource.com/c/1281226 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599755}
-
chrome://interventions-internalsRyan Sturm authored
Change-Id: I78dbd167d319a24c25c9f1631f2adbaa2cdd64ce BUG=894996 Change-Id: I78dbd167d319a24c25c9f1631f2adbaa2cdd64ce Reviewed-on: https://chromium-review.googlesource.com/c/1271675 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599754}
-
dpapad authored
Also fix newly found JS Compiler errors (apparently ES6 classes trigger stricter checks, which is good). Bug: None Change-Id: I22460e5e7c2fc6449317c31642ba1f69fe12eccc Reviewed-on: https://chromium-review.googlesource.com/c/1279412 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#599753}
-
Lukasz Anforowicz authored
ContentBrowserClients assume that |browser_context| client is not null (e.g. HeadlessContentBrowserClient::DoesSiteRequireDedicatedProcess and ChromeContentBrowserClientExtensionsPart::DoesSiteRequireDedicatedProcess). To avoid surprises, this CL adds DCHECK(browser_context) to most methods of ContentBrowserClients, so that the assumption is documented and verified during //content-layer tests. Bug: 787576 Change-Id: I115ab53bb64cebe50b5993a39b3e153e3054b1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1276559Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#599752}
-
Aga Wronska authored
Change-Id: I2c32fb619d45746896329400737edc08ed6a0dde Reviewed-on: https://chromium-review.googlesource.com/c/1281425 Commit-Queue: Aga Wronska <agawronska@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599751}
-
Clifford Cheng authored
All tests complains about no MR dialog because Harmony UI kicks in. Change-Id: Ibcef272966f802a8fa52b8ade0f2a8247c25ca78 Reviewed-on: https://chromium-review.googlesource.com/c/1281181Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599750}
-
Yuchen Liu authored
Once offline license is released, MediaDrm won't allow restore it no matter whether server ack is received or not. However EME allows persistent session to be loaded back in such case. We should treat such failure as success in persistent license. BUG=883895 TEST=Test page in the bug and see "EVERYTHING WORKS!" in the log. Change-Id: I301c9fd69cd21e323aaec0446a857ac4a65d2bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1227114 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599749}
-
Ken Rockot authored
Adds a |suppress_navigations| option to NavigableContentsParams, allowing clients to block navigations from occurring as a result of e.g. user gesture or scripting behavior. When enabled, suppressed navigations instead trigger a message on the NavigableContentsClient interface and a corresponding event on any attached NavigableContentsObservers. Bug: 854367 Change-Id: I85b4a0ca970f83a4d0b27e56843f99841434c483 Reviewed-on: https://chromium-review.googlesource.com/c/1269444 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599748}
-
Henrique Grandinetti authored
It was stored in minutes, which was causing some rounding problems when the CheckTimeLimit function was called less than 1 minute before the device being locked by a screen time. Bug: 895036 Change-Id: Ia6d243e8d59e32fa07151e76542b6235caf5b33a Reviewed-on: https://chromium-review.googlesource.com/c/1281662 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#599747}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f274436bd0d..2f727917ac25 git log 9f274436bd0d..2f727917ac25 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: add reviewers and ccs to git push command if possible. Created with: gclient setdep -r src/third_party/depot_tools@2f727917ac25 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875089 TBR=agable@chromium.org Change-Id: I3ecf74c74a21847cb52ffb91bd7d66687e93738d Reviewed-on: https://chromium-review.googlesource.com/c/1281202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599746}
-
Sergey Ulanov authored
It's not safe to map resizeable VMOs because they can be resized while being mapped and Zircon faults the thread that tries to access mapped memory outside of the VMO bounds. This CL adds ZX_VM_REQUIRE_NON_RESIZABLE to zx_vmar_map() calls, which ensures that mapped VMOs are always non-resizable. Change-Id: I5b40347400f839c2e4d879054d222950ba0d3d31 Reviewed-on: https://chromium-review.googlesource.com/c/1281051 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599745}
-
Jonathan Backer authored
Reland of https://crrev.com/c/1258206. Revert of that CL was to defer until after M71 branchpoint to avoid unnecessary risk. Zero code change in this reland. This CL uses RasterDecoder for CPU rasterization (one-copy and zero-copy) on worker background raster threads in two cases: (1) in renderers whenever GPU raster is blacklisted or cannot create GrContext (similar to LayerTreeHostImpl::GetGpuRasterizationCapabilities) (2) in browser whenever GPU raster is not requested This CL copies some of the logic in LTHI::GetGpuRasterizationCapabilities to RenderThreadImpl::SharedCompositorWorkerContextProvider. I copied it so that if we fail GPU rasterization using GLES2Decoder, we can fallback to CPU raster using a RasterDecoder. TBR=piman Bug: 880911 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I097ede2266c9ddc4c6f6c777b34419399eb21bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1281084 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#599744}
-
Carlos IL authored
Added histograms that log start/failure/response code for autoupgraded resources, and start/failure/connection success for autoupgraded websockets. Metrics for form submissions will come in a later CL. Bug: 893685 Change-Id: I7715a61c2f7a7582d5b317c1fa8c8fa60c1408a2 Reviewed-on: https://chromium-review.googlesource.com/c/1275295 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#599743}
-
Jamie Walch authored
Bug: 879729 Change-Id: I8a7296b344c42115a7fade7d965a6b38f0688f59 Reviewed-on: https://chromium-review.googlesource.com/c/1281239Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#599742}
-
Peng Huang authored
This reverts commit 0cb76248. Reason for revert: performance regressions Original change's description: > Skia: Enable ExplicitlyAllocateGPUResources & SortRenderTargets. > > Enable those two options which may improve skia performance. > > Bug: 894492 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I80a1b9d1ce018d90ab91e5e676b6d09a7dc23d8d > Reviewed-on: https://chromium-review.googlesource.com/c/1273267 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#599321} TBR=penghuang@chromium.org,robertphillips@google.com,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894492,895408,895384,895377,895369,895280 Change-Id: I657077091716a618d18a3d1109531e6b3819108c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1281055 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599741}
-
Corentin Wallez authored
Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to translate shaders from SPIRV to other shading languages, and requires glfw for testing. Adds the Zlib license to the list of allowed license for Android. This also adds back shaderc that was very recently removed. So hopefully a new third_party review isn't required. BUG=chromium:870747 Change-Id: I506156072f34e70e12797f922a979aa8c743bd6e Reviewed-on: https://chromium-review.googlesource.com/c/1244817Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599740}
-
Ben Kelly authored
This CL fixes some edge condition interactions when being loaded as a ReadableStream. In particular, it: 1. Properly distinguishes between the end of the DataPipe and a closed DataPipe with bytes left to be read. A ReadableStream that is not actively draining the pipe could get closed too early. 2. Responses must support explicit completion in order to handle error conditions properly. This CL makes DataPipeBytesConsumer wait for an explicit signal before closing. 3. Service worker navigation preload is updated to provide the explicit completion signals. Bug: 894815 Change-Id: I2b5d61f9fe4a6f17c37e8a728b2f081debe6d936 Reviewed-on: https://chromium-review.googlesource.com/c/1278910Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#599739}
-