GitLab

BUG=381581

> Add authentication support to AttachmentUploaderImpl.
> 
> Update AUI to request an access token and send an Authorization header
> with each requests.  If the server responds with 401, AUI invalidates
> its token, but does not retry.  Retries will be implemented in a future
> CL, probably at a higher level.
> 
> BUG=371516
> 
> Review URL: https://codereview.chromium.org/304253010

TBR=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/316413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275357 0039d316-1c4b-4281-b951-d872f2087c98

We don't build browser_tests on official
> Include browser_tests.exe in output of official Chrome Windows builds.
> 
> 
> BUG=379986
> 
> Review URL: https://codereview.chromium.org/302403003

TBR=anandc@chromium.org

Review URL: https://codereview.chromium.org/314113007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275350 0039d316-1c4b-4281-b951-d872f2087c98

chrome://tracing uses TimeTicks::NowFromSystemTraceTime in
base/time/time_posix.cc.

The previous patch is reverted because it did not check this
test is running on Chrome OS.

TEST=nacl_loader_unittests  # on i686 and ARM Chrome OS
TEST=trybot (including linux_chromeos)
BUG=378063
R=jln@chromium.org

Review URL: https://codereview.chromium.org/317913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275347 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Other patches need to land before this. This broke bots.

Original issue's description:
> [Telemetry] Overhaul startup metric.
> 
> This focuses us on the user-perceived aspects of startup.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275194

TBR=aiolos@chromium.org,jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/317743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275345 0039d316-1c4b-4281-b951-d872f2087c98

This version is likely less efficient, but doesn't require gin.

BUG=372065

Review URL: https://codereview.chromium.org/294123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275342 0039d316-1c4b-4281-b951-d872f2087c98

1) BeginInteraction+EndInteraction becomes
    interaction = action_runner.BeginInteraction(...)
    interaction.End()

2) Add action_runner.ExecuteJavaScript.

3) Replaced all existing use cases.

Other cleanups:
1) s/JavascriptAction/JavaScriptAction/
2) s/GetJavascriptMarker/GetJavaScriptMarker/


BUG=361809

Review URL: https://codereview.chromium.org/313383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275341 0039d316-1c4b-4281-b951-d872f2087c98

WebTouchPoint has used floating point co-ordinate and radius values for awhile, but we've never allowed generating non-integer values via EventSender.

BUG=323935

Review URL: https://codereview.chromium.org/316303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373091

Review URL: https://codereview.chromium.org/321433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275339 0039d316-1c4b-4281-b951-d872f2087c98

This is when we expose DrawBuffers extension.

BUG=376951
TEST=the attached test case, webgl conformance
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/315283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=oshima@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/310243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357517

Review URL: https://codereview.chromium.org/281323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/316223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347825

Review URL: https://codereview.chromium.org/309593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275334 0039d316-1c4b-4281-b951-d872f2087c98

Focus a media source when it's view is tapped. Select it on double-tap.

BUG=380490

Review URL: https://codereview.chromium.org/317783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275333 0039d316-1c4b-4281-b951-d872f2087c98

There's no reason to have this. It was originally because PermissionsData
didn't really belong on Extension (and was to be taken off), but now that
PermissionsData is refactored to only include active permissions, it belongs
on the extension object.

TBR=ben@chromium.org (c/b/ui - simple refactor, no functional changes)
TBR=thestig@chromium.org (c/b/media_galleries - simple refactor, no functional changes)
BUG=379356

Review URL: https://codereview.chromium.org/315573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275332 0039d316-1c4b-4281-b951-d872f2087c98

Added two JSON tree dumps to be loaded by the perftests

Same as issue 305063002 (https://codereview.chromium.org/305063002)

Review URL: https://codereview.chromium.org/312233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/314223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275330 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue where a lazy require of app bindings (when unavailable) will not yield a properly constructed bindings export.

BUG=373179

Review URL: https://codereview.chromium.org/319783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275329 0039d316-1c4b-4281-b951-d872f2087c98

And with this patch, the error detail is shown in case of error.

BUG=355545
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/315103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275328 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378911

Review URL: https://codereview.chromium.org/303123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275326 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the upstream libaddressinput strings into the Chrome
build inside of chrome/app/address_input.grdp to work well with the
translation tools.

TBR=estade@chromium.org
BUG=327046

Review URL: https://codereview.chromium.org/312883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275325 0039d316-1c4b-4281-b951-d872f2087c98

Only take a screenshot if the page id changes.

Looking at NavigationControllerImpl::ClassifyNavigation(), I think this is the
right check. If we could move the code for taking the screenshot post
controller_->RendererDidNavigate() call, we'd be able to use the NavigationType
calculated in that method, but based on the comments for the screenshot code,
this doesn't seem like a safe thing to do.


BUG=375921

Review URL: https://codereview.chromium.org/316553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275324 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/314583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275323 0039d316-1c4b-4281-b951-d872f2087c98

Listen for clicks in the embedded app and close the corresponding view when clicked.

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/311423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381374

Review URL: https://codereview.chromium.org/317153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275321 0039d316-1c4b-4281-b951-d872f2087c98

This is behind the cloud devices flag. Registration is nonworking at the moment. Scan for an display WiFi devices in the devices page.

Depends on:
https://codereview.chromium.org/294173002/ [build variable for WiFi bootstrapping]
https://codereview.chromium.org/226883002/ [WiFi library for cloud devices]
https://codereview.chromium.org/288043004/ [bootstrapping device lister]

BUG=370071

Review URL: https://codereview.chromium.org/296963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275320 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org, rch@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/312193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275319 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/318893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275318 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275317 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175582:175594&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/321443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275316 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275309 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/316083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380680
TBR=reed@google.com

Review URL: https://codereview.chromium.org/322463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275306 0039d316-1c4b-4281-b951-d872f2087c98

Moves many of the files in sync/notifier to components/invalidation.

This change does not introduce any new dependencies.  The relevant
dependency rules both before and after this change should be:
- chrome/browser/invalidation and chrome in general depend on
  components/invalidation.
- components/invalidation depends on sync/notifier and sync in
  general.
- sync/notifier, components/invalidation, and various parts of
  chrome all depend on sync/internal_api/public.

The eventual goal is to move all of sync/notifier into
components/invalidation.  The invalidation-related parts of
sync/internal_api/public should be moved to components/invalidation,
too.  This will allow us to remove the deopendencies from
components/invalidation to sync, and remove sync's dependencies on
cacheinvalidation and libjingle.

This change is a regression in terms of shared library componentization.
the files in the sync/notifier folder could be built as a shared
library.  The files in compononents/invalidation do not support this
yet.  The SYNC_EXPORT declarations in the moved files have been changed
to INVALIDATION_EXPORT so as to not lose this information, but the
macros are currently #defined to no-ops.

This change does not attempt to rename any classes or namespaces.
Many of the files ported from sync/notifier still use the syncer
namespace.  Some, like SyncSystemResources, still have names tied
to their sync heritage.  This will be addressed in future CLs.

Some non-trivial or non-obvious changes include:
- invalidator_state.h was moved to sync/internal_api/public/base so it
could be shared by both sync/ and components/invalidation.  This should
be fixed in a future CL.
- FromNotifierReason was split out of invalidator_state.h and moved to
the newly-created components/invalidator_reason_util.h

TBR=zea,rtenneti,mallinath,dcheng
BUG=259559

Review URL: https://codereview.chromium.org/315433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381180

Review URL: https://codereview.chromium.org/314263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275304 0039d316-1c4b-4281-b951-d872f2087c98

The original CL was reverted in r275139 for XP test failures:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31455
(MediaGalleriesPlatformAppBrowserTest.Scan timeouts)
I've addressed this here by reverting a test helper:
MediaGalleriesScanResultDialogViews::AcceptDialogForTesting

r272016 regressed web-modal dialog shadow styling.
Use CreateDialogWidget for dialog creation to fix that.
Only set SHADOW_TYPE_NONE for new-style dialogs there.
(removes the double border, consolidates dialog widget init)
Take WidgetDelegate for ConstrainedWebDialogDelegateViewViews.
Mark web-modals as ui::MODAL_TYPE_CHILD and child widgets.

Remove now unused Widget::CreateWindowAsFramelessChild.
(keep a copy for the system-modal captive portal dialog)
(that dialog is very odd, system-modal and "web-modal"?)

Add [Create|Show]WebModalDialogViews helper functions.
Use these for c/b/ui/views web-modal dialog init/show.
(cannot be used by c/b/chromeos, so cleanup less there)
Cleanup includes, cached widgets, using statements, etc.

BUG=376646, 378970
TEST=Views tab-modal dialogs appear as expected.
TBR=wittman@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/319013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378064

Review URL: https://codereview.chromium.org/312043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275302 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275301 0039d316-1c4b-4281-b951-d872f2087c98

Pulls in:
9caa384 avcodec/mpegaudiodec: Reset dither and mdct state

BUG=381356
TEST=md5 hashes of decoded packets match (test coming separately).
R=wolenetz@chromium.org
TBR=wolenetz

Review URL: https://codereview.chromium.org/319043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275300 0039d316-1c4b-4281-b951-d872f2087c98