- 11 Oct, 2019 40 commits
-
-
John Lee authored
Bug: 1010349 Change-Id: I796809b063a92cfca1cfdf243b8aee66b51e283d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854217Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705304}
-
Maksym Onufriienko authored
Add handling to prevent potential timeouts in suprocess.check_call We're observing some timeouts in some of the bot runs, so we're trying to add some preventative guardrails in test_runner in places that have blocking calls to prevent potential timeouts. Handling freezes in blocking calls will allow for more graceful recoveries and/or even just better data collections in the case of time outs if they happen. This CL specifically is adding some handling around suprocess.check_call in tear_down. Since this is a blocking call, if it should freeze, it would cause the entire tear_down to timeout instead of gracefully recovering and completing the rest of teardown, which would include data collection.e.g. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8900250401157621888/+/steps/base_unittests__iPhone_X_iOS_13.1___with_patch__on_iOS-13.1/0/stdout Bug: 1011851 Change-Id: Ib5a955551e209648b9982593b9e2c1ee4a71f7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845774 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#705303}
-
Xiyuan Xia authored
Make perf test generate LUCI test result json when trace is enabled so that performance test script could pick it up and extract metrics out of the trace file. Test result json follows the TestResultEntry spec in LUCI Test Results format (go/luci-test-results-design). Outputting in this format will allow reusing the code for results processor ( https://docs.google.com/document/d/1GYiqUJGxdUWtg9YQMXEXSILylG4J2wpiGIZM8F-HD_U ) for gtest perf tests. Bug: 945711 Change-Id: I405b3aeab1217d5f87a9c7d3eba8f5e8eabac4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790122 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705302}
-
Darin Fisher authored
Bug: 1006919 Change-Id: Ib0fb43411215bfba48ece94323f9167588f7adeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856847Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705301}
-
Robert Liao authored
This is still currently used for testing. BUG=979530 TBR=weili@chromium.org Change-Id: Ie837afa0f996faf22303459ffbfdb03c3182b938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857204Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#705300}
-
Marc Treib authored
After recent cleanups, HasEntry(), GetUrlForEntry(), and ViewEntry() didn't do anything useful anymore. Bug: 1007942 Change-Id: I14cfaf0804bed1f280c9710b470e81968090d639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855982 Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705299}
-
Lei Zhang authored
TBR=lukasza@chromium.org Bug: 988938 Change-Id: If76ccad83da2685a82d06f6dfda5c9850879abaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857478Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705298}
-
Jan Wilken Dörrie authored
This change makes base::CheckedContiguousIterator's API constexpr and updates base::span's begin and end member functions. Furthermore, this change makes the various CHECK_* macros usable in a constexpr context (given that the condition actually is true), and makes more use of them in CheckedContiguousIterator. Bug: 817982, 828324 Change-Id: I012941d31237559a7776948c613c45e9ff60b2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856519Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This test tests UA-specific behavior; see https://github.com/web-platform-tests/wpt/pull/19557 Bug: None Change-Id: I650dfa3c59488ad44c4b91f70be5144fd56f6024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856860Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705296}
-
Mike Jackson authored
This change ensures that we only run best-practice and wcag2a rules, and disables low value or performance impacting rules. These are the net new rules enabled: - duplicate-id-active - duplicate-id-aria - input-button-name - role-img-alt This change does not disable any rules that were previously running prior to the axe-core upgrade. Change-Id: I3b1942e09b29aed6e1055e5159d2d52eb2aa260d Bug: 1013391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854561 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705295}
-
Lei Zhang authored
Also disable TabStackTraceTest.testCrashMinimalSymbols for the same reason. TBR=crouleau@chromium.org Bug: 820282 Change-Id: Ib7096d1fdb97b3e870b82b3d41deb188989d8727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856850Reviewed-by:
-
Guido Urdaneta authored
This system permission is currently checked using a heuristic due to lack of a specific API. However, this heuristic might not be 100% reliable. This CL adds a feature flag as a precaution in order to make it easier to disable the heuristic. Bug: 993692 Change-Id: Ie07ff1eef930e0e42f14392abf1cddcbcfb8dfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857120 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705293}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec08b81b4fde..07295b9bedc6 git log ec08b81b4fde..07295b9bedc6 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 ahassani@chromium.org auto_updater: Fix payload properties file for very old payloads Created with: gclient setdep -r src/third_party/chromite@07295b9bedc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8fe39d157b2c054669e5912098dbaa5c5fb632d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705292}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/12265a8f7de0..5c869191c19f git log 12265a8f7de0..5c869191c19f --date=short --no-merges --format='%ad %ae %s' 2019-10-11 ehmaldonado@chromium.org Reland "depot_tools: Use vpython to execute fetch." 2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@5c869191c19f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I6bcad588c3870892f9cf38fb60e1612e0f5377f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857163Reviewed-by:
-
Lukasz Anforowicz authored
Main change =========== Site Isolation and process allocation should work correctly even in absence of a cooperating renderer process - there should be no need for the renderer-side ChromeContentRendererClient::ShouldFork. This CL removes the NTP-related parts of that method. Treating NTP navigations as browser-initiated ============================================= After removal of NTP-related ShouldFork, NTP navigations won't go through OpenURL, but will go through the regular BeginNavigation code path. The NTP relies on ChromeContentBrowserClient::OverrideNavigationParams to treat clicking NTP links as browser-initiated, bookmark-like navigations. Before this CL OverrideNavigationParams would be only applied to OpenURL-like code paths. To address this, the CL moves the call-sites of OverrideNavigationParams from 1) before OpenURL calls to 2) NavigationRequest::StartNavigation. This aspect of desirable behavior is covered by the LocalNTPTest.NtpNavigationsAreTreatedAsBrowserInitiated test. Allowing navigations to non-web-accessible-extension-resources from NTP ======================================================================= ExtensionNavigationThrottle excludes 3 schemes from web-accessible-resource checks: - content::kChromeUIScheme (chrome://) - content::kChromeDevToolsScheme - chrome::kChromeSearchScheme (NTP) The checks need to be added to ResourceRequestPolicy::CanRequestResource. They need to be added because CanRequestResource wouldn't run before this CL (it doesn't run in OpenURL code path; only in BeginNavigation code path). This aspect of desirable behavior is covered by the ExtensionBrowserTest.NavigateToInaccessibleResourceFromChromeURL test. Deleted tests ============= The CL deletes the following NTP/ShouldFork tests: - InstantProcessNavigationTest.ForkForNavigationsFromInstantProcess - InstantProcessNavigationTest.ForkForNavigationsToNewTabURLs These tests were tightly coupled to the ShouldFork implementation and are not applicable anymore after the NTP-specific parts of ShouldFork implementation have been removed. The CL deletes the following prerender tests: - PrerenderBrowserTest.PrerenderCancelReferrer - PrerenderBrowserTest.PrerenderCancelReferrerPolicy This is okay because: - Prerender is not used in production (e.g. see https://crbug.com/755921 opened in August 2017). Supporting prerender tests carries a significant burden (over the last few months multiple non-prerender-related CLs had to tweak //chrome/browser/prerender/prerender_browsertest.cc). - The tests were tautological. The test were verifying that prerender ends with FINAL_STATUS_CANCELLED, but this status was not a result of how production code behaves, but rather a direct consequence of how the test used an TestContentBrowserClient::OverrideNavigationParams (earlier ShouldAllowOpenURL before r702175). Bug: 1003957, 883549 Change-Id: Ib7c1e18173a861704589959f5e1aff904ee3eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842112Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#705290}
-
Pavel Shmakov authored
This fixes an error due to which AppCompatDelegate.setLocalNightMode wasn't always triggered on CCT startup Bug: 1012755 Change-Id: I5dce526db679ba36b667f6330bd94c577aef02a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857318 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#705289}
-
Victor Costan authored
Bug: 1010273, 1001838 Change-Id: Ic7a490640f44fe3d449462c974737f71d20c76a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853847 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#705288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0912f5e649f3..d6527adcbefb Created with: gclient setdep -r src-internal@d6527adcbefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iee3b8db7235fe2b826e28eacca96d38163d60f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857162Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705287}
-
Andrew Xu authored
This CL adds the rounded corners for |shelf_container_view_|. It helps to cut off the child view outside of scrollable shelf's bounds. Bug: 1009368 Change-Id: I47119b7126100753f9c7ded2d9a6cde67fc44e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848345 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705286}
-
Elly Fong-Jones authored
This change adds two new global key bindings: Command-Option-UpArrow traverses to the next accessible pane Command-Option-Shift-UpArrow traverses to the previous accessible pane This allows keyboard access to: * The downloads bar * Bubbles that don't grab focus when they appear * The toolbar etc etc. This is the approach proposed by UX in https://bugs.chromium.org/p/chromium/issues/detail?id=919260#c20, but I decided to use the (imo more Mac-like) "shift means backward" convention rather than using DownArrow for forward and UpArrow for backward. Bug: 919260,956432,945923 Change-Id: I4d15d706b903d1be9d1894725f96107a4b6b1373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856888 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705285}
-
Kevin DiClemente authored
Initialize allow_default_credentials before being used in HttpNetworkSession::QuicInfoToValue(), as this can cause a use-of-uninitialized-value in net::FileNetLogObserver::FileWriter::WritePolledDataToFile, where in JSONWriter::BuildJSONString, for Value::Type::BOOLEAN, node.GetBool() contains an uninitialized value. Change-Id: Ia3c1f530046c246255cde9394b04773eb5d9ccac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853991 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705284}
-
Xianzhu Wang authored
These tests failed on the try bot linux_layout_tests_layout_ng_disabled with and without patch. Blindly rebaseline them to save CPU of the bot by avoiding additional steps. Also remove outdated disable-blink-features=LayoutNG/virtual/disable-blink-gen-property-trees TBR=kojii@chromium.org Change-Id: Iba3bee92f93283759414940a222d66a54708b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856881Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705283}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/80f53b785b37..6787f232aedd git log 80f53b785b37..6787f232aedd --date=short --no-merges --format='%ad %ae %s' 2019-10-11 saza@webrtc.org Remove AudioProcessing::level_estimator() getter 2019-10-11 eladalon@webrtc.org Fix WebRTC-Video-MinVideoBitrate for VP9 2019-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3d7980bd..da0e48ef (705004:705127) 2019-10-11 srte@webrtc.org Adds support for stopping fake TCP cross traffic. Created with: gclient setdep -r src/third_party/webrtc@6787f232aedd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I7f64a1a1c5e6f553481b123b1ca4ba8b63a6c3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857160Reviewed-by:
-
Fabrice de Gans-Riberi authored
The "hub" feature is the permanent replacement for the "deprecated-shell" feature. Bug: 977730 Change-Id: I3212a39f8d8acce39a33470d63a5dc1d8aa4d965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848651 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705281}
-
Oystein Eftevaag authored
R=ssid@chromium.org Change-Id: Ifacbffb22fdbc7aeb6abf96fe3dd85edbc075c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850772Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#705280}
-
Ahmed Fakhry authored
This CL implements the following: - Launching Chrome either from the Shelf, or from the Launcher, the current active desk is favored to find a tabbed browser. This means if active desk doesn't have a browser window, a new one will be created to host the new tab, even if there exists another browser windows on other desks. - Launching an app that opens in a tab will behave the same way as above if it is being launched from the Launcher. However, clicking on its icon in the shelf will switch to the desk that contains its tab (if any), otherwise it will launch a new instance. BUG=1009505 TEST=Manually, Added tests. Change-Id: I139af619aaf4337de6c944b7018eaef6ee454148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842624Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#705279}
-
Josh Nohle authored
EasyUnlockServiceRegular::RefreshCryptohomeKeysIfPossible() now just calls CheckCryptohomeKeysAndMaybeHardlock(). The method's refresh functionality was removed in http://crrev/c/1306348. Bug: 1013682 Change-Id: Id7789c7cde15303251470afb97eda5f49c6896fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856880 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#705278}
-
Toni Barzic authored
Same as for shared app list configs, if vertical space available to app list grid is extremely limited, non-shared configs should be scaled down to save as much space as possible. Change-Id: I5347b39723cc556eeda88061b8e9f5a181b6c803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854636 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Henrique Nakashima authored
All usages should be from FeatureUtilities. Change the usages from other classes to go through FeatureUtilities. This is a step to avoid collateral effects from refactoring FeatureUtilities. Bug: 1012975 Change-Id: I2efc779784bafc56cd2ae32392a6e2ab1377fbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854858 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705276}
-
Sidney San Martín authored
It's been said before and will be said again: keyboard event handling in Chrome is a monster. Several things came together to make this happen: First, in most Mac apps, cmd+w closes the dictionary popover if it's visible. This specifically happens through the `performClose:` action sent by the main menu. But, in Chrome, cmd+w closes the tab and not the window, so cmd+w sends a different action. This meant that cmd+w originally closed the tab and left the dictionary popover floating. This was fixed many years ago (see r118131 and r322075) by making `-[AppController menuNeedsUpdate:]` check the current target of `performClose:` and only map cmd+w to "close tab" when the target is a browser window. This would work but for another layer of keyboard shortcut handling trickery. For a number of reasons (see comment beginning "If this keyEquivalent" added in r565490), Chrome doesn't actually let `NSMenuItem`s send their own actions. Instead, ChromeCommandDispatcherDelegate determines which menu item *would* have been targeted by a given event, then handles the event itself. The end result is that, when the dictionary popover is visible, the menu items are successfully remapped so that cmd+w means "Close Window". But, any actual cmd+w event is grabbed by ChromeCommandDispatcherDelegate and sent directly to Chrome's own keyboard shortcut handling… so the browser window closes. This change adds a check that was proposed back in r322075, and makes ChromeCommandDispatcherDelegate only grab the event when the found menu item's action would be sent to its own window. Bug: 947752 Change-Id: Ib32988d5fb69c79f899069feb02f7529ea05225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849431 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Clark DuVall authored
This makes it so various inputs (e.g. file input, submit button) have the correct labels. Change-Id: I5d49dc5d2d71a92fedfd0a6748ad142454e0e55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856845Reviewed-by:
-
Anastasia Helfinstein authored
After feedback from leberly@ that the significance of the dashed focus rings used by Switch Access is unclear, we are changing that behavior. Per a discussion with lpalmaro@ and jasonwan@, the new behavior is to show a dashed focus ring around the "next" focus when selecting the element has a primary effect of changing the focus (i.e. selecting the back button or entering a group), and no dashed ring otherwise. The previous behavior was to always show the dashed ring as the current group's location. Bug: 996392 Change-Id: I5f13df27f7a57818cd0cca9f118fe46581009071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848352 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705273}
-
Adam Langley authored
If FidoCableDiscovery was only provided with v2 pairing information then it wouldn't send any advertisements, but also wouldn't signal that it was ready. BUG=1002262 Change-Id: I0e15d0017ec97891316c0fe1ea83761384676e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857298Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#705272}
-
Manu Cornet authored
Bug: None Change-Id: I6110495e02aca81c2f9fead9037fcc1be0352255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855219Reviewed-by:
-
Ian Kilpatrick authored
Realized it was easier to read this in reverse that what was happening previously. Probably just as a result of it being moved away from NGPaintFragment at some point. Change-Id: I0bc29a0b6868c8c47a69bfdc82cbc8a8c9017eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856723 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705270}
-
Lei Zhang authored
Replace the std::unique_ptr<base::Value> parameter to base::Value. Bug: 1012811 Change-Id: Id63d78a0ce54a381822b911ce67caf5afe38b3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848857Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705269}
-
Sahel Sharify authored
This cl reads supported delegations of an installable payment app from its web app manifest for just in time installation. With this change an installable payment app can specify whether or not they will provide shipping address and/or payer's contact information in their app manifest. Change-Id: I278bf5484bb52f5f02e3d66193e6f705b5313ab3 Bug: 984694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834421Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705268}
-
John Budorick authored
One of the shards times out when running w/ just 2 shards. Bug: 1011494 Change-Id: Ie1764870e928373e0fee97db957ebc60cc501019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856844 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c3fdfcff. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" 1644eff7 "Update scroll to text feature detectability API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/mediasession NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I36aa5e20ad2e4f6e9d89043096273da706ccf2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855381Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705266}
-
Roman Sorokin authored
Also removed ShellObserver from LockLayoutManager Bug: 833348 Change-Id: Ic4e899145eb7751ff5c089193e7733017383ff03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855939Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705265}
-
