GitLab

The return value is whether it's enforced by policy, the out param is whether it's enabled (not whether it's enforced, which made it an awfully confusing name).

R=ananta@chromium.org, jwd@chromium.org

Review-Url: https://codereview.chromium.org/2279063002
Cr-Commit-Position: refs/heads/master@{#414712}

BUG=640080

Review-Url: https://codereview.chromium.org/2269003002
Cr-Commit-Position: refs/heads/master@{#414711}

There is currently a single callback provided to PlatformScreen for when
new displays are added. We need to be able to notify not only when new
displays are added but also when displays are modified or removed.
Instead of having three callbacks, the PlatformScreenDelegate interface
is added.

The ui::ws::DisplayManager class implements PlatformScreenDelegate. This
is ultimately the class that needs to know about changes to displays so
it can update root windows accordingly.

There are some changes to ownership and constructor parameters to
facilitate having DisplayManager implement PlatformScreenDelegate. The
WindowServer instance is passed into DisplayManager, as it doesn't make
sense that Display objects owned by DisplayManager are allowed to know
about WindowServer but DisplayManager is not. The DisplayManagerDelegate
interface is simplified and changed to UserDisplayManagerDelegate as
it's no longer needed for DisplayManager.

The instantiation of SurfaceState is moved from Service to WindowServer.
There is no need to have Service know about SurfaceState anymore. Also,
SurfaceState will be moving to the GPU processes regardless.

BUG=641012

Review-Url: https://codereview.chromium.org/2274353003
Cr-Commit-Position: refs/heads/master@{#414710}

BUG=None

Review-Url: https://codereview.chromium.org/2280543003
Cr-Commit-Position: refs/heads/master@{#414709}

Previous: https://codereview.chromium.org/2241973002/

Original issue: https://codereview.chromium.org/2240573004/

Suppress all existing lint warnings so that builds will fail when new warnings
are generated. New lint warnings that are generated in files that are ignored
in suppressions.xml will not be caught. However, now we can remove lint
warnings on a file by file basis instead of having to fix all lint warnings
before making lint break builds.

BUG=607761

Review-Url: https://codereview.chromium.org/2241233002
Cr-Commit-Position: refs/heads/master@{#414708}

BUG=627517
TBR=

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2263843002
Cr-Commit-Position: refs/heads/master@{#414707}

Encrypted media browser tests involving Widevine use the stub CDM when
branding != Chrome.  This change allows them to register the
preinstalled component containing the stub CDM.

BUG=622273

TEST=Widevine browser tests 'browser_tests --gtest_filter=*Widevine*' pass

Review-Url: https://codereview.chromium.org/2136983002
Cr-Commit-Position: refs/heads/master@{#414706}

Update expectations to match current flakiness:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Ftransitions%2F

BUG=248938
TBR=ajuma@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2283823002
Cr-Commit-Position: refs/heads/master@{#414705}

BUG=None

Review-Url: https://codereview.chromium.org/2280763002
Cr-Commit-Position: refs/heads/master@{#414704}

The code stays around for now, so we can turn it on via a variation param if required.

BUG=640566

Review-Url: https://codereview.chromium.org/2279273002
Cr-Commit-Position: refs/heads/master@{#414703}

NOTREECHECKS=true
NOTRY=true
TBR=tapted@chromium.org,avi@chromium.org
BUG=640457

Review-Url: https://codereview.chromium.org/2286713002
Cr-Commit-Position: refs/heads/master@{#414702}

This CL removes calls to these methods from tools/ files:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447

Review-Url: https://codereview.chromium.org/2278993002
Cr-Commit-Position: refs/heads/master@{#414701}

BUG=615123
TBR=jialiul@chromium.org
TEST=
1. Go to the following URLs in different tabs:
   http://ianfette.org
   http://parkerly.com/sb-tests/bad-subresources.html
   https://parkerly.com/sb-tests/bad-subresources.html
2. Verify that the omnibox security indicator shows a red triangle for
   all three warnings

Review-Url: https://codereview.chromium.org/2275123004
Cr-Commit-Position: refs/heads/master@{#414700}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fca74cffde72..393e77578d5b

$ git log fca74cffd..393e77578 --date=short --no-merges --format='%ad %ae %s'
2016-08-26 petrcermak [tracing] Use tr.b.requestAnimationFrame in tr.ui.analysis.RebuildableBehavior

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2284643002
Cr-Commit-Position: refs/heads/master@{#414699}

This is accomplished by using the embedderOrigin more
consistently throughout.

BUG=639208
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2269963003
Cr-Commit-Position: refs/heads/master@{#414698}

Based on the flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=BackgroundTracingManagerBrowserTest

- All tests BackgroundTracingManagerBrowserTest tests are flaky on Android

- BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
  is flaky on Android & Linux

- BackgroundTracingManagerBrowserTest.NoWhitelistedArgsStripped
  and BackgroundTracingManagerBrowserTest.TraceMetadataInTrace
  are flaky on Android & Chrome OS

NOTREECHECKS=true
NOTRY=true
BUG=639706
TBR=simonhatch@chromium.org

Review-Url: https://codereview.chromium.org/2280073002
Cr-Commit-Position: refs/heads/master@{#414697}

When a new NTP is created, it queries the list of registered categories
with the backend. The returned category order will be kept for the
visible categories.
Suggestions received from categories that are after that point will
be ignored.

BUG=640568

Review-Url: https://codereview.chromium.org/2274293002
Cr-Commit-Position: refs/heads/master@{#414696}

This CL fixes styles of Welcome screen.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2267533002
Cr-Commit-Position: refs/heads/master@{#414695}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/7b10c1874469fdf3f8d621bd83c3093de7c46531 Add OWNERS file for goma team in recipe_modules/goma (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2281883002
Cr-Commit-Position: refs/heads/master@{#414694}

Setting OOM scores generally requires root permission. In the past it's done
1. For Chrome processes: via a SUID binary chrome-sandbox.
2. For Andorid processes: Send scores to Android via IPC. Android
handles the rest.

Now a new method is added to debugd dbus interface on ChromeOS to
handle OOM score settings.
https://chromium-review.googlesource.com/#/c/366154/

So we can set OOM score settings in the unified way on ChromeOS.

BUG=b:30193036
TEST=minnie

Review-Url: https://codereview.chromium.org/2247433002
Cr-Commit-Position: refs/heads/master@{#414693}

BUG=641309
TBR=thakis,primiano,mattcary

patch from issue 2283753002 at patchset 20001 (http://crrev.com/2283753002#ps20001)

Review-Url: https://codereview.chromium.org/2280953002
Cr-Commit-Position: refs/heads/master@{#414692}

BUG=640344
TEST=Manual steps in bug.

Review-Url: https://codereview.chromium.org/2278723002
Cr-Commit-Position: refs/heads/master@{#414691}

net::ParsedCookie::SetValue() applies a strict check to the passed-in value,
but ParsedCookie::ParseTokenValuePairs() applies a weaker check. It
would nice if this was consistent.

Add a histogram to determine the degree of compatibility problems with making
it consistent.

BUG=638117

Review-Url: https://codereview.chromium.org/2273633004
Cr-Commit-Position: refs/heads/master@{#414690}

Failed DCHECK on builds 7067 7054 7051 7024 7022 7021 7000 6988 of
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

BUG=638693
NOTRY=true
NOTREECHECKS=true
TBR=alancutter@chromium.org

Review-Url: https://codereview.chromium.org/2283773002
Cr-Commit-Position: refs/heads/master@{#414689}

I'm making toV8() never return an empty handle.
This CL replaces the return value of toV8(ScriptValue) with v8::Undefined,
but it won't change any web-exposed behavior because V8 interprets
a returned empty handle as v8::Undefined().

BUG=625512

Review-Url: https://codereview.chromium.org/2280893002
Cr-Commit-Position: refs/heads/master@{#414688}

At this moment, creating an ImageBitmap has several options such as flipY
and premultiplyAlpha = false. So in some cases, we would have to convert
the premultiplied input to unpremul format, and that involves allocating
new memory. To prevent any potential integer overflow or OOM situation,
this CL checks the size of the cropRect and the resizeWidth(resizeHeight),
if the width * height * bytesPerPixel is larger than size_t range, we reject
the promise. By doing the check at the beginning of each ImageBitmap constructor,
we can guarantee that the subsequent multiplication of
width * height * bytesPerPixel will not overflow.

This CL also correct other places where there could be
potential integer overflow. In particular, since we have checked at
the beginning of each ImageBitmap constructor, it should be safe
to use size_t for any computation of width * height in the code.

TBR=kbr@chromium.org, haraken@chromium.org
BUG=638615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2249853008
Cr-Commit-Position: refs/heads/master@{#414687}

Revert of Support server categories in NTPSnippetsService. (patchset #3 id:40001 of https://codereview.chromium.org/2279863002/ )

Reason for revert:
I'm afraid this failed again on
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27385/steps/components_unittests%20on%20Mac-10.9

Original issue's description:
> Support server categories in NTPSnippetsService.
>
> Reland of:
> https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f
>
> Not clear why tests failed; they passed for me and in the CQ.
> Removed one synchronization bit that wasn't really part of the change.
>
> BUG=633613
>
> Committed: https://crrev.com/880bb766ee4985a8dd36be10098c5196c41f7509
> Cr-Commit-Position: refs/heads/master@{#414681}

TBR=treib@chromium.org,sfiera@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633613

Review-Url: https://codereview.chromium.org/2283743002
Cr-Commit-Position: refs/heads/master@{#414686}

FFmpeg's AVCodecContext->channels contains "raw number of channels"
(e.g. "2" for 2 channels, "8" for 8 channels). The change ensures that:
- the value of "8" is correctly mapped to 0b111 ADTS channel
config (aka MPEG-4 Channel Configuration),
- the value of "7" becomes unsupported.

BUG=640610

Review-Url: https://codereview.chromium.org/2273203003
Cr-Commit-Position: refs/heads/master@{#414685}

RELEASE_ASSERT prints the same message as SECURITY_CHECK, because
RELEASE_ASSERT is deprecated and being actively replaced by SECURITY_CHECK.

BUG=620960

Review-Url: https://codereview.chromium.org/2240233002
Cr-Commit-Position: refs/heads/master@{#414684}

Review-Url: https://codereview.chromium.org/2274663003
Cr-Commit-Position: refs/heads/master@{#414683}

For no apparent reason we were always doing a full document recalc when
finishing loading a non-blocking stylesheet.

From webkit: https://bugs.webkit.org/show_bug.cgi?id=119236

BUG=284142

Review-Url: https://codereview.chromium.org/2278803002
Cr-Commit-Position: refs/heads/master@{#414682}

Reland of:
https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f

Not clear why tests failed; they passed for me and in the CQ.
Removed one synchronization bit that wasn't really part of the change.

BUG=633613

Review-Url: https://codereview.chromium.org/2279863002
Cr-Commit-Position: refs/heads/master@{#414681}

In editing/selection/select-across-readonly-input-{1,4}.html, the end position is
anchor=innerEditor type=AfterAnchor.  indexFromPosition() didn't work well with
such position.

Review-Url: https://codereview.chromium.org/2278373002
Cr-Commit-Position: refs/heads/master@{#414680}

BrowsingDataHandler observes local history deletions, but not synced
history deletions. In cases where there are no local history entries
to delete, it can happen that the history page does not reload and it
looks as if the deletion failed.

See https://docs.google.com/document/d/1Fd6CdBf6UMbYbkwSjEKyFOxew0Xid5IaT-QwnFchjig/
for background.

This CL
1. Adds an Observer subclass to the WebHistoryService.
2. Registers BrowsingHistoryHandler as a WebHistoryService::Observer;
   and since WebHistoryService's existence is based on whether history
   sync is enabled, we also register as a SyncServiceObserver.
3. Adds a test to browsing_history_handler_unittest.cc.

Also tested manually on Android - seems to solve the problem described
in the above mentioned document.

BUG=604114,630164

Review-Url: https://codereview.chromium.org/2263613002
Cr-Commit-Position: refs/heads/master@{#414679}

selectionDirection incorrectly returned "none" in such case even on non-Mac
platforms.

BUG=640861

Review-Url: https://codereview.chromium.org/2285613002
Cr-Commit-Position: refs/heads/master@{#414678}

Since we dropped support for rendering Type 1 fonts in Chrome, we should
filter the list of fonts that can be configured as defaults to only
display fonts that have the right font format, i.e. TrueType or CFF.

A a side effect, this allows us to build the font list enumeration for
ozone as well, as it is only dependent on Fontconfig after this CL, not
dependent on Pango anymore.

For backwards compability with the old implementation, we're adding
three Fontconfig alias families Sans, Serif and Monospace to the list,
since our default settings on Linux included the "Monospace" family for
the fixed width font.

BUG=630508,457307

Review-Url: https://codereview.chromium.org/2278143002
Cr-Commit-Position: refs/heads/master@{#414677}

BUG=604119
TEST=none

Review-Url: https://codereview.chromium.org/2281813002
Cr-Commit-Position: refs/heads/master@{#414676}

Revert "Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah"

This is a manual revert of commit 41165826,
due to causing performance regression.

Original issue's description:
> Stop SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar from using TextCheckingParagrah
>
> SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar() does not really need
> a TextCheckingParagraph as its parameter; an EphemeralRange of text to check is
> sufficient.
>
> Hence, this patch changes its parameter from a TextCheckingParagraph to an
> EphemeralRange, simplifying code and improving performance by eliminating the
> overhead for finding the paragraph containing the text to be checked.
>
> BUG=n/a
> TEST=n/a; no visible change
>
> Committed: https://crrev.com/41165826c11cc0b7f1457b4c455d7e2eb2de0819
> Cr-Commit-Position: refs/heads/master@{#414328}

BUG=641083
TBR=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2286573002
Cr-Commit-Position: refs/heads/master@{#414675}

Safe browsing subresource filter should be able to make activation
descision based on the type of the list and metadata for the list.

BUG=609747, 641037

Review-Url: https://codereview.chromium.org/2272323002
Cr-Commit-Position: refs/heads/master@{#414674}

This CL disables the toolbar shadow test because it's flaky. This will be
reenabled after investigation.

BUG=640862

Review-Url: https://codereview.chromium.org/2271583009
Cr-Commit-Position: refs/heads/master@{#414673}