- 24 Jul, 2020 2 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I7a91b5ee733c9b393b8ea3e53f177444c0ad9a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316528Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791299}
-
Garrett Beaty authored
The Android capacity for android-marshmallow-arm64-rel is mostly recovered, so it is being re-enabled so that APAC and EMEA can get Android M coverage. Bug: 1108842 Change-Id: Ie865ced7efcdaa8357068db616e88801b8247840 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316446 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791298}
-
- 23 Jul, 2020 38 commits
-
-
Garrett Beaty authored
Change-Id: Ib91c6c6d7876b2200d09f6e79a35d8a257375d4d No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314164 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#791297}
-
Haiyang Pan authored
The datacenter holding GPU's bots is offline, so these tests are stuck. Remove them while we work on getting ATL back online. TBR=gbeaty No-Try: true No-Tree-Checks: true Bug: 1108842 Change-Id: I1446673656eee48134dd271724de4a7f3279a3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316689Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791296}
-
Ali Juma authored
This adds an about:flags entry for real-time Safe Browsing lookups, to make it easier to enable and test. Bug: 1103213 Change-Id: I28bae0f333ece6d1f5f8f4dcf5b3c89ef6037772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315236 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791295}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ba0609c22877..2bda4d1319b4 2020-07-23 vapier@chromium.org cros_sdk: merge user PATH with root's PATH 2020-07-23 pprabhu@chromium.org cbuildbot: Pin the CIPD instance of the `skylab` tool 2020-07-23 tcwang@google.com afdo: Attach chrome version info to Chrome debug binary name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ic42cebef59aa4f27ddab32a76c945d5cbd9b82e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791294}
-
Jonathan Ross authored
This reverts commit 26f4c62b. Reason for revert: crbug.com/1108303 regressions showing up on a large number of Graphics.Smoothness.PercentDroppedFrames graphs. We should analyze the impact and reland. Original change's description: > Re-add field trial testing config for DisableLatencyRecoveryDesktop > > Based on the data gathered from running the experiment on canary/dev and > beta, it seems that the disabling latency recovery for both main and > impl threads is an overall performance win. So, we are going to > re-enable the (now-expired) experiment on stable and move forward with > its gradual rollout. > > Bug: 993895 > Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790549} TBR=mohsen@chromium.org,rkaplow@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993895 Change-Id: I0409a5a5df03b34c8e4a203482175089dac83e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315014Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#791293}
-
Wen-Chien Wang authored
Change-Id: I4de9eaddd47175d7c295532ee292e8bf6351cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304975 Commit-Queue: Wen-Chien Wang <wcwang@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791292}
-
Alexey Baskakov authored
Inline previously established constants. The formatting has become messy anyway. Fixed: 1103916 Change-Id: I9e8970614c05bde425c67418e42028150f281b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315896 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#791291}
-
Jose Dapena Paz authored
GCC cannot map passing directly curly braces notation to the x11->PutImage call. We need to initialize it first to an instance and pass it to PutImage. Bug: 819294 Change-Id: I9bbd1060eb3f8889ac789db21bb09a0d6a0ae504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302995Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#791290}
-
wutao authored
Needs to add $ to data-id attribute otherwise reads undefined. Bug: b/161081423 Test: manual Change-Id: I35fce415685645b5dbb5afa1df781374333f7311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315802Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791289}
-
Jose Dapena Paz authored
MockWebRtcVideoTrack and MockWebRtcVideoTrackSource are abstract because they do not implement the rtc::RefCounted interface. To fix hte problem, solution is inheriting from rtc::RefCountedObject. Bug: 819294 Change-Id: Ia0975711cff5755f0608e801a5cb60d175bd9b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310414Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#791288}
-
Matt Jones authored
Bug: 1108731 Change-Id: Ibbf6c03ad6c068c90ab356008c68878cb3d6604f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316319Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#791287}
-
Miguel Casas authored
While experimenting with SDR-HDR on Chromebooks with DCHECK()s on, I noticed I hit a few of them unnecessarily. This CL adds the RGB10 format where needed. Bug: 958166 Change-Id: Ifc3cbd4c6a6a4ee23b9430f3ee4ac75ac7c65a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315253Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791286}
-
Orin Jaworski authored
This CL eliminates the override readiness and execution logic to make the Pedal for updating Chrome rely on the base implementation with navigation to chrome://settings/help . Other URLs are also updated to stay in sync with targets agreed upon with PM & UX. Related unit tests are also eliminated. Bug: 893183 Change-Id: Iaaf2a02700449932d198331a0856cb7c926c145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314160Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#791285}
-
Dan H authored
This reverts commit cbd8c160. Reason for revert: Failure on win32-archive-dbg - https://bugs.chromium.org/p/chromium/issues/detail?id=1108859 Original change's description: > Allow use of Abseil in //net/third_party/quiche. > > This has been previously blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=1046390. > > Change-Id: I1c0d68dc56d109be6189df0cfb8fc04230949a1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302721 > Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791073} TBR=zhongyi@chromium.org,vasilvv@chromium.org,mbonadei@chromium.org Change-Id: Ibf29f66c708ae25e5a140f04eec39e1a751e0369 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316323Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#791284}
-
Elly Fong-Jones authored
See the bug for details about why. Bug: 1102153 Change-Id: I71423c13405cfd57a1eee024205c48145af18009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313156 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791283}
-
Aaron Colwell authored
Adding an extra sanity check in the BrowserContext destructor to immediately terminate if we detect that a RenderProcessHost still references the object being destroyed. Bug: 1099998 Change-Id: I84af3b5d5f09274fa551b63903101ab5710d073d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305674 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#791282}
-
Wei Li authored
Use direct event calls so the tests will work across platforms including Mac. Bug: none Change-Id: I41df114ed67709f7fcb95400ddec99aaf83a2ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304135Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#791281}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595437495-2d3f811bb66fa71af5c868be4b1e4126108bec15.profdata to chrome-win64-master-1595483644-344e9c0c00099fa9f04b516964f94e743df86469.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I523c07323d754ca5dced2bdb36e9361b51e5f2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791280}
-
Bruce Dawson authored
Due to Windows event log spam (tracked in bug 1070362) there is no guarantee that there will be enough system session events to do analysis and, in fact, there is no guarantee that there will be *any* system session events. This means that FetchEvents is unavoidably flaky and must be disabled, and ValidateEvents has to tolerate another failure mode. Bug: 1053451, 1070362 Change-Id: Ib95701d42f1152c6e7726bd7c6de913d6764ac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314667Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#791279}
-
Elly Fong-Jones authored
This test needs to be updated for Big Sur's new visual style. Bug: 1101415 Change-Id: Iea580bdef7828e79e73a453443958152a1aa33ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314999 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791278}
-
Brian Sheedy authored
Adds support for specifying a non-default corpus when initializing a SkiaGoldPixelDiff or BrowserSkiaGoldPixelDiff instance. This allows users to separate their images, either to reduce clutter when looking through results or to prevent internal results from being mirrored to the public Gold instance. This particular implementation is meant to be a temporary solution so that users can be unblocked. A more robust implementation that will catch public corpora being used in non-public settings, etc. will be implemented later. Bug: 1108465 Change-Id: I8f868bfb32cdf72cf9feccf64c7291f758c3ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314976Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791277}
-
Maksim Ivanov authored
Provide test coverage for the scenario when the signature operation, triggered during the challenge-response login (a.k.a. smart card based login), fails. This corresponds to the real-world case when a smart card user tries to log into the system but the smart card is broken or is ejected during the login. Bug: 1090941 Change-Id: Ida39fa52385905643bbeb3728dbbc2f49c527195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315676 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791276}
-
Haiyang Pan authored
The datacenter holding GPU's bots is offline, so these CQ tests are stuck. Remove them from the CQ while we work on getting ATL back online. TBR=gbeaty No-Try: true Bug: 1108842 Change-Id: I3833475c71d7f79380c22303c989d05baf2fd8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316438Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791275}
-
Maksim Sisov authored
The condition is incorrect. Fix that. Change-Id: I408a1ed242c03ebee26640929ecbeb07487ce204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315343Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791274}
-
Leonard Grey authored
The fullscreen toolbar controller currently uses undocumented Carbon events to track the menubar's reveal amount in fullscreen. In recent macOS versions, the intermediate values are no longer send and we only receive events when the menubar is fully shown or fully hidden. The Mac immersive code which is still behind a flag uses a different technique, observing the reveal amount on a hidden titlebar accessory view. This *does* provide correct intermediate values. This change extracts the reveal code from the immersive controller and uses it in the current fullscreen code rather than the Carbon event. Unfortunately, despite receiving the correct progress notifications, the topchrome still does a discontinuous jump, but we'll cross that bridge later. Bug: 1063417 Change-Id: I6827cafbcad58eeaabf98c6facaeb85ce3439997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314998Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#791273}
-
rajendrant authored
This CL disables image redirect when content-security-policy disallows loading image from other origins, to adhere to CSP restrictions. This CL also disallows image redirect when crossorigin attribute is specified. Bug: 1098985 Change-Id: Ib6a25a31d716b6d0f318afd4e503482cede2148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264588Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#791272}
-
Kramer Ge authored
This reverts commit 0c9696bf. Reason for revert: potential suspect for failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20%28NVIDIA%29/25848 Original change's description: > ExternalVkImageBacking: fix concurrent read problem > > Concurrent read access from both GL and Vulkan is not allowed. > Get rid of the concurrent read problem by releasing the texture > from GL temporarily, when a Vulkan read is requested. And resume > GL read access, when the Vulkan read access is over. > Current chrome GL and Vulkan concurrent read pattern is - Blink holds > and caches read access for a backing shared image for a WebGL or > 2D canvas. SkiaOutputSurfaceImplOnGpu only requests read access just > before playing back DDL and releases the read access after playing back > DDL and before SwapBuffers. The GPU will not schedule other tasks > between playing back DDL and SwapBuffers. So it should be safe to > temporarily pause GL read access. > > Bug: 1104231 > Change-Id: I729eeebd5196bc5387ac148133b5926358bb4b53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311330 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791022} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: Ibcadd314ed775910395b2d29d6133a1fcbb2aeb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315918Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#791271}
-
sandromaggi authored
Before this change the state of the progress bar got lost when changing icons. This means that icons and lines marked as "done" would become unmarked again and the currently active (i.e. animated) icon would stop being active. This generally is only a problem for the first icon when starting with the proper experiment. The flow would set the active step to 0, then change the icons and thus lose the state. Additionally, it was not possible to stop using the new progress bar without specifying icons, as the action would fail. Bug: b/161962005 Change-Id: I80592cb6215a94a95dd67fe66a7d5d494e0f3c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315883 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#791270}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/f624790b7f..41a6263fd0 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/f624790b7f..41a6263fd0 Bug: None Change-Id: I79e04696901bf607d83ff66393340de2bd5da3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315143Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#791269}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I90724839a059c21bb98098c90a3861863f12c5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791268}
-
Elly Fong-Jones authored
Currently, some flags tests that need to simulate flag expiration work by installing a custom expiration predicate that replaces the entire body of flags::IsFlagExpired(). This is convenient but makes it difficult to test the expiration logic itself. This change replaces that test hook with one that allows injecting a custom set of flag expirations, by analogy with SetFeatureEntries(). The expiration logic then happens as normal. Tests that used to rely on a custom expiration predicate are rewritten to control expiration in the same way as production code would (i.e. via features). This change is preparatory to fixing the linked bug. Bug: 1101828 Change-Id: Ie6336c1fc1522edf2a62cd4044c121cf86ac4e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309352 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791267}
-
Pavol Marko authored
http/tests/devtools/tracing/timeline-js/timeline-gc-event.js is flaky on Mac builders, mark it as such. Bug: 1108786 TBR=ulan@chromium.org Change-Id: I40861cea4daee5d2dcf3fa4aa91c30beceef86b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315689Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791266}
-
Ben Mason authored
TBR=andypaicu@chromium.org Bug: 1108800 Change-Id: I4d4bbda03d49039a378764db2a92f2463e67a353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316316Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#791265}
-
Torne (Richard Coles) authored
Avoid needing to update the R8 playground script to point at the correct version of build-tools by just finding the first one available, since this is just a quick experimentation tool and not part of the actual build. Change-Id: If277326101039b1e5ec2ef0541008045957ed398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316317 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#791264}
-
Sangwoo Ko authored
Theres' no intended behavior change. ui: :ImageModel should be preferred to gfx::ImageSkia. Bug: 1048901, 1100034 Change-Id: I20d653317e3e8e0dd4782688e135f34f1507ef39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#791263}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9061d5d154bc..4d9cadd58aea 2020-07-23 tommek@google.com Enabling sampleMask usage in RenderPipelineVk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibe4bdbf3e93091276a14d199b771a3da4e5af354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791262}
-
Alexander Cooper authored
These focus changed calls ultimately trigger javascript events. These events could potentially run code that would modify the list of items that the FocusChanged notifiers are notifying, and thus invalidate their in-use iterators. Fix this by having these methods iterate over a copy instead of the member list. Fixed: 1107815 Change-Id: I03fa08eeadc60736f3a3fae079253dbd3ee26476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314158Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#791261}
-
Maksim Ivanov authored
Support having multiple AuthStatusConsumer's in ExistingUserController. This is a preparation CL for implementing a browsertest that needs to subscribe itself as a "consumer" without suppressing the default consumer functionality (LoginDisplayHostMojo). Bug: 1033936 Change-Id: I97e6869c105bcddc6263f6bc201ff370a03d41dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315336Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791260}
-