GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1a76e688..cbf276fd

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0ff0bcfb3406e483b20276e0711578a82e777910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822098Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699416}

Change-Id: I6b45699c6813d62987f96dbeafbca112410bcc15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817317
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699415}

Update comment to refer to WebAppMenuButton.

Bug: 788051
Change-Id: I397cc63296996f0a4dc8438a45986531b4ad5718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819095
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699414}

Bug: 967716
Change-Id: I8c6f6d7ebd6a9e27744368811340eb1737cf4eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822017Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699413}

The translation pipeline needs destinations and scaffold files. This CL
adds that.

TBR:agrieve@chromium.org
TBR Reason: The translation pipeline is blocked on this and it's a small
change that doesn't touch any code. benmason@ can confirm :)

Bug: 1006869
Change-Id: I65af5a8eba6b4e8ea47bb12aec67c0cc7a5ed1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821528
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699412}

I'm not really doing much stuff w/ Blink these days, and so
there are better owners in //third_party/blink and
//third_party/test_fonts. I also don't really know much about
//third_party/libcxx-pretty-printers, and so probably shouldn't
be an owner there.

Change-Id: I0bca5f54285be2f9d9913fa6bd55a8d2bfc132b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819892Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699411}

This CL removes the unconsented_primary_account_ in identity manager.
Instead, PrimaryAccountManager is now storing this information, in the
form of a boolean rather than a string. This will prevent bugs where the
two strings go out of sync.
PrimaryAccountManager also persists that boolean in prefs, and as a result
the unconsented primary account becomes available at Chrome startup.
This will allow simplifying the code, as it won't be necessary for users
to wait for it to be loaded.

TBR=jzw

Change-Id: I832ae5775c9665709d6780a9ec5ef2a2389357ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803145Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699410}

This code is no longer needed after switching to the new cookie store.

Bug: 989554
Change-Id: I83b89a77b141a313343f20615b9ab0eeb3d2f2a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819998Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699409}

BUG=1006102
R=pkasting

Change-Id: I67b040c84886655f37b4731a09e990399affcfb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819332
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699408}

In the Elements Event Listeners pane, one of the things that is
possible due to the "Ancestors" inclusion is that a parent element
with an event listener can be navigated-to via a mouse click on
the element name. This functionality is now extended to keyboard-
only users by handling the enter keypress for that same tree node.

Change-Id: I7603c43991079af24cbf749b10ff270928945d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815820Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#699407}

Removing 'non-white-bg' class as search suggestions was the only user
of it and they are not using it anymore.

Bug: None
Change-Id: Icb118c92f4117b6f6a7da5d6c97acdcf994c380d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811929
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699406}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8de7737d65f3..59ab7b718b08

git log 8de7737d65f3..59ab7b718b08 --date=short --no-merges --format='%ad %ae %s'
2019-09-24 seanabraham@chromium.org Revert "image_lib: more debug output forLoopbackPartitions.Mount"

Created with:
  gclient setdep -r src/third_party/chromite@59ab7b718b08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Idf76444d1689e3a3a7ddab2324f2f3b878360a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821960Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699405}

Previously, the third argument was web-exposed when it should not have
been.

Bug: 1006131
Change-Id: Ie35a6e8b0e08f35e8fdf7bf297435ab6edac3cd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816579
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699404}

This is one of a series of three CLs adding more uniformity
to referrer controls' implementation. The switch's functionality
remains accessible via disabling the enable_referrers pref.

The changes in this CL comprise:
1. Removing the switch
2. Removing the previous calls directly checking the switch, rather than
the enable_referrers pref. Happily, these checks of the switch were both
redundant with the later check of enable_referrers performed in
NetworkDelegate::NotifyBeforeURLRequest.
3. A nominal amount of refactoring of some dead/nearly-dead referrer-related
code:
  - network::ComputeReferrer removed from loader_util.cc (after removing
the --no-referrers switch, this method now duplicates GURL::GetAsReferrer).
  - content::Referrer::SetReferrerForRequest removed (it had no callers).

R=gab, falken

Bug: 1004486
Change-Id: I00bc503d0954700565047a188bbb9842c4d4bc9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808144
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699403}

Bug: 1005568
Change-Id: I3aa86d1f9cf20eacabdc1084cecd24894e5252b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822019
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699402}

This CL was created automatically with tools/perf/update_wpr script

R=perezju@chromium.org

Change-Id: I8ababa87c428f3b7431a10b0f9e758071837c505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815128
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699401}

Bug: 82078
Change-Id: I27733feb3e38bddb24509d7588c4f41b2acc4831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820318
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699400}

Requests from `<portal>` elements currently send a `Sec-Fetch-Mode` of
`navigation`. They ought to send something more like
`nested-navigation`, which more accurately represents the request's
status vis-a-vis its requestor.

https://github.com/w3c/webappsec-fetch-metadata/issues/46

Bug: 1005143
Change-Id: Ib7f434ddf90d2e15b4bf139ab77c778a090251f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819297Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699399}

Adds functions for creating, removing and getting all records from
leaked credentials table in Login Database.
Adds initialization of leaked credentials table in LoginDatabase.

Bug: 1005746
Change-Id: I5b97e9ed2ed309f6d7babcb905559fa72ab6263a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816544
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699398}

https://android.googlesource.com/platform/external/perfetto.git/+log/5a9d89d158eb..696ceeee0ff2

git log 5a9d89d158eb..696ceeee0ff2 --date=short --no-merges --format='%ad %ae %s'
2019-09-24 nicomazz@google.com Merge "Fix error logs when WebUSB is not available"

Created with:
  gclient setdep -r src/third_party/perfetto@696ceeee0ff2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ida300383ca6f397caf462b342b34fa729270aa50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821959Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699397}

Change-Id: Ia85f646245f86b4a8e9b6899c9185f88ea35e360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817321
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699396}

This is a reland of 17ccf43e

This is basically a copy of the original CL, with merge conflicts resolved.

Now that t_a_auditor.exe defaults to using extractor.py instead of the
Clang tool (t_a_extractor.exe), this should be safer to land.

Original change's description:
> [Traffic Annotation] Remove function_context from extractor output
>
> The new extractor can't trivially determine the name of the enclosing
> function, and it didn't bring much value anyways.
>
> Bug: 966883
> Change-Id: I7b52050730186c6972754d3b9e577d4c4740d5dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686621
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675223}

Bug: 966883
Change-Id: I93fa0385d44c9427f805248fac2af55fb128fe5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752065
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699395}

On Cast audio devices, we replace some URLs, e.g. images, CSS, with
data scheme URLs to reduce memory pressure.

Bug: b/141260084
Test: Load plex example page on an audio device.
Change-Id: I735fe038924b11ceca839c980ba995346b84dabd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818460Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699394}

* "down" property does not have any effect on outer container
* with new material design, all dialogs have same size, no
  need for special handling

Bug: 999058
Change-Id: I670a4e885691deca606afa395bd8f5b961303aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792862
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699393}

This policy is used to enable extension request feature which allow user
send extension install request to their admins.

Bug: 1006899
Change-Id: I792947faaacc3eb306068d610fa677ab8e2b76fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656094
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699392}

For deferred offscreen canvases, it's possible that there are un-drawn,
recorded commands at these points.

A revamped version of https://chromium-review.googlesource.com/c/chromium/src/+/1779107
which was reverted here https://chromium-review.googlesource.com/c/chromium/src/+/1798758
Don't record in finalize frame for the 2d layer bridge, as that causes
the pixel 2 bots to hang on put image data for some reason.
See crbug.com/1002946

Bug: 1002523
Change-Id: I8a2b57f5534486a551e3cb545a346d0320136a8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814457Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699391}

Floats have some "interesting" behaviour which allows a left (or right)
float to be placed left (or right) of a previous float. This typically
isn't allowed.

This occurs when a float has "negative size" e.g. it has a large
negative margin, which is larger than its width. E.g.
<div style="width: 50px; margin-left: -150px; float: left;"></div>

In such cases the float doesn't respect the normal rules, and is
placed in a typically invalid area.

This patch also changes "const LogicalSize& minimum_size" to
"const LayoutUnit minimum_inline_size" for "FindLayoutOpportunity".

Bug: 1005437
Change-Id: I4c91a53911b2651346487f71c4b31ec6e0240202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819356
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699390}

This change fixes a bug where a misplaced blue bar appears in the middle
of the debugger when paused at a line.

The blue bar was intended to add color to the line gutter when paused on
that line. However, the "chevron" icon that appears on the line number
overlays the gutter border, so the rule has no visual effect even when
positioned correctly.

Thus, this change removes the CSS rule entirely as it is presently
positioned incorrectly, and has no effect when positioned correctly.

Before: https://i.imgur.com/cGluk3C.png
Positioned "correctly": https://i.imgur.com/xJzup61.png
After: https://i.imgur.com/RgpRIU1.png

Bug: 1005964
Change-Id: I701f6defca6a35dce2cedaccdc8ddf829598c4fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815853
Auto-Submit: Brian Cui <brcui@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Mandy Chen <mandy.chen@microsoft.com>
Commit-Queue: Brian Cui <brcui@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#699389}

Conversion performed automatically using '2to3 -w -f has_key .'.
This is backwards compatible with Python 2.

Bug: 941669
Change-Id: I296c93d354cc4b49c5bcdc416cd495b352aa0617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817601
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#699388}

Bug: 1003391
Change-Id: Ibdc72029f647eff989bebb9b6542cffb8273064a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815847Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699387}

This allows other users of Chromium's zlib library who don't depend on
//base (for example, V8), to reuse some boilerplate code.

Bug: 833361
Change-Id: Ifc9023fdb9915e0452d424b030e8a8e5ae1c0df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819838Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699386}

virtual/threaded/external/wpt/css/css-scroll-snap/scroll-margin.html was
failing because the expected output file for Win7 was not deleted.

Bug: 964239
Change-Id: Ie49db2682d1e0148e60a03bea8f752165d2b1d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821824
Commit-Queue: Kaan Alsan <alsan@google.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699385}

Also removed learn-more node handling from the public session pods.
Filed crbug.com/1007193 to get rid of public account pods.

Also Added restart at the end of enrollment if device policy has public
accounts. This should fix most of the cases.

One rare case when WebUI public accounts will be shown: After enterprise
enrollment (w/o public accounts) device policy changes to have public
accounts. This should trigger public session pods on the WebUI login
screen.

Bug: 1000990, 943720
Change-Id: Ib9672821ef8fec303fc83c3d5f57952fb7f90c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820800
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699384}

This change addresses all accessiblity issues listed by AXE accessiblity tool:
a. <html> element must have a lang attribute
b. Document must have one main landmark
c. Page must contain a level-one heading
d. All page content must be contained by a landmarks
e. Page must have a means to bypass repeated blocks

Verified screen reader reads content on the page.
a. Screen reader was working as expected when accessing links. This was already working.
b. Added a role heading with level 1 value for header of the links to inspectables pages.

Verified keyboard accessibility:
Scenario 1: Launch browser without custom flag e.g. chrome.exe --remote-debugging-port=9222 http://localhost:9222
If the url of page doesn't contain '#custom=true' flag e.g. http://localhost:9222
User can navigate to any inspectable page link using Tab and pressing Enter opens the link
This was already working as expected before this change.
https://imgur.com/7zZ9BIn

Scenario 2: Launch remote debugging using npm run start
If the url of page has '#custom=true' flag e.g. http://localhost:9222/#custom=true&experiments=true
This change adds tabIndex=0 to element which holds of the remote-url. Pressing Enter or Space copies the url value.
https://imgur.com/aWShNVk

Gif: Showing keyboard accessibility in remote debugging page where it has a #custom flag in url
e.g. http://localhost:9222/#custom=true&experiments=true which is a default url opened up by
'npm run start' in devtools
https://imgur.com/l2j75TD

Bug: 963183
Change-Id: Ifc3dfc288591fd198c1e9e99d4828d0ebd933894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788287Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#699383}

A few other payment API tests are failing with BFCache on, adding to the
list.

BUG=1006256

Change-Id: I0d183349311457b2f93cefcd6560a51d5e1f5bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821600Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699382}

This class was wrongfully attached to all WorkerGlobalScope.
This fixes it and aligns us to the spec.

Bug: 1003442
Change-Id: I829620997d0149da36d036eaba40c569f899991b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807576Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699381}

Incorrect base::NoDestructor usage generated 11 static initializers.
As is, the static globals have to be initialized when the program
begins. Move the declarations so they become static local constants that
are instead initialized on first use.

Also fix lint errors and use constexpr in more spots.

Bug: 537099
Change-Id: I604e1a5828646b17340ce0986a2653fc75ba8dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819656Reviewed-by: A Olsen <olsen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699380}

Incorrect base::NoDestructor usage generated 6 static initializers.
As is, the static global has to be initialized when the program begins.
Move the declaration so it becomes a static local constant that is
instead initialized on first use.

Bug: 537099
Change-Id: Ieb64c7ba476331cd22ae2fb98960301166200d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820262Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699379}

CL:1591595 removed kStateDisconnect usage/support from NetworkState
because Shill had not been using that Service state for years. $bug
led to the conclusion that Shill should have a disconnecting state so
that the potentially non-negligible time between beginning a
disconnection and completing the disconnection will be clear (both
internally to Shill and for Shill D-Bus clients), rather than having
the Service Disconnect D-Bus method block until completion. This CL is
done in preparation of re-introducing the disconnect state to Shill,
such that future Shill CLs will cause Chrome to trigger DCHECKs.

Note that many of the changes in CL:1591595 are necessary in order to
avoid a future scenario where different usages of the kStateDisconnect
state (received from Shill vs Chrome-internal usages) have different
semantics.

Bug: 989361
Change-Id: I3d2ef136d531a39d5e1f89da77321d1866ac28aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819630
Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699378}

Previously Stability.iOS.UTE.HasPossibleExplanation would always be true
if OSRestartedAfterPreviousSession is true. But according to M78 UMA
OSRestartedAfterPreviousSession is true in more than 50% of UTEs, which
suggests that most restarts don't actually cause UTE.

Relax the logic to take into account OSRestartedAfterPreviousSession
only if battery level at 1%.

Also remove deviceWasInLowPowerMode from logging condition as it seem
irrelevant.

Bug: 1006928
Change-Id: I583f0aaeff842ea058a54315dd27d79537242296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819884Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699377}