- 16 Mar, 2017 40 commits
 - 
- 
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/faf60eb37f8b..efbc9db2ef8f $ git log faf60eb37..efbc9db2e --date=short --no-merges --format='%ad %ae %s' 2017-03-16 charliea Fix bug in always uploading BattOr serial logs Created with: roll-dep src/third_party/catapult BUG=699581 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2748273004 Cr-Commit-Position: refs/heads/master@{#457535}
 - 
mikecase authored
BUG=688263 Review-Url: https://codereview.chromium.org/2752093003 Cr-Commit-Position: refs/heads/master@{#457534}
 - 
glebl authored
BUG=635619 Review-Url: https://codereview.chromium.org/2750153003 Cr-Commit-Position: refs/heads/master@{#457533}
 - 
nasko authored
This CL implements a new policy for which process do error pages commit. When an error page is a result of a blocked request, it should be committed in the same process as the document requesting the navigation. Otherwise the error page should be committed in the process that would render the destination URL. BUG=685074 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2738643002 Cr-Commit-Position: refs/heads/master@{#457532}
 - 
lunalu authored
BUG=674593 Review-Url: https://codereview.chromium.org/2744713004 Cr-Commit-Position: refs/heads/master@{#457531}
 - 
kerrnel authored
In addition to the at-launch reauthorization, this adds an at-update reauthorization step. It only runs for users not on a system Keystone ticket, because the updater runs as root when on a system ticket, and root can't read individual user's Keychains. The at-update reauthorization is intended to handle the reauthorization for users who rarely restart Chrome and might miss out on the at-launch step during the window where Chrome is signed by the old certificate but has the new reauthorization code in place. The at-update reauthorization step can remain in place even after the certificate switch occurs by shipping an old reauthorization stub binary signed with the old certificate. BUG=629906 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2745223006 Cr-Commit-Position: refs/heads/master@{#457530}
 - 
bnc authored
Remove declaration of FLAGS_use_http2_frame_decoder_adapter from spdy_flags.h which is never used in the codebase, see [1]. Instead, FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter is used everywhere. [1] https://cs.chromium.org/search/?q=FLAGS_use_http2_frame_decoder_adapter&ssfr=1&type=cs Review-Url: https://codereview.chromium.org/2758523002 Cr-Commit-Position: refs/heads/master@{#457529}
 - 
dcastagna authored
This CL enables alpha-blended HW overlays. Additionally, it clears up the way overlay candidates might or might not be considered based on buffer format and alpha blending requested: - An opacity on the quad different than 1 will cause the candidate to always be rejected since we can't modulate the alpha of an overlay plane. - We support only kSrc (no blending) and kSrcOver (blend) blending modes. - For fullscreen overlays we can allow both blending modes as long as the opaque rect is as big as the buffer (ShouldDrawWithBlending() true). An opaque FD will always be used in this case (crrev.com/2743403005). - For non-fullscreen overlays, we can't allow kSrc if the buffer has a format with an alpha channel, since the alpha channel might not be initialized and we don't disable blending when scanning out yet. BUG=695296 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2749783006 Cr-Commit-Position: refs/heads/master@{#457528}
 - 
chrome://versiondgn authored
Adds a new entry to the version info page that displays the version number of the client library and the one for the installed Play Services app. It also displays whether First Party APIs are available. BUG=None Review-Url: https://codereview.chromium.org/2751773002 Cr-Commit-Position: refs/heads/master@{#457527}
 - 
miu authored
In cases where the number of in-flight frames grows large, the PruneFrameStats() logic was eliminating entries that were later being referenced. This caused a CHECK() guard around the offset calculation to trigger. The fix: Force retention of data beyond the configured history size, based on the last ACKed frame. This means that in cases where there is a large number of in-flight frames, we will be maintaining a little more history. However, that should work well for performance in such a scenario. This change also re-examined some of the logic, preemptively fixing things that could cause the history dataset to grow unbounded, now that it must maintain a range consisting of all in-flight frames plus a few extra. Regression test added to validate the fix. BUG=685392 TEST=Added regression test to cast_unittests, which crashes w/o the fix and passes w/ the fix. Review-Url: https://codereview.chromium.org/2718263002 Cr-Commit-Position: refs/heads/master@{#457526}
 - 
fjhenigman authored
https://chromium.googlesource.com/angle/angle.git/+log/6445ddf..8aeeed6 BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2754833003 Cr-Commit-Position: refs/heads/master@{#457525}
 - 
rbpotter authored
Unlike for prints from the system dialog, when printing from print preview the RenderFrameHost is retained by print preview dialog controller and the preview WebContentses are kept alive by the controller and the background printing manager. This causes a CHECK failure in ProfileDestroyer if a print job is still spooling when an incognito window is closed. Since NOTIFICATION_PROFILE_DESTROYED is deprecated and using a KeyedServiceShutdownNotifierFactory does not notify in time, remove these RFHs in browser shutdown directly. Note that this will have the effect of terminating any print jobs that have not been completely rendered, so if the incognito window is closed before a print job is finished, the document will not be printed completely. BUG=579155 Review-Url: https://codereview.chromium.org/2746903005 Cr-Commit-Position: refs/heads/master@{#457524}
 - 
thakis authored
Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2756713002/ ) Reason for revert: Still breaks pnacl-ld on Windows: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F16241%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout pnacl-ld: "--build-id=sha1" affects translation. To allow, specify --pnacl-allow-native Original issue's description: > Reland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2732023004/ ) > > Reason for revert: > With https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391#c1 fixed, this might now work. > > Original issue's description: > > Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #2 id:20001 of https://codereview.chromium.org/2732293002/ ) > > > > Reason for revert: > > https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30394/steps/compile/logs/stdio > > > > pnacl-ld: Unrecognized option: --build-id=sha1 > > > > gn args: > > goma_dir = "/b/c/goma_client" > > is_chrome_branded = true > > is_debug = false > > is_official_build = true > > target_os = "chromeos" > > use_goma = true > > > > Original issue's description: > > > build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON > > > > > > BUG=622775 > > > > > > Review-Url: https://codereview.chromium.org/2732293002 > > > Cr-Commit-Position: refs/heads/master@{#455154} > > > Committed: https://chromium.googlesource.com/chromium/src/+/4e5c4a1545902ab817b8d758c8b3ec4380552b5d > > > > TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=622775 > > > > Review-Url: https://codereview.chromium.org/2732023004 > > Cr-Commit-Position: refs/heads/master@{#455172} > > Committed: https://chromium.googlesource.com/chromium/src/+/e806d46df51009e8c254727b374873bc4379b1fb > > TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=622775 > > Review-Url: https://codereview.chromium.org/2756713002 > Cr-Commit-Position: refs/heads/master@{#457493} > Committed: https://chromium.googlesource.com/chromium/src/+/c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22 TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622775 Review-Url: https://codereview.chromium.org/2754973002 Cr-Commit-Position: refs/heads/master@{#457523}
 - 
scottchen authored
The visual we had for disabled md-select was too light for a11y standards; this CL gives it the same visuals as other disabled elements in md-settings. BUG=657647 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2753983002 Cr-Commit-Position: refs/heads/master@{#457522}
 - 
spqchan authored
There was a race condition with the Page Info icon where it might switch between LocationIconDecoration and SecurityStateBubbleDecoration BUG=694396 Review-Url: https://codereview.chromium.org/2752623003 Cr-Commit-Position: refs/heads/master@{#457521}
 - 
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/dc3c336c84db..be4eed2ef77d $ git log dc3c336c8..be4eed2ef --date=short --no-merges --format='%ad %ae %s' 2017-03-16 bsalomon Detect Chrome either by renderer or version strings. 2017-03-16 bungeman Support pixel antialising in DirectWrite. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I3568e228671ddd588acf285c425380124dba6287 Reviewed-on: https://chromium-review.googlesource.com/456643Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457520}
 - 
rohitrao authored
Revert of Cleaned up old navigation code that did not use pending navigation item. (patchset #4 id:60001 of https://codereview.chromium.org/2751793002/ ) Reason for revert: testReloadInterstitial is failing on an internal bot. For an example, see build 4404 on the internal iphone10-simulator bot. Original issue's description: > Cleaned up old navigation code that did not use pending navigation item. > > Also removed PendingIndexNavigationDisabled experimental setting. > > BUG=692331,701717 > TEST=Back forward navigation works correctly. > > Review-Url: https://codereview.chromium.org/2751793002 > Cr-Commit-Position: refs/heads/master@{#457459} > Committed: https://chromium.googlesource.com/chromium/src/+/2feaa058530953a2232e6128e16deb31192ad9d2 TBR=kkhorimoto@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692331,701717 Review-Url: https://codereview.chromium.org/2759483002 Cr-Commit-Position: refs/heads/master@{#457519}
 - 
acondor authored
When the app button is released within a timeframe, it is considered a click. Otherwise, it is considered a gesture. Indicators appear on top of the content quad to provide visual feedback on the recognized gesture. BUG=692097 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2748763002 Cr-Commit-Position: refs/heads/master@{#457518}
 - 
wkorman authored
BUG=666986 Review-Url: https://codereview.chromium.org/2747083007 Cr-Commit-Position: refs/heads/master@{#457517}
 - 
thomasanderson authored
Revert of Linux UI: Switch to the Gtk3 theme (patchset #3 id:180001 of https://codereview.chromium.org/2670623002/ ) Reason for revert: Reverting to fix component builds on systems with Mir. Will reland (probably later today) once https://codereview.chromium.org/2756543002/ lands Original issue's description: > Linux UI: Switch to the Gtk3 theme > > Sets "use_gtk3 = true" by default. > > BUG=79722 > TBR=dpranke@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > > > Review-Url: https://codereview.chromium.org/2670623002 > > > Cr-Commit-Position: refs/heads/master@{#452118} > > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d681183a3d47b > > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#454491} > > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d13fde39e73283 > > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#455596} > Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844cb89f24d4590 TBR=erg@chromium.org,mmoss@chromium.org,thomasanderson@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=79722,700120 Review-Url: https://codereview.chromium.org/2754913002 Cr-Commit-Position: refs/heads/master@{#457516}
 - 
mohsen authored
Also, removed non-MD code from tray_cast.cc. BUG=699262,687795 TEST=manual Review-Url: https://codereview.chromium.org/2752943002 Cr-Commit-Position: refs/heads/master@{#457515}
 - 
lpromero authored
BUG=none R=marq@chromium.org,rohitrao@chromium.org Review-Url: https://codereview.chromium.org/2750003004 Cr-Commit-Position: refs/heads/master@{#457514}
 - 
jbudorick authored
Previously, command-line flags to be passed to the test had to be passed via: - (gtests) --test-arguments <string> - (instrumentation tests) --device-flags{,-file} <file> This CL changes it s.t. any flags not recognized by the test runner are passed down to the binary. It also removes --device-flags and deprecates --test-arguments. BUG=700366 Review-Url: https://codereview.chromium.org/2752493002 Cr-Commit-Position: refs/heads/master@{#457513} - 
csharrison authored
Fuzzer originally written by jsbell here: https://codereview.chromium.org/2546233002 This introduces a libFuzzer-based fuzzer template (which can be run locally or via ClusterFuzz) for the WTF::TextCodec implementations. It introduces a new target for every text codec. Fuzzer docs: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/getting_started.md This patch also includes a generated fuzzer corpus. Review-Url: https://codereview.chromium.org/2731643002 Cr-Commit-Position: refs/heads/master@{#457512}
 - 
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/cfdb5fdd12d4..c9819a972830 $ git log cfdb5fdd1..c9819a972 --date=short --no-merges --format='%ad %ae %s' 2017-03-16 npm Use EXPECT_FLOAT_EQ in cpdf_devicecs_unittest 2017-03-16 npm Compare to epsilon instead of 0 in CFX_Matrix::SetReverse Created with: roll-dep src/third_party/pdfium BUG=702041 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2752313002 Cr-Commit-Position: refs/heads/master@{#457511}
 - 
schenney authored
These tests are probably still flaky on Windows, but it's hard to tell when they are always failing on Linux. So rebaseline to get at leat some passing results to evaluate flakiness. TBR=chrishtr@chromium.org BUG=653722 Review-Url: https://codereview.chromium.org/2750913004 Cr-Commit-Position: refs/heads/master@{#457510}
 - 
xdai authored
HostPairingScreen (one of OOBE screens) is an observer of BluetoothHostPairingController and remove itself as an observer in its destructor, so it needs to be destructed before |remora_controller_| gets deleted to avoid a nullptr dereference. BUG=None Review-Url: https://codereview.chromium.org/2750973005 Cr-Commit-Position: refs/heads/master@{#457509}
 - 
michaeldo authored
When the referrer was set to an empty string, the openerURL was empty instead of set to |_documentURL|. TEST=Ensure new windows triggered without user interaction (popups) are displayed or blocked as expected. BUG=none Review-Url: https://codereview.chromium.org/2753763006 Cr-Commit-Position: refs/heads/master@{#457508}
 - 
estade authored
BUG=686282 Review-Url: https://codereview.chromium.org/2750263002 Cr-Commit-Position: refs/heads/master@{#457507}
 - 
khorimoto authored
Note that this CL uses no styling, icons, or click targets. These will be done in a future CL. BUG=672263 Review-Url: https://codereview.chromium.org/2754693002 Cr-Commit-Position: refs/heads/master@{#457506}
 - 
tommycli authored
1. Puts the "Enter required custom passphrase" UI at the top of the Sync page. 2. Auto-focuses the passphrase field when the passphrase is required. BUG=694115 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2755793002 Cr-Commit-Position: refs/heads/master@{#457505}
 - 
gmanikpure authored
BUG=chromedriver:1712 Review-Url: https://codereview.chromium.org/2754933002 Cr-Commit-Position: refs/heads/master@{#457504}
 - 
alokp authored
This provides the transitive dependency on skia which is required by media/base/video_codecs.h. BUG=702033 Review-Url: https://codereview.chromium.org/2750283002 Cr-Commit-Position: refs/heads/master@{#457503}
 - 
bcwhite authored
Fully support having multiple processes write information to the same breadcrumbs file. This involves some process-specific operations plus the ability for a controlling process to clean-up after its dead children. BUG=620813 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2680123003 Cr-Commit-Position: refs/heads/master@{#457502}
 - 
bcwhite authored
Data persisted to disk can end up with some oddities should a hard shutdown of the machine (such as from a power failure) cause an incomplete flush of the memory. It's possible that the actual data gets flushed but the "free_ptr" that indicates the end of used memory does not. The data is still iterable but might try to go beyond what is believed to be the end. The GetBlockData() checks against free_ptr have been removed, relying on the fixed mem_size_ boundary and the required existence of the header cookie to know if the block is valid. A "Flush()" call has been added to allow for signalling when essential changes have been made. It's an empty call except for file-backed memory. A call to it is done after initialization to ensure the file on disk appears initialized. A "memory state" field has been added to the shared header to indicate the overall state of the memory (initalized, deleted, etc.) and accessor methods added. This allows the caller to ensure that major changes to the memory segment get propogated. This is used to indicate if it has been "deleted" because actually deleting the file is prone to failure. Unfortunately, this requires a change to the SharedMetada structure that makes this code incompatible with previous versions. The first version with this change will be unable to read persistent data written by the previous version. It will find invalid data in the header and be unable to find the written data blocks. This is unfortunate but safe due to all the precautions against memory corruption already in the PMA. The PersistentHistogramAllocator has been updated to use this when deleting a file and the FileMetricsProvider now reads it and discards the data if it detects this. Still to do is make use of these features in the Breadcrumbs project. BUG=546019,620813 Review-Url: https://codereview.chromium.org/2742193002 Cr-Commit-Position: refs/heads/master@{#457501}
 - 
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9e9188f84b15..dc3c336c84db $ git log 9e9188f84..dc3c336c8 --date=short --no-merges --format='%ad %ae %s' 2017-03-16 ethannicholas fixed missing dependency in spirv-tools/BUILD.gn 2017-03-16 bsalomon In GrClipStackClip check whether op bounds are inside RT before checking for empty clip stack. 2017-03-16 reed Revert[3] "store vertices arrays inline with object""" 2017-03-16 benjaminwagner Marker for AMD driver update. 2017-03-16 ethannicholas turned off SPIR-V validation on ASAN bots Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I582c0134df2ae85f4aeeb25a6dcbcfbdbf498f89 Reviewed-on: https://chromium-review.googlesource.com/456398Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457500}
 - 
dgozman authored
This finally moves ConsoleModel out of sdk. NetworkLog is next. BUG=none Review-Url: https://codereview.chromium.org/2751193003 Cr-Commit-Position: refs/heads/master@{#457499}
 - 
fmalita authored
These are only called from CSSGradientValue to adjust the points/radii immediately after Gradient instantiation. Refactor CSSGradientValue to perform the adjustment before constructing the Gradient object. No functional changes. BUG=614368 R=schenney@chromium.org,fs@opera.com Review-Url: https://codereview.chromium.org/2754703003 Cr-Commit-Position: refs/heads/master@{#457498}
 - 
tsunghung authored
Use CMA backend media pipeline instead of spitzer on headless cast receiver for Android. BUG=Internal b/36179732 Review-Url: https://codereview.chromium.org/2746243002 Cr-Commit-Position: refs/heads/master@{#457497}
 - 
ynovikov authored
Previous CL missed a few. BUG=691029 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2748363003 Cr-Commit-Position: refs/heads/master@{#457496}
 
 -