- 30 Nov, 2020 40 commits
-
-
evliu authored
This CL adds a check when binding the speech recognition recognizer to destroy the speech recognition service if the Speech On-Device API (SODA) binary or model files don't exist on the device. This scenario can occur if a user manually deletes the SODA files from their device and triggers the Live caption feature before the files are redownloaded. The speech recognition service will not be launched in the first place if the SODA components have never been installed before because the local prefs containing the paths to the files will be empty. Bug: 1152915 Change-Id: I92d5abccf0ecd6c9fa5f1f80deda650f2344e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561641Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#831983}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ibac313e4c134044a13bb1219aa49895797bd50e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563761 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Patrick Monette authored
This makes it so that all content/ embedders will be able to use the concept of execution context priority. This CL also moves OverrideVoteAggregator, MaxVoteAggregator and BoostingVoteAggregator out of public visibility, as it is no longer needed. Bug: 971272 Change-Id: I39096d966cc844f75b739d909b4ac2df605eef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564038Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#831981}
-
Simon Zünd authored
This CL introduces a new experimental CDP event in the network domain. As mentioned in the event documentation, the event can fire before the corresponding network request is sent, or after the response is received, depending on success/failure and the type of the Trust Token operation. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1126824 Change-Id: I57fad66b08200ce8c98c44b8406b805627fd3b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554542 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#831980}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie7e703e9270086bd5ef1e9c3a2911f8f76d28713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563762 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If9abd86031c1eaa915a2faa5cdbada40f3e6ee3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560954 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#831978}
-
Yulun Wu authored
Bug: 1145414 Change-Id: I6f218dd45ed9403326e205cb9f125edd6ff25de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545052Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#831977}
-
Mark Yacoub authored
Problem with old non blocking commit: In some cases with high resolution and high frame rate (such as playing graphics or media content on a 4K 60Hz monitor), switching modes (extended->mirrored) will cause DRM to get 2 nearly back to back nonblocking commits from Chrome: One for disabling planes on old controller, and another actual content flip. Due to the close time proximity of the 2 nonblocking commits, while prepping the 2nd one, DRM will throw -EBUSY error because at this time, the flip_done for the 1st commit was not yet complete as userspace is not allowed to get ahead of the previous commit with nonblocking ones (a kernel check). Behavior after the EBUSY depends on the application. On Chrome, the GPU crashes, and resets, trying to recover to a good state, but content would be reset as well. Fix with blocking commit: Making DisablingOverlayPlanes a blocking commit will guarantee that the flip_done for this commit is complete before OS sends any subsequent non-blocking page flips. On blocking commits, DRM does not hand control back to OS until well after the flip_done is complete. Rationale of the new design: DisablingOverlayPlanes happens on the same thread and during the same time as the full modeset, which is a blocking commit. So makes sense that all modeset-related commits to be blocking until everything has been set/reset properly. BUG: b/171409360,b/172306392 TEST: with 4K display attached to a kohaku, switch from extended to mirror mode. Change-Id: Icff491be107267eb49cf3a2846b6d219a0f82c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559170 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#831976}
-
Becca Hughes authored
Add a metric that records whether a user opened a recommendation from Kaleidoscope during the Kaleidoscope session. BUG=1110373 Change-Id: I49cc5ac2b8a3dbccb711301068b23c315e725eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551286Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#831975}
-
Ryan Sturm authored
This refactors client hints to allow main frame prefetch navigations to add client hints without needing a frame. Related headers CL: https://chromium-review.googlesource.com/c/chromium/src/+/2552723 Bug: 1142074 Change-Id: I662d4a8529f7546df80d81128d7df8545717fbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551671Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#831974}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606715277-9385c299327136363de38f40b28eb44b3b85ec7c.profdata to chrome-win64-master-1606748271-2b69dce80f38ecf2d66f6209245527ea06788f5d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic24b6f6fdebc366d53a5a74cd282094091920402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831973}
-
Junyi Xiao authored
This is a reland for https://chromium-review.googlesource.com/c/chromium/src/+/2131009 with attempt to fix the failing test on Mac. Bug: 1046481 Change-Id: Ibd4adb5a3315df5be583dabd45de05c97127a2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511979 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#831972}
-
Ryan Sturm authored
Bug: 1152562 Change-Id: Ie719be00784ca796a3275eb9b44bb89de2ca964f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559215Reviewed-by:
-
Patrick Noland authored
on marshmallow emulators Bug: 1153888 Change-Id: Ieaa0be35276100a19a6ea6b4de6521621db96e0b TBR: hypan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564757Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#831970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5968da649c17..619ae0038825 2020-11-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 8756b1cb930a to ce0450b9e8e5 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I1e3a469b77e882ee5e1aa14ce9328668edd2b75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565104Reviewed-by:
-
Wenyu Fu authored
The previous dimension assuming the button height is 42dp, while minimum touch target size is now 48dp. Bug: 1127528 Change-Id: Ia9946360d1dc7ae261494f460cf8cb860766e526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560605 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#831968}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4324.9-1606128713-benchmark-89.0.4337.0-r1 to 89-4324.9-1606733211-benchmark-89.0.4337.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic0d27fa5c2075d42cc03d1d0cb9a816c8053191a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565498Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I8ad7887c8903f907699d1fd5f98bf4cb8f6bb42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556957Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#831966}
-
Maksim Ivanov authored
Delete the Enterprise.ExistingInstallAttributesLock UMA histogram. It's expired a while ago and doesn't seem to be needed anymore. Bug: 1084091 Change-Id: Ie62a2f3edae5d1084f0747ef0dc2e19f9c337d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548625 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1131321 Change-Id: If11517ade428937676330728733a6dccba0c0064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560616 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#831964}
-
Mike Reed authored
The long-term change is Skia dropping SkFilterQuality entirely. This has some important repercussions: - clients specify their sampling when they create their imageshader - skia never changes its behavior (due to CTM or other conditions) e.g. if the client asks for cubic-resampling, skia always does that This CL is a small step in this direction: updating callsites for scalePixels() to pass in SkSamplingOptions, rather than the enum. Bug: skia:7650 Change-Id: I8edccf6c32e5c966c65f25ea19c3c613dc710b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556474Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#831963}
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee a video frame is displayed on screen before ending the test. Bug: 1083314 Change-Id: I1e011d9bc18260f2bad3867892ed623bd4de4b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561779 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Solomon Kinard authored
Restrict web_accessible_resources based on site |matches| that extension developers have supplied in manifest.json. Manifest V3 includes changes to the web_accessible_resources key of manifest.json. Use parsed |matches| field to determine which sites have access to specific resources. In the following example, a.com can access a.gif, but other sites can't: "web_accessible_resources": [{ "resources": ["a.gif"], "matches": ["https://a.com/*"] }] Bug: 1133624 Change-Id: Idd0f4a828e2d1a543aaf5e51ab7af6ec6f2f7220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485887Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#831961}
-
Gavin Mak authored
Bug: 1007635 Change-Id: I9efd01370fde3b5263ad5a2af7878ae46b0f86c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558730Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#831960}
-
Zhaoliang Ma authored
Bug: None Change-Id: I5f83416141829c2dc898a7724df8076eb75cc283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564567 Auto-Submit: Zhaoliang Ma <zhaoliang.ma@intel.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Piotr Pawliczek authored
This patch changes slightly the grammar used by the Uri class. In the previous version, the ":" separator following the schema was always required. In the new grammar, the ":" separator is omitted for an empty schema. As a result, the normalized representation of an empty Uri is an empty string. This is more intuitive behavior than the previous one, when empty Uri was represented by ":" string. All URIs accepted by the old grammar are also accepted by the new one. Additionally, URIs without scheme and without the ":" separator are also accepted now. BUG=none TEST=with unittests on my workstation Change-Id: I4bc8875af4a5d05a227aca47863c7d659b8d4223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553529 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#831958}
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee a frame is displayed on screen before ending the test. Bug: 1103820 Change-Id: If7990fcbbc2605d5512157c8aa9b91b9e0a2ba6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561448 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee that a frame is displayed on screen before ending the test. Bug: 1099336 Change-Id: I02fa119bb20875111187da94460263a3d75e39e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561681 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Previously the code within NGTableLayoutAlgorithm::ComputeMinMaxSizes was doing (some) the job of ComputeMinAndMaxContentContributionInternal. This patch removes some of that logic (only leaving the "infinite" quirk), and changing ComputeMinAndMaxContentContributionInternal to always make NG tables respect the "min-intrinsic" table inline-size. Bug: 958381 Change-Id: I9d1b35f281378f199a3758a20304a12f27c3e10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561745Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#831955}
-
Jeffrey Kardatzke authored
This adds encrypted content support to the VAAPI H265 accelerator. This is not implemented in the driver yet, but this will facilitate better testing by Intel if we implement it first and it's fairly straightforward to do it. BUG=b:153111783,chromium:1141237 TEST=Builds, clear HEVC content playback works Change-Id: Ibe468777b663cbc301b6d2c14ab1d2bceeda8e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555544 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#831954}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/media_router Bug: 1113033 Change-Id: Ic399c177758d3fbfefa46b336080ed0091290793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545023 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831953}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dd3be2e78615..c4492956adde 2020-11-30 jacktfranklin@chromium.org Remove component bridges generation 2020-11-30 jacktfranklin@chromium.org Fix regression in keyboard navigation of SoftContextMenu 2020-11-30 pfaffe@chromium.org [wasm debug] Fix propagating debug evaluate errors in language plugins 2020-11-30 yiorsi@gmail.com Add copy css context menu in Styles panel 2020-11-30 raphael.kubo.da.costa@intel.com SensorsView: Set angle input type to "number" in createInput() call. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137514,chromium:1152391,chromium:1153315 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e9162d840acb54175872e3a985c4e7fdf60611f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564030Reviewed-by:
-
Jeremy Roman authored
They're cool and efficient. This should be more efficient at runtime but approximately as readable in the source text. Change-Id: Id8b8a2b1c8b869c4a3f22326bfa381fb67b3de13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562819 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc75a97b8010..c4fbc8d6cf34 2020-11-30 robertphillips@google.com Stop overflow of windows rects in GrClipStack 2020-11-30 johnstiles@google.com Fix SPIR-V and Metal support for enum types. 2020-11-30 johnstiles@google.com Fix SPIR-V compilation error with arrays of samplers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I7b0d288842aeefc977b942d0db79ad94468332c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565106Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dc7b108da629..eb386eb3d290 2020-11-30 vapier@chromium.org Reland "repo: auto-update depot_tools when used" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1148984 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2a488e1e038c34459b27b46f16b162d6d3144bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565107Reviewed-by:
-
Shimi Zhang authored
We are calling Icon#loadDrawable on the UI thread previously, based on the Android doc, we should use Icon#loadDrawableAsync instead. Previously, this is not enforced, but now we encountered a StrictMode violation for this. Since now we are calling Icon#loadDrawableAsync, we need to pre-warm the Drawable before we show the popup menu, otherwise the icon will be set after the popup menu showed for the first time. Bug: 1129211 Change-Id: Iac5127a307d1d2d124a4b2debb7b021a2be2da75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562059Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#831948}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/printing... Bug: 1113033 Change-Id: I4f0aeb9552b900c80bec42e9435a49118f4903c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555558Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831947}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I81b1f6a8fb76d2ca7120a12e7fab1a66156aef11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561391 Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#831946}
-
Rushan Suleymanov authored
The removed DCHECK could be violated in case when SendTabToSelfBridge is initialized and DeviceInfoSyncBridge hasn't been initialized yet (and the local cache GUID hasn't been stored in recent cache GUIDs). There are several possible cases when it happens: 1. DeviceInfoSyncBridge::OnReadData is done, however metadata hasn't loaded yet. It means that DeviceInfoSyncBridge::IsSyncing() will return true while the cache GUID is not known. 2. (less likely) Cache GUID has changed and the old metadata of DeviceInfoSyncBridge has been loaded (but OnSyncStarting hasn't been called yet). In both cases if SendTabToSelfBridge is fully initialized (both metadata has been loaded and OnSyncStarting has been called with a new cache GUID), then the DCHECK will fail. Bug: 1023457 Change-Id: I27951f825a7b900b55d8a22b645064c53a056c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563488Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#831945}
-
Aaron Leventhal authored
AddChild() already does two useful things for us: - Null checks, doesn't add child if there isn't one - Recursively adds descendants if the AXObject isn't included in tree Also progresses toward a future change where adding children automatically sets the parent to |this|, rather than needing to compute it and possibly getting different results. See CL:2528573. There are still a couple of remaining cases not addressed, but are addressed in other WIP CL's. Bug: None Change-Id: Id1632732c66bc17173294e62092d8be58cf88873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564465 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#831944}
-
