- 27 Sep, 2017 40 commits
-
-
Dale Curtis authored
There shouldn't be any remaining issues with these tests on ChromeOS vs any other platforms, so attempt re-enable. BUG=622397 TEST=none Change-Id: If1fbf56b9da66fb1b2d6290999a868e1b488e73e Reviewed-on: https://chromium-review.googlesource.com/685820Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#504772}
-
Alexandr Ilin authored
The speculative preconnect feature comes in three modes: * Learning - only the LoadingPredictor database construction is enabled. * Preconnect - the LoadingPredictor actually does preconnects leveraging the historical database. This mode also disables net::Predictor to avoid an interference between them. * No preconnect - disables both types of preconnects. This mode is useful for manual testing. Bug: 699080 Change-Id: I445583d937e57cd99f78ea6f4bc4134b2614c885 Reviewed-on: https://chromium-review.googlesource.com/684896 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#504771}
-
Dale Curtis authored
The conditional in FFmpegAudioDecoder checking for unsupported channel layouts was not using the right variable. It used the one from the config rather than the one for the frame (which is required for config change support). I think there's no real harm in this besides a DCHECK failure, but might be worth merging back anyways. This regressed in M62 with 16223674. BUG=726971 TEST=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibcdc5ceeb263c3e247742b4fbfe07a45e64297de Reviewed-on: https://chromium-review.googlesource.com/686064 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#504770}
-
Christopher Grant authored
We have been assuming a platform-specific arrangement of bytes in the Skia textures we generate. The resulting SkPixmap color format varies by platform, and is different on Linux vs. Android. BUG=769325 Change-Id: Id157f45b179fa74478b1662e7ada3b2e8ff82456 Reviewed-on: https://chromium-review.googlesource.com/688334Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#504769}
-
Eugene Ostroukhov authored
Bug: Change-Id: I9b0ef3f4a9776ef27f57b67c08731e2ad967d970 Reviewed-on: https://chromium-review.googlesource.com/683007Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#504768}
-
Luigi Semenzato authored
BUG=chromium:758016 TEST=none Change-Id: I6da6a2ebadabf39109534706fb8673b13ae95fff Reviewed-on: https://chromium-review.googlesource.com/679274 Commit-Queue: Luigi Semenzato <semenzato@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#504767}
-
Fernando Serboncini authored
Bug: 765719 Change-Id: Id172d596202bab6c2e8093b285feacceadc4425a Reviewed-on: https://chromium-review.googlesource.com/672665 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#504766}
-
Jian Li authored
Bug: 701939 Change-Id: I72f565cb28fc4e13e34226baea5bb421b4a8de83 Reviewed-on: https://chromium-review.googlesource.com/675889 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#504765}
-
dpapad authored
Bug: 751758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0552b674bf1ab78e2ab942a79d7d98bf0da181d3 Reviewed-on: https://chromium-review.googlesource.com/679196 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504764}
-
Alexandr Ilin authored
This CL redirects hints from the omnibox to the LoadingPredictor if it is enabled. For now the LoadingPredictor attempts only to preconnect in case of search query or preresolve otherwise to keep it consistent with the current behavior. Bug: 699080 Change-Id: I25593be62e751a6ff983b3e97f397985c77c6644 Reviewed-on: https://chromium-review.googlesource.com/675685Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504763}
-
Andrew Grieve authored
Also fix logcat -v showing all logcat lines from before launch Change-Id: I375c520bdc89a5d8b0f1e7b4cdcfbc739a7bdacc Reviewed-on: https://chromium-review.googlesource.com/687557Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#504762}
-
Nicolas Dossou-gbete authored
Follow up to https://crrev.com/c/674691 The test failure on CQ related to the change was ignored because the test was also failing without the patch for another reason. TBR=bauerb@chromium.org Bug: None Change-Id: I1ff5645171141642540940500ae99561e1343e61 Reviewed-on: https://chromium-review.googlesource.com/688076Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504761}
-
CJ DiMeglio authored
This change is a follow up to a TODO that calls for direct access to the ContextProvider after it has been moved to the gpu. Bug: 746182 Change-Id: Iad2e9e89e234724e4f9053b43ae74dfd66cfa901 Reviewed-on: https://chromium-review.googlesource.com/668029Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#504760}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/168f550c..408b8e44 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ie329123549c567d97a406e5e9b5d37c16b66c413 Reviewed-on: https://chromium-review.googlesource.com/686780Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#504759}
-
Peng Huang authored
The surface input region doesn't work in mus and mash. This CL implements WindowTargeter::GetExtraHitTestShapeRects() for exo::Surface::window_. In mus and mash, this function will be called and returned hittest rects will be sent to mus. Bug: 766174 Change-Id: I67dc04cc331f0174ff3390920c3de98c00100df5 Reviewed-on: https://chromium-review.googlesource.com/685277 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504758}
-
Jun Cai authored
This CL adds necessary {} and removes unnecessary {} for generic_sensor code. Bug: None Change-Id: I1a752303d39ddb2d215a018ee6adeacd7f8d1b58 Reviewed-on: https://chromium-review.googlesource.com/687556Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#504757}
-
Filip Gorski authored
This patch removes a duplicate method and renames its uses. Bug: 753595 Change-Id: I8c101b726418f457e4d0feadfb6f042c6558e02f Reviewed-on: https://chromium-review.googlesource.com/687822Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504756}
-
Hans Wennborg authored
It was causing a Clang warning to fire: FAILED: obj/third_party/WebKit/Source/core/editing/editing/TextIteratorTextNodeHandler.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes @obj/third_party/WebKit/Source/core/editing/editing/TextIteratorTextNodeHandler.obj.rsp /c ../../third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp /Foobj/third_party/WebKit/Source/core/editing/editing/TextIteratorTextNodeHandler.obj /Fd"obj/third_party/WebKit/Source/core/editing/editing_cc.pdb" In file included from ../../third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp:1: In file included from C:\b\c\builder\ClangToTWin_dbg_\src\out\Debug\..\..\third_party\WebKit\..\..\third_party\WebKit\Source\core\Precompile-core.h:25: In file included from ../../third_party/WebKit/Source\core/dom/Document.h:37: In file included from ../../third_party/WebKit/Source\bindings/core/v8/ExceptionState.h:34: In file included from ../../third_party/WebKit/Source\bindings/core/v8/ScriptPromise.h:34: In file included from C:\b\c\builder\ClangToTWin_dbg_\src\out\Debug\..\..\third_party\WebKit\Source\bindings\core\v8\ScriptFunction.h:34: In file included from ../../third_party/WebKit/Source\bindings/core/v8/ScriptValue.h:36: In file included from ../../third_party/WebKit/Source\platform/bindings/ScriptState.h:12: In file included from C:\b\c\builder\ClangToTWin_dbg_\src\out\Debug\..\..\third_party\WebKit\Source\platform\bindings\V8PerContextData.h:41: In file included from ../../third_party/WebKit/Source\platform/bindings/V8GlobalValueMap.h:10: In file included from ../../third_party/WebKit/Source\platform/wtf/text/StringHash.h:28: In file included from ../../third_party/WebKit/Source\platform/wtf/text/AtomicString.h:31: In file included from ../../third_party/WebKit/Source\platform/wtf/text/CString.h:31: ../../third_party/WebKit/Source\platform/wtf/RefCounted.h(161,44): error: delete called on non-final 'blink::NGPhysicalFragment' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] static void DeleteInternal(const T* x) { delete x; } ^ ../../third_party/WebKit/Source\platform/wtf/RefCounted.h(142,7): note: in instantiation of member function 'WTF::RefCounted<blink::NGPhysicalFragment, blink::NGPhysicalFragmentTraits>::DeleteInternal' requested here class RefCounted : public RefCountedBase { ^ 1 error generated. BUG=84424 TBR=thakis Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8699ffcd62064f2c53f2dd12ac0456bb46aaacb2 Reviewed-on: https://chromium-review.googlesource.com/687555Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#504755}
-
Alexis Hetu authored
The Linux CFI bot was detecting unrelated casts in LLVM's allocator, which is actually the desired behavior of an allocator, generally. Added an entry to the blacklist to prevent this error on the CFI bot. R=vtsyrklevich@chromium.org TBR=pcc@chromium.org Bug: 726075 Change-Id: I7fd970a5f564d46a066ae57a0d7c6fe46be62868 Reviewed-on: https://chromium-review.googlesource.com/688017Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504754}
-
danakj authored
GLRenderer uses a non-immutable resource when copying the current RenderPass to a texture, as the storage format is not explicit when copying from the OutputSurface backbuffer. In that case the buffer can be RGB so we need to define the format of the texture as RGB (you can't add a component when copying), but the ResourceProvider does not support RGB textures, and adding it everywhere there would be unneeded complexity. Instead, we make GLRenderer stop using ResourceProvider for this use case. Since it is isolated to the GLRenderer subclass (DirectRenderer does not need to know about these textures), we don't need to use a "ResourceId" abstraction. This adds a GetFramebufferCopyTextureFormat() method to GLRenderer that returns the GL format to use for a texture if copying from the current Renderpasss output. This removes the GetFramebufferTexture() method, and moves the call to CopyTexImage2D() out to the two callsites: - In the CopyOutputRequest code, we already have a texture id, and just need to bind it and call CopyTexImage2D. - In GetBackdropTexture(), we create a new texture id, set up its filters, and bind and CopyTexImage2D. - Both of these use the GetFramebufferCopyTextureFormat() to choose the best format for the copy output. Since we have a raw texture id, we replace uses ResourceProvider locks and ScopedResource throughout, and ensure to delete the texture ID when we set it to 0, or when we destroy the |params| at the end of GLRenderer::CopyRenderPassDrawQuadToOverlayResource and GLRenderer::DrawRenderPassDrawQuad. R=piman@chromium.org Bug: 768976 Change-Id: I14ee01a767416da9210d80a73c39ef1d2022c58c Reviewed-on: https://chromium-review.googlesource.com/685300 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504753}
-
Xida Chen authored
This reverts commit f37c1971. Reason for revert: <INSERT REASONING HERE> Causing layout test failure on Mac10.9 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/50208 Original change's description: > Split the accessible combo box role into three roles. > > For historical reasons, the ARIA role "combobox" is misused > and misunderstood. It can be one of three things: > > 1. A fully editable text field that also has a drop-down list > of possible options > 2. A button that opens to reveal a mutually-exclusive list of > choices (but with no text field anywhere) > 3. A grouping container with a text field and a drop-down list > inside > > The only platform where this mostly worked was on Windows, > where "combo box" is a native control. On Mac and Android, > we need to treat #1 as a text field primarily, and #2 more > like a button, since there's no equivalent that acts as > both. > > Bug: 516869, 666049, 546051 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I7ffd92f2996c729398d4300262e545eaa9ca0009 > Reviewed-on: https://chromium-review.googlesource.com/642056 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504725} TBR=dmazzoni@chromium.org,dtseng@chromium.org,michaelpg@chromium.org,aleventhal@chromium.org Change-Id: I4a3c390bd6c363f531ed00f1faa5fb660f637d16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516869, 666049, 546051 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/688354Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504752}
-
Ted Choc authored
Previous CL: https://chromium.googlesource.com/chromium/src/+/995c535793ecd77fc2661c428d507a017d042db1 BUG=768789 Change-Id: Id162e32921e55a597c2253737f2180e0a4006596 Reviewed-on: https://chromium-review.googlesource.com/685821Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#504751}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/c29c16f8cb98..8b1408e70532 $ git log c29c16f8c..8b1408e70 --date=short --no-merges --format='%ad %ae %s' 2017-09-27 rharrison Remove FXSYS_strlen and FXSYS_wcslen 2017-09-27 rharrison Replace FX_SAFE_STRSIZE with FX_SAFE_SIZE_T 2017-09-27 rharrison Remove FX_STRSIZE and replace with size_t 2017-09-26 rharrison Make names of GIF types less opaque 2017-09-27 rharrison Add in missing ! to conditional 2017-09-27 dsinclair Move static methods to anonymous namespace Created with: roll-dep src/third_party/pdfium BUG=769292 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iaae379bbcfe4991deac62bcbedc268c752e68011 Reviewed-on: https://chromium-review.googlesource.com/687816 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504750}
-
Sahel Sharify authored
In case of nested OOPIFs the GSB event is bubbled one target at a time; when GSB is bubbling up from an intermediate target, a synthetic GSE is sent to the target to finish the scrolling sequence on it. Once GSB has found its final target, the rest of the scroll events are directly bubbled to that target rather than getting bubbled up one target at a time. https://chromium-review.googlesource.com/658217 cl has fixed the DCHECK hit while sending a synthetic GSE to an intermediate target. However, the generated GSE still stops scroll bubbling by resetting the bubbling target to null. This cl drops generated GSEs that are sent to intermediate bubbling targets and prevents them from stopping the scroll bubbling. Bug: 763422 Change-Id: I6a49d431b6f838b3f56e477ef6b0af7b8e6bf0c2 Reviewed-on: https://chromium-review.googlesource.com/678536Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#504749}
-
Justin Novosad authored
Call to WaitSyncTokenCHROMIUM was removed by mistake in: https://chromium-review.googlesource.com/c/chromium/src/+/579690 BUG=769155, 766611 Change-Id: I25a95c79755801463b15fb12047458c594bf24d6 Reviewed-on: https://chromium-review.googlesource.com/685379 Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#504748}
-
Daniel Murphy authored
This reverts commit 93935b15. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=769403 (causing bot failures on newtabpage test) Original change's description: >
📰 Use standard styles for classic action items > > Updates the SuggestionCardActionModern style to be more generic and > be usable for classic cards, use it for the classic generic signin > promo and the action item. > > Preview: https://photos.app.goo.gl/GC9l01D8QI7YSLtI2 > Bug: None > Change-Id: If1a007ad4288cc88511845b3ac89a9c8f2f1cbab > Reviewed-on: https://chromium-review.googlesource.com/674691 > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504678} TBR=mvanouwerkerk@chromium.org,dgn@chromium.org Change-Id: Ife5676ada7e69b01c3b8fcb3002cd779527e93cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769403 Reviewed-on: https://chromium-review.googlesource.com/688160 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#504747}
-
Scott Chen authored
To allow new WebUI to use the KioskAppsHandler code, this CL converts all the CallJavascriptUnsafe calls to either fire a WebUI event, or resolve a specific Javascript promise. Bug: 764943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I04e0f81220251cfd3eaab3100b256f13b7f34430 Reviewed-on: https://chromium-review.googlesource.com/676092 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504746}
-
Dominik Laskowski authored
This CL extends app launching to include the display ID of the shelf/launcher/view used to launch an app/intent, which allows ARC to launch apps on a specific display. using different shelves/launchers. Bug: b:63535964 Test: Launch apps using different shelves/launchers. Test: Launch Android settings on different displays. Test: Open app info pages using different launchers. Test: Add Hangouts conversation to home screen, and launch the intent Change-Id: I637b50092b4c107ef24d93af4b0bce6cd7916b54 Reviewed-on: https://chromium-review.googlesource.com/641666Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#504745}
-
Fernando Serboncini authored
Bug: 722511 Change-Id: I3821a71b15056fc034788b5317bbab342f65a553 Reviewed-on: https://chromium-review.googlesource.com/677230Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#504744}
-
Walter Korman authored
Two variant data types will be done in subsequent change. A complete ToString will be useful for folks working on font support in out-of-process raster. For more see: https: //docs.google.com/document/d/1vsJsk1zGSagxxBggd8j5G9u0rMzD1NTaQWgEbUabEvY/preview#heading=h.xzi2kl5b59mm This is a follow-up to: https: //chromium-review.googlesource.com/c/chromium/src/+/683463 Change-Id: I0eca62cd0e53c1d283a3b3f2c1d01932fe9f47d5 Reviewed-on: https://chromium-review.googlesource.com/685898 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#504743}
-
Sadrul Habib Chowdhury authored
Add API to get into/out of overview mode in ash for a telemetry test. BUG=758061 Change-Id: I13dcebbde047688011f072b3e82eccfb718559ae Reviewed-on: https://chromium-review.googlesource.com/664120Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504742}
-
Selim Gurun authored
WebView did not have tests for shouldoverrideurlloading in popups. This code path is different from main code path and needs to be tested. These tests only add a few basic ones. Bug: 766167 Change-Id: Ic9223ca602d82cf5f2902e0db599af463e703077 Reviewed-on: https://chromium-review.googlesource.com/685750Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#504741}
-
Matthew Jones authored
This change adds a static utility method for creating animations and a new class called AnimatedFloat. The AnimatedFloat is a wrapper for a primitive float value that can be held by an animator for updating. BUG=750381 Change-Id: Ibfc69be0228e1ff5cda3193c9c72eb44a9b5de89 Reviewed-on: https://chromium-review.googlesource.com/636173 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#504740}
-
min c authored
This reverts commit 865d42f4. Reason for revert: The flakiness in interactive_ui_tests in AppListTest.PressAppListButtonToShowAndDismiss (which is a test about the mouse event) seems not related with the change. Try to reland it. Original change's description: > Revert "Dragging up on app list button to open the launcher." > > This reverts commit 60ef03d4. > > Reason for revert: Causes flakiness in interactive_ui_tests in > AppListTest.PressAppListButtonToShowAndDismiss on > ChromiumOS on Linux (dbg). > > https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30578 > > Original change's description: > > Dragging up on app list button to open the launcher. > > > > Changes, > > 1. Don't handle the scroll gesture events in AppListButton::OnGestureEvent, let > > the ShelfView handle it instead. > > 2. Add a test for the swiping on applist button to open launcher. > > > > Bug: 758071 > > Change-Id: I71557411e9de6cd21bdb76c52dfb545a1e621783 > > Reviewed-on: https://chromium-review.googlesource.com/685535 > > Commit-Queue: min c <minch@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#504492} > > TBR=xiyuan@chromium.org,minch@chromium.org > > Change-Id: I0a09a59593521f2049e9a782cd5029312c61098b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 758071 > Reviewed-on: https://chromium-review.googlesource.com/685899 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504520} TBR=xiyuan@chromium.org,michaelpg@chromium.org,minch@chromium.org Change-Id: I3ca0e004c69dae81ca6abdd46285d129e3e40f4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758071 Reviewed-on: https://chromium-review.googlesource.com/687876Reviewed-by:
min c <minch@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#504739}
-
Tom Anderson authored
This CL fixes the ozone Linux build after r504590. TBR=tommi@chromium.org CC=mfoltz@chromium.org Change-Id: Ice6b7e1f5858c43bd1d9388ef84ee179e2268a32 Reviewed-on: https://chromium-review.googlesource.com/688155Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#504738}
-
David Reveman authored
This reverts commit 056af850. Reason for revert: Should now be safe to remove this interface. Original change's description: > Revert "exo: Remove support for wl_drm interface." > > This reverts commit 4c157e7a. > > Reason for revert: Need to wait for Android uprev on CrOS before this can land. > > Original change's description: > > exo: Remove support for wl_drm interface. > > > > linux-dmabuf protocol is preferred over wl_drm and the latter can now be > > removed as ARC++ has switched to linux-dmabuf. > > > > BUG=b/62900000 > > TEST=manual > > > > Change-Id: Ibb28361b1055ef7f61e38530cf7640ec05ecd894 > > Reviewed-on: https://chromium-review.googlesource.com/549258 > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Commit-Queue: David Reveman <reveman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#483087} > > TBR=reveman@chromium.org,piman@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: b/62900000 > Change-Id: Ifd47be08a3d1d4164c05885dcfaa4a85d5d0149f > Reviewed-on: https://chromium-review.googlesource.com/558104 > Reviewed-by: David Reveman <reveman@chromium.org> > Commit-Queue: David Reveman <reveman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#483865} TBR=reveman@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/62900000 Change-Id: Id49343d0f956eb29af8b04bc11bd3e3eb278b990 Reviewed-on: https://chromium-review.googlesource.com/687334Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504737}
-
Istiaque Ahmed authored
GetIsDistillableJs() is used in ConvertUTF8ToJavaString from url_utils_android.cc, and the conversion function already accepts base::StringPiece param. So this would essentially remove an unnecessary string copy. Bug: None Change-Id: Ic49eb0cfb89b4daca5cb57c20b725f9bd1e41483 Reviewed-on: https://chromium-review.googlesource.com/685645Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#504736}
-
Evan Stade authored
This fixes the crash and restores old behavior, although that old behavior is wrong: since we never update the current notifier group (i.e. profile), it will always just disable the notification for the first profile rather than the one that originated the notification. I'll work on fixing that in a follow up. from ..." on any desktop platform TEST: right click on a web notification and click "Disable notifications Bug: 769171 Change-Id: Ibe6eb97e3da46fa70e5363748ce772a006aea64a Reviewed-on: https://chromium-review.googlesource.com/687654Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#504735}
-
Nicolas Dossou-gbete authored
Bug: 768779 Change-Id: I43930a031b9e42a11f018a93022dcbfafa8b6863 Reviewed-on: https://chromium-review.googlesource.com/687500Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#504734}
-
Rune Lillesveen authored
I did not find a way to await each forEach or map in inert-inlines, so I fell back on a plain old for-loop. Bug: 726218, 769347 Change-Id: I196ff128ce95319b7ca297254745aec842ef6cff Reviewed-on: https://chromium-review.googlesource.com/686814 Commit-Queue: Rune Lillesveen <rune@opera.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#504733}
-