GitLab

Change the watchlist to cover ui code like:
chrome/browser/resources/settings/clear_browsing_data_dialog
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingData*

Change-Id: Ibe872c09e8ba9737faf474c1126524ca8c148531
Reviewed-on: https://chromium-review.googlesource.com/c/1276765Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598787}

Not sure yet why this isn't breaking M71, but it's breaking M70.

Bug: 894429
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7eadef0d8a6e990e37300ec0b391f05c1220ec0d
Reviewed-on: https://chromium-review.googlesource.com/c/1276566
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598786}

This is a prerequisite to:
https://chromium-review.googlesource.com/c/chromium/src/+/1122629

When a file chooser dialog is opened for an active iframe, but is closed
when the iframe is in pending deletion, it should not continue.

Bug: 609963
Change-Id: I897258f642e812de4b3abf117a2a83815568aba8
Reviewed-on: https://chromium-review.googlesource.com/c/1253783
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598785}

Currently to fix a layout issue in the save card infobar in iPhone X,
|-setFrame:| is overridden to call |-layoutIfNeeded| in order to update the
layout of subviews immediately. |-setFrame:| won't be required to be
overridden if the logic to adjust the layout constraints is moved from
|-sizeThatFits:| to |-layoutSubviews|. The existing logic is likely to be
wrong as the layout should not get updated in calls to |-sizeThatFits|.

This is likely the root cause for the crash in crbug.com/892144

Bug: 862688,892144
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iee81a30afa14581f304813512b84b86fc5c6feb5
Reviewed-on: https://chromium-review.googlesource.com/c/1262087
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598784}

Current resources that are cached are being reported as 0 byte
resources in Ads.ResourceUsage.Size.* histograms. This is skewing
the histograms low making it hard to see the real distribution of
resource sizes. Record cached resources in a separate histogram.

Change-Id: I379029ff70ad9f655a8e8887ff7cb5a5a3a08f5e
Bug: 859080, 892153
Reviewed-on: https://chromium-review.googlesource.com/c/1258284Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598783}

Currently, ProtoDatabase<T> only allows us to have a LevelDB that stores
a single proto type.

In preparation for a single unified proto DB, ProtoDatabase and
ProtoDatabaseImpl have been refactored. Much of ProtoDatabaseImpl's
logic has been moved into ProtoLevelDBWrapper, which contains template
functions instead of being a template class.

ProtoDatabase<T> provides the interface we have today, and we now
have a UniqueProtoDatabase<T> as a thin layer above ProtoDatabase so
that it can manage the unique_ptr to its own LevelDB.
ProtoDatabaseImpl<T> is kept around as an alias for UniqueProtoDatabase
for compatibility, and as a result no ProtoDatabase(Impl) users are
negatively impacted by this change.

The addition of the ProtoLevelDBWrapper provides a convenient place to
record metrics for the various database clients.

Bug: 870813
Change-Id: I6175a3cbea5dd312f09c1d88d5ad80f1f4b26006
Reviewed-on: https://chromium-review.googlesource.com/c/1170093
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598782}

https://webrtc.googlesource.com/src.git/+log/2b1562632a02..f81170b48fd4


git log 2b1562632a02..f81170b48fd4 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 perkj@webrtc.org Add error logs to RtpPacketHistory::GetBestFittingPacket when no packet is found.
2018-10-11 srte@webrtc.org Adds srte to WATCHLISTS.


Created with:
  gclient setdep -r src/third_party/webrtc@f81170b48fd4

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I817a9238ca176782360de7570a8cf747d5fa2098
Reviewed-on: https://chromium-review.googlesource.com/c/1276547Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598781}

It appears for the Chrome Sync users.

Bug: 890336
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0a443b3d29670c00c28a847d6d2253db3a620996
Reviewed-on: https://chromium-review.googlesource.com/c/1270922Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598780}

This is a cleanup CL to merge MainThreadWorkletGlobalScope and
ThreadedWorkletGlobalScope into WorkletGlobalScope for shallowing the class
hierarchy of WorkletGlobalScope and making it more extensible.

========== Details ==========

Before this CL, WorkletGlobalScope has the following class hierarchy.
MainThreadWorkletGlobalScope and ThreadedWorkletGlobalScope implement thread
specific things, for example, GetTaskRunner().

- WorkerOrWorkletGlobalScope
  - WorkletGlobalScope
    - MainThreadWorkletGlobalScope
      - PaintWorkletGlobalScope
      - LayoutWorkletGlobalScope
    - ThreadedWorkletGlobalScope
      - AudioWorkletGlobalScope
      - AnimationWorkletGlobalScope

This separation has been worked well until now because each subclass of
WorkletGlobalScope runs only on a specific thread (i.e., the main thread or a
worker thread). However, the situation has been changed. We started implementing
off-the-main-thread PaintWorklet (See https://crbug.com/829967) and noticed
this separation makes it so difficult to enable PaintWorklet to run on both the
main thread and a worker thread.

To mitigate the difficulty, this CL merges them into WorkletGlobalScope. After
this CL, the class hierarchy looks like this:

- WorkerOrWorkletGlobalScope
  - WorkletGlobalScope
    - PaintWorkletGlobalScope
    - LayoutWorkletGlobalScope
    - AudioWorkletGlobalScope
    - AnimationWorkletGlobalScope

In this new hierarchy, WorkletGlobalScope implements thread specific things, and
provides multiple constructors for its subclasses to specify thread affinity.

Bug: 893478
Change-Id: Iad817c7dd10ce5bd51a4c381fbd34aa1669454f7
Reviewed-on: https://chromium-review.googlesource.com/c/1272416Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598779}

FindIt is moving away from always using the --gtest* flags to a new set
of unified flags for all isolated script tests. This change adds the new
flags (as aliases to existing flags). The old --gtest* aliases will be
removed when FindIt no longer uses them.

Bug: 893235
Change-Id: I728c1377fb5f43a37b2cea7392c455af7b4a0e73
Reviewed-on: https://chromium-review.googlesource.com/c/1273886Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598778}

https://crrev.com/c/1272435 made it so that rebaseline-test-internal
would receive the step name from the parent rebaseline process, which
fixed rebaseline-cl.

However, there are still two users of BuildBot.results_url that do not
provide step_name: a log message in rebaseline_cl, and try_flag. This
change makes BuildBot.results_url get the step name if no step name is
provided, which will fix both the log message and try_flag.
https://crrev.com/c/1272435 is still good to have, because it saves lots
of network requests in the children rebaseline-test-internal processes.

Also include some drive-by cleanups.

Bug: 882946
Change-Id: I889885f42c001937123e733c6cf8124e2a9f2b3a
Reviewed-on: https://chromium-review.googlesource.com/c/1274665Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598777}

Bug: 101600
Change-Id: Ib2457bd9c714fe4d05b1eeb9dcaa1c311280c8fe
Reviewed-on: https://chromium-review.googlesource.com/c/1276685Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598776}

This CL adds a randomized encoder class. Instances of this class will
be used to encode autofill form and field metadata using differential
privacy, specifically randomized responses.

Bug: 850606
Change-Id: If0600595dafc6d3233674b92f40e3d092b2d5381
Reviewed-on: https://chromium-review.googlesource.com/c/1265832
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598775}

TBR=foolip

No-Try: True
Bug: 894457
Change-Id: I078420e54ad1b4626d5064b926da72048c6761c8
Reviewed-on: https://chromium-review.googlesource.com/c/1276828Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598774}

Ancient datatype-specific quirks are common in sync, and here's another
one: HISTORY_DELETE_DIRECTIVES datatype has special-handling in
GenericChangeProcessor() to handle directive deletion: instead of
tombstones uploaded to the server, the entries should be untracked
locally but nothing sent to the server.

The patch also fixes a DCHECK failure affecting pseudo-USS, because
such events (local "deletions") are signaled by the SyncableService as
remote changes / SyncDataRemote. Such is the implementation in
GenericChangeProcessor, so we follow the same approach in the
pseudo-USS bridge for compatibility.

Bug: 870624
Change-Id: Ic009b13c6e4aa7c3982d01b9ebd7511c6a0e3185
Reviewed-on: https://chromium-review.googlesource.com/c/1276607Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598773}

In order to get better understanding of Cacao hints applying to
slow page loads, this CL adds some HintCache match stats per
ECT. For original navigation it records whether the HintCache
has a known hint for the URL's host. At commit time it records
if there is a loaded hint for the committed URL and then whether
there is a matching PageHint (regardless of what the PageHint is
for) for the committed URL.

Bug: 892238
Change-Id: Ia66f899f1ee9299a1f780aa471e238ea073e06a2
Reviewed-on: https://chromium-review.googlesource.com/c/1270155Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598772}

This test was broken a while ago but now works.

Bug: 845503
Change-Id: I5275fe0166d3b82b26f616d0dcfe92e15d457b93
Reviewed-on: https://chromium-review.googlesource.com/c/1276786
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598771}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9ce2f8b70cf..2146d0609ce9


Created with:
  gclient setdep -r src-internal@2146d0609ce9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9f62c4437ff241c15b8e88de791b3c70b73daaab
Reviewed-on: https://chromium-review.googlesource.com/c/1275875Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598770}

This is only applicable when the application does not specify the
sdpSemantics and is relying on the default behavior which is about to
change from Plan B to Unified Plan. In "complex" use cases, Plan B SDP
would be rejected by Unified Plan clients. This CL adds a warning if:
- The SDP is "complex Plan B SDP".
- The RTCPeerConnection was constructed without specifying sdpSemantics.

Bug: 857003
Change-Id: I82b88fde2687edd68e0dc8e1126b16e49bf54c2b
Reviewed-on: https://chromium-review.googlesource.com/c/1275892
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598769}

MessageListView crashes when a notification is updated during the
UnifiedSystemTray is closing. Like other views::Widget methods,
SynthesizeMouseMoveEvent() should not be called during the widget is
closing.

See the bug for the asan trace.

TEST=manual
BUG=894070

Change-Id: I9ffba0f73260542ebf21b2aef572af1f68e5c40b
Reviewed-on: https://chromium-review.googlesource.com/c/1276225
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598768}

The new minimal behavior of the keyboard accessory requires it to show
only on password fields. Before this CL, we still had tests expecting
the accessory to show up on username fields.

This CL replaces clicks into the username field with password field
clicks.
For the one case (autofill dialog dismissal), we add a more explicit
call to force that behavior.
Additionally, a new test checks that the accessory is dismissed when
changing from a password to a username field.

Additionally, it uses real password sheets instead of sheetless tabs
which is much closer to the actual use-case and doesn't screw up the
tests that rely on caching sheets.

Bug: 887493
Change-Id: I7e5387487d403941ee6242393e3860bdef674b1f
Reviewed-on: https://chromium-review.googlesource.com/c/1275954
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598767}

This reverts commit 0dce4507.

Reason for revert: Fixed cronet issue

Original change's description:
> Revert "Android build: moved proguarding into dex() for most cases"
> 
> This reverts commit 93aa458f.
> 
> Reason for revert: Suspect for build failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2802
> 
> Original change's description:
> > Android build: moved proguarding into dex() for most cases
> > 
> > This is to allow R8 to proguard and dex in one call, since it has some
> > optimizations that only work when doing everything in one shot.
> > 
> > Bug: 872904
> > Change-Id: Id2c75dac4d9feecae461a0b1e279056253f1b71b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1227142
> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Commit-Queue: Sam Maier <smaier@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#597257}
> 
> TBR=yfriedman@chromium.org,agrieve@chromium.org,smaier@chromium.org
> 
> Change-Id: Idf8f855094fb1bf4c4e1b47326b76166a158c1e8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 872904
> Reviewed-on: https://chromium-review.googlesource.com/c/1265559
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597274}

TBR=yfriedman@chromium.org,agrieve@chromium.org,mcnee@chromium.org,smaier@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 872904
Change-Id: I1bebed520132e81b199c639690d36171ccb46ab6
Reviewed-on: https://chromium-review.googlesource.com/c/1271792
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598766}

When calling IsAdScriptInStack, return true if the current context is an ad frame's context.

This is a minor optimization in positive cases, and also covers more cases (e.g., inline script
in the ad frame).

BUG: 894080

Change-Id: I7b691c6746235bf4cc8be9860d81b7899c86e847
Reviewed-on: https://chromium-review.googlesource.com/c/1264955
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598765}

Android notifications are stored in Android logs. User data are removed
from WebRTC notifications in incognito mode to avoid leaking this data.
The change is behind a disabled by default switch.

    considering their translations, the size change cannot be avoided.

Bug: 629887
Change-Id: I80443ba0fbd463babc30c985a5cd4ef6781ae1a1
Binary-Size: This change doubles the media capture strings and
Reviewed-on: https://chromium-review.googlesource.com/c/1261023Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598764}

While solving crbug.com/878372 I ran into a case where
having two different locations for setting the fallback
caused it to go backwards. Add a DCHECK to prevent such
bugs.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If883bf03169135b3cbf0a5274a30a18ed149b08a
Reviewed-on: https://chromium-review.googlesource.com/c/1274610Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598763}

Incumbent realm was not designated for content attribute, so this CL
sets event target's realm to incumbent realm.

Bug: 893951
Change-Id: If7f526907dae803cd875d70ed79c9ee288df72a9
Reviewed-on: https://chromium-review.googlesource.com/c/1276406
Commit-Queue: Yuki Yamada <yukiy@google.com>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598762}

This CL adds rounded corners and elevation to DropdownPopupWindowImpl.
It also adds a small util function to ApiCompatibilityUtils to
facilitate elevation.

Screenshots: https://docs.google.com/presentation/d/1cSW-l62jY_6HB3UA-KDg8JlguNrVJlncse9HL7xIhuU/edit?usp=sharing

BUG: 874077
Change-Id: Icd01731c2f7292d3ea1397e6790525af00bfa71d
Reviewed-on: https://chromium-review.googlesource.com/c/1265595Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598761}

https://skia.googlesource.com/skia.git/+log/43a5497bf643..9c37cd96e4c8


git log 43a5497bf643..9c37cd96e4c8 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 brianosman@google.com Revert "Fix image info checking for always-opaque color types"
2018-10-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2018-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f955bdac1ce6..956ab4d9fab3 (3 commits)
2018-10-10 caryclark@skia.org undo what was done
2018-10-10 brianosman@google.com Fix image info checking for always-opaque color types
2018-10-10 caryclark@skia.org remove skirect makelargest from docs
2018-10-10 herb@google.com Small re-inline cleanup for GrGlyphCache
2018-10-10 reed@google.com Revert "remove unneeded flag SK_SUPPORT_LEGACY_RECTMAKELARGEST"
2018-10-10 mtklein@google.com Revert "SkTArray: clean up, no change to behaviour"
2018-10-10 reed@google.com remove unneeded flag SK_SUPPORT_LEGACY_RECTMAKELARGEST
2018-10-10 kjlubick@google.com Make CCPR optional
2018-10-10 halcanary@google.com SkPDF: more accurate (float) colors from paint
2018-10-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-10-10 halcanary@google.com SkTArray: clean up, no change to behaviour
2018-10-10 kjlubick@google.com Tweak to compile flags
2018-10-10 robertphillips@google.com Add --reduceOpListSplitting to a swath of bots
2018-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9d0bb3d4d5c0..f955bdac1ce6 (1 commits)
2018-10-10 mtklein@google.com consolidate SkBinaryWriteBuffers
2018-10-10 brianosman@google.com Use SkSurfaceValidateRasterInfo in some lesser-used canvas factories
2018-10-10 jvanverth@google.com Fix up SkImage_GpuYUVA MakePromiseYUVATexture
2018-10-10 robertphillips@google.com Fix yuv_to_rgb_effect GM
2018-10-10 csmartdalton@google.com ccpr: Use ceil/floor to round out path cover octagons
2018-10-10 kjlubick@google.com Remove old code size analysis
2018-10-10 kjlubick@google.com Track Skia's Code size in Flutter
2018-10-10 robertphillips@google.com Add reduceOpListSplitting flag
2018-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader aaaf93a38a83..d6126aea667e (1 commits)
2018-10-10 jvanverth@google.com Fix up degenerate quads


Created with:
  gclient setdep -r src/third_party/skia@9c37cd96e4c8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:891693,chromium:890698
TBR=stani@chromium.org

Change-Id: I550e140a0ef6050ef65c602263e4f0fc70544a78
Reviewed-on: https://chromium-review.googlesource.com/c/1275877Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598760}

Bug: 833764, 891721
Change-Id: I0a8f06b391765bcd911a4ccb4e1f0ba1a312b0c2
Reviewed-on: https://chromium-review.googlesource.com/c/1269706
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598759}

For a long time when setting a textBaseline on canvas we have been
rounding the returning values to always* use integers. This extra
round operation seems to be unnecessary now and it is actually
creating other alignment issues. This change fixes does alignment
problems with no noticeable regressions.

*For super tiny fonts (< 5px) we already returned floats.
(crbug.com/338908)

Bug: 890515
Change-Id: I099af9834aaf28bb2770e080bdb849eb729c18fd
Reviewed-on: https://chromium-review.googlesource.com/c/1260210Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598758}

Reports whether a parallel request successfully started, and its final
completion status.

Bug: 884751
Change-Id: Ic4c975bd22b7fca98c066970cb202b93e8c7ca8c
Reviewed-on: https://chromium-review.googlesource.com/c/1273150Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598757}

Disabling zoom and pan in this (odd special-)case leads to some weird
behavior, so just enable it instead to avoid confusion.

This takes care of one of the testcases mentioned in the referenced bug,
but does not address the real issue in any way.

Bug: 222786
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I25d9cbf9cd10c1631d64fddcd133014b9602bcba
Reviewed-on: https://chromium-review.googlesource.com/c/1275886Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#598756}

Bug: 892216
Change-Id: I728bde6f03e7896df093d1abb75027dba726fa47
Reviewed-on: https://chromium-review.googlesource.com/c/1269110Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598755}

This reverts commit 20990963.

Reason for revert: The revert did not fix crbug.com/883963.
Requested to re-run bisect.

Original change's description:
> Revert "Improve performance of PreviousBreakOpportunity"
> 
> This reverts commit 99d504fd.
> 
> Reason for revert:
> 
> crbug.com/883963 bisected to this CL. I'm not sure how this
> affects print preview, reverting to see the effect.
> 
> This revert may affect LayoutNG performance, but should not
> affect the currently shipping line breaker.
> 
> Original change's description:
> > Improve performance of PreviousBreakOpportunity
> >
> > In the current layout engine, PreviousBreakOpportunity is used
> > only when mid-word break (break-all or break-word), but it is
> > much more heavily used in LayoutNG.
> >
> > LazyLineBreakIterator is designed for forward only.
> > PreviousBreakOpportunity is implemented by repeatedly calling
> > NextBreakablePosition, but since NextBreakablePosition look
> > for the next break opportunity until the end of the string,
> > when a very long word without break opportunity is given,
> > PreviousBreakOpportunity is O(n!).
> >
> > This patch changes it to O(n) by limiting the end position
> > NextBreakablePosition can look for.
> >
> > blink/perf_tests/layout/word-break-break-word.html consumes
> > 78% of the total time in LayoutNG. The average run is:
> >   Current engine:    469ms
> >   LayoutNG:       26,644ms
> >   This patch:      2,250ms
> >
> > It's still 4-5 times slower, more improvements will be in
> > following patches.
> >
> > Bug: 636993
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> > Change-Id: I814e2c45c8030aa682c7f5e3a3b785b3c0733c84
> > Reviewed-on: https://chromium-review.googlesource.com/1095894
> > Commit-Queue: Koji Ishii <kojii@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567133}
> 
> TBR=eae@chromium.org,kojii@chromium.org
> 
> Bug: 636993, 883963
> Change-Id: I2c453a011208b014e342d7b44646eb90b5b7bbd2
> Reviewed-on: https://chromium-review.googlesource.com/c/1270396
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597876}

TBR=eae@chromium.org,kojii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 636993, 883963
Change-Id: I8e9881deca736c5b574dc287d04f9c2fffe76680
Reviewed-on: https://chromium-review.googlesource.com/c/1275985Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598754}

Parsing of the form on saving may return empty result. For example
if all password fields are marked as credit card related fields.
In this case NewPasswordFormManager shouldn't be considered to be
submitted. Anyway it's not possible to save. This CL fixes a crash
on attempt to use parsed submitted form in OnLoginSuccessful.

Bug: 893672, 831123
Change-Id: Id0211f26ec1ba03d3659b41f815792e6a5d71a68
Reviewed-on: https://chromium-review.googlesource.com/c/1275888
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598753}

Bug: None
Change-Id: Ib0b805cd28e7e45f533d93f22d893e4298407b8a
Reviewed-on: https://chromium-review.googlesource.com/c/1273526
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598752}

Moving focus to/from a text field doesn't necessarily show/hide the
virtual keyboard.
For example, a hidden text field is automatically focused when opening
window switcher, but it should not cause the virtual keyboard show up.
This CL adds 2 new methods to ArcInputMethodManagerInstance interface to
control show/hide the virtual keyboard of ARC IMEs.
A caller of HideVirtualKeyboard() will be added later in a separate CL.

Bug: 845079
Test: Open window switcher, but ARC IME doesn't show up.
Change-Id: I538cf826d97a0d3bab49dd64075cde9b55494ac5
Reviewed-on: https://chromium-review.googlesource.com/c/1273395Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598751}

This CL removes the remaining voice bar support.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9b348cd4360ee692b228f972a6216ebcf8838350
Reviewed-on: https://chromium-review.googlesource.com/c/1251451Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598750}

https://boringssl.googlesource.com/boringssl/+log/ce00828c89df3d4c40de7d715b1a032eb03c525c..2d98d49cf712ca7dc6f4b23b9c5f5542385d8dbe

Bug: none
Change-Id: Ib79f15ec5c31b511551d4e87783dcda822fbfd28
Reviewed-on: https://chromium-review.googlesource.com/c/1274203
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598749}

This looks like it was hiding some sutble bugs, e.g. not running
microtasks, and not being able to create other objects correctly.

Change-Id: Ieb6ade2906aeedebdc6dc664470b38955c32811d
Reviewed-on: https://chromium-review.googlesource.com/c/1272438Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598748}