- 05 Oct, 2018 40 commits
-
-
Ben Kelly authored
When SimpleCache starts up it runs a consistency check and performs any necessary version upgrades. The cache_storage code is seeing SimpleCache initialization fail on some devices. This histogram will record why the SimpleCache check and upgrade process is failing to help track down any underlying problems. R=morlovich@chromium.org Bug: 889976 Change-Id: I6072d7d11294d360d3ff48b44ae0531fce03e004 Reviewed-on: https://chromium-review.googlesource.com/c/1249961 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#597306}
-
David Black authored
AssistantContainerViewAnimator is the class responsible for rebounding AssistantContainerView smoothly in response to size/state changes. This CL moves the existing animation logic into AssistantContainerViewAnimatorLegacyImpl with the hopes that we will be able to deprecate it in favor of a more performant implementation. Bug: b:116657110, b:113348616 Change-Id: Ic81beb977c176f445d3ce8ef1c075ef0e75cd64c Reviewed-on: https://chromium-review.googlesource.com/c/1244540 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#597305}
-
Charlie Reis authored
The formatting logic may rewrite such URLs into an unsafe state. This is a first step before preventing navigations to invalid URLs entirely. Bug: 850824 Change-Id: I71743bfb4b610d55ce901ee8902125f934a2bb23 Reviewed-on: https://chromium-review.googlesource.com/c/1252942Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#597304}
-
Becca Hughes authored
Add a source name in AudioFocusDelegateDefault for "web". BUG=875004 Change-Id: Id80b828ee7b717d8f9c0b624974bc3758db1c858 Reviewed-on: https://chromium-review.googlesource.com/c/1239540 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#597303}
-
Robert Ogden authored
Virtual URLs are used in almost all UI display contexts in Chrome, but do not always represent the page that was actually loaded in the renderer. If the scheme is HTTP or HTTPS, and the virtual and loaded URLs are totally different origins, automatically deny the request. This should basically never happen because all but one virtual URL handlers are for chrome:// pages. The only http handler is for a special type of Preview which will have JavaScript disabled and should not create permission dialogs. None the less, if one does get created, it should be denied so that the user doesn't approve a request for the wrong page. Bug: 881938 Change-Id: Iedb835f72e0a963347ed2a85dc2a71dc43e1f53c Reviewed-on: https://chromium-review.googlesource.com/c/1260082 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#597302}
-
Stephen Martinis authored
This CL makes rebaseline_cl.py detect the step name for a build programmatically when retrieving results. Layout test results will soon be always uploaded to a subdirectory of their step name, so the step name needs to be known. Bug: 882946 Change-Id: Iebf03c968f559c49872f97b25fa7e12f16ec5ad2 Reviewed-on: https://chromium-review.googlesource.com/c/1262425 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#597301}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/942603d49e30..f75ce5a16f89 git log 942603d49e30..f75ce5a16f89 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 vapier@chromium.org validation_pool_unittest: finish removing mox references 2018-10-05 vapier@chromium.org proctitle: fix running inside of `python` 2018-10-05 vapier@chromium.org paygen: {file,gs,uri}lib: drop Exists helper 2018-10-05 vapier@chromium.org patch_series_unittest: convert to mock 2018-10-05 nya@chromium.org cidb: Return branch info in build statuses. Created with: gclient setdep -r src/third_party/chromite@f75ce5a16f89 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3f334821aeb9259fba50a608cb9f2580a036cc17 Reviewed-on: https://chromium-review.googlesource.com/c/1265422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597300}
-
Nasko Oskov authored
This is a follow up on a comment from https://chromium-review.googlesource.com/c/chromium/src/+/1098562 Bug: 609963 Change-Id: I8ba97bcbb8961f1dbacd4d3fe5c1766c44c20042 Reviewed-on: https://chromium-review.googlesource.com/c/1265023Reviewed-by:
-
Mihai Sardarescu authored
This CL reverts all code in the SyncDisableObserver to its state before http://crrev.com/c/1152744. It also disables all UKMBrowserTests for Unified Consent enabled feature as this not supported anymore. This is an attempt to verify whether http://crrev.com/c/1152744 is the culprit from the drop in UKM collected metrics seen in bug 891777. For reference - here is the diff of file sync_disable_observer.cc with the version before http://crrev.com/c/1152744: $ git diff 8f1b6d09 -- components/ukm/observers/sync_disable_observer.cc diff --git a/components/ukm/observers/sync_disable_observer.cc b/components/ukm/observers/sync_disable_observer.cc index f6d72866cfdd..beb5dac78eb5 100644 --- a/components/ukm/observers/sync_disable_observer.cc +++ b/components/ukm/observers/sync_disable_observer.cc @@ -68,7 +68,8 @@ SyncDisableObserver::SyncState SyncDisableObserver::GetSyncState( } void SyncDisableObserver::ObserveServiceForSyncDisables( - syncer::SyncService* sync_service) { + syncer::SyncService* sync_service, + PrefService* pref_service) { previous_states_[sync_service] = GetSyncState(sync_service); sync_observer_.Add(sync_service); UpdateAllProfileEnabled(false); $ git diff 8f1b6d09 -- components/ukm/observers/sync_disable_observer.h diff --git a/components/ukm/observers/sync_disable_observer.h b/components/ukm/observers/sync_disable_observer.h index 2de46181f0f5..2b89842addcb 100644 --- a/components/ukm/observers/sync_disable_observer.h +++ b/components/ukm/observers/sync_disable_observer.h @@ -11,6 +11,8 @@ #include "components/sync/driver/sync_service.h" #include "components/sync/driver/sync_service_observer.h" +class PrefService; + namespace ukm { // Observes the state of a set of SyncServices for changes to history sync @@ -23,7 +25,8 @@ class SyncDisableObserver : public syncer::SyncServiceObserver { ~SyncDisableObserver() override; // Starts observing a service for sync disables. - void ObserveServiceForSyncDisables(syncer::SyncService* sync_service); + void ObserveServiceForSyncDisables(syncer::SyncService* sync_service, + PrefService* pref_service); // Returns true iff sync is in a state that allows UKM to be enabled. // This means that for all profiles, sync is initialized, connected, has the Bug: 891777 Change-Id: Ie55d4df1a66454918fa4931b3cc5000dade1d3e9 Reviewed-on: https://chromium-review.googlesource.com/c/1264781Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#597298}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9934cc2f2f1a..be4e055bce62 git log 9934cc2f2f1a..be4e055bce62 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 tsepez@chromium.org Remove unreachable null checks in CPDF_ActionFields Created with: gclient setdep -r src/third_party/pdfium@be4e055bce62 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia3bf715bbf81091d477f6ae4d6106186c7054eff Reviewed-on: https://chromium-review.googlesource.com/c/1265049Reviewed-by:
-
Adam Langley authored
WebIDL allows hyphens in identifiers[1], specifically in dictionary keys. Currently the generated bindings end up emitting the hyphen in C++ which fails to compile. One option would be to use the ImplementedBy name more uniformly: at the moment it's used in a couple of places, but generally not for methods that have strings appended or prepended (like "get" or "set"). That could be changed at the cost of tweaking a bunch of existing usages. Instead, this change doesn't touch existing code, but tweaks the generation so that hyphens in WebIDL identifiers are lowerCamelCased. This is all motivated because WebAuthn defines a dictionary of extensions[2] and FIDO has defined an extension with a hyphen in the name[3]. [1] https://heycam.github.io/webidl/#prod-identifier [2] https://www.w3.org/TR/webauthn/#iface-authentication-extensions-client-inputs [3] https://fidoalliance.org/specs/fido-v2.0-rd-20180702/fido-client-to-authenticator-protocol-v2.0-rd-20180702.html#sctn-hmac-secret-extension Change-Id: Id17c528c5594251385a0a10fa5e91988908b88b6 Reviewed-on: https://chromium-review.googlesource.com/c/1247233 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#597296}
-
Jesse McKenna authored
Change-Id: I9094d0e239084cd77381949ae12cc7982a96e63c Bug: 889029 Reviewed-on: https://chromium-review.googlesource.com/c/1250085 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#597295}
-
Dmitry Titov authored
The new metric ExploreSites.MonthlyHostCount counts the same thing but is reported on elapsed-time basis instead of on on-startup basis to help avoid bias toward more active users who start Chrome more often. Also updated 'units' for related histograms. Bug: 867488 Change-Id: I22915ed143af031dadb74aaee5d9b6260726f1af Reviewed-on: https://chromium-review.googlesource.com/c/1265496Reviewed-by:
-
Christian Fremerey authored
This is to prevent regression that only manifests in very subtle issues such as device enumeration becoming unreliable. Bug: 848042 Change-Id: I4044c2494e2a525ca2eeca22bd67698e651360ff Reviewed-on: https://chromium-review.googlesource.com/c/1246147Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#597293}
-
Adam Langley authored
The current version of this proposal[1] ditches the idea that the transport used for a given registration is put at the beginning of the list and, instead, requires that the list be sorted. (This is still behind a flag so there's no world-visible change here.) [1] https://github.com/w3c/webauthn/pull/1050 Change-Id: I2f1f0dae97a4be184bf367f65c580a706442fe75 Reviewed-on: https://chromium-review.googlesource.com/c/1261933Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#597292}
-
Dana Fried authored
Issue manifests when user logs in after setting higher DPI. No effect from actual monitor DPI/scale. Happens because GetNonClientMetrics() returns font size based on global default DPI, so we have to adjust. Bug: 892393 Change-Id: I19a841a6f05e8087048960b2f5a4ed91e2f674a9 Reviewed-on: https://chromium-review.googlesource.com/c/1264895Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da3dfedf..2cefd983 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icdb1b089eefa5766386c1f65e99ce486dbd5fb26 Reviewed-on: https://chromium-review.googlesource.com/c/1265498Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597290}
-
Jared Saul authored
Bug: 884817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifdf444eab32052a9b84d17a9b21ccf14edb78e52 Reviewed-on: https://chromium-review.googlesource.com/c/1255723Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#597289}
-
Marijn Kruisselbrink authored
This reverts commit 9eba977d. Reason for revert: Causes test failures in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/44735 ../../components/autofill/core/browser/strike_database_unittest.cc:148: Failure Expected equality of these values: 3 GetStrikes(key) Which is: 0 Original change's description: > [AF][Traffic Light] Cache for StrikeDatabase > > Implemented a cache in form of a [key, StrikeData] map for set or > retrieved values to avoid hitting the disk repeatedly for the same > card. > > Bug: 884717 > Change-Id: I5e8a5936a54f30a64a919a97314cd04d3874b2a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1249130 > Commit-Queue: Anne Lim <annelim@google.com> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#597235} TBR=mathp@chromium.org,sebsg@chromium.org,jsaul@google.com,annelim@google.com Change-Id: I3050c39a2711575c0157cfbc83cef5c61c74121d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884717 Reviewed-on: https://chromium-review.googlesource.com/c/1265775Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597288}
-
Becca Hughes authored
Adds a source name to the AudioFocusManager API that can be used to identify a client to the media session service. This adds more granularity than service_manager::Identity so we can differentiate between ARC and Content. It will be used to identify a client when recording metrics and for tweaking the UI based on where the media session originated from. BUG=875004 Change-Id: I4a78fd2bf17189de503aa507d51a7260f62ac7ee Reviewed-on: https://chromium-review.googlesource.com/c/1239258 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597287}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c3bd49069d4..71e3be7a50c2 git log 0c3bd49069d4..71e3be7a50c2 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-05 iannucci@chromium.org [windows_sdk] Default to cache/windows_sdk. Created with: gclient setdep -r src/third_party/depot_tools@71e3be7a50c2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877775 TBR=agable@chromium.org Change-Id: I025a744cc1400d500985ca5cadcffe34b3284a3b Reviewed-on: https://chromium-review.googlesource.com/c/1265048Reviewed-by:
-
Eric Karl authored
This is the OOP-D counterpart to: https://chromium-review.googlesource.com/c/chromium/src/+/1244106 A previous patch added a callback to handle context creation failures. This patch now adds the surface error workaround, causing us to recreate our surface on a surface error. Bug: 787086 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9c283f3b4052afcfe865b4564220d779aca24b88 Reviewed-on: https://chromium-review.googlesource.com/c/1257658 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597285}
-
Ehsan Karamad authored
Currently embedding a PDF creates a MimeHandlerViewFrameContainer which then loads an extension that attaches another internal plugin element to load the PDF plugin. This CL makes sure we do not create a second MimeHandlerViewFrameContainer for that. Bug: 659750 Change-Id: Iff71eee6d59b824572628f1ba68651d6be16138c Reviewed-on: https://chromium-review.googlesource.com/c/1265502 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#597284}
-
Kurt Horimoto authored
This CL adds a |-setNeedsLayout| call to the web view content view in case the content view needs to do any additional layout due to changes in toolbar overlap that don't result in a change in bounds size. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0b5619e8e4f038e0ce85d9626bc1906ad9ad626c Reviewed-on: https://chromium-review.googlesource.com/c/1262643 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Ryan Sturm authored
This CL aims to move URLRequest dependencies out of Previews triggering code (and into CRDHD methods) to allow for a much smaller CL when moving to the UI thread. Ultimately, these methods will be called from the content/ Navigation stack using delegates there (ChromeContentBrowserClient). This will allow Previews decisions to occur slightly earlier in the Navigation pathway, and it will allow Previews to operate strictly on the UI thread. However, PreviewsState will still be plumbed to the IO thread until DRP is moved out of Net Delegate classes. Instead of passing URLRequest to Previews code, the PreviewsUserData is passed along with request information (i.e., reload, URL). These will be available on the UI thread, so the previews methods themselves should be able to be consumed post thread switch. Bug: 842233,892448 Change-Id: I0f7ab5d23aeb34e89bad5d027d685c348d94569a Reviewed-on: https://chromium-review.googlesource.com/c/1259621 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597282}
-
Parastoo Geranmayeh authored
to server. The flag has been added to the Autofill Profile but not synced. Syncing it would optimize the client side validation. If a profile has already been validated, and the validation states are up-to-date (meaning that the flag is on), we won't need to validate the synced profile. Bug: 892373 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I34957cf9e95316e3bae44595e5ea278b0021c8bb Reviewed-on: https://chromium-review.googlesource.com/c/1252539Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#597281}
-
Gang Wu authored
Bug: 831638 Change-Id: Iebaa9f5223fed30bb0ae525a24c1dd2a5befa7b2 Reviewed-on: https://chromium-review.googlesource.com/c/1260509Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597280}
-
Christian Biesinger authored
We should also consider inlining most of the rest of the functions, but as that requires including layout_box.h in the header I wasn't sure if I should do that in this CL. R=eae@chromium.org, mstensho@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia11009965653f57144ff6937c3e1b9265d44fe6e Reviewed-on: https://chromium-review.googlesource.com/c/1265124Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597279}
-
Min Qin authored
This CL allows us to create the network service when service manager is running, and sets the URLLOaderFactoryGetter for InProgressManager. This should allow download to resume without browser process. BUG=842245 Change-Id: Id985b5d6adc4144f4b51588ba4659f57cf607e31 Reviewed-on: https://chromium-review.googlesource.com/c/1264523Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597278}
-
Boris Sazonov authored
This CL adds a wrapper around ImageViewCompat.setImageTintList that sets the tint mode to default (PorterDuff.Mode.SRC_IN) if there's no tint mode yet. This is necessary because tint mode is checked by ImageViewCompat.setImageTintList to trigger a workaround for a bug in Android L. Bug: 891609 Change-Id: Ia799bdfd5fa597e6e10622784544ae1fa9a3d842 Reviewed-on: https://chromium-review.googlesource.com/c/1264756Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#597277}
-
Chris Lu authored
Creates new NativeActivityOverlayCoordinator that presents a NativeActivityOverlayViewController to show the activity indicator. Presents it from ClearBrowsingDataTableViewController before executing remove browsing data, and removes it in the callback. Video: https://drive.google.com/file/d/1qWKW7L4Q1K_SWRkJirl1oogPvjRxgfLh/view?usp=sharing https://drive.google.com/file/d/1cZ43c6iJA9mhbr_95DgJXGHS33zGCvAO/view?usp=sharing Bug: 760598 Change-Id: I4b4bde0811502691438e520c87e128496cdd0e1b Reviewed-on: https://chromium-review.googlesource.com/c/1259483 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#597276}
-
Francois Doray authored
No need to create a TaskRunner to do a one-off PostTaskAndReplyWithResult(). Change-Id: Icb3f731906863431b03b9e932baf39dbe9d74218 Reviewed-on: https://chromium-review.googlesource.com/c/1230700 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#597275}
-
Kevin McNee authored
This reverts commit 93aa458f. Reason for revert: Suspect for build failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2802 Original change's description: > Android build: moved proguarding into dex() for most cases > > This is to allow R8 to proguard and dex in one call, since it has some > optimizations that only work when doing everything in one shot. > > Bug: 872904 > Change-Id: Id2c75dac4d9feecae461a0b1e279056253f1b71b > Reviewed-on: https://chromium-review.googlesource.com/c/1227142 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597257} TBR=yfriedman@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Idf8f855094fb1bf4c4e1b47326b76166a158c1e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872904 Reviewed-on: https://chromium-review.googlesource.com/c/1265559Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#597274}
-
Ken Rockot authored
This changes views::RemoteViewHost and ws::ServerRemoteViewHost slightly, such that they are attached to an aura window as soon as possible (upon addition to a widget) rather than waiting for the initiation of an embed request. Bug: 854367 Change-Id: I684abe7568318b0ced412e1bc6bdb52a866aa9b5 Reviewed-on: https://chromium-review.googlesource.com/c/1255460 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597273}
-
Kevin McNee authored
The wrong union member is written to during deserialization of the contact_size. A few tap types have been added in switch statements where they were missing. Bug: None Change-Id: I7f1b389070bd42b540ed78cfaff40cc463827d79 Reviewed-on: https://chromium-review.googlesource.com/c/1252633Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#597272}
-
Stephen Martinis authored
Bug: 892366 Change-Id: I091de0ff478bf4d6a955b2fcab57dff4e4429d75 Reviewed-on: https://chromium-review.googlesource.com/c/1265503 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597271}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e9584b32dfe..89a5e559a7c9 Created with: gclient setdep -r src-internal@89a5e559a7c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:892125 TBR=mmoss@chromium.org Change-Id: I25a39107cdbc9bad3867f61d6ddf3bbbbe202f98 Reviewed-on: https://chromium-review.googlesource.com/c/1265044Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597270}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/de52d9ad295e..4fc4281d2152 git log de52d9ad295e..4fc4281d2152 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 benjhayden@chromium.org Update benchmark_owner_emailer to new alerts API. Created with: gclient setdep -r src/third_party/catapult@4fc4281d2152 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic609848dddbc3b56183c399aa7c8793faf54eb8c Reviewed-on: https://chromium-review.googlesource.com/c/1265043Reviewed-by:
-
Marijn Kruisselbrink authored
This test is flaky on at least windows and linux. Bug: 892032 Change-Id: If541fa6c5a4ad118c3c5ab143bfd7fe5aec177e6 Tbr: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1265499Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 891310 Change-Id: Ie3aeb33c2f6031bdafd2ded0131cc54e1ee496cf Reviewed-on: https://chromium-review.googlesource.com/c/1256907Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
